flux reports: signs (e.g. signs:wooden_long_ ... #5553

New Issue

yourland-report · 2023-11-25T22:20:33Z

yourland-report commented

2023-11-25 22:20:33 +00:00

flux reports a bug:

signs (e.g. signs:wooden_long_sign) have regressed to having both a node formspec and one that's displayed later from the on_right_click callback

Player position:

{
	x = 1273.1309814453,
	y = 48,
	z = 591.7509765625
}

Player look:

{
	x = 0.033323116600513,
	y = 0.17622578144073,
	z = 0.98378556966782
}

Player information:

{
	max_rtt = 4.5710000991821,
	version_string = "5.8.0-dev-841a1a788",
	protocol_version = 42,
	state = "Active",
	ip_version = 6,
	min_rtt = 0.17200000584126,
	max_jitter = 4.3889999389648,
	major = 5,
	minor = 8,
	lang_code = "",
	avg_rtt = 0.18199999630451,
	min_jitter = 0,
	formspec_version = 7,
	avg_jitter = 0,
	connection_uptime = 16551,
	serialization_version = 29,
	patch = 0
}

Player meta:

{
	fields = {
		arenalib_infobox_arenaID = "0",
		["stamina:exhaustion"] = "146",
		xp = "2312985",
		["stamina:poisoned"] = "no",
		placed_nodes = "481237",
		yl_commons_player_created = "1615351173",
		["petz:lycanthropy"] = "1",
		hotbar_size = "16",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 52, [\"z\"] = 214, [\"x\"] = 2810}, [\"last_death_portal\"] = 1692114993, [\"last_heal\"] = 1615504208}",
		punch_count = "318819",
		["stamina:level"] = "10",
		yl_commons_thankyou = "333",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		played_time = "42974178",
		digged_nodes = "1716530",
		jointime = "1615351173",
		bitten = "0",
		crafted = "209740",
		["petz:werewolf_clan_idx"] = "1",
		["petz:werewolf_vignette_id"] = "20",
		partychat = "party",
		hud_state = "on",
		["signslib:pos"] = "(1290,65,550)",
		repellant = "0",
		yl_commons_player_joined = "1700934300",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 9248\", \"3d_armor:leggings_rainbow 1 9248\", \"shields:shield_rainbow 1 9248\", \"3d_armor:chestplate_rainbow 1 9248\", \"nether_mobs:dragon_boots 1 23060\", \"\"}",
		["petz:werewolf"] = "0",
		died = "101",
		inflicted_damage = "6303432"
	}
}

Log identifier


[MOD] yl_report log identifier = mM4xOBbtE351AwVANfmKRnXvhT8qDHV7

Profiler save:

profile-20231125T222033.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 2d 21h 13s | max lag: 0.427s | clients (30/52): AliasAlreadyTaken, Bailiff, Boot, Chache, coder2134, daydream, Empempires, flux, Hallifax, Heron, Isolde, jackofthebean000, joumasepoes, Julcsika, Karu, Keya, laira, lairiel, Lichberry, nazthelizard122, Neon_, Pif, polik, Randy999, Ravise, rewired_X, rewired_X1, Sandmuel, Service, Therottenpotato

Teleport command:

/teleport xyz 1273 48 592

Compass command:

/give_compass Construction mM4xOBbtE351AwVANfmKRnXvhT8qDHV7 D2691E 1273 48 592

flux reports a bug: > signs (e.g. signs:wooden_long_sign) have regressed to having both a node formspec and one that's displayed later from the on_right_click callback Player position: ``` { x = 1273.1309814453, y = 48, z = 591.7509765625 } ``` Player look: ``` { x = 0.033323116600513, y = 0.17622578144073, z = 0.98378556966782 } ``` Player information: ``` { max_rtt = 4.5710000991821, version_string = "5.8.0-dev-841a1a788", protocol_version = 42, state = "Active", ip_version = 6, min_rtt = 0.17200000584126, max_jitter = 4.3889999389648, major = 5, minor = 8, lang_code = "", avg_rtt = 0.18199999630451, min_jitter = 0, formspec_version = 7, avg_jitter = 0, connection_uptime = 16551, serialization_version = 29, patch = 0 } ``` Player meta: ``` { fields = { arenalib_infobox_arenaID = "0", ["stamina:exhaustion"] = "146", xp = "2312985", ["stamina:poisoned"] = "no", placed_nodes = "481237", yl_commons_player_created = "1615351173", ["petz:lycanthropy"] = "1", hotbar_size = "16", yl_church = "return {[\"last_death\"] = {[\"y\"] = 52, [\"z\"] = 214, [\"x\"] = 2810}, [\"last_death_portal\"] = 1692114993, [\"last_heal\"] = 1615504208}", punch_count = "318819", ["stamina:level"] = "10", yl_commons_thankyou = "333", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", played_time = "42974178", digged_nodes = "1716530", jointime = "1615351173", bitten = "0", crafted = "209740", ["petz:werewolf_clan_idx"] = "1", ["petz:werewolf_vignette_id"] = "20", partychat = "party", hud_state = "on", ["signslib:pos"] = "(1290,65,550)", repellant = "0", yl_commons_player_joined = "1700934300", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 9248\", \"3d_armor:leggings_rainbow 1 9248\", \"shields:shield_rainbow 1 9248\", \"3d_armor:chestplate_rainbow 1 9248\", \"nether_mobs:dragon_boots 1 23060\", \"\"}", ["petz:werewolf"] = "0", died = "101", inflicted_damage = "6303432" } } ``` Log identifier ``` [MOD] yl_report log identifier = mM4xOBbtE351AwVANfmKRnXvhT8qDHV7 ``` Profiler save: ``` profile-20231125T222033.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 2d 21h 13s | max lag: 0.427s | clients (30/52): AliasAlreadyTaken, Bailiff, Boot, Chache, coder2134, daydream, Empempires, flux, Hallifax, Heron, Isolde, jackofthebean000, joumasepoes, Julcsika, Karu, Keya, laira, lairiel, Lichberry, nazthelizard122, Neon_, Pif, polik, Randy999, Ravise, rewired_X, rewired_X1, Sandmuel, Service, Therottenpotato ``` Teleport command: ``` /teleport xyz 1273 48 592 ``` Compass command: ``` /give_compass Construction mM4xOBbtE351AwVANfmKRnXvhT8qDHV7 D2691E 1273 48 592 ```

AliasAlreadyTaken was assigned by yourland-report

2023-11-25 22:20:33 +00:00

flux added the

1. kind/bug

label 2023-11-26 02:21:10 +00:00

AliasAlreadyTaken removed their assignment 2023-11-26 13:21:55 +00:00

AliasAlreadyTaken self-assigned this 2023-11-26 13:22:09 +00:00

Niklp commented

2023-11-26 13:25:26 +00:00

I take this issue. (Alias can't assign me due to permission issues)

👍 2

Niklp was assigned by AliasAlreadyTaken

2023-11-26 13:32:53 +00:00

flux commented

2023-11-27 06:43:08 +00:00

Niklp> hey, I can't reproduce #5553. Both on_construct and on_rightclick call signs_api.set_formspec (which sets the formspec to nodemeta).

fluxionary> i'm not 100% sure i diagnosed that issue correctly. the behavior i see is that i look at a sign and click on it, it opens a formspec, i type a couple letters, then the formspec resets and erase what i typed

> Niklp> hey, I can't reproduce https://gitea.your-land.de/your-land/bugtracker/issues/5553. Both `on_construct` and `on_rightclick` call `signs_api.set_formspec` (which sets the formspec to nodemeta). > fluxionary> i'm not 100% sure i diagnosed that issue correctly. the behavior i see is that i look at a sign and click on it, it opens a formspec, i type a couple letters, then the formspec resets and erase what i typed

Niklp commented

2023-11-27 19:16:05 +00:00

i type a couple letters, then the formspec resets and erase what i typed

Never happend to me :\

> i type a couple letters, then the formspec resets and erase what i typed Never happend to me :\

flux commented

2023-11-28 21:03:59 +00:00

i type a couple letters, then the formspec resets and erase what i typed

Never happend to me :\

hm. it's inconsistent for me, and only seems to happen on the your-land server - i can't get it to happen on a local server, even when creating artificial lag...

and it only seems to happen once for each sign, but resets when i leave the area and come back?

> > i type a couple letters, then the formspec resets and erase what i typed > > Never happend to me :\ hm. it's inconsistent for me, and only seems to happen on the your-land server - i can't get it to happen on a local server, even when creating artificial lag... and it only seems to happen once for each sign, but resets when i leave the area and come back?

AliasAlreadyTaken commented

2023-11-29 02:06:13 +00:00

Does it happen on the testserver?

If so, does it happen to signs that are //saved and //loaded via WE?

Does it happen on the testserver? If so, does it happen to signs that are //saved and //loaded via WE?

flux commented

2023-11-29 20:14:09 +00:00

Does it happen on the testserver?

test server is down, but it does happen locally when i'm running my your-land clone

If so, does it happen to signs that are //saved and //loaded via WE?

if the sign is susceptible, then yes.

> Does it happen on the testserver? test server is down, but it does happen locally when i'm running my your-land clone > If so, does it happen to signs that are //saved and //loaded via WE? if the sign is susceptible, then yes.

flux commented

2023-11-29 20:29:44 +00:00

i figured out why i could't replicate this locally initially - it only happens when using the mt-mods fork of display_modpack, not the pyrollo fork. i've traced it to this commit: 1f8e99c9c5

i figured out why i could't replicate this locally initially - it only happens when using the mt-mods fork of display_modpack, not the pyrollo fork. i've traced it to this commit: https://github.com/mt-mods/display_modpack/commit/1f8e99c9c52afb05d7523b25e2e4fff6f236ed5f

flux commented

2023-11-30 00:08:55 +00:00

the issue is that when a player is looking at a node formspec, and the node formspec is modified, what the player sees is also modified. but looking at that commit above, right-clicking the sign should only modify the formspec if it needs to have that fix applied. however, i'm having this issue multiple times on certain signs, and also for new signs that were placed well after the fix was applied. something else might be modifying the sign formspec, perhaps...

👍 1 😕 1

Niklp commented

2023-12-04 21:08:28 +00:00

Explanation: Minetest sends the nodemeta automatically and doesn't need a server step to show up the node formspec. when the lag is high enough, the formspecs gets visibly re-setted (that removes the already written, but not send text).

Fix: Remove the on_rightclick callback and update all formspecs via a single run LBM.

Explanation: Minetest sends the nodemeta automatically and doesn't need a server step to show up the node formspec. when the lag is high enough, the formspecs gets visibly re-setted (that removes the already written, but not send text). Fix: Remove the `on_rightclick` callback and update all formspecs via a single run LBM.

untitled.mp4

2.2 MiB

👍 2

Niklp commented

2023-12-05 18:55:25 +00:00

Should be fixed by https://github.com/mt-mods/display_modpack/pull/9 (already on the testserver).

AliasAlreadyTaken referenced this issue from a commit

2023-12-09 02:30:25 +00:00

Fix sign formspec updates while used (#9)

Niklp commented

2023-12-10 11:11:15 +00:00

The main PR is merged and introduced a regression. https://github.com/mt-mods/display_modpack/pull/10/ is required too.