your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

testserver minetest-tnt/init.lua:257: attempt to index local 'def' (a nil value) #5526

New Issue
Closed
opened 2023-11-19 18:59:34 +00:00 by AliasAlreadyTaken · 8 comments
AliasAlreadyTaken commented 2023-11-19 18:59:34 +00:00
Owner
Copy Link

2023-11-19 18:41:25: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'wielded_light' in callback luaentity_Step(): ...mt/5.7.0/Minetest_test/bin/../mods/minetest-tnt/init.lua:257: attempt to index local 'def' (a nil value)
2023-11-19 18:41:25: ERROR[Main]: stack traceback:
2023-11-19 18:41:25: ERROR[Main]: ...mt/5.7.0/Minetest_test/bin/../mods/minetest-tnt/init.lua:257: in function 'add_effects'
2023-11-19 18:41:25: ERROR[Main]: ...mt/5.7.0/Minetest_test/bin/../mods/minetest-tnt/init.lua:462: in function 'boom'
2023-11-19 18:41:25: ERROR[Main]: ....7.0/Minetest_test/bin/../mods/yl_nether_mobs/wither.lua:161: in function 'hit_node'
2023-11-19 18:41:25: ERROR[Main]: /home/mt/5.7.0/Minetest_test/bin/../mods/mobs_redo/api.lua:4230: in function 'func'
2023-11-19 18:41:25: ERROR[Main]: ...inetest_test/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:101>

2023-11-19 18:41:25: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'wielded_light' in callback luaentity_Step(): ...mt/5.7.0/Minetest_test/bin/../mods/minetest-tnt/init.lua:257: attempt to index local 'def' (a nil value) 2023-11-19 18:41:25: ERROR[Main]: stack traceback: 2023-11-19 18:41:25: ERROR[Main]: ...mt/5.7.0/Minetest_test/bin/../mods/minetest-tnt/init.lua:257: in function 'add_effects' 2023-11-19 18:41:25: ERROR[Main]: ...mt/5.7.0/Minetest_test/bin/../mods/minetest-tnt/init.lua:462: in function 'boom' 2023-11-19 18:41:25: ERROR[Main]: ....7.0/Minetest_test/bin/../mods/yl_nether_mobs/wither.lua:161: in function 'hit_node' 2023-11-19 18:41:25: ERROR[Main]: /home/mt/5.7.0/Minetest_test/bin/../mods/mobs_redo/api.lua:4230: in function 'func' 2023-11-19 18:41:25: ERROR[Main]: ...inetest_test/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:101>
AliasAlreadyTaken added the
1. kind/bug
 label 2023-11-19 18:59:40 +00:00
AliasAlreadyTaken commented 2023-11-19 19:48:28 +00:00
Author
Owner
Copy Link

Repro:

  1. Wield light, like a torch
  2. Let Withers shoot you
  3. Dodge, so their shots explode
  4. Turn off the light, switch to something else
    => boom
Repro: 1. Wield light, like a torch 2. Let Withers shoot you 3. Dodge, so their shots explode 4. Turn off the light, switch to something else => boom
flux added this to the flux's TODO list project 2023-11-19 21:40:47 +00:00
flux commented 2023-11-19 23:35:01 +00:00
Member
Copy Link

apparently this is caused by trying to set the tnt explosion texture to the texture of the dropped node, but the dropped thing isn't a node. perhaps an anvil w/ a tool on it?

should be fixed here: f4487dd093

apparently this is caused by trying to set the tnt explosion texture to the texture of the dropped node, but the dropped thing isn't a node. perhaps an anvil w/ a tool on it? should be fixed here: https://github.com/fluxionary/minetest-tnt/commit/f4487dd0934ed75eff5e6c3c4ff98cb5e0cd1009
flux added the
4. step/ready to QA test
 label 2023-11-19 23:35:38 +00:00
AliasAlreadyTaken commented 2023-11-20 00:09:25 +00:00
Author
Owner
Copy Link

If we're not sure, feel free to add logging to it so we can see what's actually happening. I'm fairly certain there was no anvil around.

If we're not sure, feel free to add logging to it so we can see what's actually happening. I'm fairly certain there was no anvil around.
AliasAlreadyTaken added this to the 1.1.122 milestone 2023-11-20 00:09:54 +00:00
flux commented 2023-11-21 22:59:07 +00:00
Member
Copy Link

If we're not sure, feel free to add logging to it so we can see what's actually happening. I'm fairly certain there was no anvil around.

it could have been something other than an anvil, anything that drops an item when it blows up. an ore node seems likely if there was no anvil nearby, there's ore in the nether.

> If we're not sure, feel free to add logging to it so we can see what's actually happening. I'm fairly certain there was no anvil around. it could have been something other than an anvil, anything that drops an item when it blows up. an ore node seems likely if there was no anvil nearby, there's ore in the nether.
AliasAlreadyTaken commented 2023-11-30 13:05:47 +00:00
Author
Owner
Copy Link

Repro:

=> Bring a damaged balrog whip and an anvil

  1. go to nether
  2. get shot at by withers and blazes
  3. Place an the anvil and the balrog whip on top
    => Boom

The commit above is on the testserver where the crash happened. It crashes as soon as a wither shot hits the anvil, the anvil and the damaged weapon survives the crash.

2023-11-30 13:02:21: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'fire' in callback luaentity_Step(): /home/mt/5.7.0/Minetest_test/bin/../mods/anvil/anvil.lua:275: attempt to call global 'remove_item' (a nil value)
2023-11-30 13:02:21: ERROR[Main]: stack traceback:
2023-11-30 13:02:21: ERROR[Main]: 	/home/mt/5.7.0/Minetest_test/bin/../mods/anvil/anvil.lua:275: in function 'on_blast'
2023-11-30 13:02:21: ERROR[Main]: 	...mt/5.7.0/Minetest_test/bin/../mods/minetest-tnt/init.lua:416: in function 'tnt_explode'
2023-11-30 13:02:21: ERROR[Main]: 	...mt/5.7.0/Minetest_test/bin/../mods/minetest-tnt/init.lua:455: in function 'boom'
2023-11-30 13:02:21: ERROR[Main]: 	....7.0/Minetest_test/bin/../mods/yl_nether_mobs/wither.lua:161: in function 'hit_node'
2023-11-30 13:02:21: ERROR[Main]: 	/home/mt/5.7.0/Minetest_test/bin/../mods/mobs_redo/api.lua:4299: in function 'func'
2023-11-30 13:02:21: ERROR[Main]: 	...inetest_test/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:101>
Repro: => Bring a damaged balrog whip and an anvil 1. go to nether 2. get shot at by withers and blazes 3. Place an the anvil and the balrog whip on top => Boom The commit above is on the testserver where the crash happened. It crashes as soon as a wither shot hits the anvil, the anvil and the damaged weapon survives the crash. ``` 2023-11-30 13:02:21: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'fire' in callback luaentity_Step(): /home/mt/5.7.0/Minetest_test/bin/../mods/anvil/anvil.lua:275: attempt to call global 'remove_item' (a nil value) 2023-11-30 13:02:21: ERROR[Main]: stack traceback: 2023-11-30 13:02:21: ERROR[Main]: /home/mt/5.7.0/Minetest_test/bin/../mods/anvil/anvil.lua:275: in function 'on_blast' 2023-11-30 13:02:21: ERROR[Main]: ...mt/5.7.0/Minetest_test/bin/../mods/minetest-tnt/init.lua:416: in function 'tnt_explode' 2023-11-30 13:02:21: ERROR[Main]: ...mt/5.7.0/Minetest_test/bin/../mods/minetest-tnt/init.lua:455: in function 'boom' 2023-11-30 13:02:21: ERROR[Main]: ....7.0/Minetest_test/bin/../mods/yl_nether_mobs/wither.lua:161: in function 'hit_node' 2023-11-30 13:02:21: ERROR[Main]: /home/mt/5.7.0/Minetest_test/bin/../mods/mobs_redo/api.lua:4299: in function 'func' 2023-11-30 13:02:21: ERROR[Main]: ...inetest_test/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:101> ```
AliasAlreadyTaken added the
ugh/QA NOK
 label 2023-11-30 13:05:54 +00:00
flux commented 2023-12-01 01:25:29 +00:00
Member
Copy Link

Repro:

this is a separate bug w/ the anvil code. i apparently copied some code from "upstream" which wasn't compatible w/ our fork. i don't remember why i forked it, perhaps we should revisit that. should be fixed with this 7f43f0e8dd

either way, i should add a pre-commit check to our fork to ensure that we don't try to call undeclared globals, this was totally avoidable w/ automation.

> Repro: this is a separate bug w/ the anvil code. i apparently copied some code from "upstream" which wasn't compatible w/ our fork. i don't remember why i forked it, perhaps we should revisit that. should be fixed with this https://gitea.your-land.de/your-land/anvil/commit/7f43f0e8dd992462917057fd73f5ccd6fa9ef8b1 either way, i should add a pre-commit check to our fork to ensure that we don't try to call undeclared globals, this was totally avoidable w/ automation.
AliasAlreadyTaken commented 2023-12-04 18:11:35 +00:00
Author
Owner
Copy Link

QA

No more boom

QA No more boom
AliasAlreadyTaken added
ugh/QA OK
 and removed
ugh/QA NOK
 labels 2023-12-04 18:11:42 +00:00
flux commented 2023-12-18 22:10:15 +00:00
Member
Copy Link

assuming this is live because no boom

assuming this is live because no boom
flux closed this issue 2023-12-18 22:10:15 +00:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2023-12-18 22:10:30 +00:00
flux removed this from the flux's TODO list project 2023-12-18 22:10:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.122
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5526
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?