your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

DezS4125 reports: cows dying because of torches ... #5424

New Issue
Closed
opened 2023-10-27 13:56:21 +00:00 by yourland-report · 17 comments
yourland-report commented 2023-10-27 13:56:21 +00:00
Member
Copy Link

DezS4125 reports a bug:

cows dying because of torches

Player position:

{
	x = 3949.4030761719,
	y = 25.5,
	z = 408.34698486328
}

Player look:

{
	x = 0.43512740731239,
	y = -0.88212686777115,
	z = -0.18032270669937
}

Player information:

{
	lang_code = "",
	version_string = "5.7.0",
	formspec_version = 6,
	minor = 7,
	ip_version = 6,
	min_rtt = 0.25499999523163,
	avg_rtt = 0.38499999046326,
	min_jitter = 0,
	max_jitter = 13.910999298096,
	avg_jitter = 0.019999980926514,
	connection_uptime = 9321,
	serialization_version = 29,
	patch = 0,
	max_rtt = 14.217000007629,
	state = "Active",
	protocol_version = 42,
	major = 5
}

Player meta:

{
	fields = {
		["petz:werewolf"] = "0",
		yl_commons_player_created = "1697732720",
		["petz:lycanthropy"] = "1",
		jointime = "1697732720",
		["3d_armor_inventory"] = "return {\"shields:shield_rainbow 1 4624\", \"3d_armor:leggings_crystal 1 11560\", \"3d_armor:helmet_crystal 1 11560\", \"3d_armor:chestplate_crystal 1 11560\", \"3d_armor:boots_crystal 1 11560\", \"\"}",
		bitten = "0",
		["stamina:level"] = "13",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_medium\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_medium\"}",
		["stamina:poisoned"] = "no",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 3955, [\"y\"] = 34, [\"z\"] = 438}}",
		["stamina:exhaustion"] = "154",
		repellant = "0",
		xp = "34958",
		["signslib:pos"] = "(1984,-851,1308)",
		partychat = "party",
		hud_state = "on",
		digged_nodes = "40303",
		punch_count = "358",
		["petz:werewolf_clan_idx"] = "1",
		inflicted_damage = "6294",
		died = "17",
		crafted = "25517",
		yl_commons_player_joined = "1698405709",
		placed_nodes = "8085",
		played_time = "169156",
		yl_commons_thankyou = "6"
	}
}

Log identifier


[MOD] yl_report log identifier = SuwBB9bxfQLEepJzDl0nAXKsMnXxAKEI

Profiler save:

profile-20231027T135621.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 16h 47min 30s | max lag: 0.31s | clients (21/52): AliasAlreadyTaken, Bailiff, Basilius, BenOnly, Bingo, bizon, Cezar, daydream, DezS4125, donald, Heron, ihc, jim15, LadyPixels, LilyBelle, MineWorlds, Murmel, Parrish, Penelopee, Service, Sieros

Teleport command:

/teleport xyz 3949 26 408

Compass command:

/give_compass Construction SuwBB9bxfQLEepJzDl0nAXKsMnXxAKEI D2691E 3949 26 408
DezS4125 reports a bug: > cows dying because of torches Player position: ``` { x = 3949.4030761719, y = 25.5, z = 408.34698486328 } ``` Player look: ``` { x = 0.43512740731239, y = -0.88212686777115, z = -0.18032270669937 } ``` Player information: ``` { lang_code = "", version_string = "5.7.0", formspec_version = 6, minor = 7, ip_version = 6, min_rtt = 0.25499999523163, avg_rtt = 0.38499999046326, min_jitter = 0, max_jitter = 13.910999298096, avg_jitter = 0.019999980926514, connection_uptime = 9321, serialization_version = 29, patch = 0, max_rtt = 14.217000007629, state = "Active", protocol_version = 42, major = 5 } ``` Player meta: ``` { fields = { ["petz:werewolf"] = "0", yl_commons_player_created = "1697732720", ["petz:lycanthropy"] = "1", jointime = "1697732720", ["3d_armor_inventory"] = "return {\"shields:shield_rainbow 1 4624\", \"3d_armor:leggings_crystal 1 11560\", \"3d_armor:helmet_crystal 1 11560\", \"3d_armor:chestplate_crystal 1 11560\", \"3d_armor:boots_crystal 1 11560\", \"\"}", bitten = "0", ["stamina:level"] = "13", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_medium\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_medium\"}", ["stamina:poisoned"] = "no", yl_church = "return {[\"last_death\"] = {[\"x\"] = 3955, [\"y\"] = 34, [\"z\"] = 438}}", ["stamina:exhaustion"] = "154", repellant = "0", xp = "34958", ["signslib:pos"] = "(1984,-851,1308)", partychat = "party", hud_state = "on", digged_nodes = "40303", punch_count = "358", ["petz:werewolf_clan_idx"] = "1", inflicted_damage = "6294", died = "17", crafted = "25517", yl_commons_player_joined = "1698405709", placed_nodes = "8085", played_time = "169156", yl_commons_thankyou = "6" } } ``` Log identifier ``` [MOD] yl_report log identifier = SuwBB9bxfQLEepJzDl0nAXKsMnXxAKEI ``` Profiler save: ``` profile-20231027T135621.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 16h 47min 30s | max lag: 0.31s | clients (21/52): AliasAlreadyTaken, Bailiff, Basilius, BenOnly, Bingo, bizon, Cezar, daydream, DezS4125, donald, Heron, ihc, jim15, LadyPixels, LilyBelle, MineWorlds, Murmel, Parrish, Penelopee, Service, Sieros ``` Teleport command: ``` /teleport xyz 3949 26 408 ``` Compass command: ``` /give_compass Construction SuwBB9bxfQLEepJzDl0nAXKsMnXxAKEI D2691E 3949 26 408 ```
AliasAlreadyTaken was assigned by yourland-report 2023-10-27 13:56:21 +00:00
AliasAlreadyTaken added the
3. source/integration
 label 2023-10-27 18:08:10 +00:00
AliasAlreadyTaken commented 2023-10-27 18:08:30 +00:00
Owner
Copy Link

We need to add torches to "blocks" the normal mobs try to avoid

We need to add torches to "blocks" the normal mobs try to avoid
AliasAlreadyTaken added the
2. prio/good first issue
1. kind/enhancement
 labels 2023-10-27 18:08:41 +00:00
rewired_X commented 2023-10-27 19:56:25 +00:00
Copy Link

I can try to work on this but im not entirely sure what I should be looking for so I can add torches to the list

I can try to work on this but im not entirely sure what I should be looking for so I can add torches to the list
daydream commented 2023-10-28 20:48:09 +00:00
Member
Copy Link

How about you put torches up higher so they can't get burned on them?

How about you put torches up higher so they can't get burned on them?
DragonWrangler commented 2023-10-28 23:24:23 +00:00
Copy Link

someone should also make it where miocene avoid torches too. after all, a few miocene have already died due to torches in the first wave of new quests.

someone should also make it where miocene avoid torches too. after all, a few miocene have already died due to torches in the first wave of new quests.
AliasAlreadyTaken commented 2023-10-30 02:04:51 +00:00
Owner
Copy Link

I can try to work on this but im not entirely sure what I should be looking for so I can add torches to the list

Mobs have a "avoid this block" mechanic. You could write a loop that targets all mobs_redo mobs and adds this block to the blocks to be avoided. Make sure not to overwrite existing avoidblocks:

https://codeberg.org/tenplus1/mobs_redo/src/branch/master/api.txt#L156

> I can try to work on this but im not entirely sure what I should be looking for so I can add torches to the list Mobs have a "avoid this block" mechanic. You could write a loop that targets all mobs_redo mobs and adds this block to the blocks to be avoided. Make sure not to overwrite existing avoidblocks: https://codeberg.org/tenplus1/mobs_redo/src/branch/master/api.txt#L156
flux commented 2023-11-09 23:08:50 +00:00
Member
Copy Link

I can try to work on this but im not entirely sure what I should be looking for so I can add torches to the list

Mobs have a "avoid this block" mechanic. You could write a loop that targets all mobs_redo mobs and adds this block to the blocks to be avoided. Make sure not to overwrite existing avoidblocks:

https://codeberg.org/tenplus1/mobs_redo/src/branch/master/api.txt#L156

if you were trying to indicate the runaway_from parameter, that won't work - it only works for entities and players. instead you have to override mobs:is_node_dangerous(mob_object, nodename)

9e27f45663/api.txt (L765-L768)

> > I can try to work on this but im not entirely sure what I should be looking for so I can add torches to the list > > Mobs have a "avoid this block" mechanic. You could write a loop that targets all mobs_redo mobs and adds this block to the blocks to be avoided. Make sure not to overwrite existing avoidblocks: > > https://codeberg.org/tenplus1/mobs_redo/src/branch/master/api.txt#L156 if you were trying to indicate the `runaway_from` parameter, that won't work - it only works for entities and players. instead you have to override `mobs:is_node_dangerous(mob_object, nodename)` https://codeberg.org/tenplus1/mobs_redo/src/commit/9e27f45663cc0c0df0e329bfbcf92466cca2ce3c/api.txt#L765-L768
AliasAlreadyTaken commented 2023-11-10 16:03:25 +00:00
Owner
Copy Link

Documentation says it can also have nodes to run away from. Does that not work?

 	   'runaway_from'        contains a table with mob names or nodesto run away
	                         from, add "player" to list to runaway from player also.
Documentation says it can also have nodes to run away from. Does that not work? ``` 'runaway_from' contains a table with mob names or nodesto run away from, add "player" to list to runaway from player also. ```
flux commented 2023-11-11 22:37:32 +00:00
Member
Copy Link

Documentation says it can also have nodes to run away from. Does that not work?

 	   'runaway_from'        contains a table with mob names or nodesto run away
	                         from, add "player" to list to runaway from player also.

oh somehow i didn't see the word "nodes" in there despite reading it several times. probably because my brain filtered it out due to the typo.

> Documentation says it can also have nodes to run away from. Does that not work? > > ``` > 'runaway_from' contains a table with mob names or nodesto run away > from, add "player" to list to runaway from player also. > ``` oh somehow i didn't see the word "nodes" in there despite reading it several times. probably because my brain filtered it out due to the typo.
flux commented 2023-11-11 23:06:24 +00:00
Member
Copy Link

i implemented this before i remembered we'd marked it as "good first issue". fde9ac9ddb

it works ok, but the cows and other things certainly get confused if there's a lot of torches in the area, and lag makes it unreliable (though there isn't really a good solution for that due to limitations of mobs).

i implemented this before i remembered we'd marked it as "good first issue". https://gitea.your-land.de/your-land/yl_commons/commit/fde9ac9ddbeb56af4ebab236c2e5f383925e2cd8 it works ok, but the cows and other things certainly get confused if there's a lot of torches in the area, and lag makes it unreliable (though there isn't really a good solution for that due to limitations of mobs).
👍 1
flux added the
4. step/ready to QA test
 label 2023-11-11 23:06:34 +00:00
AliasAlreadyTaken added this to the 1.1.122 milestone 2023-11-12 19:22:50 +00:00
AliasAlreadyTaken commented 2023-11-30 16:33:15 +00:00
Owner
Copy Link

QA

Flower cows do not run away, most hostile mobs don't either. We can't add a cost to a field for hostile mobs, right?

Maybe we should also make Miocene, Balrogs and dragons not take damage from fire.

QA Flower cows do not run away, most hostile mobs don't either. We can't add a cost to a field for hostile mobs, right? Maybe we should also make Miocene, Balrogs and dragons not take damage from fire.
AliasAlreadyTaken added the
4. step/question
 label 2023-11-30 19:27:08 +00:00
flux commented 2023-12-01 21:31:14 +00:00
Member
Copy Link

Balrogs

those are already immune, i'll add to the avoid lists of the other non-hostile mobs and dragons

> Balrogs those are already immune, i'll add to the avoid lists of the other non-hostile mobs and dragons
flux commented 2023-12-01 21:39:07 +00:00
Member
Copy Link

added flower and biome cows: 7f0d41cd24

dragons and mios are already immune to fire damage, though i'm not certain if they're immune to fire-based node damage...

added flower and biome cows: https://gitea.your-land.de/your-land/yl_commons/commit/7f0d41cd24fbd3b92a1c172c2b05450ff09dc01a dragons and mios are already immune to fire damage, though i'm not certain if they're immune to fire-based node damage...
flux commented 2023-12-01 21:42:04 +00:00
Member
Copy Link

i'm not certain if they're immune to fire-based node damage...

experiments show they are not

> i'm not certain if they're immune to fire-based node damage... experiments show they are not
flux commented 2023-12-01 22:44:27 +00:00
Member
Copy Link

experiments show they are not

because torches are not in the "fire" group. neither is lava, fire flowers, . i'm wondering if the best way to solve this is to just add things to that group in integration, or suggest to Tenplus1 to change the logic... probably i'll opt for the former, i'm not sure what the best logic change would be.

> experiments show they are not because torches are not in the "fire" group. neither is lava, fire flowers, . i'm wondering if the best way to solve this is to just add things to that group in integration, or suggest to Tenplus1 to change the logic... probably i'll opt for the former, i'm not sure what the best logic change would be.
flux commented 2023-12-01 23:14:41 +00:00
Member
Copy Link

added a bunch of relevant things to the fire group:

this will prevent fire-proof mobs like nether dragon and mios from taking node damage from these nodes.

added a bunch of relevant things to the fire group: * https://gitea.your-land.de/your-land/yl_commons/commit/b8e253cf6cefb539c28d96c767416e981369eb01 * https://gitea.your-land.de/your-land/yl_events/commit/bba4022e4ca8b544a7f0a34152a2778fbb9096a0 * https://gitea.your-land.de/your-land/yl_fireplace/commit/0534ec55eda6ec38aec63ed35fa341f71592c65c this will prevent fire-proof mobs like nether dragon and mios from taking node damage from these nodes.
👍 1
AliasAlreadyTaken commented 2023-12-03 21:44:58 +00:00
Owner
Copy Link

QA

Appears to be working. I only took reasonable random samples.

QA Appears to be working. I only took reasonable random samples.
AliasAlreadyTaken added
ugh/QA OK
 and removed
4. step/question
 labels 2023-12-03 21:45:12 +00:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2023-12-18 01:07:49 +00:00
AliasAlreadyTaken was unassigned by flux 2023-12-18 01:07:52 +00:00
flux commented 2023-12-18 01:08:32 +00:00
Member
Copy Link

this is live. note that cows can still run over torches and burn to death, mostly due to lag.

this is live. note that cows can still run over torches and burn to death, mostly due to lag.
flux closed this issue 2023-12-18 01:09:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.122
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5424
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?