Stack overflow yl_commons/features/tool_alert.lua:330: in function 'node_dig' #5420
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#5420
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
2023-10-25 14:22:55: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback node_on_dig(): stack overflow
2023-10-25 14:22:55: ERROR[Main]: stack traceback:
2023-10-25 14:22:55: ERROR[Main]: [C]: in function 'read'
2023-10-25 14:22:55: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../builtin/game/auth.lua:14: in function 'get_auth'
2023-10-25 14:22:55: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../builtin/game/misc.lua:99: in function 'player_exists'
2023-10-25 14:22:55: ERROR[Main]: ...live/bin/../mods/yl_areas_addon/chatcommand_area_ban.lua:201: in function 'is_protected'
2023-10-25 14:22:55: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../builtin/game/item.lua:473: in function 'old_node_dig'
2023-10-25 14:22:55: ERROR[Main]: ...test_live/bin/../mods/yl_commons/features/tool_alert.lua:330: in function 'node_dig'
2023-10-25 14:22:55: ERROR[Main]: ...ve/bin/../games/minetest_game/mods/default/functions.lua:301: in function 'dig_up'
2023-10-25 14:22:55: ERROR[Main]: ...t_live/bin/../games/minetest_game/mods/default/nodes.lua:1416: in function 'after_dig_node'
2023-10-25 14:22:55: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../builtin/game/item.lua:547: in function 'old_node_dig'
2023-10-25 14:22:55: ERROR[Main]: ...test_live/bin/../mods/yl_commons/features/tool_alert.lua:330: in function 'node_dig'
2023-10-25 14:22:55: ERROR[Main]: ...
2023-10-25 14:22:55: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../builtin/game/item.lua:547: in function 'old_node_dig'
2023-10-25 14:22:55: ERROR[Main]: ...test_live/bin/../mods/yl_commons/features/tool_alert.lua:330: in function 'node_dig'
2023-10-25 14:22:55: ERROR[Main]: ...ve/bin/../games/minetest_game/mods/default/functions.lua:301: in function 'dig_up'
2023-10-25 14:22:55: ERROR[Main]: ...t_live/bin/../games/minetest_game/mods/default/nodes.lua:1416: in function 'after_dig_node'
2023-10-25 14:22:55: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../builtin/game/item.lua:547: in function 'old_node_dig'
2023-10-25 14:22:55: ERROR[Main]: ...test_live/bin/../mods/yl_commons/features/tool_alert.lua:330: in function 'node_dig'
2023-10-25 14:22:55: ERROR[Main]: ...ve/bin/../games/minetest_game/mods/default/functions.lua:301: in function 'dig_up'
2023-10-25 14:22:55: ERROR[Main]: ...t_live/bin/../games/minetest_game/mods/default/nodes.lua:1416: in function 'after_dig_node'
2023-10-25 14:22:55: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../builtin/game/item.lua:547: in function 'old_node_dig'
2023-10-25 14:22:55: ERROR[Main]: ...test_live/bin/../mods/yl_commons/features/tool_alert.lua:330: in function <...test_live/bin/../mods/yl_commons/features/tool_alert.lua:324>
this isn't actually the fault of the tool_alert code. the culprit here seems to be the "dig up" functionality of the papyrus. i suspect this isn't actually an infinite loop, but someone tried to dig an artificially tall papyrus. this probably gets registered as a bug in minetest_game.
upstream issue: https://github.com/minetest/minetest_game/issues/3075
i bet this was an attempt at getting a whole lot of XP quickly... which is another issue. looking @ the crash logs, the culprit is ALCOHOL3.
From the upstream issue steps to reproduce:
When trying to reproduce #5420 this happened:
Repro:
5000 blocks high papyrus
1 rainbow axe
1 Boris
leads to all blocks getting dug upwards, falling and Boris' inventory filling up. Then crash:
i'm not surprised it still crashes, the fix in #6353 doesn't address the stack overflow. there's not a great way to do that either.