your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

Suggestion: Make mobs protected by a level 2 rune immune to elec sword's explosive damage #5329

New Issue
Closed
opened 2023-09-26 20:59:56 +00:00 by rewired_X · 11 comments
rewired_X commented 2023-09-26 20:59:56 +00:00
Copy Link

#5328 is mainly why im making this after my freak accident, but imo it should be made that explosive damage from an electrumese sword should be nullified with a level 2 rune

#5328 is mainly why im making this after my freak accident, but imo it should be made that explosive damage from an electrumese sword should be nullified with a level 2 rune
AliasAlreadyTaken added the
1. kind/bug
3. source/integration
 labels 2023-09-27 07:08:44 +00:00
flux commented 2023-11-04 17:24:43 +00:00
Member
Copy Link

i'm not certain it's possible to differentiate explosion damage from the electrumese sword vs. other explosions

i'm not certain it's possible to differentiate explosion damage from the electrumese sword vs. other explosions
AliasAlreadyTaken commented 2023-11-06 23:58:49 +00:00
Owner
Copy Link

maybe we need to make explosive damage "owned" by whoever sends it? your-land/administration#163

maybe we need to make explosive damage "owned" by whoever sends it? https://gitea.your-land.de/your-land/administration/issues/163
flux commented 2023-11-10 20:57:47 +00:00
Member
Copy Link

the bullets already track that info and pass it to the explosion, so the pvp stuff can make it behave by those rules... that's an idea.

the bullets already track that info and pass it to the explosion, so the pvp stuff can make it behave by those rules... that's an idea.
👍 1
flux commented 2023-11-10 21:59:59 +00:00
Member
Copy Link

i tweaked our TNT fork so that

  1. when tnt causes damage to a mob, if there was a "puncher" (player who caused the explosion), that is passed to the obj:punch call instead of the object itself. note there's still a race condition where the player shoots a bullet and then logs off, the animal will still "punch itself"...
  2. on_blast callbacks for objects and nodes get an additional argument, the "owner" of the explosion.

however, as mobs_redo implements an on_blast callback already, we're going to have to override that for every tamable mob...

i tweaked our TNT fork so that 1. when tnt causes damage to a mob, if there was a "puncher" (player who caused the explosion), that is passed to the `obj:punch` call instead of the object itself. note there's still a race condition where the player shoots a bullet and then logs off, the animal will still "punch itself"... 2. on_blast callbacks for objects and nodes get an additional argument, the "owner" of the explosion. however, as mobs_redo implements an `on_blast` callback already, we're going to have to override that for every tamable mob...
flux commented 2023-11-10 22:17:44 +00:00
Member
Copy Link

overriding on_blast: 40e0490937

overriding on_blast: https://gitea.your-land.de/your-land/yl_commons/commit/40e0490937a9d4a89c24e4be0798b23a73f272f7
flux commented 2023-11-10 22:41:08 +00:00
Member
Copy Link

hm, that didn't work....

hm, that didn't work....
flux commented 2023-11-11 00:39:52 +00:00
Member
Copy Link

actually protection isn't working at all on my local server, i need to dig into that more. not today though, not sure when i'll get back to this.

actually protection isn't working *at all* on my local server, i need to dig into that more. not today though, not sure when i'll get back to this.
flux added this to the flux's TODO list project 2023-11-11 00:40:01 +00:00
flux self-assigned this 2023-11-23 20:43:38 +00:00
flux added the
4. step/at work
 label 2023-11-23 20:43:49 +00:00
flux commented 2023-11-23 21:21:25 +00:00
Member
Copy Link

actually protection isn't working at all on my local server, i need to dig into that more. not today though, not sure when i'll get back to this.

turns out protection runes only work if the mob is also in a protection area that the player doesn't have access to. explosions are still killing them though...

> actually protection isn't working *at all* on my local server, i need to dig into that more. not today though, not sure when i'll get back to this. turns out protection runes only work if the mob is also in a protection area that the player doesn't have access to. explosions are still killing them though...
👀 1
flux commented 2023-11-23 22:01:11 +00:00
Member
Copy Link

figured out the main issue - the protection code wasn't executing due to an error.

mobs with protection and in protection areas are now protected against damage from explosions that originate from a player.

ae3663c2e2

figured out the main issue - the protection code wasn't executing due to an error. mobs with protection and in protection areas are now protected against damage from explosions that originate from a player. https://gitea.your-land.de/your-land/yl_commons/commit/ae3663c2e239640aca863b6f7273db98d102f988
flux added
4. step/ready to QA test
 and removed
4. step/at work
 labels 2023-11-23 22:01:22 +00:00
AliasAlreadyTaken added this to the 1.1.122 milestone 2023-11-23 22:06:42 +00:00
AliasAlreadyTaken commented 2023-12-03 23:02:28 +00:00
Owner
Copy Link

QA

I can still explode my own cows, but now those of someone else.

QA I can still explode my own cows, but now those of someone else.
AliasAlreadyTaken added the
ugh/QA OK
 label 2023-12-03 23:02:33 +00:00
flux commented 2023-12-17 23:54:42 +00:00
Member
Copy Link

this is live

this is live
flux closed this issue 2023-12-17 23:54:43 +00:00
flux removed this from the flux's TODO list project 2023-12-17 23:54:50 +00:00
flux removed their assignment 2023-12-17 23:54:55 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.122
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#5329
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?