Tree roots from the Trunks mod no longer spawn naturally #5327

New Issue

Chache · 2023-09-25T21:22:51Z

Chache commented

2023-09-25 21:22:51 +00:00

In the same fashion as Rheo did in issue number #5120 about the "woodsoils:dirt_with_leaves_2" not spawning (and therefore questioning the usefulness of having a node that doesn't appear in the map) I'd like to point out that the roots from the Trunks mod, although they did spawn some time ago, have since ceased to do so.

This is all I have found:

By about the time I joined the server (Feb 2022) there was a different map-generating algorithm that caused, amongst other things, these tree roots and also tree trunks placed horizontally (imitating fallen trees) to appear naturally.
Soon after, that algorithm must have been replaced by another one, so roots and fallen trees ceased to spawn.
Such tree roots can still be found but they are extremely rare. You need to visit chunks that were created prior to the mapgen algorithm change. Seeing naturally fallen trees is a sign you're in the good environment. Evil123 has been taking me to all the places where the war between dwarves and seekers took place (the timeline agrees), and I did found some of the roots near those places.
I think Sixer said there are between 20 and 400 such tree roots on the whole map of YourLand.

The question is: do we want those to be so rare that most players have never seen any of them?

PS: in case you don't know what I'm talking about, type "root" (in singular) in the search bar of the crafting guide. You can see all 14 root nodes from the Trunks mod in Puerto del Sol's Dendrology Museum, coords [3031, -1, -2702].

In the same fashion as Rheo did in issue number #5120 about the "woodsoils:dirt_with_leaves_2" not spawning (and therefore questioning the usefulness of having a node that doesn't appear in the map) I'd like to point out that the roots from the Trunks mod, although they did spawn some time ago, have since ceased to do so. This is all I have found: - By about the time I joined the server (Feb 2022) there was a different map-generating algorithm that caused, amongst other things, these tree roots and also tree trunks placed horizontally (imitating fallen trees) to appear naturally. - Soon after, that algorithm must have been replaced by another one, so roots and fallen trees ceased to spawn. - Such tree roots can still be found but they are extremely rare. You need to visit chunks that were created prior to the mapgen algorithm change. Seeing naturally fallen trees is a sign you're in the good environment. Evil123 has been taking me to all the places where the war between dwarves and seekers took place (the timeline agrees), and I did found some of the roots near those places. - I think Sixer said there are between 20 and 400 such tree roots on the whole map of YourLand. The question is: do we want those to be so rare that most players have never seen any of them? PS: in case you don't know what I'm talking about, type "root" (in singular) in the search bar of the crafting guide. You can see all 14 root nodes from the Trunks mod in Puerto del Sol's Dendrology Museum, coords [3031, -1, -2702].

Chache commented

2023-09-25 21:28:58 +00:00

And by the way, the "emtpy rubber tree trunk" is another thing that ceased to spawn. Apparently, sap from rubber trees can be collected using something called a "tree tap" from some Tree Technic mod, but that mod is not installed.

That would cause the normal rubber tree trunk to turn into empty rubber tree trunk, which would re-generate and turn normal again after some time, if connected to rubber tree leaves.

As far as I know, it is currently not possible to harvest sap from rubber trees.

And by the way, the "emtpy rubber tree trunk" is another thing that ceased to spawn. Apparently, sap from rubber trees can be collected using something called a "tree tap" from some Tree Technic mod, but that mod is not installed. That would cause the normal rubber tree trunk to turn into empty rubber tree trunk, which would re-generate and turn normal again after some time, if connected to rubber tree leaves. As far as I know, it is currently not possible to harvest sap from rubber trees.

screenshot_20230925_232405.png

384 KiB

Sokomine commented

2023-09-26 02:47:18 +00:00

The roots can be very decorative. I like the plantlife_modpack a lot, and many of us here love well-looking nature. If the natural spawning of the roots broke for some reason, perhaps we can add a way to add them back manually?

Idea: Call abstract_trunks.grow_roots(pos) for the lowest trunk node when the player hits a tree trunk somewhere above that lowest node with bonemeal. We're not taking the lowest part as that might conflict with the player having grown that tree from a sapling with bonemeal.

The roots can be very decorative. I like the plantlife_modpack a lot, and many of us here love well-looking nature. If the natural spawning of the roots broke for some reason, perhaps we can add a way to add them back manually? Idea: Call abstract_trunks.grow_roots(pos) for the lowest trunk node when the player hits a tree trunk somewhere above that lowest node with bonemeal. We're not taking the lowest part as that might conflict with the player having grown that tree from a sapling with bonemeal.

AliasAlreadyTaken added the

1. kind/enhancement

label 2023-09-26 06:36:20 +00:00

flux commented

2023-11-03 19:03:09 +00:00

the old (2 years ago?) generation of the tree roots wasn't done at map load time, but rather was done by a relatively expensive ABM. i don't think anything was put in to create them when that was removed, so they started to become rare. recently there's been a lot of work done to remove dependency of plantlife_modpack on biome_lib, which is an ancient mod that predates mapgen features like decorations. it looks like the vines still use biome_lib though, at least in our code (github seems to be having a seizure at the moment, so i can't see what's upstream). it looks like it should be trying to spawn in hot, humid biomes, though...