noodles reports: I just found an infinite mater ... #527

New Issue

yourland-report · 2021-05-08T18:32:39Z

yourland-report commented

2021-05-08 18:32:39 +00:00

noodles reports a bug:

I just found an infinite materials bug... 5 wood crossbraces make 10 wood crossbraces. Also, crossbraces can be used to make chests, sticks, ladders...

Player position:

{
	y = 4.5,
	x = -1434.7330322266,
	z = -2886.1501464844
}

Player look:

{
	y = -0.081764563918114,
	x = 0.83595716953278,
	z = -0.54266947507858
}

Player information:

{
	min_rtt = 0.11999999731779,
	max_rtt = 1.2259999513626,
	connection_uptime = 1578,
	lang_code = "",
	address = "::ffff:74.134.5.182",
	formspec_version = 4,
	protocol_version = 39,
	avg_rtt = 0.12600000202656,
	min_jitter = 0,
	ip_version = 6,
	max_jitter = 1.1019999980927,
	avg_jitter = 0.0029999986290932
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 2120\", \"3d_armor:chestplate_crystal 1 2120\", \"3d_armor:leggings_crystal 1 2120\", \"3d_armor:boots_crystal 1 2120\", \"shields:shield_crystal 1 2120\", \"\"}",
		yl_commons_thankyou = "1",
		jointime = "1614625622",
		yl_commons_player_joined = "1620497263",
		["signslib:pos"] = "(-1432,5,-2883)",
		digged_nodes = "144949",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -14, [\"x\"] = -1301, [\"z\"] = -2900}, [\"last_death_portal\"] = 1619908208}",
		["stamina:level"] = "14",
		xp = "166408",
		inflicted_damage = "117086",
		crafted = "6025",
		punch_count = "6777",
		played_time = "879263",
		died = "13",
		hud_state = "on",
		placed_nodes = "66170",
		yl_commons_player_created = "1614625622"
	}
}

Log identifier


[MOD] yl_report log identifier = QX9GKmhHHC9FFNypwaRAogwowJqIBmyR

Profiler save:

profile-20210508T203239.json_pretty

Status:

# Server: version=5.3.0-yl, uptime=309130, max_lag=3.31759, clients={kosti, kev1, ria, noodles, The_Dirt_Robber, -friskgamer-, debian44, Cooki, Runy, bibi, Test_User, ROMEOPOLO, Boot, MIK, whosit, AliasAlreadyTaken, Ernesto, Service, Bailiff}

noodles reports a bug: > I just found an infinite materials bug... 5 wood crossbraces make 10 wood crossbraces. Also, crossbraces can be used to make chests, sticks, ladders... Player position: ``` { y = 4.5, x = -1434.7330322266, z = -2886.1501464844 } ``` Player look: ``` { y = -0.081764563918114, x = 0.83595716953278, z = -0.54266947507858 } ``` Player information: ``` { min_rtt = 0.11999999731779, max_rtt = 1.2259999513626, connection_uptime = 1578, lang_code = "", address = "::ffff:74.134.5.182", formspec_version = 4, protocol_version = 39, avg_rtt = 0.12600000202656, min_jitter = 0, ip_version = 6, max_jitter = 1.1019999980927, avg_jitter = 0.0029999986290932 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 2120\", \"3d_armor:chestplate_crystal 1 2120\", \"3d_armor:leggings_crystal 1 2120\", \"3d_armor:boots_crystal 1 2120\", \"shields:shield_crystal 1 2120\", \"\"}", yl_commons_thankyou = "1", jointime = "1614625622", yl_commons_player_joined = "1620497263", ["signslib:pos"] = "(-1432,5,-2883)", digged_nodes = "144949", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = -14, [\"x\"] = -1301, [\"z\"] = -2900}, [\"last_death_portal\"] = 1619908208}", ["stamina:level"] = "14", xp = "166408", inflicted_damage = "117086", crafted = "6025", punch_count = "6777", played_time = "879263", died = "13", hud_state = "on", placed_nodes = "66170", yl_commons_player_created = "1614625622" } } ``` Log identifier ``` [MOD] yl_report log identifier = QX9GKmhHHC9FFNypwaRAogwowJqIBmyR ``` Profiler save: ``` profile-20210508T203239.json_pretty ``` Status: ``` # Server: version=5.3.0-yl, uptime=309130, max_lag=3.31759, clients={kosti, kev1, ria, noodles, The_Dirt_Robber, -friskgamer-, debian44, Cooki, Runy, bibi, Test_User, ROMEOPOLO, Boot, MIK, whosit, AliasAlreadyTaken, Ernesto, Service, Bailiff} ```

AliasAlreadyTaken was assigned by yourland-report

2021-05-08 18:32:39 +00:00

whosit referenced this issue

2021-06-12 22:58:23 +00:00

MilesPacis reports: So, another bug related to the ... #650

AliasAlreadyTaken added the

1. kind/bug

label 2021-07-18 10:36:59 +00:00

AliasAlreadyTaken commented

2021-07-18 10:40:55 +00:00

https://github.com/minetest-mods/castle_masonry/issues/18

AliasAlreadyTaken added the

3. source/mod upstream

label 2021-07-18 10:41:00 +00:00

Styxcolor commented

2021-12-30 23:22:20 +00:00

Checked it and found out I already "fixed" the immediate problem of making 5 wooden pillars into ten by changing the recipe for the small crossbraces. They currently can only be crafted with 5 default wood.
See #284

I don't know whether that's an ideal solution though. At least the original dupe doesn't work. The big crossbrace is still part of the wood group though.

Checked it and found out I already "fixed" the immediate problem of making 5 wooden pillars into ten by changing the recipe for the small crossbraces. They currently can only be crafted with 5 default wood. See #284 I don't know whether that's an ideal solution though. At least the original dupe doesn't work. The big crossbrace is still part of the wood group though.

Styxcolor added the

4. step/question

label 2021-12-30 23:22:42 +00:00

Styxcolor added this to the 1.1.104.3 milestone 2021-12-30 23:22:46 +00:00

Styxcolor added this to the (deleted) project 2021-12-30 23:22:48 +00:00

flux referenced this issue

2022-01-03 23:30:17 +00:00

Discord Bugreport Wood Dupe #1143

AliasAlreadyTaken removed this from the 1.1.104.3 milestone 2022-01-04 10:01:43 +00:00

AliasAlreadyTaken referenced this issue

2022-01-06 08:11:14 +00:00

Discord Bugreport Wood Dupe #1143

flux commented

2022-01-06 21:36:39 +00:00

The crossbrace isn't the only problem - the half pillars are as well.

There's a few ways I can see to fix this.

The simplest would be to remove the "composition_material" from wooden items - you would then not be able to craft random wooden stuff with them, or burn them. Fortunately, wood is the only material that specifies a composition material, otherwise we'd have bigger problems.

The next simplest way would be to change the recipes for the various things to output as many items as were used in the crafting recipes. pillar tops/bottoms would output 5, pillar shafts would be 3, crossbraces would be 5 (instead of 10), and half pillars would be made with full pillars (instead of getting 2).

I could implement either of these pretty directly. If I do, would you prefer me to PR upstream, or to our own repo?

The crossbrace isn't the only problem - the half pillars are as well. There's a few ways I can see to fix this. The simplest would be to remove the "composition_material" from wooden items - you would then not be able to craft random wooden stuff with them, or burn them. Fortunately, wood is the only material that specifies a composition material, otherwise we'd have bigger problems. The next simplest way would be to change the recipes for the various things to output as many items as were used in the crafting recipes. pillar tops/bottoms would output 5, pillar shafts would be 3, crossbraces would be 5 (instead of 10), and half pillars would be made with full pillars (instead of getting 2). I could implement either of these pretty directly. If I do, would you prefer me to PR upstream, or to our own repo?

Styxcolor removed this from the (deleted) project 2022-01-28 00:28:56 +00:00

flux added the

4. step/want approval

label 2022-04-01 21:10:20 +00:00

flux referenced this issue

2022-04-12 18:11:21 +00:00

JeCel reports: Stone Crossbrace can't be craf ... #1730

AliasAlreadyTaken commented

2022-04-14 15:35:08 +00:00

Let's use the 2nd option and make equal in, equal out.

AliasAlreadyTaken added the

4. step/approved