LeetPeet reports: The crafting recipe for 2 wood ... #284

New Issue

yourland-report · 2021-02-18T00:49:15Z

yourland-report commented

2021-02-18 00:49:15 +00:00

LeetPeet reports a bug:

The crafting recipe for 2 wooden pillar half bases is one full base.  However, when I put a full wooden pillar in the crafting area, it turns it into sticks.  Why?

Player position:

{
	y = 4.5009999275208,
	x = 854.57098388672,
	z = 2052.0061035156
}

Player look:

{
	y = -0.58623099327087,
	x = 0.65475475788116,
	z = 0.477105230093
}

Player information:

{
	min_rtt = 0.097000002861023,
	max_rtt = 1.3630000352859,
	connection_uptime = 770,
	lang_code = "",
	address = "::ffff:108.48.172.201",
	formspec_version = 3,
	protocol_version = 39,
	avg_rtt = 0.10300000011921,
	min_jitter = 0,
	ip_version = 6,
	max_jitter = 1.2419999837875,
	avg_jitter = 0.0010000020265579
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"3d_armor:boots_crystal 1 23190\", \"\", \"\"}",
		yl_commons_player_joined = "1613608616",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 1, [\"x\"] = 938, [\"z\"] = 1958}, [\"last_death_portal\"] = 1613425312}",
		played_time = "992321",
		["stamina:level"] = "10.1",
		xp = "600506",
		punch_count = "6433",
		inflicted_damage = "46676",
		crafted = "13961",
		["signslib:pos"] = "(855,7,2061)",
		digged_nodes = "637641",
		yl_commons_player_created = "1609243939",
		placed_nodes = "62686",
		hud_state = "on",
		died = "117",
		partychat = "party"
	}
}

Log identifier


[MOD] yl_report log identifier = 2s1woieHiQz92uRE5pj0iGTMLteENZUS

Profiler save:

profile-20210218T014915.json_pretty

Status:

# Server: version=5.3.0-yl, uptime=149494, max_lag=1.14568, clients={darealbang, Bailiff, Eckkert, LeetPeet, Vino, InitialD, SireShaun, Torri}

LeetPeet reports a bug: ``` The crafting recipe for 2 wooden pillar half bases is one full base. However, when I put a full wooden pillar in the crafting area, it turns it into sticks. Why? ``` Player position: ``` { y = 4.5009999275208, x = 854.57098388672, z = 2052.0061035156 } ``` Player look: ``` { y = -0.58623099327087, x = 0.65475475788116, z = 0.477105230093 } ``` Player information: ``` { min_rtt = 0.097000002861023, max_rtt = 1.3630000352859, connection_uptime = 770, lang_code = "", address = "::ffff:108.48.172.201", formspec_version = 3, protocol_version = 39, avg_rtt = 0.10300000011921, min_jitter = 0, ip_version = 6, max_jitter = 1.2419999837875, avg_jitter = 0.0010000020265579 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"3d_armor:boots_crystal 1 23190\", \"\", \"\"}", yl_commons_player_joined = "1613608616", yl_church = "return {[\"last_death\"] = {[\"y\"] = 1, [\"x\"] = 938, [\"z\"] = 1958}, [\"last_death_portal\"] = 1613425312}", played_time = "992321", ["stamina:level"] = "10.1", xp = "600506", punch_count = "6433", inflicted_damage = "46676", crafted = "13961", ["signslib:pos"] = "(855,7,2061)", digged_nodes = "637641", yl_commons_player_created = "1609243939", placed_nodes = "62686", hud_state = "on", died = "117", partychat = "party" } } ``` Log identifier ``` [MOD] yl_report log identifier = 2s1woieHiQz92uRE5pj0iGTMLteENZUS ``` Profiler save: ``` profile-20210218T014915.json_pretty ``` Status: ``` # Server: version=5.3.0-yl, uptime=149494, max_lag=1.14568, clients={darealbang, Bailiff, Eckkert, LeetPeet, Vino, InitialD, SireShaun, Torri} ```

AliasAlreadyTaken was assigned by yourland-report

2021-02-18 00:49:15 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2021-02-22 18:49:49 +00:00

AliasAlreadyTaken added the

3. source/mod upstream

label 2021-02-22 19:10:13 +00:00

Styxcolor commented

2021-11-16 12:53:07 +00:00

Tested it, with me, I got a different but also buggy result. I could take apart a full wood pillar base into two half pillar bases without a problem - but two half pillar bases gave me back a wood pressure plate instead of a full pillar base. There must be conflicting recipes.

Styxcolor added the

4. step/at work

label 2021-11-16 12:53:16 +00:00

Styxcolor commented

2021-11-16 13:00:27 +00:00

this might be the rare case where I might to change a recipe to make it more expensive just to avoid being mistaken with other crafting recipes.
My suggestion:
{"castle_masonry:pillar_wood_bottom_half","castle_masonry:pillar_wood_bottom_half", ""},
{"castle_masonry:pillar_wood_bottom_half","castle_masonry:pillar_wood_bottom_half", ""}

... and this would return 2 full pillars, that would be fair.

I cannot recreate the bug that turns castle_masonry:pillar_wood_bottom into sticks, but that might as well be an issue, too, that I will check in the code.

If we're at it, I'll also check what's up with the top part of the same blocktype. Does that work as it should?

Update: castle_masonry:pillar_wood_top_half gives me the same erraneous crafting result as the bottom half pillar. Need to fix, too.

this might be the rare case where I might to change a recipe to make it more expensive just to avoid being mistaken with other crafting recipes. My suggestion: {"castle_masonry:pillar_wood_bottom_half","castle_masonry:pillar_wood_bottom_half", ""}, {"castle_masonry:pillar_wood_bottom_half","castle_masonry:pillar_wood_bottom_half", ""} ... and this would return 2 full pillars, that would be fair. I cannot recreate the bug that turns castle_masonry:pillar_wood_bottom into sticks, but that might as well be an issue, too, that I will check in the code. If we're at it, I'll also check what's up with the top part of the same blocktype. Does that work as it should? Update: castle_masonry:pillar_wood_top_half gives me the same erraneous crafting result as the bottom half pillar. Need to fix, too.

Styxcolor commented

2021-11-16 13:33:27 +00:00

Fixed. Everything worked fine in testing.

commit b4d1519b815c85d3e61d3a761d83448eadae832f

Fixed. Everything worked fine in testing. commit b4d1519b815c85d3e61d3a761d83448eadae832f

Styxcolor added

5. result/fixed

and removed

4. step/at work

labels 2021-11-16 13:33:39 +00:00

Styxcolor self-assigned this 2021-11-16 13:33:44 +00:00

Styxcolor added this to the 1.1.100 milestone 2021-11-16 13:33:49 +00:00