AspireMint reports: [bucket] Add new recipes river ... #4568

New Issue

yourland-report · 2023-05-20T21:06:29Z

yourland-report commented

2023-05-20 21:06:29 +00:00

AspireMint reports a bug:

[bucket] Add new recipes river_water_bucket -> empty_bucket and water_bucket -> empty_bucket.

Player position:

{
	z = 1172.3000488281,
	x = 1981.0310058594,
	y = 18
}

Player look:

{
	z = 0.921147108078,
	x = 0.013988272286952,
	y = -0.38896316289902
}

Player information:

{
	avg_rtt = 0.037999998778105,
	min_jitter = 0,
	max_jitter = 1.0680000782013,
	avg_jitter = 0,
	connection_uptime = 4290,
	serialization_version = 29,
	patch = 0,
	lang_code = "",
	state = "Active",
	formspec_version = 6,
	ip_version = 6,
	protocol_version = 41,
	minor = 7,
	major = 5,
	version_string = "5.7.0",
	max_rtt = 1.1089999675751,
	min_rtt = 0.035999998450279
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_nether 1 16920\", \"shields:shield_nether 1 16920\", \"3d_armor:helmet_nether 1 8460\", \"3d_armor:boots_crystal 1 8460\", \"3d_armor:leggings_nether 1 16920\", \"\"}",
		bitten = "0",
		repellant = "0",
		["stamina:exhaustion"] = "47.5",
		yl_commons_player_created = "1619715757",
		yl_commons_player_joined = "1684612519",
		played_time = "6138629",
		digged_nodes = "1946313",
		placed_nodes = "382922",
		died = "347",
		crafted = "111827",
		["stamina:level"] = "9",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 4175, [\"y\"] = 9, [\"z\"] = 1662}, [\"last_death_portal\"] = 1684610954, [\"last_heal\"] = 1681080750}",
		["ocean_build.forbidden"] = "true",
		hud_state = "on",
		punch_count = "522258",
		jointime = "1619715757",
		inflicted_damage = "11310026",
		xp = "2070964",
		yl_commons_thankyou = "241",
		["ocean_build.last_warning"] = "1.65674e+09",
		["stamina:poisoned"] = "no",
		["ocean_build.ocean_built"] = "12",
		["signslib:pos"] = "(2923,-193,349)",
		partychat = "party",
		arenalib_infobox_arenaID = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}"
	}
}

Log identifier


[MOD] yl_report log identifier = LhdKckYg3jPQ5Ru90Ltu9nCtxh8DaOGB

Profiler save:

profile-20230520T210629.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 1h 13min 8s | max lag: 0.308s | clients (23/52): AliasAlreadyTaken, annah, APercy, Apocralypse, AspireMint, Bailiff, bizon, Boot, Cryon, Dirac, flux, IIIullaIII, Kalek, laira, mahou, MineWorlds, Nomtom, Oakenshield, rewired_X, Service, shanish2, STEALTH, the_chosen_one

Teleport command:

/teleport xyz 1981 18 1172

Compass command:

/give_compass Construction LhdKckYg3jPQ5Ru90Ltu9nCtxh8DaOGB D2691E 1981 18 1172

AspireMint reports a bug: > [bucket] Add new recipes river_water_bucket -> empty_bucket and water_bucket -> empty_bucket. Player position: ``` { z = 1172.3000488281, x = 1981.0310058594, y = 18 } ``` Player look: ``` { z = 0.921147108078, x = 0.013988272286952, y = -0.38896316289902 } ``` Player information: ``` { avg_rtt = 0.037999998778105, min_jitter = 0, max_jitter = 1.0680000782013, avg_jitter = 0, connection_uptime = 4290, serialization_version = 29, patch = 0, lang_code = "", state = "Active", formspec_version = 6, ip_version = 6, protocol_version = 41, minor = 7, major = 5, version_string = "5.7.0", max_rtt = 1.1089999675751, min_rtt = 0.035999998450279 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_nether 1 16920\", \"shields:shield_nether 1 16920\", \"3d_armor:helmet_nether 1 8460\", \"3d_armor:boots_crystal 1 8460\", \"3d_armor:leggings_nether 1 16920\", \"\"}", bitten = "0", repellant = "0", ["stamina:exhaustion"] = "47.5", yl_commons_player_created = "1619715757", yl_commons_player_joined = "1684612519", played_time = "6138629", digged_nodes = "1946313", placed_nodes = "382922", died = "347", crafted = "111827", ["stamina:level"] = "9", yl_church = "return {[\"last_death\"] = {[\"x\"] = 4175, [\"y\"] = 9, [\"z\"] = 1662}, [\"last_death_portal\"] = 1684610954, [\"last_heal\"] = 1681080750}", ["ocean_build.forbidden"] = "true", hud_state = "on", punch_count = "522258", jointime = "1619715757", inflicted_damage = "11310026", xp = "2070964", yl_commons_thankyou = "241", ["ocean_build.last_warning"] = "1.65674e+09", ["stamina:poisoned"] = "no", ["ocean_build.ocean_built"] = "12", ["signslib:pos"] = "(2923,-193,349)", partychat = "party", arenalib_infobox_arenaID = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}" } } ``` Log identifier ``` [MOD] yl_report log identifier = LhdKckYg3jPQ5Ru90Ltu9nCtxh8DaOGB ``` Profiler save: ``` profile-20230520T210629.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 1h 13min 8s | max lag: 0.308s | clients (23/52): AliasAlreadyTaken, annah, APercy, Apocralypse, AspireMint, Bailiff, bizon, Boot, Cryon, Dirac, flux, IIIullaIII, Kalek, laira, mahou, MineWorlds, Nomtom, Oakenshield, rewired_X, Service, shanish2, STEALTH, the_chosen_one ``` Teleport command: ``` /teleport xyz 1981 18 1172 ``` Compass command: ``` /give_compass Construction LhdKckYg3jPQ5Ru90Ltu9nCtxh8DaOGB D2691E 1981 18 1172 ```

👍 1

AliasAlreadyTaken was assigned by yourland-report

2023-05-20 21:06:29 +00:00

flux added the

1. kind/enhancement

1. kind/balancing

labels 2023-05-20 23:17:20 +00:00

flux commented

2023-05-20 23:17:27 +00:00

makes sense to me.

AliasAlreadyTaken added the

2. prio/good first issue

4. step/approved

labels 2023-05-20 23:34:37 +00:00

daydream commented

2023-05-21 11:30:54 +00:00

I got this :)

good first or second project :)

I got this :) good first or second project :)

niceride commented

2023-05-21 14:00:49 +00:00

Should a ethereal:sponge be in the recipe?

daydream commented

2023-05-22 01:41:50 +00:00

that is a cute idea... so turn the sponge into wet sponge but don't use it up (which would not be ocean friendly heh) that could work nicely.

And it helps build on my little foray into modding too so works well for me too :p

that is a cute idea... so turn the sponge into wet sponge but don't use it up (which would not be ocean friendly heh) that could work nicely. And it helps build on my little foray into modding too so works well for me too :p

flux commented

2023-05-22 04:37:08 +00:00

Should a ethereal:sponge be in the recipe?

turn the sponge into wet sponge

i think it'd be reasonable to replicate the act of pouring the bucket out, resulting in an empty bucket.

if we want a different mechanic, cf. #1746, crafting a bucket of X might give you an empty bucket, and an X source?

> Should a ethereal:sponge be in the recipe? > turn the sponge into wet sponge i think it'd be reasonable to replicate the act of pouring the bucket out, resulting in an empty bucket. if we want a different mechanic, cf. #1746, crafting a bucket of X might give you an empty bucket, and an X source?

daydream commented

2023-05-22 05:34:31 +00:00

Well for now I just did the bucket of water to the empty bucket for simplicity
5bd1a166e0

Playing around with adding a sponge next - I will do it on my local and can make it a separate commit later so you can choose what you like.

Well for now I just did the bucket of water to the empty bucket for simplicity https://gitea.your-land.de/your-land/yl_commons/commit/5bd1a166e09406144d822390a934d10a6371effd Playing around with adding a sponge next - I will do it on my local and can make it a separate commit later so you can choose what you like.

niceride commented

2023-05-22 12:13:20 +00:00

if we want a different mechanic, cf. #1746, crafting a bucket of X might give you an empty bucket, and an X source?

I really like that, although there are balance issues you need to make decisions on. For example there's no way currently to even get a river water source, and to craft a water source takes thin ice which must be mined, not to mention lava bucket into lava source upends some existing expectations about game balance. None of those are showstoppers for me but they seem like big decisions to make concerning balance. And what would a milk source be?

> if we want a different mechanic, cf. #1746, crafting a bucket of X might give you an empty bucket, and an X source? I really like that, although there are balance issues you need to make decisions on. For example there's no way currently to even get a river water source, and to craft a water source takes thin ice which must be mined, not to mention lava bucket into lava source upends some existing expectations about game balance. None of those are showstoppers for me but they seem like big decisions to make concerning balance. And what would a milk source be?

AliasAlreadyTaken commented

2023-05-22 14:19:39 +00:00

You do not get a lava or water source if you use this.

All it does is "empty the bucket"

You do not get a lava or water source if you use this. All it does is "empty the bucket"

flux added

4. step/ready to QA test

and removed

4. step/approved

labels 2023-05-23 15:39:21 +00:00

flux commented

2023-05-23 17:00:55 +00:00

Well for now I just did the bucket of water to the empty bucket for simplicity
5bd1a166e0

Playing around with adding a sponge next - I will do it on my local and can make it a separate commit later so you can choose what you like.

nice, i see you figured out git :)

> Well for now I just did the bucket of water to the empty bucket for simplicity > https://gitea.your-land.de/your-land/yl_commons/commit/5bd1a166e09406144d822390a934d10a6371effd > > > Playing around with adding a sponge next - I will do it on my local and can make it a separate commit later so you can choose what you like. nice, i see you figured out git :)

AliasAlreadyTaken added this to the 1.1.122 milestone 2023-12-06 12:31:11 +00:00

AliasAlreadyTaken commented

2023-12-06 12:32:27 +00:00

QA

Probably in for at least two updates, but ... it works :P

QA Probably in for at least two updates, but ... it works :P

AliasAlreadyTaken added the

ugh/QA OK

label 2023-12-06 12:32:35 +00:00

flux added

5. result/fixed

and removed