testserver Can't sethome #4457

New Issue

Boris can sethome in the wilderness.
Boris can sethome in not-owned areas.
Boris is prevented from sethome in questareas.
Violetta can sethome in an owned subarea of a "prevent sethome" area of Boris
Boris can sethome in an owned area where the subarea of Violetta has "prevent sethome"

NOK:

Boris can't sethome in the nether.

Discussion:

What should happen if there are two areas at one place and one is a quest area, one is not? Same question for "prevent sethome". Which area should take precedence? Currently it depends whether there is an area found to allow sethome before an area is found to block it.

This is the same question that arises with blacklisting/whitelisting blocks and similar, may ithe discussion should get its own issue?

QA OK: Boris can sethome in the wilderness. Boris can sethome in not-owned areas. Boris is prevented from sethome in questareas. Violetta can sethome in an owned subarea of a "prevent sethome" area of Boris Boris can sethome in an owned area where the subarea of Violetta has "prevent sethome" NOK: Boris can't sethome in the nether. Discussion: What should happen if there are two areas at one place and one is a quest area, one is not? Same question for "prevent sethome". Which area should take precedence? Currently it depends whether there is an area found to allow sethome before an area is found to block it. This is the same question that arises with blacklisting/whitelisting blocks and similar, may ithe discussion should get its own issue?

AliasAlreadyTaken removed the

4. step/ready to QA test

label 2023-05-13 14:58:07 +00:00

flux commented

2023-05-13 17:19:13 +00:00

What should happen if there are two areas at one place and one is a quest area, one is not?

currently, if the player's own area intersects a quest area, they can /sethome in that intersection. if another area intersects the quest area, they cannot. this seems correct to me.

Same question for "prevent sethome". Which area should take precedence? Currently it depends whether there is an area found to allow sethome before an area is found to block it.

currently, if a player's own protection area intersects one which prevents sethome, they can /sethome in that intersection. if another area intersects an area that prevents sethome, they cannot.

the order doesn't matter - all areas at that point are checked 02a4d7be61/prevent_sethome.lua (L15-L22)

> What should happen if there are two areas at one place and one is a quest area, one is not? currently, if the player's own area intersects a quest area, they can `/sethome` in that intersection. if another area intersects the quest area, they cannot. this seems correct to me. > Same question for "prevent sethome". Which area should take precedence? Currently it depends whether there is an area found to allow sethome before an area is found to block it. currently, if a player's own protection area intersects one which prevents sethome, they can `/sethome` in that intersection. if another area intersects an area that prevents sethome, they cannot. the order doesn't matter - all areas at that point are checked https://gitea.your-land.de/your-land/yl_areas_addon/src/commit/02a4d7be612d486a8f06b77908c170d195b603a0/prevent_sethome.lua#L15-L22

flux commented

2023-05-13 17:19:37 +00:00

Boris can't sethome in the nether.

i thought this was desired, i can remove it if not.

> Boris can't sethome in the nether. i thought this was desired, i can remove it if not.

AliasAlreadyTaken commented

2023-05-14 17:47:32 +00:00

Boris can't sethome in the nether.

i thought this was desired, i can remove it if not.

I think having the option to this feature is a good idea, having no sethome in the nether though may be harsh :D For now, please remove it.

Now I wonder, when and why I said we don't want to have sethome in the nether. I probably had some idea, but can't recall it now. It may be a good idea to currently disallow sethome above the nether, but there's an area there, so this can be accomplished with the commands we have. Hm. Alias' smol brain forgot.

> > Boris can't sethome in the nether. > > i thought this was desired, i can remove it if not. I think having the option to this feature is a good idea, having no sethome in the nether though may be harsh :D For now, please remove it. Now I wonder, when and why I said we don't want to have sethome in the nether. I probably had some idea, but can't recall it now. It may be a good idea to currently disallow sethome *above* the nether, but there's an area there, so this can be accomplished with the commands we have. Hm. Alias' smol brain forgot.

flux commented

2023-05-15 18:35:13 +00:00

Boris can't sethome in the nether.

i thought this was desired, i can remove it if not.

I think having the option to this feature is a good idea, having no sethome in the nether though may be harsh :D For now, please remove it.

Now I wonder, when and why I said we don't want to have sethome in the nether. I probably had some idea, but can't recall it now. It may be a good idea to currently disallow sethome above the nether, but there's an area there, so this can be accomplished with the commands we have. Hm. Alias' smol brain forgot.

removed: 0fd298947e

for reference, i tried to dig up where i came up w/ the idea that this was desired, and i think it was something i came up w/ on my own that no-one else commented on, so i don't think it was ever something you desired: #1572 (comment)

> > > Boris can't sethome in the nether. > > > > i thought this was desired, i can remove it if not. > > I think having the option to this feature is a good idea, having no sethome in the nether though may be harsh :D For now, please remove it. > > Now I wonder, when and why I said we don't want to have sethome in the nether. I probably had some idea, but can't recall it now. It may be a good idea to currently disallow sethome *above* the nether, but there's an area there, so this can be accomplished with the commands we have. Hm. Alias' smol brain forgot. removed: https://gitea.your-land.de/your-land/yl_areas_addon/commit/0fd298947e8416ac6399d0f630f6b9cf72d2eaad for reference, i tried to dig up where i came up w/ the idea that this was desired, and i think it was something i came up w/ on my own that no-one else commented on, so i don't think it was ever something you desired: https://gitea.your-land.de/your-land/bugtracker/issues/1572#issuecomment-13373

😆 1

AliasAlreadyTaken added the

4. step/ready to QA test

ugh/QA OK

labels 2023-05-15 21:39:25 +00:00

flux commented

2023-05-18 23:29:35 +00:00

this is live

flux closed this issue

2023-05-18 23:29:36 +00:00

flux added

5. result/fixed