copper248 reports: Load bow with arrow place in p ... #4217

New Issue

yourland-report · 2023-04-17T23:15:28Z

yourland-report commented

2023-04-17 23:15:28 +00:00

copper248 reports a bug:

Load bow with arrow place in pedestal, I used steel bow with diamond arrow but it almost cetainly works in othe cases

Player position:

{
	x = 1949.1159667969,
	y = -30904.4375,
	z = 1442.4870605469
}

Player look:

{
	x = -0.72002106904984,
	y = -0.68581831455231,
	z = -0.10593815892935
}

Player information:

{
	version_string = "5.6.1",
	lang_code = "",
	min_rtt = 0.13500000536442,
	avg_rtt = 0.15800000727177,
	min_jitter = 0,
	max_jitter = 3.1949999332428,
	avg_jitter = 0.0049999952316284,
	protocol_version = 41,
	serialization_version = 29,
	patch = 1,
	formspec_version = 6,
	state = "Active",
	minor = 6,
	connection_uptime = 4042,
	max_rtt = 3.5269999504089,
	ip_version = 6,
	major = 5
}

Player meta:

{
	fields = {
		["stamina:exhaustion"] = "112",
		placed_nodes = "78001",
		died = "76",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		crafted = "3492",
		xp = "450526",
		["petz:lycanthropy"] = "0",
		digged_nodes = "498289",
		repellant = "0",
		["petz:werewolf"] = "0",
		arenalib_infobox_arenaID = "0",
		["petz:werewolf_vignette_id"] = "19",
		yl_commons_player_created = "1662436925",
		yl_commons_player_joined = "1681769324",
		inflicted_damage = "837716",
		punch_count = "39136",
		["petz:werewolf_clan_idx"] = "3",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false}",
		bitten = "0",
		hud_state = "on",
		yl_commons_thankyou = "8",
		played_time = "1259638",
		["ocean_build.last_warning"] = "1.66667e+09",
		["stamina:poisoned"] = "no",
		["signslib:pos"] = "(2017,-30900,1411)",
		yl_church = "return {[\"last_heal\"] = 1664922768, [\"last_death\"] = {[\"x\"] = -193, [\"y\"] = 35, [\"z\"] = 898}, [\"last_death_portal\"] = 1681625262}",
		["3d_armor_inventory"] = "return {\"shields:shield_rainbow 1 21612\", \"3d_armor:helmet_crystal 1 35720\", \"3d_armor:chestplate_crystal 1 35720\", \"3d_armor:leggings_crystal 1 35720\", \"3d_armor:boots_crystal 1 35720\", \"\"}",
		["stamina:level"] = "13",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		jointime = "1662436925"
	}
}

Log identifier


[MOD] yl_report log identifier = 9r6lVtLbIrvAEhdHuT0Xm0hmouz411Oc

Profiler save:

profile-20230417T231528.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 4d 1h 45min 42s | max lag: 0.796s | clients (24/52): AliasAlreadyTaken, Aliza, AspireMint, Bailiff, copper248, daydream, Dirac, Ecklair, Empempires, fellow, Figaro, flux, HorusDamocles, Insomniacs_Yello, ivyy, MineWorlds, niceride, rewired_X, RosLenin33, SADDDD, Service, shanish3, STEALTH, Sysmatic

Teleport command:

/teleport xyz 1949 -30904 1442

Compass command:

/give_compass Construction 9r6lVtLbIrvAEhdHuT0Xm0hmouz411Oc D2691E 1949 -30904 1442

copper248 reports a bug: > Load bow with arrow place in pedestal, I used steel bow with diamond arrow but it almost cetainly works in othe cases Player position: ``` { x = 1949.1159667969, y = -30904.4375, z = 1442.4870605469 } ``` Player look: ``` { x = -0.72002106904984, y = -0.68581831455231, z = -0.10593815892935 } ``` Player information: ``` { version_string = "5.6.1", lang_code = "", min_rtt = 0.13500000536442, avg_rtt = 0.15800000727177, min_jitter = 0, max_jitter = 3.1949999332428, avg_jitter = 0.0049999952316284, protocol_version = 41, serialization_version = 29, patch = 1, formspec_version = 6, state = "Active", minor = 6, connection_uptime = 4042, max_rtt = 3.5269999504089, ip_version = 6, major = 5 } ``` Player meta: ``` { fields = { ["stamina:exhaustion"] = "112", placed_nodes = "78001", died = "76", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", crafted = "3492", xp = "450526", ["petz:lycanthropy"] = "0", digged_nodes = "498289", repellant = "0", ["petz:werewolf"] = "0", arenalib_infobox_arenaID = "0", ["petz:werewolf_vignette_id"] = "19", yl_commons_player_created = "1662436925", yl_commons_player_joined = "1681769324", inflicted_damage = "837716", punch_count = "39136", ["petz:werewolf_clan_idx"] = "3", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false}", bitten = "0", hud_state = "on", yl_commons_thankyou = "8", played_time = "1259638", ["ocean_build.last_warning"] = "1.66667e+09", ["stamina:poisoned"] = "no", ["signslib:pos"] = "(2017,-30900,1411)", yl_church = "return {[\"last_heal\"] = 1664922768, [\"last_death\"] = {[\"x\"] = -193, [\"y\"] = 35, [\"z\"] = 898}, [\"last_death_portal\"] = 1681625262}", ["3d_armor_inventory"] = "return {\"shields:shield_rainbow 1 21612\", \"3d_armor:helmet_crystal 1 35720\", \"3d_armor:chestplate_crystal 1 35720\", \"3d_armor:leggings_crystal 1 35720\", \"3d_armor:boots_crystal 1 35720\", \"\"}", ["stamina:level"] = "13", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", jointime = "1662436925" } } ``` Log identifier ``` [MOD] yl_report log identifier = 9r6lVtLbIrvAEhdHuT0Xm0hmouz411Oc ``` Profiler save: ``` profile-20230417T231528.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 4d 1h 45min 42s | max lag: 0.796s | clients (24/52): AliasAlreadyTaken, Aliza, AspireMint, Bailiff, copper248, daydream, Dirac, Ecklair, Empempires, fellow, Figaro, flux, HorusDamocles, Insomniacs_Yello, ivyy, MineWorlds, niceride, rewired_X, RosLenin33, SADDDD, Service, shanish3, STEALTH, Sysmatic ``` Teleport command: ``` /teleport xyz 1949 -30904 1442 ``` Compass command: ``` /give_compass Construction 9r6lVtLbIrvAEhdHuT0Xm0hmouz411Oc D2691E 1949 -30904 1442 ```

AliasAlreadyTaken was assigned by yourland-report

2023-04-17 23:15:28 +00:00

daydream commented

2023-04-17 23:37:42 +00:00

Yep loading on pedestal and then removing and reloading - every time you get another free arrow. Reproduced.

AliasAlreadyTaken added the

1. kind/bug

2. prio/critical

labels 2023-04-18 00:34:20 +00:00

flux commented

2023-04-18 03:37:57 +00:00

noting that upgrading xbows doesn't fix this

AliasAlreadyTaken added the

3. source/integration

label 2023-04-18 04:11:24 +00:00

niceride commented

2023-04-18 06:44:19 +00:00

Some further testing:
The duplication happens when a loaded bow is supposed to be unloaded but the unloaded arrow has nowhere to go. For example player has 42 arrows, loads bow which leaves 41 arrows in inventory, then on death event there's an arrow in inventory on respawn and there's still a loaded bow (and 41 arrows) in the playerbones; So that death has effectively added an arrow to the inventory. I suspect the pedestal is triggering the same codepath.

Some further testing: The duplication happens when a loaded bow is supposed to be unloaded but the unloaded arrow has nowhere to go. For example player has 42 arrows, loads bow which leaves 41 arrows in inventory, then on death event there's an arrow in inventory on respawn and there's still a loaded bow (and 41 arrows) in the playerbones; So that death has effectively added an arrow to the inventory. I suspect the pedestal is triggering the same codepath.

flux commented

2023-04-18 18:51:06 +00:00

cf. #666, #1250, #3684

flux commented

2023-04-18 18:53:48 +00:00

this is the same bug as #1250, which was not fixed (you can still dupe arrows on an anvil as well). i'm not sure why that was closed, looks like it might have been confused w/ another issue.

the fix in #666 doesn't fix this because the inventories are being modified programmatically, not via user inventory action (drag/drop/etc.)

this is the same bug as #1250, which was *not* fixed (you can still dupe arrows on an anvil as well). i'm not sure why that was closed, looks like it might have been confused w/ another issue. the fix in #666 doesn't fix this because the inventories are being modified programmatically, not via user inventory action (drag/drop/etc.)

flux referenced this issue

2023-04-19 01:15:02 +00:00

copper248 reports: when player dies with a charge ... #4229

AliasAlreadyTaken added this to the 1.1.119 milestone 2023-04-25 14:20:14 +00:00

AliasAlreadyTaken added this to the Alias@work project 2023-04-28 13:24:34 +00:00

AliasAlreadyTaken removed this from the 1.1.119 milestone 2023-05-07 20:16:57 +00:00

AliasAlreadyTaken removed this from the Alias@work project 2023-12-05 16:57:59 +00:00

AliasAlreadyTaken referenced this issue

2023-12-20 10:51:05 +00:00

mahou reports: when charge a bow and put it i ... #5756

flux referenced this issue

2024-01-11 22:35:07 +00:00