daydream reports: suspect ghosts killed more ch ... #4131

New Issue

yourland-report · 2023-04-06T18:47:35Z

yourland-report commented

2023-04-06 18:47:35 +00:00

daydream reports a bug:

susptect ghosts killed more chickens - this time they had L2 runes too - very expensive and apparently useless :(

Player position:

{
	x = -7854.3149414063,
	z = -9707.0224609375,
	y = 3.5
}

Player look:

{
	x = -0.12324611842632,
	z = -0.85632783174515,
	y = -0.50151073932648
}

Player information:

{
	avg_rtt = 0.17499999701977,
	min_jitter = 0,
	max_jitter = 3.558000087738,
	avg_jitter = 0.0029999911785126,
	connection_uptime = 84026,
	serialization_version = 29,
	formspec_version = 6,
	protocol_version = 41,
	state = "Active",
	minor = 7,
	max_rtt = 3.7360000610352,
	version_string = "5.7.0-56d2567b5-56d2567b5",
	patch = 0,
	major = 5,
	lang_code = "",
	ip_version = 6,
	min_rtt = 0.16400000452995
}

Player meta:

{
	fields = {
		inflicted_damage = "2318866",
		repellant = "0",
		jointime = "1650064821",
		bitten = "0",
		["stamina:poisoned"] = "no",
		["stamina:level"] = "16",
		["petz:werewolf"] = "0",
		["ocean_build.last_warning"] = "1.65235e+09",
		["petz:lycanthropy"] = "0",
		["ocean_build.ocean_built"] = "8",
		["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}",
		xp = "1506960",
		hud_state = "on",
		["petz:werewolf_vignette_id"] = "19",
		["stamina:exhaustion"] = "55.5",
		partychat = "party",
		crafted = "2710",
		played_time = "18451320",
		["petz:werewolf_clan_idx"] = "1",
		arenalib_infobox_arenaID = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		digged_nodes = "1756907",
		placed_nodes = "266479",
		yl_commons_player_created = "1650064821",
		yl_commons_player_joined = "1680722867",
		["signslib:pos"] = "(-7802,29889,-9651)",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 100\", \"shields:shield_rainbow 1 40\", \"3d_armor:chestplate_nether 1 200\", \"3d_armor:leggings_nether 1 200\", \"3d_armor:boots_crystal 1 100\", \"\"}",
		yl_church = "return {[\"last_death_portal\"] = 1680203646, [\"last_death\"] = {[\"z\"] = 1117, [\"x\"] = 2051, [\"y\"] = 16}, [\"last_heal\"] = 1673944229}",
		yl_commons_thankyou = "329",
		xp_redo_hud_color = "0xFFC001",
		punch_count = "112907",
		died = "261"
	}
}

Log identifier


[MOD] yl_report log identifier = q5bLydiMzmbKSvQMdEINJv0C56tdJqG5

Profiler save:

profile-20230406T184735.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 6d 13h 47min 41s | max lag: 1.34s | clients (37/52): AliasAlreadyTaken, Alinia, Amanda, AspireMint, Autumnal, Bailiff, betzi, Bishiro, bizon, BobaCat, Boris, Chameleon, copper248, daydream, drgn, Ecklair, Felicja, flux, FullmetalBOI, gogo77210, Kaline, Lupercus, mahou, MineWorlds, Murmel, niceride, noface, Oscoder_, PHANTOMRIDER, Sarinha, Service, shanish3, sneik, Sokomine, STEALTH, tatus, taysonk

Teleport command:

/teleport xyz -7854 4 -9707

Compass command:

/give_compass Construction q5bLydiMzmbKSvQMdEINJv0C56tdJqG5 D2691E -7854 4 -9707

daydream reports a bug: > susptect ghosts killed more chickens - this time they had L2 runes too - very expensive and apparently useless :( Player position: ``` { x = -7854.3149414063, z = -9707.0224609375, y = 3.5 } ``` Player look: ``` { x = -0.12324611842632, z = -0.85632783174515, y = -0.50151073932648 } ``` Player information: ``` { avg_rtt = 0.17499999701977, min_jitter = 0, max_jitter = 3.558000087738, avg_jitter = 0.0029999911785126, connection_uptime = 84026, serialization_version = 29, formspec_version = 6, protocol_version = 41, state = "Active", minor = 7, max_rtt = 3.7360000610352, version_string = "5.7.0-56d2567b5-56d2567b5", patch = 0, major = 5, lang_code = "", ip_version = 6, min_rtt = 0.16400000452995 } ``` Player meta: ``` { fields = { inflicted_damage = "2318866", repellant = "0", jointime = "1650064821", bitten = "0", ["stamina:poisoned"] = "no", ["stamina:level"] = "16", ["petz:werewolf"] = "0", ["ocean_build.last_warning"] = "1.65235e+09", ["petz:lycanthropy"] = "0", ["ocean_build.ocean_built"] = "8", ["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}", xp = "1506960", hud_state = "on", ["petz:werewolf_vignette_id"] = "19", ["stamina:exhaustion"] = "55.5", partychat = "party", crafted = "2710", played_time = "18451320", ["petz:werewolf_clan_idx"] = "1", arenalib_infobox_arenaID = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", digged_nodes = "1756907", placed_nodes = "266479", yl_commons_player_created = "1650064821", yl_commons_player_joined = "1680722867", ["signslib:pos"] = "(-7802,29889,-9651)", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 100\", \"shields:shield_rainbow 1 40\", \"3d_armor:chestplate_nether 1 200\", \"3d_armor:leggings_nether 1 200\", \"3d_armor:boots_crystal 1 100\", \"\"}", yl_church = "return {[\"last_death_portal\"] = 1680203646, [\"last_death\"] = {[\"z\"] = 1117, [\"x\"] = 2051, [\"y\"] = 16}, [\"last_heal\"] = 1673944229}", yl_commons_thankyou = "329", xp_redo_hud_color = "0xFFC001", punch_count = "112907", died = "261" } } ``` Log identifier ``` [MOD] yl_report log identifier = q5bLydiMzmbKSvQMdEINJv0C56tdJqG5 ``` Profiler save: ``` profile-20230406T184735.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 6d 13h 47min 41s | max lag: 1.34s | clients (37/52): AliasAlreadyTaken, Alinia, Amanda, AspireMint, Autumnal, Bailiff, betzi, Bishiro, bizon, BobaCat, Boris, Chameleon, copper248, daydream, drgn, Ecklair, Felicja, flux, FullmetalBOI, gogo77210, Kaline, Lupercus, mahou, MineWorlds, Murmel, niceride, noface, Oscoder_, PHANTOMRIDER, Sarinha, Service, shanish3, sneik, Sokomine, STEALTH, tatus, taysonk ``` Teleport command: ``` /teleport xyz -7854 4 -9707 ``` Compass command: ``` /give_compass Construction q5bLydiMzmbKSvQMdEINJv0C56tdJqG5 D2691E -7854 4 -9707 ```

AliasAlreadyTaken was assigned by yourland-report

2023-04-06 18:47:35 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2023-04-06 22:40:19 +00:00

daydream changed title from ~~daydream reports: susptect ghosts killed more ch ...~~ to daydream reports: suspect ghosts killed more ch ...

2023-04-07 01:48:07 +00:00

daydream commented

2023-04-07 01:49:07 +00:00

L2 runes are very very expensive to make and they should work! It's not like it can be shrugged off as "ugh petz" cuz it's not petz.

flux commented

2023-04-07 02:10:00 +00:00

i protected a flower cow with an L2 rune at ... "i forget" pastures, and it's gone. i swear ghosts didn't attack animals in the past. maybe it was a disguised mime?

AliasAlreadyTaken commented

2023-04-07 02:12:15 +00:00

Even mimics shouldn't spawn in protected areas.
Also mimics shouldn't kill anything that's protected with a L2 rune.
Let's make experiments.

Even mimics shouldn't spawn in protected areas. Also mimics shouldn't kill anything that's protected with a L2 rune. Let's make experiments.

flux commented

2023-04-07 02:18:46 +00:00

mimics can't spawn in protected areas, but they absolutely can kill things that are protected. that's a relatively easy change i can make, as hamlet abandoned the mod and i'm effectively the maintainer.

flux commented

2023-04-07 02:35:51 +00:00

i'm testing a fix, but there's a confound - i've discovered that if you protect a mob, and the server crashes before the mob is properly unloaded, the protection status may be lost.

flux commented

2023-04-07 02:40:55 +00:00

and the fix doesn't work, the "do_custom" code doesn't always get called, and so can't abort attacks on protected mobs. blech, eat kitty.

😆 1

flux commented

2023-04-07 19:43:31 +00:00

think i've got it working now: 76e857a459

think i've got it working now: https://github.com/fluxionary/minetest-mobs_mime/commit/76e857a4591c4a848cdda96b93b11d4c248d257c

flux added the

4. step/ready to QA test

4. step/partially fixed

labels 2023-04-07 19:44:31 +00:00

flux commented

2023-04-07 19:44:46 +00:00

ok, ghosts attack cows too, need to fix them as well

flux commented

2023-04-07 21:16:42 +00:00

fixed the ghost too: ceaf3308bf

fixed the ghost too: https://gitea.your-land.de/your-land/mobs_ghost_redo/commit/ceaf3308bf53dc59c9f73ba6aaad07bd1f944b0f

flux removed the

4. step/partially fixed

label 2023-04-07 21:16:52 +00:00

flux commented

2023-04-07 21:21:08 +00:00

other mobs which attack animals:

tree monster (mobs monster)
whip (yl nether mobs)
wither (yl nether mobs)
gazers
nether dragons (nether monsters)
snow walkers (mobs others)
ice monsters (mobs others)
balrog

other mobs which attack animals: * tree monster (mobs monster) * whip (yl nether mobs) * wither (yl nether mobs) * gazers * nether dragons (nether monsters) * snow walkers (mobs others) * ice monsters (mobs others) * balrog

AliasAlreadyTaken commented

2023-04-08 00:06:20 +00:00

Hostiles attacking animals is a game mechanic, so that people have a reason to shelter them from harm. I would not want them to stop that. However, ghosts killing animals is bad, since the animals do not have any defense and a shelter does nothing against ghosts. Therefore, we should stop ghosts from killing animals and go after players only.

Could be done via

attack_animals = false,

in

https://gitea.your-land.de/your-land/mobs_ghost_redo/src/branch/master/init.lua#L127

Hostiles attacking animals is a game mechanic, so that people have a reason to shelter them from harm. I would not want them to stop that. However, ghosts killing animals is bad, since the animals do not have any defense and a shelter does nothing against ghosts. Therefore, we should stop ghosts from killing animals and go after players only. Could be done via ``` attack_animals = false, ``` in https://gitea.your-land.de/your-land/mobs_ghost_redo/src/branch/master/init.lua#L127

👍 1

AliasAlreadyTaken added this to the 1.1.118 milestone 2023-04-13 00:55:03 +00:00

AliasAlreadyTaken commented

2023-04-13 00:56:41 +00:00

QA

Should we deploy both solutions?

Either the one in do_custom OR the attack_animals = false

QA Should we deploy both solutions? Either the one in do_custom OR the `attack_animals = false`

AliasAlreadyTaken added the

ugh/QA NOK

label 2023-04-13 00:56:46 +00:00

flux commented

2023-04-14 03:13:02 +00:00

QA

Should we deploy both solutions?

Either the one in do_custom OR the attack_animals = false

part of the fun of mimes is that they mimic and attack wild animals, that was intentional.

it wasn't intentional to have them target protected animals.

> QA > > Should we deploy both solutions? > > Either the one in do_custom OR the `attack_animals = false` part of the fun of mimes is that they mimic and attack wild animals, that was intentional. it wasn't intentional to have them target protected animals.

👍 2

AliasAlreadyTaken added

ugh/QA OK

and removed

ugh/QA NOK

labels 2023-04-14 04:24:00 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2023-04-26 14:14:16 +00:00

AliasAlreadyTaken was unassigned by flux