rabenkind reports: gapples disapear when felling ... #3631

Open
opened 2 months ago by yourland-report · 8 comments
Collaborator

rabenkind reports a bug:

gapples disapear when felling a tree. other fruits always fall down. tested that with 4 trees. replanted them same as befor no gapples.

Player position:

{
	y = 19.5,
	z = -502.43701171875,
	x = 2658.6579589844
}

Player look:

{
	y = 0.91425395011902,
	z = -0.28502482175827,
	x = -0.28792467713356
}

Player information:

{
	protocol_version = 41,
	ip_version = 6,
	min_rtt = 0.028000000864267,
	lang_code = "",
	major = 5,
	max_jitter = 15.114999771118,
	avg_jitter = 0.0029999986290932,
	connection_uptime = 23858,
	formspec_version = 6,
	patch = 0,
	minor = 7,
	state = "Active",
	version_string = "5.7.0-dev-1e9640395",
	min_jitter = 0,
	avg_rtt = 0.028000000864267,
	max_rtt = 17.333999633789,
	serialization_version = 29
}

Player meta:

{
	fields = {
		["petz:werewolf"] = "0",
		["ocean_build.last_warning"] = "1.65685e+09",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		["3d_armor_inventory"] = "return {\"\", \"3d_armor:enchanted_helmet_mithril_strong 1 10626\", \"shields:shield_rainbow\", \"3d_armor:enchanted_chestplate_mithril_strong\", \"3d_armor:boots_crystal 1 800\", \"3d_armor:enchanted_leggings_mithril_strong\"}",
		["petz:werewolf_vignette_id"] = "19",
		yl_commons_player_created = "1650393800",
		yl_commons_player_joined = "1674726984",
		["stamina:level"] = "15",
		arenalib_infobox_arenaID = "0",
		punch_count = "63886",
		["petz:werewolf_clan_idx"] = "2",
		inflicted_damage = "1337512",
		played_time = "5438356",
		digged_nodes = "1588428",
		placed_nodes = "442734",
		died = "119",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false, [\"speed\"] = 2, [\"sneak\"] = true}",
		crafted = "72532",
		xp = "1528105",
		["stamina:exhaustion"] = "46",
		["stamina:poisoned"] = "no",
		yl_commons_thankyou = "70",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 3686, [\"y\"] = 4, [\"z\"] = 1671}, [\"last_death_portal\"] = 1674510142}",
		partychat = "party",
		repellant = "0",
		jointime = "1650393800",
		bitten = "0",
		["signslib:pos"] = "(2707,-4,137)",
		["petz:lycanthropy"] = "0",
		hud_state = "on"
	}
}

Log identifier


[MOD] yl_report log identifier = 2Op1XN77GYjHmLspIdbbc27DVJsIUjX0

Profiler save:

profile-20230126T163327.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 15h 12min 45s | max lag: 2.91s | clients (21/52): AliasAlreadyTaken, Apophis, Bailiff, BibaBoba, donald, FailFactory, flux, Katze, LCB, LRB, mob, niceride, playerofgames, rabenkind, Service, shanish2, shanish3, shibu3, Sysmatic, TobiasGaming, yo_hi

Teleport command:

/teleport xyz 2659 20 -502

Compass command:

/give_compass Construction 2Op1XN77GYjHmLspIdbbc27DVJsIUjX0 D2691E 2659 20 -502
rabenkind reports a bug: > gapples disapear when felling a tree. other fruits always fall down. tested that with 4 trees. replanted them same as befor no gapples. Player position: ``` { y = 19.5, z = -502.43701171875, x = 2658.6579589844 } ``` Player look: ``` { y = 0.91425395011902, z = -0.28502482175827, x = -0.28792467713356 } ``` Player information: ``` { protocol_version = 41, ip_version = 6, min_rtt = 0.028000000864267, lang_code = "", major = 5, max_jitter = 15.114999771118, avg_jitter = 0.0029999986290932, connection_uptime = 23858, formspec_version = 6, patch = 0, minor = 7, state = "Active", version_string = "5.7.0-dev-1e9640395", min_jitter = 0, avg_rtt = 0.028000000864267, max_rtt = 17.333999633789, serialization_version = 29 } ``` Player meta: ``` { fields = { ["petz:werewolf"] = "0", ["ocean_build.last_warning"] = "1.65685e+09", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", ["3d_armor_inventory"] = "return {\"\", \"3d_armor:enchanted_helmet_mithril_strong 1 10626\", \"shields:shield_rainbow\", \"3d_armor:enchanted_chestplate_mithril_strong\", \"3d_armor:boots_crystal 1 800\", \"3d_armor:enchanted_leggings_mithril_strong\"}", ["petz:werewolf_vignette_id"] = "19", yl_commons_player_created = "1650393800", yl_commons_player_joined = "1674726984", ["stamina:level"] = "15", arenalib_infobox_arenaID = "0", punch_count = "63886", ["petz:werewolf_clan_idx"] = "2", inflicted_damage = "1337512", played_time = "5438356", digged_nodes = "1588428", placed_nodes = "442734", died = "119", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false, [\"speed\"] = 2, [\"sneak\"] = true}", crafted = "72532", xp = "1528105", ["stamina:exhaustion"] = "46", ["stamina:poisoned"] = "no", yl_commons_thankyou = "70", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", yl_church = "return {[\"last_death\"] = {[\"x\"] = 3686, [\"y\"] = 4, [\"z\"] = 1671}, [\"last_death_portal\"] = 1674510142}", partychat = "party", repellant = "0", jointime = "1650393800", bitten = "0", ["signslib:pos"] = "(2707,-4,137)", ["petz:lycanthropy"] = "0", hud_state = "on" } } ``` Log identifier ``` [MOD] yl_report log identifier = 2Op1XN77GYjHmLspIdbbc27DVJsIUjX0 ``` Profiler save: ``` profile-20230126T163327.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 15h 12min 45s | max lag: 2.91s | clients (21/52): AliasAlreadyTaken, Apophis, Bailiff, BibaBoba, donald, FailFactory, flux, Katze, LCB, LRB, mob, niceride, playerofgames, rabenkind, Service, shanish2, shanish3, shibu3, Sysmatic, TobiasGaming, yo_hi ``` Teleport command: ``` /teleport xyz 2659 20 -502 ``` Compass command: ``` /give_compass Construction 2Op1XN77GYjHmLspIdbbc27DVJsIUjX0 D2691E 2659 20 -502 ```
AliasAlreadyTaken was assigned by yourland-report 2 months ago
flux added the 1. kind/bug 4. step/needs confirmation labels 2 months ago
flux added 3. source/integration and removed 4. step/needs confirmation labels 2 months ago
flux commented 2 months ago
Collaborator

you can pick gapples just fine by hand, but woodcutting doesn't drop them?

you can pick gapples just fine by hand, but woodcutting doesn't drop them?
flux commented 2 months ago
Collaborator

this probably has to do w/ the fix for #2925, though (1) i'm unsure why they don't fall when unsupported (2) why this only affects apples, not other fruit

this probably has to do w/ the fix for #2925, though (1) i'm unsure why they don't fall when unsupported (2) why this only affects apples, not other fruit
flux added the 2. prio/elevated label 2 months ago
flux added this to the flux's TODO list project 2 months ago
flux commented 2 months ago
Collaborator

tested locally, and choppy does the right thing, so that's another reason to use it.

tested locally, and choppy does the right thing, so that's another reason to use it.

Hi! This is for all fruits i tested so far: normal apples, gapples, bananas, lemon and orange. yes you can pick them from the tree as usual. But if you fell a tree they all poof disappear. I will test more trees and report.
I fell them with a normal axe and shift. so the work is done automatically. Before all the fruits always drop to the ground but now i get nothing.

Hi! This is for all fruits i tested so far: normal apples, gapples, bananas, lemon and orange. yes you can pick them from the tree as usual. But if you fell a tree they all poof disappear. I will test more trees and report. I fell them with a normal axe and shift. so the work is done automatically. Before all the fruits always drop to the ground but now i get nothing.
flux commented 2 months ago
Collaborator

not other fruit
...
normal apples, gapples, bananas, lemon and orange.

i admit i didn't test bananas, lemon, and orange, but moretrees "fruit" (mostly nuts) seems to fall.

> not other fruit > ... > normal apples, gapples, bananas, lemon and orange. i admit i didn't test bananas, lemon, and orange, but moretrees "fruit" (mostly nuts) seems to fall.

Yes they do at least fir and cedar do. i tested also far outside of my area its the same. no banana and orange ...
a jungle tree cocoa don't fall. but i am not sure if they should.

Yes they do at least fir and cedar do. i tested also far outside of my area its the same. no banana and orange ... a jungle tree cocoa don't fall. but i am not sure if they should.

palm tree from moretrees also. you have to dig the coconut beforehand else it will vanish. so two of my export products are by now more or less broken ;-)

palm tree from moretrees also. you have to dig the coconut beforehand else it will vanish. so two of my export products are by now more or less broken ;-)
flux commented 2 months ago
Collaborator

fixed in 881392275d and 29b4df95a9

fixed in https://gitea.your-land.de/your-land/yl_commons/commit/881392275d25e5caf5f549fa14e3df0f3e6b8de9 and https://gitea.your-land.de/your-land/yl_commons/commit/29b4df95a9f36905ee513290a8ec2f326b657d8f
flux added the 4. step/ready to QA test label 2 months ago
AliasAlreadyTaken added this to the 1.1.117.1 milestone 2 months ago
AliasAlreadyTaken modified the milestone from 1.1.117.1 to 1.1.118 1 month ago
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#3631
Loading…
There is no content yet.