flux reports: is it possible to define allow ... #3389

New Issue

yourland-report · 2023-01-01T01:53:39Z

yourland-report commented

2023-01-01 01:53:39 +00:00

flux reports a bug:

is it possible to define allow_metadata_inventory_put and on_metadtata_inventory_put so that listrings (shift-click) will put fuel items into the fuel slot?

Player position:

{
	x = 1288.1599121094,
	y = 47.5,
	z = 622.80401611328
}

Player look:

{
	x = -0.034788195043802,
	y = -0.36341381072998,
	z = 0.93097805976868
}

Player information:

{
	ip_version = 6,
	min_rtt = 0.16400000452995,
	avg_rtt = 0.17200000584126,
	min_jitter = 0,
	max_jitter = 4.1560001373291,
	avg_jitter = 0.038999989628792,
	connection_uptime = 35486,
	max_rtt = 4.3280000686646,
	patch = 0,
	formspec_version = 6,
	version_string = "5.7.0-dev-142c6f1c8-dirty",
	state = "Active",
	protocol_version = 41,
	major = 5,
	serialization_version = 29,
	minor = 7,
	lang_code = ""
}

Player meta:

{
	fields = {
		digged_nodes = "1153334",
		placed_nodes = "365264",
		died = "74",
		hud_state = "on",
		yl_commons_thankyou = "187",
		["petz:werewolf"] = "0",
		partychat = "party",
		["signslib:pos"] = "(1975,19,1178)",
		crafted = "48027",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		arenalib_infobox_arenaID = "0",
		["petz:werewolf_vignette_id"] = "20",
		yl_commons_player_joined = "1672502558",
		yl_commons_player_created = "1615351173",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = 1582, [\"x\"] = 1833, [\"y\"] = -27684}, [\"last_death_portal\"] = 1670728451, [\"last_heal\"] = 1615504208}",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 936\", \"3d_armor:chestplate_rainbow 1 936\", \"shields:shield_rainbow 1 936\", \"3d_armor:leggings_rainbow 1 936\", \"3d_armor:boots_crystal 1 2340\", \"\"}",
		["petz:werewolf_clan_idx"] = "1",
		bitten = "0",
		["stamina:level"] = "5",
		punch_count = "130128",
		["stamina:poisoned"] = "no",
		inflicted_damage = "2329100",
		["stamina:exhaustion"] = "121",
		["petz:lycanthropy"] = "1",
		jointime = "1615351173",
		xp = "1385894",
		repellant = "0",
		played_time = "28741752"
	}
}

Log identifier


[MOD] yl_report log identifier = uUzGXqPH3kiPrSwDm4zBv3v9DLM4CJiG

Profiler save:

profile-20230101T015339.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 12h 15min 52s | max lag: 4.17s | clients (32/42): AliasAlreadyTaken, Alwe, Azelf, Bailiff, Bishiro, bizon, CamiliaCat4, CrazyLuigi, CupOCoffee, DanielBoone, daydream, digdeep, DragonWrangler1, Elias, flux, Futureismine, iceduck, icser, jackofthebean000, labrat, Laylem, LeetPeet, MinerLeon, niceride, Queenfire234312, S-Dubb, Service, shanish2, sherkhan30452, Squawk, Susanna_ca, Therottenpotato

Teleport command:

/teleport xyz 1288 48 623

Compass command:

/give_compass Construction uUzGXqPH3kiPrSwDm4zBv3v9DLM4CJiG D2691E 1288 48 623

flux reports a bug: > is it possible to define allow_metadata_inventory_put and on_metadtata_inventory_put so that listrings (shift-click) will put fuel items into the fuel slot? Player position: ``` { x = 1288.1599121094, y = 47.5, z = 622.80401611328 } ``` Player look: ``` { x = -0.034788195043802, y = -0.36341381072998, z = 0.93097805976868 } ``` Player information: ``` { ip_version = 6, min_rtt = 0.16400000452995, avg_rtt = 0.17200000584126, min_jitter = 0, max_jitter = 4.1560001373291, avg_jitter = 0.038999989628792, connection_uptime = 35486, max_rtt = 4.3280000686646, patch = 0, formspec_version = 6, version_string = "5.7.0-dev-142c6f1c8-dirty", state = "Active", protocol_version = 41, major = 5, serialization_version = 29, minor = 7, lang_code = "" } ``` Player meta: ``` { fields = { digged_nodes = "1153334", placed_nodes = "365264", died = "74", hud_state = "on", yl_commons_thankyou = "187", ["petz:werewolf"] = "0", partychat = "party", ["signslib:pos"] = "(1975,19,1178)", crafted = "48027", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", arenalib_infobox_arenaID = "0", ["petz:werewolf_vignette_id"] = "20", yl_commons_player_joined = "1672502558", yl_commons_player_created = "1615351173", yl_church = "return {[\"last_death\"] = {[\"z\"] = 1582, [\"x\"] = 1833, [\"y\"] = -27684}, [\"last_death_portal\"] = 1670728451, [\"last_heal\"] = 1615504208}", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 936\", \"3d_armor:chestplate_rainbow 1 936\", \"shields:shield_rainbow 1 936\", \"3d_armor:leggings_rainbow 1 936\", \"3d_armor:boots_crystal 1 2340\", \"\"}", ["petz:werewolf_clan_idx"] = "1", bitten = "0", ["stamina:level"] = "5", punch_count = "130128", ["stamina:poisoned"] = "no", inflicted_damage = "2329100", ["stamina:exhaustion"] = "121", ["petz:lycanthropy"] = "1", jointime = "1615351173", xp = "1385894", repellant = "0", played_time = "28741752" } } ``` Log identifier ``` [MOD] yl_report log identifier = uUzGXqPH3kiPrSwDm4zBv3v9DLM4CJiG ``` Profiler save: ``` profile-20230101T015339.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 12h 15min 52s | max lag: 4.17s | clients (32/42): AliasAlreadyTaken, Alwe, Azelf, Bailiff, Bishiro, bizon, CamiliaCat4, CrazyLuigi, CupOCoffee, DanielBoone, daydream, digdeep, DragonWrangler1, Elias, flux, Futureismine, iceduck, icser, jackofthebean000, labrat, Laylem, LeetPeet, MinerLeon, niceride, Queenfire234312, S-Dubb, Service, shanish2, sherkhan30452, Squawk, Susanna_ca, Therottenpotato ``` Teleport command: ``` /teleport xyz 1288 48 623 ``` Compass command: ``` /give_compass Construction uUzGXqPH3kiPrSwDm4zBv3v9DLM4CJiG D2691E 1288 48 623 ```

👍 1

AliasAlreadyTaken was assigned by yourland-report

2023-01-01 01:53:39 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2023-01-01 15:50:35 +00:00

flux added the

4. step/ready to QA test

label 2023-01-01 19:12:24 +00:00

flux commented

2023-01-01 19:14:31 +00:00

implemented in 25fa513484

it only works if you put the fuel in first. if there's already something waiting to cook, the game isn't smart enough to add fuel to the fuel slot.
in some ambiguous cases where something is both cookable and a fuel (e.g. oil extract and unprocessed paraffin), things might not go where the player expects.

implemented in https://gitea.your-land.de/your-land/yl_commons/commit/25fa5134842a6fe9ad9f8c65e7951b68573e3fcb 1. it only works if you put the fuel in first. if there's already something waiting to cook, the game isn't smart enough to add fuel to the fuel slot. 2. in some ambiguous cases where something is both cookable and a fuel (e.g. oil extract and unprocessed paraffin), things might not go where the player expects.

AliasAlreadyTaken added this to the 1.1.117 milestone 2023-01-02 11:43:06 +00:00

AliasAlreadyTaken commented

2023-01-18 06:37:00 +00:00

It's an improvement :)

Not sure, but maybe MTG upstream may be interested?

It's an improvement :) Not sure, but maybe MTG upstream may be interested?

AliasAlreadyTaken added the

ugh/QA OK

label 2023-01-18 06:37:05 +00:00

AliasAlreadyTaken added

ugh/QA NOK

and removed

ugh/QA OK

labels 2023-01-18 07:33:10 +00:00

AliasAlreadyTaken commented

2023-01-18 07:35:36 +00:00

Unfortunately this lead to ambiguous items not only ending up in the fuel slot when you shiftclick them, but ALSO when you drag them in?

Repro:

Rightclick furnace with empty fuel and cooking slot
Dragdrop ethereal:palmleaves on the upper slot

Expected: ethereal:palmleaves end up in the upper slot
Is wrong: ethereal:palmleaves end up in the lower slot

Unfortunately this lead to ambiguous items not only ending up in the fuel slot when you shiftclick them, but ALSO when you drag them in? Repro: 1. Rightclick furnace with empty fuel and cooking slot 2. Dragdrop ethereal:palmleaves on the upper slot Expected: ethereal:palmleaves end up in the upper slot Is wrong: ethereal:palmleaves end up in the lower slot

flux commented

2023-01-18 21:33:44 +00:00

Not sure, but maybe MTG upstream may be interested?

given that MTG is "feature complete" and even my bugfixes don't get accepted, probably not.

but ALSO when you drag them in?

there's no way for the game to tell whether you shift-clicked something or click-and-drag, but i do think you're right that the default behavior should be what you're proposing. if something is cookable and a fuel, and you put it in the cooking slot, it should stay there.

i've also added support to the public furnace while i was looking at this again (though not the locked furnace, i fear there's more going on there).

40640753ce

> Not sure, but maybe MTG upstream may be interested? given that MTG is "feature complete" and even my bugfixes don't get accepted, probably not. > but ALSO when you drag them in? there's no way for the game to tell whether you shift-clicked something or click-and-drag, but i do think you're right that the default behavior should be what you're proposing. if something is cookable and a fuel, and you put it in the cooking slot, it should stay there. i've also added support to the public furnace while i was looking at this again (though not the locked furnace, i fear there's more going on there). https://gitea.your-land.de/your-land/yl_commons/commit/40640753ce8fa511b076092bf5df5d953a8744f5

Sokomine commented

2023-01-18 21:53:52 +00:00

flux wrote:

i've also added support to the public furnace while i was looking at this again (though not the locked furnace, i fear there's more going on there).

The furnace from my locks mod is based on an older version of the furnace from MTG. It needs to be updated. The old version still uses an abm while the new version in MTG works with timers.

I'm just not sure if the furnace from my locks mod is still needed. The one in MTG also got updated so that others can't take out things.

flux wrote: > i've also added support to the public furnace while i was looking at this again (though not the locked furnace, i fear there's more going on there). The furnace from my locks mod is based on an older version of the furnace from MTG. It needs to be updated. The old version still uses an abm while the new version in MTG works with timers. I'm just not sure if the furnace from my locks mod is still needed. The one in MTG also got updated so that others can't take out things.

👍 1

AliasAlreadyTaken commented

2023-01-19 09:15:52 +00:00

There are people who use locked furnaces. At least 384 lines of log deal with people placing those or adding items in and out.

AliasAlreadyTaken commented

2023-01-19 10:27:55 +00:00

Not sure, but maybe MTG upstream may be interested?

given that MTG is "feature complete" and even my bugfixes don't get accepted, probably not.

Maybe we should maintain at least a fixed version of MTG

> > Not sure, but maybe MTG upstream may be interested? > > given that MTG is "feature complete" and even my bugfixes don't get accepted, probably not. Maybe we should maintain at least a fixed version of MTG

AliasAlreadyTaken added

ugh/QA OK

and removed

ugh/QA NOK

labels 2023-01-19 10:55:15 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2023-01-25 21:25:44 +00:00

AliasAlreadyTaken was unassigned by flux

2023-01-25 21:25:47 +00:00