Xonon reports: Feature suggestion: craft an e ... #2790

New Issue

yourland-report · 2022-09-30T16:13:19Z

yourland-report commented

2022-09-30 16:13:19 +00:00

Xonon reports a bug:

Feature suggestion: craft an empty book with another item to produce an output book containing the contents of a text file and/or command output

Player position:

{
	x = 3736.712890625,
	y = 9.5,
	z = 2325.4919433594
}

Player look:

{
	x = 0.93907868862152,
	y = -0.34365969896317,
	z = -0.0054100654087961
}

Player information:

{
	ip_version = 6,
	min_rtt = 0.16500000655651,
	avg_rtt = 0.17499999701977,
	min_jitter = 0,
	max_jitter = 10.668000221252,
	avg_jitter = 0.0029999911785126,
	protocol_version = 40,
	serialization_version = 29,
	patch = 0,
	formspec_version = 6,
	major = 5,
	minor = 7,
	version_string = "5.7.0-dev-ec77850",
	lang_code = "",
	connection_uptime = 2525,
	max_rtt = 20.027000427246,
	state = "Active"
}

Player meta:

{
	fields = {
		["petz:werewolf_vignette_id"] = "19",
		["signslib:pos"] = "(3337,-10829,3768)",
		["petz:werewolf_clan_idx"] = "2",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 2256\", \"shields:shield_rainbow 1 2256\", \"3d_armor:chestplate_rainbow 1 2256\", \"3d_armor:leggings_rainbow 1 2256\", \"3d_armor:boots_crystal 1 5640\", \"\"}",
		["stamina:level"] = "13",
		punch_count = "25429",
		xp = "593227",
		hud_state = "on",
		partychat = "party",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["stamina:exhaustion"] = "83",
		placed_nodes = "268657",
		inflicted_damage = "365804",
		arenalib_infobox_arenaID = "0",
		yl_church = "return {[\"last_death_portal\"] = 1663572283, [\"last_heal\"] = 1664513729, [\"last_death\"] = {[\"x\"] = 3703, [\"y\"] = 19, [\"z\"] = 2354}}",
		digged_nodes = "564721",
		repellant = "0",
		jointime = "1621665541",
		bitten = "0",
		["ocean_build.ocean_built"] = "7",
		played_time = "4417619",
		["ocean_build.last_warning"] = "1.65801e+09",
		["petz:werewolf"] = "0",
		died = "74",
		crafted = "25664",
		yl_commons_thankyou = "62",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["stamina:poisoned"] = "no",
		["petz:lycanthropy"] = "0",
		yl_commons_player_created = "1621665541",
		yl_commons_player_joined = "1664551923"
	}
}

Log identifier


[MOD] yl_report log identifier = pUaiTngg27Xth80mqiPqFpvajaW6cnDW

Profiler save:

profile-20220930T161319.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 5d 22h 10min 20s | max lag: 2.07s | clients: rabenkind, Bond007, niceride, Xonon, Juank, flux, HorusDamocles, div, Bla, The4spaceconstants, Stelio, Majkl1, BlackLemon, Davidsoft, RIPBla, icser, Service, Bailiff, AliasAlreadyTaken

Teleport command:

/teleport xyz 3737 10 2325

Compass command:

/give_compass Construction pUaiTngg27Xth80mqiPqFpvajaW6cnDW D2691E 3737 10 2325

Xonon reports a bug: > Feature suggestion: craft an empty book with another item to produce an output book containing the contents of a text file and/or command output Player position: ``` { x = 3736.712890625, y = 9.5, z = 2325.4919433594 } ``` Player look: ``` { x = 0.93907868862152, y = -0.34365969896317, z = -0.0054100654087961 } ``` Player information: ``` { ip_version = 6, min_rtt = 0.16500000655651, avg_rtt = 0.17499999701977, min_jitter = 0, max_jitter = 10.668000221252, avg_jitter = 0.0029999911785126, protocol_version = 40, serialization_version = 29, patch = 0, formspec_version = 6, major = 5, minor = 7, version_string = "5.7.0-dev-ec77850", lang_code = "", connection_uptime = 2525, max_rtt = 20.027000427246, state = "Active" } ``` Player meta: ``` { fields = { ["petz:werewolf_vignette_id"] = "19", ["signslib:pos"] = "(3337,-10829,3768)", ["petz:werewolf_clan_idx"] = "2", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 2256\", \"shields:shield_rainbow 1 2256\", \"3d_armor:chestplate_rainbow 1 2256\", \"3d_armor:leggings_rainbow 1 2256\", \"3d_armor:boots_crystal 1 5640\", \"\"}", ["stamina:level"] = "13", punch_count = "25429", xp = "593227", hud_state = "on", partychat = "party", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["stamina:exhaustion"] = "83", placed_nodes = "268657", inflicted_damage = "365804", arenalib_infobox_arenaID = "0", yl_church = "return {[\"last_death_portal\"] = 1663572283, [\"last_heal\"] = 1664513729, [\"last_death\"] = {[\"x\"] = 3703, [\"y\"] = 19, [\"z\"] = 2354}}", digged_nodes = "564721", repellant = "0", jointime = "1621665541", bitten = "0", ["ocean_build.ocean_built"] = "7", played_time = "4417619", ["ocean_build.last_warning"] = "1.65801e+09", ["petz:werewolf"] = "0", died = "74", crafted = "25664", yl_commons_thankyou = "62", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["stamina:poisoned"] = "no", ["petz:lycanthropy"] = "0", yl_commons_player_created = "1621665541", yl_commons_player_joined = "1664551923" } } ``` Log identifier ``` [MOD] yl_report log identifier = pUaiTngg27Xth80mqiPqFpvajaW6cnDW ``` Profiler save: ``` profile-20220930T161319.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 5d 22h 10min 20s | max lag: 2.07s | clients: rabenkind, Bond007, niceride, Xonon, Juank, flux, HorusDamocles, div, Bla, The4spaceconstants, Stelio, Majkl1, BlackLemon, Davidsoft, RIPBla, icser, Service, Bailiff, AliasAlreadyTaken ``` Teleport command: ``` /teleport xyz 3737 10 2325 ``` Compass command: ``` /give_compass Construction pUaiTngg27Xth80mqiPqFpvajaW6cnDW D2691E 3737 10 2325 ```

AliasAlreadyTaken was assigned by yourland-report

2022-09-30 16:13:19 +00:00

flux added the

1. kind/enhancement

4. step/ready to QA test

2. prio/interesting

labels 2022-09-30 17:13:59 +00:00

flux commented

2022-09-30 17:14:25 +00:00

xonon mentioned this to me, and i wrote it:

https://github.com/fluxionary/minetest-book_runner

xonon mentioned this to me, and i wrote it: https://github.com/fluxionary/minetest-book_runner

flux self-assigned this 2022-09-30 17:14:36 +00:00

flux added this to the flux's TODO list project 2022-09-30 17:14:39 +00:00

AliasAlreadyTaken commented

2022-10-12 16:55:44 +00:00

Someone else also saw the problem and asked for a solution. Maybe we could use theirs, maybe you could suggest them yours?

https://github.com/minetest/minetest/issues/12842

Someone else also saw the problem and asked for a solution. Maybe we could use theirs, maybe you could suggest them yours? https://github.com/minetest/minetest/issues/12842

flux commented

2022-10-12 20:02:14 +00:00

Someone else also saw the problem and asked for a solution. Maybe we could use theirs, maybe you could suggest them yours?

https://github.com/minetest/minetest/issues/12842

i'm confused; that issue is about adding documentation of command parameters.

this is about capturing the output of a command somewhere else than in in-game chat (where you can't copy/paste it).

> Someone else also saw the problem and asked for a solution. Maybe we could use theirs, maybe you could suggest them yours? > > https://github.com/minetest/minetest/issues/12842 i'm confused; that issue is about adding documentation of command parameters. this is about capturing the output of a command somewhere else than in in-game chat (where you can't copy/paste it).

AliasAlreadyTaken commented

2022-10-12 22:04:30 +00:00

Ups, then I mistook it somehow.

flux referenced this issue

2022-11-10 01:03:47 +00:00

daydream reports: how hard would it be to get th ... #2988

flux added this to the 1.1.117 milestone 2022-11-18 22:48:07 +00:00

AliasAlreadyTaken removed this from the 1.1.117 milestone 2023-01-18 11:54:28 +00:00

flux referenced this issue

2023-05-12 16:46:25 +00:00

AliasAlreadyTaken reports: add a chatcommand to output profiler prints #4440

AliasAlreadyTaken commented

2023-12-06 17:56:40 +00:00

QA

I found the issue when looking for issues ready for QA, but not on a milestone.

I tried various commands:

/run_in_book p help => The output of the command /p help is added to the book
/run_in_book /p help => WorldEdit -!- unknown subcommand: help
/run_in_book coords => Since there is no "personal output", there's nothing we can put into the book
/run_in_book profiler print => Creates a book that is 52 pages long, but works.
/run_in_book run_in_book => please provide a command as an argument

I recommend to either have a default text "This command did not return any output" if there was nothing returned or not write the book at all.

The command doesn't crash in a command block, even if the owning player is not online. To the contrary, it works even from inside a command block.

Privs appear to be respected as well and recursive call as well.

I did not find any combination that would break it.

Proper logging is missing, that's the only point NOK. If that works, we'll add it as OK

QA I found the issue when looking for issues ready for QA, but not on a milestone. I tried various commands: ``` /run_in_book p help => The output of the command /p help is added to the book /run_in_book /p help => WorldEdit -!- unknown subcommand: help /run_in_book coords => Since there is no "personal output", there's nothing we can put into the book /run_in_book profiler print => Creates a book that is 52 pages long, but works. /run_in_book run_in_book => please provide a command as an argument ``` I recommend to either have a default text "This command did not return any output" if there was nothing returned or not write the book at all. The command doesn't crash in a command block, even if the owning player is not online. To the contrary, it works even from inside a command block. Privs appear to be respected as well and recursive call as well. I did not find any combination that would break it. Proper logging is missing, that's the only point NOK. If that works, we'll add it as OK

👍 1

AliasAlreadyTaken added the

ugh/QA NOK

label 2023-12-06 19:08:25 +00:00

AliasAlreadyTaken added this to the 1.1.122 milestone 2023-12-06 19:08:30 +00:00

flux commented

2023-12-07 19:00:15 +00:00

Proper logging is missing, that's the only point NOK. If that works, we'll add it as OK

added logging: f4a5f685f6

> Proper logging is missing, that's the only point NOK. If that works, we'll add it as OK added logging: https://github.com/fluxionary/minetest-book_runner/commit/f4a5f685f679dfd0bf594dc40752ad0f53cb0f15

👍 1

AliasAlreadyTaken added

ugh/QA OK

and removed

ugh/QA NOK

labels 2023-12-07 22:20:55 +00:00

AliasAlreadyTaken referenced this issue from a commit

2023-12-08 01:00:35 +00:00

your-land/bugtracker#2790 Added book_runner

flux added

5. result/fixed

and removed