flux reports: apparently there are flowerpot ... #2288

New Issue

yourland-report · 2022-07-20T21:03:27Z

yourland-report commented

2022-07-20 21:03:27 +00:00

flux reports a bug:

apparently there are flowerpot nodes for ongen saplings? seems like a waste of nodes...

Player position:

{
	x = 1289,
	y = 47.700000762939,
	z = 624
}

Player look:

{
	x = -0.33552131056786,
	y = -0.39008837938309,
	z = -0.85747098922729
}

Player information:

{
	connection_uptime = 19776,
	patch = 0,
	state = "Active",
	formspec_version = 5,
	lang_code = "",
	major = 5,
	minor = 6,
	version_string = "5.6.0-dev-0db22e793-dirty",
	serialization_version = 29,
	min_rtt = 0.15800000727177,
	ip_version = 6,
	protocol_version = 40,
	max_rtt = 4.2760000228882,
	avg_rtt = 0.16899999976158,
	min_jitter = 0,
	max_jitter = 4.1019997596741,
	avg_jitter = 0
}

Player meta:

{
	fields = {
		played_time = "20126306",
		["petz:werewolf_clan_idx"] = "1",
		placed_nodes = "353056",
		hud_state = "on",
		["stamina:level"] = "4",
		crafted = "38780",
		["stamina:poisoned"] = "no",
		inflicted_damage = "1355034",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		digged_nodes = "1078550",
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 4180\", \"3d_armor:leggings_nether 1 8360\", \"3d_armor:chestplate_nether 1 8360\", \"3d_armor:helmet_nether 1 4180\", \"nether_mobs:dragon_shield 1 4180\", \"\"}",
		died = "66",
		punch_count = "83136",
		arenalib_infobox_arenaID = "0",
		["signslib:pos"] = "(1274,70,546)",
		jointime = "1615351173",
		bitten = "0",
		xp = "1268678",
		["petz:werewolf"] = "1",
		repellant = "0",
		["petz:lycanthropy"] = "1",
		yl_commons_thankyou = "130",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		yl_commons_player_created = "1615351173",
		yl_commons_player_joined = "1658331258",
		["petz:werewolf_vignette_id"] = "20",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 48, [\"x\"] = 1289, [\"z\"] = 624}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1653796347}",
		["stamina:exhaustion"] = "17"
	}
}

Log identifier


[MOD] yl_report log identifier = PW1kKTvnzjHfcjuTY8zfpSOsybxBcg26

Profiler save:

profile-20220720T230326.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 8h 44min 15s | max lag: 3.88s | clients: 232, bodshfa, NATESFOOD, daydream, NikoSkillz, Kalek, Chache, shadowdog9063, SoozieQ, denki_kami_thecat, hbreturns, Therottenpotato, flux, kiss, mindfrost, Bailiff, Service, AliasAlreadyTaken

Teleport command:

/teleport xyz 1289 48 624

Compass command:

/give_compass Construction PW1kKTvnzjHfcjuTY8zfpSOsybxBcg26 D2691E 1289 48 624

flux reports a bug: > apparently there are flowerpot nodes for ongen saplings? seems like a waste of nodes... Player position: ``` { x = 1289, y = 47.700000762939, z = 624 } ``` Player look: ``` { x = -0.33552131056786, y = -0.39008837938309, z = -0.85747098922729 } ``` Player information: ``` { connection_uptime = 19776, patch = 0, state = "Active", formspec_version = 5, lang_code = "", major = 5, minor = 6, version_string = "5.6.0-dev-0db22e793-dirty", serialization_version = 29, min_rtt = 0.15800000727177, ip_version = 6, protocol_version = 40, max_rtt = 4.2760000228882, avg_rtt = 0.16899999976158, min_jitter = 0, max_jitter = 4.1019997596741, avg_jitter = 0 } ``` Player meta: ``` { fields = { played_time = "20126306", ["petz:werewolf_clan_idx"] = "1", placed_nodes = "353056", hud_state = "on", ["stamina:level"] = "4", crafted = "38780", ["stamina:poisoned"] = "no", inflicted_damage = "1355034", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", digged_nodes = "1078550", ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 4180\", \"3d_armor:leggings_nether 1 8360\", \"3d_armor:chestplate_nether 1 8360\", \"3d_armor:helmet_nether 1 4180\", \"nether_mobs:dragon_shield 1 4180\", \"\"}", died = "66", punch_count = "83136", arenalib_infobox_arenaID = "0", ["signslib:pos"] = "(1274,70,546)", jointime = "1615351173", bitten = "0", xp = "1268678", ["petz:werewolf"] = "1", repellant = "0", ["petz:lycanthropy"] = "1", yl_commons_thankyou = "130", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", yl_commons_player_created = "1615351173", yl_commons_player_joined = "1658331258", ["petz:werewolf_vignette_id"] = "20", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 48, [\"x\"] = 1289, [\"z\"] = 624}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1653796347}", ["stamina:exhaustion"] = "17" } } ``` Log identifier ``` [MOD] yl_report log identifier = PW1kKTvnzjHfcjuTY8zfpSOsybxBcg26 ``` Profiler save: ``` profile-20220720T230326.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 8h 44min 15s | max lag: 3.88s | clients: 232, bodshfa, NATESFOOD, daydream, NikoSkillz, Kalek, Chache, shadowdog9063, SoozieQ, denki_kami_thecat, hbreturns, Therottenpotato, flux, kiss, mindfrost, Bailiff, Service, AliasAlreadyTaken ``` Teleport command: ``` /teleport xyz 1289 48 624 ``` Compass command: ``` /give_compass Construction PW1kKTvnzjHfcjuTY8zfpSOsybxBcg26 D2691E 1289 48 624 ```

AliasAlreadyTaken was assigned by yourland-report

2022-07-20 21:03:27 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2022-07-21 09:46:52 +00:00

AliasAlreadyTaken commented

2022-07-21 10:35:16 +00:00

To be honest, that flowerpot is only a "different" itemframe, we could scrap all of those nodes and make it one entity instead.

flux commented

2022-07-21 20:12:07 +00:00

To be honest, that flowerpot is only a "different" itemframe, we could scrap all of those nodes and make it one entity instead.

have we not yet learned our lesson w/ having tons of entities? =D
we'd have to separate the pot mesh from the "plantlike" mesh it provides. i don't know how to do that.

my idea was to register_alias_force all the ongen variants to the normal variants

> To be honest, that flowerpot is only a "different" itemframe, we could scrap all of those nodes and make it one entity instead. 1. have we not yet learned our lesson w/ having tons of entities? =D 2. we'd have to separate the pot mesh from the "plantlike" mesh it provides. i don't know how to do that. my idea was to `register_alias_force` all the ongen variants to the normal variants

AliasAlreadyTaken commented

2022-08-05 06:04:01 +00:00

have we not yet learned our lesson w/ having tons of entities? =D

Entities are not bad per se. Only somehow MT entities are worse than any other game I saw. Even the "mostly inactive" ones like upright sprites or how signposts are done.

If a (rare) entitiy can save us a bazillion nodecount, then we should at least consider it.

We could remodel the flowerpot and then simply add an entity ... oh wait ... those x-shaped things require TWO entities??

> have we not yet learned our lesson w/ having tons of entities? =D Entities are not bad per se. Only somehow MT entities are worse than any other game I saw. Even the "mostly inactive" ones like upright sprites or how signposts are done. If a (rare) entitiy can save us a bazillion nodecount, then we should at least consider it. We could remodel the flowerpot and then simply add an entity ... oh wait ... those x-shaped things require TWO entities??

flux commented

2022-08-05 15:52:49 +00:00

We could remodel the flowerpot and then simply add an entity ... oh wait ... those x-shaped things require TWO entities??

i'm not sure whether the plantlike drawtypes would require multiple entities to replicate, but i've got no idea how to do that.

> We could remodel the flowerpot and then simply add an entity ... oh wait ... those x-shaped things require TWO entities?? i'm not sure whether the plantlike drawtypes would require multiple entities to replicate, but i've got no idea how to do that.

flux commented

2022-08-07 17:57:35 +00:00

i'm warming up to the idea of turning them into "item-frame"-like objects, particularly if we want to add more plant nodes. however, the 3d modelling bit is not something i could easily do myself.