your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

moretrees' giant jungle trees leave floating nodes when cut w/ the electrumese axe #2211

New Issue
Open
opened 2022-07-12 15:56:53 +00:00 by flux · 8 comments
flux commented 2022-07-12 15:56:53 +00:00
Member
Copy Link

![](https://gitea.your-land.de/attachments/7ab9623d-059f-4170-9993-263134c4fbbc)
screenshot_20220712_085730.png
1.7 MiB
flux added the
1. kind/bug
3. source/integration
 labels 2022-07-12 16:04:14 +00:00
flux added this to the flux's TODO list project 2022-07-12 16:04:16 +00:00
flux self-assigned this 2022-07-12 16:04:21 +00:00
flux commented 2022-07-12 16:13:40 +00:00
Author
Member
Copy Link

perhaps the real question is, why does moretrees even define its own jungle trunk?

perhaps the real question is, why does moretrees even define its own jungle trunk?
👍 1
AliasAlreadyTaken commented 2022-07-13 00:43:22 +00:00
Owner
Copy Link

Maybe they wanted to do "something special" later, but never came to. Or they tried to be independent from MTG.

Maybe they wanted to do "something special" later, but never came to. Or they tried to be independent from MTG.
flux commented 2022-07-13 15:16:55 +00:00
Author
Member
Copy Link

62cab1b1d9/node_defs.lua (L609-L611)

local jungle_tree = table.copy(minetest.registered_nodes["default:jungletree"])
jungle_tree.drop = "default:jungletree"
minetest.register_node("moretrees:jungletree_trunk", jungle_tree)

it's literally an exact replica.

there's some code that suggests that perhaps it's an attempt to keep too many moretrees "giant" jungle trees from spawning in an area? but the logic for that is redundant...

i'm gonna try aliasing them and see if anything weird happens.

https://gitea.your-land.de/your-land/moretrees/src/commit/62cab1b1d9d40a73b2f304650951d4659d86e391/node_defs.lua#L609-L611 ```lua local jungle_tree = table.copy(minetest.registered_nodes["default:jungletree"]) jungle_tree.drop = "default:jungletree" minetest.register_node("moretrees:jungletree_trunk", jungle_tree) ``` it's literally an exact replica. there's some code that suggests that perhaps it's an attempt to keep too many moretrees "giant" jungle trees from spawning in an area? but the logic for that is redundant... i'm gonna try aliasing them and see if anything weird happens.
flux added the
4. step/at work
 label 2022-07-13 15:17:12 +00:00
flux commented 2022-07-13 18:05:12 +00:00
Author
Member
Copy Link

i aliased them, but the issue doesn't seem to be due to there being random wrong nodes in the tree:

(i have no idea what's up w/ the flying item drops)

i aliased them, but the issue doesn't seem to be due to there being random wrong nodes in the tree: ![](https://gitea.your-land.de/attachments/7616e79c-704f-4960-90ca-401b666c6c10) (i have no idea what's up w/ the flying item drops)
screenshot_20220713_105556.png
512 KiB
flux commented 2022-07-13 18:06:49 +00:00
Author
Member
Copy Link

the real issue seems to be that moretrees giant jungletree models have "nubs" on the branches which the electrumese axe "treecapitator" code can't handle.

the real issue seems to be that moretrees giant jungletree models have "nubs" on the branches which the electrumese axe "treecapitator" code can't handle. ![](https://gitea.your-land.de/attachments/e42557b5-b55a-47f7-8ca3-8b9a5dbfe7ef)
screenshot_20220713_110330.png
399 KiB
flux commented 2022-07-13 18:13:48 +00:00
Author
Member
Copy Link

upstream issue (question) https://github.com/mt-mods/moretrees/issues/12

upstream issue (question) https://github.com/mt-mods/moretrees/issues/12
flux commented 2022-07-13 18:15:08 +00:00
Author
Member
Copy Link

committed the alias just to reduce the node count by 1:

b4f6d3acfe

committed the alias just to reduce the node count by 1: https://gitea.your-land.de/your-land/yl_commons/commit/b4f6d3acfeb2d550240c03e83a1a0ec145fbbdd9
flux changed title from moretrees:jungletree_trunk is not cut down via woodcutting to moretrees' giant jungle trees leave floating nodes when cut w/ the electrumese axe 2022-07-13 18:15:44 +00:00
flux removed the
4. step/at work
 label 2022-07-20 18:21:41 +00:00
flux commented 2022-07-20 18:22:30 +00:00
Author
Member
Copy Link

will rewrite treecapitator logic later

will rewrite treecapitator logic later
flux closed this issue 2022-07-20 18:22:30 +00:00
flux reopened this issue 2022-07-20 18:22:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
flux's TODO list
Assignees
Clear assignees
No Assignees
flux
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2211
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?