Redshirt reports: dying because of tree cutting ... #3066

New Issue

yourland-report · 2022-11-17T02:51:47Z

yourland-report commented

2022-11-17 02:51:47 +00:00

Redshirt reports a bug:

dying because of tree cutting and some leaves ending up floating over a protected street is a bug and needs fixing

Player position:

{
	z = 1179.8990478516,
	x = 2006.0080566406,
	y = 14.5
}

Player look:

{
	z = 0.89556062221527,
	x = -0.42428630590439,
	y = -0.13398618996143
}

Player information:

{
	lang_code = "",
	max_rtt = 5.4759998321533,
	state = "Active",
	major = 5,
	minor = 7,
	version_string = "5.7.0-dev-b3503e785-dirty",
	protocol_version = 41,
	avg_rtt = 0.018999999389052,
	ip_version = 6,
	min_rtt = 0.01799999922514,
	formspec_version = 6,
	min_jitter = 0,
	max_jitter = 5.4260001182556,
	avg_jitter = 0.0020000003278255,
	connection_uptime = 4455,
	serialization_version = 29,
	patch = 0
}

Player meta:

{
	fields = {
		["petz:werewolf"] = "1",
		xp = "80782",
		["petz:lycanthropy"] = "1",
		crafted = "7030",
		["stamina:level"] = "17",
		yl_commons_thankyou = "7",
		["stamina:poisoned"] = "no",
		repellant = "0",
		["stamina:exhaustion"] = "21.5",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = 3072, [\"x\"] = 6741, [\"y\"] = 19}, [\"last_death_portal\"] = 1644102059}",
		yl_commons_player_created = "1631645913",
		yl_commons_player_joined = "1668649076",
		["petz:werewolf_clan_idx"] = "3",
		placed_nodes = "448",
		punch_count = "39998",
		hud_state = "on",
		inflicted_damage = "874990",
		arenalib_infobox_arenaID = "0",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		jointime = "1631645913",
		bitten = "0",
		["petz:werewolf_vignette_id"] = "19",
		died = "6",
		["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 1300\", \"shields:shield_rainbow 1 6440\", \"3d_armor:chestplate_crystal 1 1300\", \"3d_armor:boots_crystal 1 400\", \"3d_armor:leggings_crystal 1 1300\"}",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		played_time = "246372",
		digged_nodes = "21625"
	}
}

Log identifier


[MOD] yl_report log identifier = s0VELYEWatRPtnvnwVTXVdKIrR3rS5iV

Profiler save:

profile-20221117T025147.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 9h 47min 3s | max lag: 3.03s | clients (24/42): AliasAlreadyTaken, Bailiff, Chicago, Crystal1976, daydream, ecki, flux, Ha7rpy, HorusDamocles, Ivanhoe, LeetPeet, Lupercus, Minetest13, montezumo, niceride, ourland, Parrish, PixelMan, Queenfire234312, Redshirt, Service, shanish, shanish3, wordes

Teleport command:

/teleport xyz 2006 15 1180

Compass command:

/give_compass Construction s0VELYEWatRPtnvnwVTXVdKIrR3rS5iV D2691E 2006 15 1180

Redshirt reports a bug: > dying because of tree cutting and some leaves ending up floating over a protected street is a bug and needs fixing Player position: ``` { z = 1179.8990478516, x = 2006.0080566406, y = 14.5 } ``` Player look: ``` { z = 0.89556062221527, x = -0.42428630590439, y = -0.13398618996143 } ``` Player information: ``` { lang_code = "", max_rtt = 5.4759998321533, state = "Active", major = 5, minor = 7, version_string = "5.7.0-dev-b3503e785-dirty", protocol_version = 41, avg_rtt = 0.018999999389052, ip_version = 6, min_rtt = 0.01799999922514, formspec_version = 6, min_jitter = 0, max_jitter = 5.4260001182556, avg_jitter = 0.0020000003278255, connection_uptime = 4455, serialization_version = 29, patch = 0 } ``` Player meta: ``` { fields = { ["petz:werewolf"] = "1", xp = "80782", ["petz:lycanthropy"] = "1", crafted = "7030", ["stamina:level"] = "17", yl_commons_thankyou = "7", ["stamina:poisoned"] = "no", repellant = "0", ["stamina:exhaustion"] = "21.5", yl_church = "return {[\"last_death\"] = {[\"z\"] = 3072, [\"x\"] = 6741, [\"y\"] = 19}, [\"last_death_portal\"] = 1644102059}", yl_commons_player_created = "1631645913", yl_commons_player_joined = "1668649076", ["petz:werewolf_clan_idx"] = "3", placed_nodes = "448", punch_count = "39998", hud_state = "on", inflicted_damage = "874990", arenalib_infobox_arenaID = "0", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", jointime = "1631645913", bitten = "0", ["petz:werewolf_vignette_id"] = "19", died = "6", ["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 1300\", \"shields:shield_rainbow 1 6440\", \"3d_armor:chestplate_crystal 1 1300\", \"3d_armor:boots_crystal 1 400\", \"3d_armor:leggings_crystal 1 1300\"}", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", played_time = "246372", digged_nodes = "21625" } } ``` Log identifier ``` [MOD] yl_report log identifier = s0VELYEWatRPtnvnwVTXVdKIrR3rS5iV ``` Profiler save: ``` profile-20221117T025147.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 9h 47min 3s | max lag: 3.03s | clients (24/42): AliasAlreadyTaken, Bailiff, Chicago, Crystal1976, daydream, ecki, flux, Ha7rpy, HorusDamocles, Ivanhoe, LeetPeet, Lupercus, Minetest13, montezumo, niceride, ourland, Parrish, PixelMan, Queenfire234312, Redshirt, Service, shanish, shanish3, wordes ``` Teleport command: ``` /teleport xyz 2006 15 1180 ``` Compass command: ``` /give_compass Construction s0VELYEWatRPtnvnwVTXVdKIrR3rS5iV D2691E 2006 15 1180 ```

AliasAlreadyTaken was assigned by yourland-report

2022-11-17 02:51:47 +00:00

flux added the

1. kind/bug

3. source/integration

labels 2022-11-17 18:41:29 +00:00

flux commented

2022-11-17 18:41:56 +00:00

it's not incredibly easy to detect this. hm...

flux added the

2. prio/elevated

label 2022-11-17 18:51:06 +00:00

flux added this to the flux's TODO list project 2022-11-17 21:41:19 +00:00

AliasAlreadyTaken commented

2022-11-23 07:41:29 +00:00

Would "disable area violation punishment during woodcutting" work?

Making it an integration issue?

Would "disable area violation punishment during woodcutting" work? Making it an integration issue?

Bla commented

2022-11-23 09:05:12 +00:00

Shouldn´t woodcutting check the protection to prevent griefing?

AliasAlreadyTaken commented

2022-11-23 09:44:42 +00:00

Shouldn´t woodcutting check the protection to prevent griefing?

Yes, of course. The problem at hand is that woodcutting repeatedly tries to "digs" the same protected block, causing the player to take damage each time a dig doesn't work. The player can't disable woodcutting fast enough to not die.

The protection must remain, it must still be impossible to alter someone else's area.

> Shouldn´t woodcutting check the protection to prevent griefing? Yes, of course. The problem at hand is that woodcutting repeatedly tries to "digs" the same protected block, causing the player to take damage each time a dig doesn't work. The player can't disable woodcutting fast enough to not die. The protection must remain, it must still be impossible to alter someone else's area.

Bla commented

2022-11-23 10:22:29 +00:00

The problem at hand is that woodcutting repeatedly tries to "digs" the same protected block, causing the player to take damage each time a dig doesn't work.

Thats my point 😉
If it checks protection and still tries to dig the node thats wrong.
So instead of adding special handling for woodcutting to violation punishment, fix woodcutting to not even try to dig protected nodes the player isn´t allowed to dig.

> The problem at hand is that woodcutting repeatedly tries to "digs" the same protected block, causing the player to take damage each time a dig doesn't work. Thats my point 😉 If it checks protection and still tries to dig the node thats wrong. So instead of adding special handling for woodcutting to violation punishment, fix woodcutting to not even try to dig protected nodes the player isn´t allowed to dig.

👍 2

flux commented

2022-11-24 01:46:27 +00:00

aaaand this turned into me spending the whole day writing a treecutting mod:

https://github.com/fluxionary/minetest-choppy

there's still a lot of essential features missing, but it'll fix:

#21 automatic woodcutting seems to also cut wood different to the one that it started with
#1004 DanteLives reports: the date palm tree cannot be completely removed through automatic woodcutting.
#2211 MAYBE moretrees' giant jungle trees leave floating nodes when cut w/ the electrumese axe
#1535 MAYBE If you're using the automatic woodcutting and go do something else, you don't get any xp for the other thing that you do.
#2114 Woodcutting with a regular axe appears to be faster than an enchanted one.
#2141 When using woodcutting on Apple Tree the apples get placed on the ground instead of in the inventory.
this issue

aaaand this turned into me spending the whole day writing a treecutting mod: https://github.com/fluxionary/minetest-choppy there's still a lot of essential features missing, but it'll fix: * [x] #21 automatic woodcutting seems to also cut wood different to the one that it started with * [x] #1004 DanteLives reports: the date palm tree cannot be completely removed through automatic woodcutting. * [ ] #2211 ***MAYBE*** moretrees' giant jungle trees leave floating nodes when cut w/ the electrumese axe * [ ] #1535 ***MAYBE*** If you're using the automatic woodcutting and go do something else, you don't get any xp for the other thing that you do. * [x] #2114 Woodcutting with a regular axe appears to be faster than an enchanted one. * [x] #2141 When using woodcutting on Apple Tree the apples get placed on the ground instead of in the inventory. * [x] this issue

👍 1

flux added the

3. source/mod upstream

4. step/at work

labels 2022-11-24 01:46:41 +00:00

AliasAlreadyTaken commented

2022-11-24 17:19:07 +00:00

I'd prefer fixing the original woodcutting, for licensing and distribution reasons.

flux referenced this issue

2023-01-10 15:26:36 +00:00

Absolute_Mongoose reports: I got killed by protected bloc ... #3493

flux removed the

4. step/at work

label 2023-01-10 15:28:12 +00:00

flux commented

2023-01-26 00:56:28 +00:00

i wrote choppy because i estimated it'd be easier than fixing woodcutting, and i think i was right.

choppy works in a similar but significantly different way than woodcutting, there are intentionally some very different design decisions, and the other users of woodcutting might appreciate them, or not. but i feel like they fit the goals of your-land more. e.g. avoiding "floating treetops" above most other considerations, not cutting adjacent trees forever, not cutting (most) tree/leaves placed by players, creating less lag and simultaneously being more responsive during laggy times, being "on by default" so that players realize it's there w/out needing an education... other things.

but if choppy isn't approved, i will probably eventually PR woodcutting with some fixes.

i wrote choppy because i estimated it'd be easier than fixing woodcutting, and i think i was right. choppy works in a similar but significantly different way than woodcutting, there are intentionally some very different design decisions, and the other users of woodcutting might appreciate them, or not. but i feel like they fit the goals of your-land more. e.g. avoiding "floating treetops" above most other considerations, not cutting adjacent trees forever, not cutting (most) tree/leaves placed by players, creating less lag and simultaneously being more responsive during laggy times, being "on by default" so that players realize it's there w/out needing an education... other things. but if choppy isn't approved, i will probably eventually PR woodcutting with some fixes.

AliasAlreadyTaken commented

2023-01-26 03:19:12 +00:00

choppy is now a candidate and active on the testserver.

flux added the

4. step/ready to QA test

label 2023-02-01 15:56:42 +00:00

AliasAlreadyTaken added this to the 1.1.117.1 milestone 2023-02-02 10:39:07 +00:00

AliasAlreadyTaken modified the milestone from 1.1.117.1 to 1.1.118

2023-02-02 10:39:10 +00:00

flux referenced this issue

2023-02-20 17:25:03 +00:00

1.1.118 #3401