flux reports: compass should have an option ... #1845

New Issue

yourland-report · 2022-04-28T16:46:07Z

yourland-report commented

2022-04-28 16:46:07 +00:00

flux reports a bug:

compass should have an option to program it w/ coordinates recently seen in chat

Player position:

{
	y = 20.5,
	x = 3864.1809082031,
	z = 3072.1870117188
}

Player look:

{
	y = -0.46931743621826,
	x = -0.27565371990204,
	z = 0.83890175819397
}

Player information:

{
	min_rtt = 0.15800000727177,
	max_rtt = 24.177000045776,
	connection_uptime = 84185,
	max_jitter = 23.366998672485,
	minor = 6,
	major = 5,
	ip_version = 6,
	formspec_version = 5,
	patch = 0,
	protocol_version = 40,
	serialization_version = 29,
	lang_code = "",
	version_string = "5.6.0-dev-9683cc17c",
	avg_rtt = 0.16699999570847,
	state = "Active",
	avg_jitter = 0,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_shield 1 1760\", \"3d_armor:leggings_nether 1 3520\", \"nether_mobs:dragon_boots 1 1760\", \"3d_armor:chestplate_nether 1 3520\", \"3d_armor:helmet_nether 1 1760\", \"\"}",
		["petz:werewolf_vignette_id"] = "20",
		yl_commons_thankyou = "105",
		jointime = "1615351173",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "125",
		["signslib:pos"] = "(3234,65,3033)",
		digged_nodes = "1037027",
		xp = "1224739",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		partychat = "party",
		played_time = "14225876",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -3071, [\"x\"] = 2916, [\"z\"] = 1670}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1649877393}",
		yl_commons_player_joined = "1651080199",
		["stamina:level"] = "19",
		punch_count = "71613",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "1123736",
		crafted = "34554",
		["petz:werewolf_clan_idx"] = "1",
		["petz:werewolf"] = "0",
		died = "62",
		placed_nodes = "345378",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1615351173"
	}
}

Log identifier


[MOD] yl_report log identifier = bkcY0SAPVx4DLNflKyKY4x0aUFmBu9B0

Profiler save:

profile-20220428T184606.json_prettyEE

Status:

# Server: version: 5.5.0-yl | game: Minetest Game | uptime: 2d 5h 54min 27s | max lag: 4.86s | clients: catgodss, daydream, pitman, Boot, Willow, shanish, debiankaios, shanish2, bibi, Dragoni_is_bored, Ravise, tour, rohit, Alex1977, AliasAlreadyTaken, Service, Bailiff, flux, Gardenfire2007, Aleks555

Teleport command:

/teleport xyz 3864 21 3072

Compass command:

/give_compass Construction bkcY0SAPVx4DLNflKyKY4x0aUFmBu9B0 D2691E 3864 21 3072

flux reports a bug: > compass should have an option to program it w/ coordinates recently seen in chat Player position: ``` { y = 20.5, x = 3864.1809082031, z = 3072.1870117188 } ``` Player look: ``` { y = -0.46931743621826, x = -0.27565371990204, z = 0.83890175819397 } ``` Player information: ``` { min_rtt = 0.15800000727177, max_rtt = 24.177000045776, connection_uptime = 84185, max_jitter = 23.366998672485, minor = 6, major = 5, ip_version = 6, formspec_version = 5, patch = 0, protocol_version = 40, serialization_version = 29, lang_code = "", version_string = "5.6.0-dev-9683cc17c", avg_rtt = 0.16699999570847, state = "Active", avg_jitter = 0, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_shield 1 1760\", \"3d_armor:leggings_nether 1 3520\", \"nether_mobs:dragon_boots 1 1760\", \"3d_armor:chestplate_nether 1 3520\", \"3d_armor:helmet_nether 1 1760\", \"\"}", ["petz:werewolf_vignette_id"] = "20", yl_commons_thankyou = "105", jointime = "1615351173", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "125", ["signslib:pos"] = "(3234,65,3033)", digged_nodes = "1037027", xp = "1224739", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", bitten = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", partychat = "party", played_time = "14225876", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = -3071, [\"x\"] = 2916, [\"z\"] = 1670}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1649877393}", yl_commons_player_joined = "1651080199", ["stamina:level"] = "19", punch_count = "71613", arenalib_infobox_arenaID = "0", inflicted_damage = "1123736", crafted = "34554", ["petz:werewolf_clan_idx"] = "1", ["petz:werewolf"] = "0", died = "62", placed_nodes = "345378", hud_state = "on", repellant = "0", yl_commons_player_created = "1615351173" } } ``` Log identifier ``` [MOD] yl_report log identifier = bkcY0SAPVx4DLNflKyKY4x0aUFmBu9B0 ``` Profiler save: ``` profile-20220428T184606.json_prettyEE ``` Status: ``` # Server: version: 5.5.0-yl | game: Minetest Game | uptime: 2d 5h 54min 27s | max lag: 4.86s | clients: catgodss, daydream, pitman, Boot, Willow, shanish, debiankaios, shanish2, bibi, Dragoni_is_bored, Ravise, tour, rohit, Alex1977, AliasAlreadyTaken, Service, Bailiff, flux, Gardenfire2007, Aleks555 ``` Teleport command: ``` /teleport xyz 3864 21 3072 ``` Compass command: ``` /give_compass Construction bkcY0SAPVx4DLNflKyKY4x0aUFmBu9B0 D2691E 3864 21 3072 ```

AliasAlreadyTaken was assigned by yourland-report

2022-04-28 16:46:07 +00:00

flux added the

1. kind/enhancement

label 2022-04-28 23:47:29 +00:00

flux referenced this issue

2022-05-02 16:46:11 +00:00

Machtrollo reports: I'd like a command /whome (whe ... #631

flux added this to the flux's TODO list project 2022-07-02 21:08:45 +00:00

whosit self-assigned this 2023-05-12 14:35:16 +00:00

whosit removed their assignment 2023-05-12 14:35:45 +00:00

whosit commented

2023-05-14 08:02:27 +00:00

This is an awesome idea, didn't know I will miss it so much :)

added here:
1193508202
Seems to work, but please test too.

Also: looks good enough to me, but suggestions are welcome.

This is an awesome idea, didn't know I will miss it so much :) added here: https://gitea.your-land.de/whosit/waypoint_compass/commit/11935082029f5f0abe3c27c2da4851f02d32aaeb Seems to work, but please test too. Also: looks good enough to me, but suggestions are welcome.

AliasAlreadyTaken added the

4. step/ready to QA test

label 2023-05-14 08:12:10 +00:00

AliasAlreadyTaken added this to the 1.1.119 milestone 2023-05-14 08:12:12 +00:00

whosit commented

2023-05-14 09:51:57 +00:00

OH, one thing I forgot is to check/implement how that will be hooked into announcements... hmmm.

UPD: we don't have any sort of announcement api, do we?
Should compass have a hook that /coords and waypoint_announcement can call?

UPD2: niceride reminded me about death positions. This currently has one global list of points, but I can easily keep and append a per-player one, that would be filled with death positions. (probably should remove step/ready to qa label, but it's half-working I guess by itself [other stuff needs changes elsewhere too] :P)

OH, one thing I forgot is to check/implement how that will be hooked into announcements... hmmm. UPD: we don't have any sort of announcement api, do we? Should compass have a hook that `/coords` and `waypoint_announcement` can call? UPD2: niceride reminded me about death positions. This currently has one global list of points, but I can easily keep and append a per-player one, that would be filled with death positions. (probably should remove `step/ready to qa` label, but it's half-working I guess by itself [other stuff needs changes elsewhere too] :P)

whosit commented

2023-05-14 13:42:15 +00:00

Some functions that could be called on announcement/death.
73bb4a1eab

Also splits recent log into global one and personal one (per player). They both get merged into one list to choose from. (Any ideas how to do it better without making UI more cluttered?)

Some functions that could be called on announcement/death. https://gitea.your-land.de/whosit/waypoint_compass/commit/73bb4a1eabf8374a69425e04f12d45122c58d581 Also splits recent log into global one and personal one (per player). They both get merged into one list to choose from. (Any ideas how to do it better without making UI more cluttered?)

whosit commented

2023-05-14 14:53:13 +00:00

Here's one way to use it:
6c369e2b6b

Works with waypoint_announce updated to this:
74a3609ac2

So, at this moment:
Compass has a list of positions you can choose from. This list is contatenated from two sources: global one and per-player one. Each stores only 5 points (can be configured), on the FIFO basis (oldest one gets pushed out). There are thre API functions:

waypoint_compass.process_message to parse any message and try to figure out coordinates from it (goes to global) (maybe it should just return guessed position and do nothing instead?)
waypoint_compass.add_point_to_recent_global adds a {x=x,y=y,z=z} point to global list
waypoint_compass.add_point_to_recent_personal adds a point to per-player list.

Here's one way to use it: https://gitea.your-land.de/whosit/waypoint_compass/commit/6c369e2b6b7d719d3905de351f99a579a2f1f69d Works with `waypoint_announce` updated to this: https://gitea.your-land.de/whosit/waypoint_announce/commit/74a3609ac24bf0241beb0e2e520f27d40178bd6c So, at this moment: Compass has a list of positions you can choose from. This list is contatenated from two sources: global one and per-player one. Each stores only 5 points (can be configured), on the FIFO basis (oldest one gets pushed out). There are thre API functions: - `waypoint_compass.process_message` to parse any message and try to figure out coordinates from it (goes to global) (maybe it should just return guessed position and do nothing instead?) - `waypoint_compass.add_point_to_recent_global` adds a {x=x,y=y,z=z} point to global list - ` waypoint_compass.add_point_to_recent_personal` adds a point to per-player list.

AliasAlreadyTaken added the

ugh/QA OK

label 2023-05-14 18:05:36 +00:00

flux commented

2023-05-14 18:48:40 +00:00

So, at this moment:
Compass has a list of positions you can choose from. This list is contatenated from two sources: global one and per-player one. Each stores only 5 points (can be configured), on the FIFO basis (last one gets pushed out). There are thre API functions:

waypoint_compass.process_message to parse any message and try to figure out coordinates from it (goes to global) (maybe it should just return guessed position and do nothing instead?)

waypoint_compass.add_point_to_recent_global adds a {x=x,y=y,z=z} point to global list

waypoint_compass.add_point_to_recent_personal adds a point to per-player list.

very nice! i've got a few proposed changes to the feature though: whosit/waypoint_compass#4

> So, at this moment: > Compass has a list of positions you can choose from. This list is contatenated from two sources: global one and per-player one. Each stores only 5 points (can be configured), on the FIFO basis (last one gets pushed out). There are thre API functions: > - `waypoint_compass.process_message` to parse any message and try to figure out coordinates from it (goes to global) (maybe it should just return guessed position and do nothing instead?) > - `waypoint_compass.add_point_to_recent_global` adds a {x=x,y=y,z=z} point to global list > - ` waypoint_compass.add_point_to_recent_personal` adds a point to per-player list. > very nice! i've got a few proposed changes to the feature though: https://gitea.your-land.de/whosit/waypoint_compass/pulls/4

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2023-05-18 18:14:41 +00:00

flux removed this from the flux's TODO list project 2023-05-18 18:14:44 +00:00

AliasAlreadyTaken was unassigned by flux

2023-05-18 18:14:47 +00:00

flux commented

2023-05-18 18:15:11 +00:00

this is live 🎉

🎉 1