whosit
/
waypoint_compass
1
0
Fork 1
Code Issues 6 Pull Requests Projects Releases Wiki Activity

fix several issues when copying coordinates from chat #4

Merged
whosit merged 1 commits from flux/waypoint_compass:bugfix into master 2023-05-14 19:35:39 +00:00
Conversation 2 Commits 1 Files Changed 2 +52 -53
flux commented 2023-05-14 18:46:37 +00:00
Collaborator
Copy Link
  1. allow for negative coordinate values
  2. instead of using minetest.register_on_chat_message, which only handles messages received from clients, override minetest.chat_send_all and minetest.chat_send_player. this allows immediate compatibility w/ e.g. /announce, /coords, /look, etc.
  3. because the distinction between messages "sent to all" and "sent to a player" is a mess due to the ignore command, unify the "personal" and "global" lists when showing options, and sort the entries by timestamp.
  4. remove the need to wrap fuzzy_parse_coords in a pcall
1. allow for negative coordinate values 2. instead of using `minetest.register_on_chat_message`, which only handles messages received from clients, override `minetest.chat_send_all` and `minetest.chat_send_player`. this allows immediate compatibility w/ e.g. `/announce`, `/coords`, `/look`, etc. 3. because the distinction between messages "sent to all" and "sent to a player" is a mess due to the [ignore command](https://gitea.your-land.de/your-land/yl_commons/src/branch/yl_stable/chatcommands/ignore.lua), unify the "personal" and "global" lists when showing options, and sort the entries by timestamp. 4. remove the need to wrap `fuzzy_parse_coords` in a `pcall`
flux added 1 commit 2023-05-14 18:46:37 +00:00
whosit merged commit fd520efce6 into master 2023-05-14 19:35:39 +00:00
whosit commented 2023-05-14 19:37:39 +00:00
Owner
Copy Link

One thing though, I kept name and playername separate to be able to make points like 1,2,3| death > lava sent to whosit only.
So, name should be label actually. So, that api is not actually related to chat in any way: it's a way for a mod to add a point of interest for all people or specific player.

Hmm, I think we have some more misunderstandings :D
(and I merged without reading, wanted to see if rebase will work :P)

One thing though, I kept name and playername separate to be able to make points like `1,2,3| death > lava ` sent to `whosit` only. So, name should be `label` actually. So, that api is not actually related to chat in any way: it's a way for a mod to add a point of interest for all people or specific player. Hmm, I think we have some more misunderstandings :D (and I merged without reading, wanted to see if rebase will work :P)
whosit commented 2023-05-14 19:40:53 +00:00
Owner
Copy Link

This is why splitting commits logically is better, eh

This is why splitting commits logically is better, eh
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: whosit/waypoint_compass#4
No description provided.
Delete Branch "flux/waypoint_compass:bugfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?