shanish reports: Right click a worn tool to rep ... #1757

New Issue

yourland-report · 2022-04-14T18:54:51Z

yourland-report commented

2022-04-14 18:54:51 +00:00

shanish reports a bug:

Right click a worn tool to replace the tool already on anvil

Player position:

{
	y = 12.5,
	x = 1964.1999511719,
	z = 1699.1311035156
}

Player look:

{
	y = -0.2571327984333,
	x = -0.96099364757538,
	z = -0.10185215622187
}

Player information:

{
	min_rtt = 0.15099999308586,
	max_rtt = 1.067999958992,
	connection_uptime = 4651,
	max_jitter = 0.70600003004074,
	minor = 1,
	major = 5,
	ip_version = 6,
	formspec_version = 2,
	patch = 1,
	protocol_version = 38,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.1.1",
	avg_rtt = 0.16099999845028,
	state = "Active",
	avg_jitter = 0.0029999911785126,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:boots_rainbow 1 11304\", \"3d_armor:chestplate_rainbow 1 11784\", \"shields:shield_rainbow 1 11784\", \"3d_armor:leggings_rainbow 1 11784\", \"3d_armor:helmet_rainbow 1 11784\", \"\"}",
		["petz:werewolf_vignette_id"] = "19",
		yl_commons_thankyou = "9",
		played_time = "4387426",
		jointime = "1638658291",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "5",
		["signslib:pos"] = "(1570,2,1162)",
		["ethereal:fly_timer"] = "-99",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		digged_nodes = "845445",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		punch_count = "1378885",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -1886, [\"x\"] = 1607, [\"z\"] = 1161}, [\"last_death_portal\"] = 1645405003}",
		placed_nodes = "227728",
		["stamina:level"] = "17",
		xp = "3934286",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "15645064",
		crafted = "872",
		["petz:werewolf_clan_idx"] = "2",
		["petz:werewolf"] = "0",
		yl_commons_player_joined = "1649957942",
		died = "76",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1638658291"
	}
}

Log identifier


[MOD] yl_report log identifier = FY1WZZQswLgkzVAcrBvwzDM12XTtTUQG

Profiler save:

profile-20220414T205451.json_prettyEE

Status:

# Server: version: 5.5.0-yl | game: Minetest Game | uptime: 10h 34min 24s | max lag: 4.42s | clients: guipertu29, Giuseppe, Flippster, JeCel, Ravise, Bla, SphinxPortalService, shanish, paneg, AliasAlreadyTaken, Service, mindfrost, GrimPixel, debiankaios, Bishiro, tour, Lucien, shanish2, my-names-is-vaeria, Bailiff, flux, pitman, Boot, Freebie, Boris

Teleport command:

/teleport xyz 1964 13 1699

Compass command:

/give_compass Construction FY1WZZQswLgkzVAcrBvwzDM12XTtTUQG D2691E 1964 13 1699

shanish reports a bug: > Right click a worn tool to replace the tool already on anvil Player position: ``` { y = 12.5, x = 1964.1999511719, z = 1699.1311035156 } ``` Player look: ``` { y = -0.2571327984333, x = -0.96099364757538, z = -0.10185215622187 } ``` Player information: ``` { min_rtt = 0.15099999308586, max_rtt = 1.067999958992, connection_uptime = 4651, max_jitter = 0.70600003004074, minor = 1, major = 5, ip_version = 6, formspec_version = 2, patch = 1, protocol_version = 38, serialization_version = 28, lang_code = "", version_string = "5.1.1", avg_rtt = 0.16099999845028, state = "Active", avg_jitter = 0.0029999911785126, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:boots_rainbow 1 11304\", \"3d_armor:chestplate_rainbow 1 11784\", \"shields:shield_rainbow 1 11784\", \"3d_armor:leggings_rainbow 1 11784\", \"3d_armor:helmet_rainbow 1 11784\", \"\"}", ["petz:werewolf_vignette_id"] = "19", yl_commons_thankyou = "9", played_time = "4387426", jointime = "1638658291", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "5", ["signslib:pos"] = "(1570,2,1162)", ["ethereal:fly_timer"] = "-99", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", digged_nodes = "845445", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", punch_count = "1378885", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = -1886, [\"x\"] = 1607, [\"z\"] = 1161}, [\"last_death_portal\"] = 1645405003}", placed_nodes = "227728", ["stamina:level"] = "17", xp = "3934286", arenalib_infobox_arenaID = "0", inflicted_damage = "15645064", crafted = "872", ["petz:werewolf_clan_idx"] = "2", ["petz:werewolf"] = "0", yl_commons_player_joined = "1649957942", died = "76", hud_state = "on", repellant = "0", yl_commons_player_created = "1638658291" } } ``` Log identifier ``` [MOD] yl_report log identifier = FY1WZZQswLgkzVAcrBvwzDM12XTtTUQG ``` Profiler save: ``` profile-20220414T205451.json_prettyEE ``` Status: ``` # Server: version: 5.5.0-yl | game: Minetest Game | uptime: 10h 34min 24s | max lag: 4.42s | clients: guipertu29, Giuseppe, Flippster, JeCel, Ravise, Bla, SphinxPortalService, shanish, paneg, AliasAlreadyTaken, Service, mindfrost, GrimPixel, debiankaios, Bishiro, tour, Lucien, shanish2, my-names-is-vaeria, Bailiff, flux, pitman, Boot, Freebie, Boris ``` Teleport command: ``` /teleport xyz 1964 13 1699 ``` Compass command: ``` /give_compass Construction FY1WZZQswLgkzVAcrBvwzDM12XTtTUQG D2691E 1964 13 1699 ```

👍 1

AliasAlreadyTaken was assigned by yourland-report

2022-04-14 18:54:51 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2022-04-14 21:19:02 +00:00

flux commented

2022-04-14 22:39:41 +00:00

I've had this exact same idea myself before, it wouldn't be hard to implement.

flux added the

4. step/want approval

label 2022-04-14 22:39:54 +00:00

AliasAlreadyTaken added the

4. step/approved

label 2022-04-16 01:18:08 +00:00

AliasAlreadyTaken commented

2022-04-16 01:18:38 +00:00

It only adds functionality and I can't see any drawbacks.

AliasAlreadyTaken was unassigned by flux

2022-04-16 18:35:14 +00:00

flux self-assigned this 2022-04-16 18:35:14 +00:00

flux removed the

4. step/want approval

label 2022-04-16 18:35:21 +00:00

flux commented

2022-05-04 23:24:30 +00:00

@AliasAlreadyTaken given that they haven't accepted by last PR for #1456, how do you want me to proceed? Is the server just pointed at https://github.com/fluxionary/minetest-anvil/tree/fix_hud_bug still?

@AliasAlreadyTaken given that they haven't accepted by [last PR](https://github.com/minetest-mods/anvil/pull/27) for #1456, how do you want me to proceed? Is the server just pointed at https://github.com/fluxionary/minetest-anvil/tree/fix_hud_bug still?

AliasAlreadyTaken commented

2022-05-05 10:00:54 +00:00

As far as I can see the anvil points to the master branch of https://github.com/minetest-mods/anvil

I will mirror that repo, fork the mirror to the your-land org, then add a yl_stable branch and we can add the fix there. Then we're kinda independent of upstream. Should they ever get around to pull your fix, we can remove it from yl_stable.

Here's our fork: https://gitea.your-land.de/your-land/anvil.git

Please push your fix to yl_stable.

Why did we not do it this way from the very start? Because I was under the false impression that pulling those mods in from their original location would save us time. This proved wrong in all cases where such a mod needed a quick bugfix and where a githost of such a mod suddenly ceased working.

Here we're using our own version of the anvil: e42038ded5

As far as I can see the anvil points to the master branch of https://github.com/minetest-mods/anvil I will mirror that repo, fork the mirror to the your-land org, then add a yl_stable branch and we can add the fix there. Then we're kinda independent of upstream. Should they ever get around to pull your fix, we can remove it from yl_stable. Here's our fork: https://gitea.your-land.de/your-land/anvil.git Please push your fix to yl_stable. Why did we not do it this way from the very start? Because I was under the false impression that pulling those mods in from their original location would save us time. This proved wrong in all cases where such a mod needed a quick bugfix and where a githost of such a mod suddenly ceased working. Here we're using our own version of the anvil: https://gitea.your-land.de/your-land/yourland-mods/commit/e42038ded5934be454c6c8732188492fbc1af87b

flux referenced this issue

2022-05-05 23:46:11 +00:00

flux reports: (note to self) argh fix the is ... #1456

flux commented

2022-05-06 22:58:56 +00:00

Pushed an update to yl_stable: cdc3391253

This commit also fixes a number of other bugs and lays the groundwork for extending anvils as discussed in e.g. #1575, your-land/administration#44, your-land/administration#111

Pushed an update to yl_stable: https://gitea.your-land.de/your-land/anvil/commit/cdc33912534262caf68b6b289d2d96a395309da0 This commit also fixes a number of other bugs and lays the groundwork for extending anvils as discussed in e.g. #1575, https://gitea.your-land.de/your-land/administration/issues/44, https://gitea.your-land.de/your-land/administration/issues/111

flux commented

2022-05-19 17:53:22 +00:00

This is live

flux closed this issue

2022-05-19 17:53:23 +00:00

flux added the

5. result/fixed

label 2022-05-19 17:53:30 +00:00

AliasAlreadyTaken added this to the 1.1.112 milestone 2022-05-20 01:47:46 +00:00

flux removed their assignment 2022-09-21 00:04:05 +00:00

Sign in to join this conversation.