Sokomine reports: thankyou ought to take a param ... #1231

New Issue

yourland-report · 2021-12-28T20:24:56Z

yourland-report commented

2021-12-28 20:24:56 +00:00

Sokomine reports a bug:

thankyou ought to take a parameter regarding the reason. would be intresting for the receipant. and also work offline :-)

Player position:

{
	y = 14.5,
	x = 2133.0881347656,
	z = 1300.9250488281
}

Player look:

{
	y = -0.54302793741226,
	x = -0.81523042917252,
	z = 0.20129606127739
}

Player information:

{
	min_rtt = 0.017000000923872,
	max_rtt = 5.0250000953674,
	connection_uptime = 4569,
	max_jitter = 4.8299999237061,
	minor = 5,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.5.0-dev-0c4929f02-dirty",
	avg_rtt = 0.01799999922514,
	state = "Active",
	avg_jitter = 0.0020000003278255,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 3360\", \"shields:shield_crystal 1 3360\", \"3d_armor:chestplate_crystal 1 3360\", \"3d_armor:boots_crystal 1 3360\", \"3d_armor:leggings_crystal 1 3360\"}",
		yl_commons_thankyou = "63",
		jointime = "1617905120",
		yl_commons_player_joined = "1640718568",
		["signslib:pos"] = "(278,10,1729)",
		digged_nodes = "858327",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}",
		partychat = "main",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 64, [\"x\"] = 1313, [\"z\"] = 270}, [\"last_heal\"] = 1632545235, [\"last_death_portal\"] = 1638390343}",
		["stamina:level"] = "15",
		punch_count = "16535",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "263540",
		crafted = "259454",
		played_time = "4915151",
		died = "18",
		xp = "854116",
		placed_nodes = "147850",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1617905120"
	}
}

Log identifier


[MOD] yl_report log identifier = lYYvxKnVGdIINgg84GKzmDOafrgHUKRK

Profiler save:

profile-20211228T212456.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=25256.7, max_lag=5.02591, clients={turtle, javid, jed, jakob, ipse, Sokomine, Apocralypse, karlbrock, Woldar, Dragoni_is_bored, Gimli, GrimPixel, ccady, Boot, sparrow, Bailiff, flux, AliasAlreadyTaken, Service, LeetPeet}

Teleport command:

/teleport xyz 2133 15 1301

Compass command:

/give_compass Construction lYYvxKnVGdIINgg84GKzmDOafrgHUKRK D2691E 2133 15 1301

Sokomine reports a bug: > thankyou ought to take a parameter regarding the reason. would be intresting for the receipant. and also work offline :-) Player position: ``` { y = 14.5, x = 2133.0881347656, z = 1300.9250488281 } ``` Player look: ``` { y = -0.54302793741226, x = -0.81523042917252, z = 0.20129606127739 } ``` Player information: ``` { min_rtt = 0.017000000923872, max_rtt = 5.0250000953674, connection_uptime = 4569, max_jitter = 4.8299999237061, minor = 5, major = 5, ip_version = 6, formspec_version = 4, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.5.0-dev-0c4929f02-dirty", avg_rtt = 0.01799999922514, state = "Active", avg_jitter = 0.0020000003278255, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 3360\", \"shields:shield_crystal 1 3360\", \"3d_armor:chestplate_crystal 1 3360\", \"3d_armor:boots_crystal 1 3360\", \"3d_armor:leggings_crystal 1 3360\"}", yl_commons_thankyou = "63", jointime = "1617905120", yl_commons_player_joined = "1640718568", ["signslib:pos"] = "(278,10,1729)", digged_nodes = "858327", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}", partychat = "main", yl_church = "return {[\"last_death\"] = {[\"y\"] = 64, [\"x\"] = 1313, [\"z\"] = 270}, [\"last_heal\"] = 1632545235, [\"last_death_portal\"] = 1638390343}", ["stamina:level"] = "15", punch_count = "16535", arenalib_infobox_arenaID = "0", inflicted_damage = "263540", crafted = "259454", played_time = "4915151", died = "18", xp = "854116", placed_nodes = "147850", hud_state = "on", repellant = "0", yl_commons_player_created = "1617905120" } } ``` Log identifier ``` [MOD] yl_report log identifier = lYYvxKnVGdIINgg84GKzmDOafrgHUKRK ``` Profiler save: ``` profile-20211228T212456.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=25256.7, max_lag=5.02591, clients={turtle, javid, jed, jakob, ipse, Sokomine, Apocralypse, karlbrock, Woldar, Dragoni_is_bored, Gimli, GrimPixel, ccady, Boot, sparrow, Bailiff, flux, AliasAlreadyTaken, Service, LeetPeet} ``` Teleport command: ``` /teleport xyz 2133 15 1301 ``` Compass command: ``` /give_compass Construction lYYvxKnVGdIINgg84GKzmDOafrgHUKRK D2691E 2133 15 1301 ```

AliasAlreadyTaken was assigned by yourland-report

2021-12-28 20:24:56 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2021-12-28 21:07:59 +00:00

Styxcolor added this to the (deleted) project 2022-01-05 07:06:09 +00:00

Styxcolor added the

4. step/question

label 2022-01-05 07:06:14 +00:00

Styxcolor commented

2022-01-05 07:07:05 +00:00

Opinions?

I'm fine with thankyou how it is right now, having to type in thankyou AND a reason makes it more cumbersome and therefore leads to less spontaneous expressions of gratefulness.

Opinions? I'm fine with thankyou how it is right now, having to type in thankyou AND a reason makes it more cumbersome and therefore leads to less spontaneous expressions of gratefulness.

flux commented

2022-01-05 16:48:27 +00:00

the reason could be optional. i've also wished i could enter a reason sometimes, but also didn't want to on other occasions.

AliasAlreadyTaken commented

2022-01-05 19:04:11 +00:00

Adding and displaying a reason is easy, saving this reason would increase persistence from an int to a table.

offline "thankyou" may be part of the postgres database mod or yl_settings

Adding and displaying a reason is easy, saving this reason would increase persistence from an int to a table. offline "thankyou" may be part of the postgres database mod or yl_settings

Styxcolor removed the

4. step/question

label 2022-01-06 21:52:02 +00:00

Styxcolor commented

2022-01-06 21:52:19 +00:00

So Alias is implementing that.

Styxcolor added the

4. step/at work

label 2022-01-06 21:52:34 +00:00

AliasAlreadyTaken referenced this issue

2022-01-15 13:05:34 +00:00

debiankaios reports: after thankyou should can give ... #1355