Sokomine reports: we ought to have a group-thank ... #3851

New Issue

yourland-report · 2023-02-19T20:49:31+01:00

yourland-report commented

2023-02-19 20:49:31 +01:00

Sokomine reports a bug:

we ought to have a group-thankyou. with such large groups and delay, there's no chance to thank all involved individually. will always miss some

Player position:

{
	y = 60.400001525879,
	z = -8.8410005569458,
	x = 2631.5249023438
}

Player look:

{
	y = -0.23666855692863,
	z = -0.82359600067139,
	x = 0.51543933153152
}

Player information:

{
	max_rtt = 5.6680002212524,
	lang_code = "",
	formspec_version = 6,
	ip_version = 6,
	min_rtt = 0.01799999922514,
	avg_rtt = 0.018999999389052,
	protocol_version = 41,
	major = 5,
	avg_jitter = 0.0010000001639128,
	minor = 7,
	serialization_version = 29,
	patch = 0,
	state = "Active",
	version_string = "5.7.0-dev-4cd6b773b-dirty",
	connection_uptime = 2815,
	max_jitter = 5.5690002441406,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["signslib:pos"] = "(-114,9,22492)",
		played_time = "11700832",
		["stamina:level"] = "16",
		placed_nodes = "284916",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "63.5",
		bitten = "0",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 3187, [\"y\"] = 94, [\"z\"] = 455}, [\"last_death_portal\"] = 1676580612, [\"last_heal\"] = 1673909657}",
		["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal\", \"shields:shield_rainbow 1 416\", \"3d_armor:chestplate_crystal\", \"3d_armor:boots_crystal 1 1040\", \"3d_armor:leggings_crystal\"}",
		hud_state = "on",
		arenalib_infobox_arenaID = "0",
		punch_count = "186898",
		inflicted_damage = "3838002",
		partychat = "main",
		crafted = "502585",
		yl_commons_player_created = "1617905120",
		yl_commons_player_joined = "1676833381",
		died = "38",
		yl_commons_thankyou = "278",
		xp = "1867904",
		jointime = "1617905120",
		["ethereal:fly_timer"] = "-99",
		repellant = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}",
		["ocean_build.last_warning"] = "1.65032e+09",
		digged_nodes = "1631065",
		["ocean_build.ocean_built"] = "5"
	}
}

Log identifier


[MOD] yl_report log identifier = feKp2U8TOzw4mdsQ3wFDDDiOhqz908uZ

Profiler save:

profile-20230219T194931.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 15h 41min 27s | max lag: 2.85s | clients (23/52): AliasAlreadyTaken, Aliza, AspireMint, Bailiff, Bbuffy, bizon, Bla, brok, Chache, Chazz, daydream, Elias, Ernesto, FailFactory, flux, itaca94, johanlegend, Lucien_II, Murmel, Service, shanish3, Sokomine, yoneda

Teleport command:

/teleport xyz 2632 60 -9

Compass command:

/give_compass Construction feKp2U8TOzw4mdsQ3wFDDDiOhqz908uZ D2691E 2632 60 -9

Sokomine reports a bug: > we ought to have a group-thankyou. with such large groups and delay, there's no chance to thank all involved individually. will always miss some Player position: ``` { y = 60.400001525879, z = -8.8410005569458, x = 2631.5249023438 } ``` Player look: ``` { y = -0.23666855692863, z = -0.82359600067139, x = 0.51543933153152 } ``` Player information: ``` { max_rtt = 5.6680002212524, lang_code = "", formspec_version = 6, ip_version = 6, min_rtt = 0.01799999922514, avg_rtt = 0.018999999389052, protocol_version = 41, major = 5, avg_jitter = 0.0010000001639128, minor = 7, serialization_version = 29, patch = 0, state = "Active", version_string = "5.7.0-dev-4cd6b773b-dirty", connection_uptime = 2815, max_jitter = 5.5690002441406, min_jitter = 0 } ``` Player meta: ``` { fields = { ["signslib:pos"] = "(-114,9,22492)", played_time = "11700832", ["stamina:level"] = "16", placed_nodes = "284916", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "63.5", bitten = "0", yl_church = "return {[\"last_death\"] = {[\"x\"] = 3187, [\"y\"] = 94, [\"z\"] = 455}, [\"last_death_portal\"] = 1676580612, [\"last_heal\"] = 1673909657}", ["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal\", \"shields:shield_rainbow 1 416\", \"3d_armor:chestplate_crystal\", \"3d_armor:boots_crystal 1 1040\", \"3d_armor:leggings_crystal\"}", hud_state = "on", arenalib_infobox_arenaID = "0", punch_count = "186898", inflicted_damage = "3838002", partychat = "main", crafted = "502585", yl_commons_player_created = "1617905120", yl_commons_player_joined = "1676833381", died = "38", yl_commons_thankyou = "278", xp = "1867904", jointime = "1617905120", ["ethereal:fly_timer"] = "-99", repellant = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}", ["ocean_build.last_warning"] = "1.65032e+09", digged_nodes = "1631065", ["ocean_build.ocean_built"] = "5" } } ``` Log identifier ``` [MOD] yl_report log identifier = feKp2U8TOzw4mdsQ3wFDDDiOhqz908uZ ``` Profiler save: ``` profile-20230219T194931.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 15h 41min 27s | max lag: 2.85s | clients (23/52): AliasAlreadyTaken, Aliza, AspireMint, Bailiff, Bbuffy, bizon, Bla, brok, Chache, Chazz, daydream, Elias, Ernesto, FailFactory, flux, itaca94, johanlegend, Lucien_II, Murmel, Service, shanish3, Sokomine, yoneda ``` Teleport command: ``` /teleport xyz 2632 60 -9 ``` Compass command: ``` /give_compass Construction feKp2U8TOzw4mdsQ3wFDDDiOhqz908uZ D2691E 2632 60 -9 ```

👍 1

AliasAlreadyTaken was assigned by yourland-report

2023-02-19 20:49:31 +01:00

flux added the

1. kind/enhancement

label 2023-02-19 23:55:22 +01:00

AliasAlreadyTaken referenced this issue

2023-03-04 16:41:11 +01:00

Sokomine reports: we really need a group-thank-y ... #3928

daydream commented

2023-03-07 19:28:37 +01:00

Yes /thankyou playerName playerName playerName playerName etc.

👍 1

AliasAlreadyTaken added the

2. prio/good first issue

label 2023-03-07 20:37:57 +01:00

flux commented

2023-03-07 21:57:42 +01:00

i feel like /thank_nearby would be a better solution than listing a bajillion names.

i feel like `/thank_nearby` would be a better solution than listing a bajillion names.

👍 1

whosit added the

4. step/ready to QA test

label 2023-06-17 22:08:23 +02:00

whosit referenced this issue

2023-07-27 23:21:12 +02:00

Sokomine reports: thankyou ought to take a param ... #1231

AliasAlreadyTaken commented

2023-12-06 15:11:27 +01:00

QA

While /thankyou NAME1, NAME2, .... works, the command /thankyou_nearby always asks to specify at least one name, regardless of whether I provide a name or not.

QA While `/thankyou NAME1, NAME2, ....` works, the command `/thankyou_nearby` always asks to specify at least one name, regardless of whether I provide a name or not.

AliasAlreadyTaken added the

ugh/QA NOK

label 2023-12-06 15:11:33 +01:00

AliasAlreadyTaken added this to the 1.1.122 milestone 2023-12-06 15:11:35 +01:00

flux commented

2023-12-07 01:13:53 +01:00

QA

While /thankyou NAME1, NAME2, .... works, the command /thankyou_nearby always asks to specify at least one name, regardless of whether I provide a name or not.

hmmmm it's probably not bugged, but the message isn't appropriate. this will happen if there's no-one close enough to you to thank.

> QA > > While `/thankyou NAME1, NAME2, ....` works, the command `/thankyou_nearby` always asks to specify at least one name, regardless of whether I provide a name or not. hmmmm it's probably not bugged, but the message isn't appropriate. this will happen if there's no-one close enough to you to thank.

flux commented

2023-12-07 01:19:51 +01:00

changed the error message: f6f6f176d4

changed the error message: https://gitea.your-land.de/your-land/yl_commons/commit/f6f6f176d40cb50e7e3f1e14e1ffd64a0c913db0

AliasAlreadyTaken added

ugh/QA OK

and removed

ugh/QA NOK

labels 2023-12-08 00:24:23 +01:00

flux added

5. result/fixed

and removed