Xonon reports: gravel repositions the entire ... #1114

New Issue

yourland-report · 2021-11-30T03:26:30Z

yourland-report commented

2021-11-30 03:26:30 +00:00

Xonon reports a bug:

gravel repositions the entire stack of gravel above it when placed by the node replacer

Player position:

{
	y = 108.5,
	x = 1087.4119873047,
	z = 835.1669921875
}

Player look:

{
	y = -0.87873381376266,
	x = -0.29155972599983,
	z = 0.37791505455971
}

Player information:

{
	min_rtt = 0.19699999690056,
	max_rtt = 12.649000167847,
	connection_uptime = 4198,
	max_jitter = 12.443000793457,
	minor = 5,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.5.0-dev-40bee27",
	avg_rtt = 0.21799999475479,
	state = "Active",
	avg_jitter = 0.11500000953674,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 5626\", \"3d_armor:chestplate_rainbow 1 5626\", \"3d_armor:leggings_rainbow 1 5626\", \"shields:shield_rainbow 1 5626\", \"3d_armor:boots_crystal 1 15180\", \"\"}",
		["petz:werewolf_vignette_id"] = "21",
		yl_commons_thankyou = "20",
		jointime = "1621665541",
		yl_commons_player_joined = "1638238646",
		["signslib:pos"] = "(6024,12,5690)",
		digged_nodes = "309244",
		died = "30",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		xp = "334700",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 19, [\"x\"] = 3692, [\"z\"] = 2337}, [\"last_death_portal\"] = 1638158086}",
		["petz:werewolf"] = "1",
		["stamina:level"] = "7.375",
		punch_count = "15306",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "169852",
		crafted = "16920",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:werewolf_clan_idx"] = "2",
		played_time = "2163837",
		placed_nodes = "135773",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1621665541"
	}
}

Log identifier


[MOD] yl_report log identifier = pApDXYC0bsFrRk6w76tODtOZNHq3YHRP

Profiler save:

profile-20211130T042629.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=126779, max_lag=4.0225, clients={bizon, flux, lazerbeak12345, Xonon, Bailiff, AliasAlreadyTaken, hgfdfdfgdhf, Service}

Teleport command:

/teleport xyz 1087 109 835

Compass command:

/give_compass Construction pApDXYC0bsFrRk6w76tODtOZNHq3YHRP D2691E 1087 109 835

Xonon reports a bug: > gravel repositions the entire stack of gravel above it when placed by the node replacer Player position: ``` { y = 108.5, x = 1087.4119873047, z = 835.1669921875 } ``` Player look: ``` { y = -0.87873381376266, x = -0.29155972599983, z = 0.37791505455971 } ``` Player information: ``` { min_rtt = 0.19699999690056, max_rtt = 12.649000167847, connection_uptime = 4198, max_jitter = 12.443000793457, minor = 5, major = 5, ip_version = 6, formspec_version = 4, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.5.0-dev-40bee27", avg_rtt = 0.21799999475479, state = "Active", avg_jitter = 0.11500000953674, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 5626\", \"3d_armor:chestplate_rainbow 1 5626\", \"3d_armor:leggings_rainbow 1 5626\", \"shields:shield_rainbow 1 5626\", \"3d_armor:boots_crystal 1 15180\", \"\"}", ["petz:werewolf_vignette_id"] = "21", yl_commons_thankyou = "20", jointime = "1621665541", yl_commons_player_joined = "1638238646", ["signslib:pos"] = "(6024,12,5690)", digged_nodes = "309244", died = "30", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", xp = "334700", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 19, [\"x\"] = 3692, [\"z\"] = 2337}, [\"last_death_portal\"] = 1638158086}", ["petz:werewolf"] = "1", ["stamina:level"] = "7.375", punch_count = "15306", arenalib_infobox_arenaID = "0", inflicted_damage = "169852", crafted = "16920", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:werewolf_clan_idx"] = "2", played_time = "2163837", placed_nodes = "135773", hud_state = "on", repellant = "0", yl_commons_player_created = "1621665541" } } ``` Log identifier ``` [MOD] yl_report log identifier = pApDXYC0bsFrRk6w76tODtOZNHq3YHRP ``` Profiler save: ``` profile-20211130T042629.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=126779, max_lag=4.0225, clients={bizon, flux, lazerbeak12345, Xonon, Bailiff, AliasAlreadyTaken, hgfdfdfgdhf, Service} ``` Teleport command: ``` /teleport xyz 1087 109 835 ``` Compass command: ``` /give_compass Construction pApDXYC0bsFrRk6w76tODtOZNHq3YHRP D2691E 1087 109 835 ```

AliasAlreadyTaken was assigned by yourland-report

2021-11-30 03:26:30 +00:00

Styxcolor added the

1. kind/bug

label 2021-12-02 01:45:01 +00:00

flux commented

2022-01-04 01:14:47 +00:00

this is a bug w/ how falling nodes are calculated in the engine, not something we can really fix.

flux commented

2022-04-07 17:27:07 +00:00

Actually, I think the falling node behavior is in the "builtin" lua code, though it's incredibly complicated and I don't really want to "fix" anything in there.

flux added the

3. source/mod upstream

label 2022-04-07 17:27:24 +00:00

AliasAlreadyTaken commented

2022-05-05 21:59:50 +00:00

Either I don't understand the bug description, or I feel that's exactly how gravel is supposed to work?

If you touch one of the gravel blocks, then all of those nearby/connected to it should start falling, right?

Either I don't understand the bug description, or I feel that's exactly how gravel is supposed to work? If you touch one of the gravel blocks, then all of those nearby/connected to it should start falling, right?

flux commented

2022-05-05 23:59:37 +00:00

Ah, I see what's confusing. Imagine there's a bunch of gravel sitting on a stone node. Using the node replacement tool, you replace the stone node with something else solid (e.g. "default:tree"). Then, the entire column of gravel above the node is triggered to "fall", but doesn't actually go anywhere, but it does briefly turn into an entity and make a "gravel falling" noise.

It's a bug, but not a hugely significant one. I'd suggest we mark this "low priority".

Ah, I see what's confusing. Imagine there's a bunch of gravel sitting on a stone node. Using the node replacement tool, you replace the stone node with something else solid (e.g. `"default:tree"`). Then, the entire column of gravel above the node is triggered to "fall", but doesn't actually go anywhere, but it does briefly turn into an entity and make a "gravel falling" noise. It's a bug, but not a hugely significant one. I'd suggest we mark this "low priority".

AliasAlreadyTaken added the

2. prio/low

label 2022-05-06 23:20:47 +00:00

AliasAlreadyTaken commented

2022-05-06 23:25:14 +00:00

Maybe we should declare this a feature: It kindly reminds people that there might be unstable terrain above.

Performance impact is minimal, right?

Maybe we should declare this a feature: It kindly reminds people that there might be unstable terrain above. Performance impact is minimal, right?

flux commented

2022-05-07 00:38:58 +00:00

Performance impact is minimal, right?

it's low, though i wouldn't say "minimal". the game hates entities, and every affected node becomes one.

> Performance impact is minimal, right? it's low, though i wouldn't say "minimal". the game hates entities, and every affected node becomes one.

flux commented

2022-05-14 03:24:27 +00:00

I think the solution has to be amending the builtin on_update code to to make use of .after(0, ...), to check whether the affected node is no longer solid.

I think the solution has to be amending the builtin `on_update` code to to make use of `.after(0, ...)`, to check whether the affected node is no longer solid.

👍 1

flux referenced this issue

2022-06-28 00:18:06 +00:00

Zonon reports: using the Node Replacement too ... #2133

flux added

3. source/engine

and removed

3. source/mod upstream

labels 2022-06-28 00:19:17 +00:00

flux added this to the flux's TODO list project 2022-07-02 19:01:07 +00:00

flux referenced this issue

2024-03-10 00:04:48 +00:00