False Death Messages in gen chat #1015

New Issue

Styxcolor · 2021-11-06T20:33:18+01:00

Styxcolor commented

2021-11-06 20:33:18 +01:00

related issue to #998 I haven't seen reported yet. Sometimes we get a death message displayed in gen chat, only to have the person in question disagree a moment later, usually they're in a fight and have just taken damage, but aren't dead.
Maybe Minetest registers the incoming lethal damage and displays the death message without considering damage that didn't come through due to the armor...and MT doesn't consider whether the player is actually dead.

Currently I cannot tell on which level or at what depth of Minetest I should look for the cause of this.

related issue to #998 I haven't seen reported yet. Sometimes we get a death message displayed in gen chat, only to have the person in question disagree a moment later, usually they're in a fight and have just taken damage, but aren't dead. Maybe Minetest registers the incoming lethal damage and displays the death message without considering damage that didn't come through due to the armor...and MT doesn't consider whether the player is actually dead. Currently I cannot tell on which level or at what depth of Minetest I should look for the cause of this.

Styxcolor added the

1. kind/bug

label 2021-11-06 20:33:18 +01:00

AliasAlreadyTaken was assigned by Styxcolor

2021-11-06 20:33:24 +01:00

Styxcolor referenced this issue

2021-11-06 20:34:08 +01:00

Eraldemay reports: I'm unkillable again lol. ... #998

Styxcolor changed title from ~~False Death Messages~~ to False Death Messages in gen chat

2021-11-06 20:38:47 +01:00

Styxcolor referenced this issue

2021-12-29 01:01:04 +01:00

sparrow reports: Death announced while half hea ... #1232

flux referenced this issue

2022-01-03 23:19:31 +01:00

sparrow reports: Death announced while half hea ... #1232

flux commented

2022-01-03 23:21:10 +01:00

There's two parts to this. The death message comes from mt-respawn. The lack of death comes from the heal factor from 3d_armor. The solution, as far as I understand it, is that mt-respawn should be using minetest.register_on_player_hpchange or even better, minetest.register_on_dieplayer, instead of minetest.register_on_punchplayer. I think it uses the latter because it allows you to more easily get the name of the weapon that was used to kill a player during PvP.

There's two parts to this. The death message comes from `mt-respawn`. The lack of death comes from the heal factor from `3d_armor`. The solution, as far as I understand it, is that `mt-respawn` should be using `minetest.register_on_player_hpchange` or even better, `minetest.register_on_dieplayer`, instead of `minetest.register_on_punchplayer`. I think it uses the latter because it allows you to more easily get the name of the weapon that was used to kill a player during PvP.

flux referenced this issue

2022-01-03 23:35:57 +01:00

Bla reports: [suggestion] add a chatcommand ... #1192

AliasAlreadyTaken commented

2022-01-06 01:12:25 +01:00

Simple solution: I gather what MT believes to be the cause of death in a table, but only send once at register_on_dieplayer