Sokomine reports: the flowerpot (from the mod wi ... #976

New Issue

yourland-report · 2021-10-30T17:45:47Z

yourland-report commented

2021-10-30 17:45:47 +00:00

Sokomine reports a bug:

the flowerpot (from the mod with the same name) ought to accept ethereal saplings as well - in particular newer ones like the olive sapling

Player position:

{
	y = 11.5,
	x = -2.4219999313354,
	z = 22628.146484375
}

Player look:

{
	y = -0.59636503458023,
	x = -0.71311205625534,
	z = 0.36853757500648
}

Player information:

{
	min_rtt = 0.017000000923872,
	max_rtt = 4.6989998817444,
	connection_uptime = 1095,
	max_jitter = 4.1970000267029,
	minor = 5,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.5.0-dev-02292e03e",
	avg_rtt = 0.018999999389052,
	state = "Active",
	avg_jitter = 0.035999998450279,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 2860\", \"shields:shield_crystal 1 2860\", \"3d_armor:chestplate_crystal 1 2860\", \"3d_armor:boots_crystal 1 2860\", \"3d_armor:leggings_crystal 1 2860\"}",
		yl_commons_thankyou = "25",
		jointime = "1617905120",
		yl_commons_player_joined = "1635614895",
		["signslib:pos"] = "(32,9,22424)",
		digged_nodes = "722064",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}",
		partychat = "main",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 19, [\"x\"] = -36, [\"z\"] = 22659}, [\"last_heal\"] = 1632545235, [\"last_death_portal\"] = 1635373235}",
		["stamina:level"] = "16",
		punch_count = "12188",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "186098",
		crafted = "179830",
		died = "17",
		played_time = "3459694",
		xp = "716102",
		placed_nodes = "109006",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1617905120"
	}
}

Log identifier


[MOD] yl_report log identifier = sqxvebscKDHCnBch60gDxaxbWLgxBYEL

Profiler save:

profile-20211030T194547.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=6100.92, max_lag=4.65323, clients={Imhotheb, Sokomine, Styxcolor, hbreturns, _DRAGON_, UltimateNoob, pizzaking, Papi, Arabella, Service, Lichberry, AliasAlreadyTaken, Bailiff, Boot}

Teleport command:

/teleport xyz -2 12 22628

Compass command:

/give_compass Construction sqxvebscKDHCnBch60gDxaxbWLgxBYEL D2691E -2 12 22628

Sokomine reports a bug: > the flowerpot (from the mod with the same name) ought to accept ethereal saplings as well - in particular newer ones like the olive sapling Player position: ``` { y = 11.5, x = -2.4219999313354, z = 22628.146484375 } ``` Player look: ``` { y = -0.59636503458023, x = -0.71311205625534, z = 0.36853757500648 } ``` Player information: ``` { min_rtt = 0.017000000923872, max_rtt = 4.6989998817444, connection_uptime = 1095, max_jitter = 4.1970000267029, minor = 5, major = 5, ip_version = 6, formspec_version = 4, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.5.0-dev-02292e03e", avg_rtt = 0.018999999389052, state = "Active", avg_jitter = 0.035999998450279, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"\", \"3d_armor:helmet_crystal 1 2860\", \"shields:shield_crystal 1 2860\", \"3d_armor:chestplate_crystal 1 2860\", \"3d_armor:boots_crystal 1 2860\", \"3d_armor:leggings_crystal 1 2860\"}", yl_commons_thankyou = "25", jointime = "1617905120", yl_commons_player_joined = "1635614895", ["signslib:pos"] = "(32,9,22424)", digged_nodes = "722064", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}", partychat = "main", yl_church = "return {[\"last_death\"] = {[\"y\"] = 19, [\"x\"] = -36, [\"z\"] = 22659}, [\"last_heal\"] = 1632545235, [\"last_death_portal\"] = 1635373235}", ["stamina:level"] = "16", punch_count = "12188", arenalib_infobox_arenaID = "0", inflicted_damage = "186098", crafted = "179830", died = "17", played_time = "3459694", xp = "716102", placed_nodes = "109006", hud_state = "on", repellant = "0", yl_commons_player_created = "1617905120" } } ``` Log identifier ``` [MOD] yl_report log identifier = sqxvebscKDHCnBch60gDxaxbWLgxBYEL ``` Profiler save: ``` profile-20211030T194547.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=6100.92, max_lag=4.65323, clients={Imhotheb, Sokomine, Styxcolor, hbreturns, _DRAGON_, UltimateNoob, pizzaking, Papi, Arabella, Service, Lichberry, AliasAlreadyTaken, Bailiff, Boot} ``` Teleport command: ``` /teleport xyz -2 12 22628 ``` Compass command: ``` /give_compass Construction sqxvebscKDHCnBch60gDxaxbWLgxBYEL D2691E -2 12 22628 ```

AliasAlreadyTaken was assigned by yourland-report

2021-10-30 17:45:48 +00:00

Styxcolor commented

2021-10-30 23:41:19 +00:00

looked it up, the eligible plants are in a local array and ethereal mod is simply not hardcoded in. I don't know how to change this remotely from our bugfixes end, we would have to insert the missing plants into the array in the flowerpot mod itself.

Styxcolor added the

4. step/question

4. step/at work

labels 2021-10-30 23:42:59 +00:00

Styxcolor self-assigned this 2021-10-30 23:43:10 +00:00

Styxcolor commented

2021-11-01 11:09:38 +00:00

Eligible plants to add from the ethereal mod:
(copypaste into array)

-- ethereal nodes from plantlife.lua
"ethereal:firethorn",
"ethereal:fire_flower",
"ethereal:fern",
"ethereal:dry_shrub",
"ethereal:snowygrass",
"ethereal:crystalgrass",
"ethereal:illumishroom",
"ethereal:illumishroom2",
"ethereal:illumishroom3",

-- ethereal nodes from onion.lua
"ethereal:wild_onion_plant",

-- ethereal nodes from strawberry.lua
"ethereal:strawberry",

-- ethereal saplings from sapling.lua
"ethereal:bamboo_sprout",
"ethereal_willow_sapling",
"ethereal_yellow_tree_sapling",
"ethereal_big_tree_sapling",
"ethereal_banana_tree_sapling",
"ethereal_frost_tree_sapling",
"ethereal_mushroom_sapling",
"moretrees_palm_sapling",
"ethereal_giant_redwood_sapling",
"ethereal_redwood_sapling",
"ethereal_orange_tree_sapling",
"moretrees_birch_sapling",
"ethereal_sakura_sapling",
"ethereal_lemon_tree_sapling",
"ethereal_olive_tree_sapling",

Eligible plants to add from the ethereal mod: (copypaste into array) -- ethereal nodes from plantlife.lua "ethereal:firethorn", "ethereal:fire_flower", "ethereal:fern", "ethereal:dry_shrub", "ethereal:snowygrass", "ethereal:crystalgrass", "ethereal:illumishroom", "ethereal:illumishroom2", "ethereal:illumishroom3", -- ethereal nodes from onion.lua "ethereal:wild_onion_plant", -- ethereal nodes from strawberry.lua "ethereal:strawberry", -- ethereal saplings from sapling.lua "ethereal:bamboo_sprout", "ethereal_willow_sapling", "ethereal_yellow_tree_sapling", "ethereal_big_tree_sapling", "ethereal_banana_tree_sapling", "ethereal_frost_tree_sapling", "ethereal_mushroom_sapling", "moretrees_palm_sapling", "ethereal_giant_redwood_sapling", "ethereal_redwood_sapling", "ethereal_orange_tree_sapling", "moretrees_birch_sapling", "ethereal_sakura_sapling", "ethereal_lemon_tree_sapling", "ethereal_olive_tree_sapling",

Styxcolor commented

2021-11-01 11:10:18 +00:00

also, the reason the ethereal saplings couldn't be found is that sapling.lua adds a very specific conversion/naming convention to them, so maybe other mods can't read that.

Styxcolor commented

2021-11-01 11:10:33 +00:00

And now we need to get this into the array.

Styxcolor added

4. step/help wanted

and removed

4. step/at work

labels 2021-11-01 11:10:49 +00:00

Styxcolor commented

2021-11-05 02:57:24 +00:00

ethereal:strawberry_8
wild onion becomes just onion when planted!

ethereal:strawberry_8 wild onion becomes just onion when planted!

Styxcolor commented

2021-11-05 03:17:10 +00:00

With Alias help with array syntax fixed this.
Strawberry and onion do not work (farming onion neither) because you never can carry the plant that you would need to plant in your hand due to the fruit being the sapling at the same time...

Fixed this in:
commit 37d18a11c36a217b15d918c4e9b24756a78a9420

With Alias help with array syntax fixed this. Strawberry and onion do not work (farming onion neither) because you never can carry the plant that you would need to plant in your hand due to the fruit being the sapling at the same time... Fixed this in: commit 37d18a11c36a217b15d918c4e9b24756a78a9420

Styxcolor added

and removed

labels 2021-11-05 03:17:33 +00:00

Styxcolor closed this issue

2021-11-05 03:17:39 +00:00

Styxcolor added this to the 1.1.98 milestone 2021-11-06 15:42:14 +00:00

Sign in to join this conversation.