FrostRanger reports: snow leopards drop regular leo ... #874

New Issue

yourland-report · 2021-09-01T21:15:14Z

yourland-report commented

2021-09-01 21:15:14 +00:00

FrostRanger reports a bug:

snow leopards drop regular leopard skin instead of their own skin

Player position:

{
	y = 3.5,
	x = 6060.8852539063,
	z = 18150.931640625
}

Player look:

{
	y = -0.095498286187649,
	x = 0.98659312725067,
	z = 0.13234096765518
}

Player information:

{
	min_rtt = 0.15999999642372,
	max_rtt = 24.028999328613,
	connection_uptime = 12001,
	max_jitter = 19.270000457764,
	minor = 5,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.5.0-dev-0c1e9603d-dirty",
	avg_rtt = 0.1630000025034,
	state = "Active",
	avg_jitter = 0.20200000703335,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_steel 1 8640\", \"3d_armor:chestplate_steel 1 8640\", \"3d_armor:leggings_steel 1 8640\", \"shields:shield_steel 1 8640\", \"3d_armor:boots_steel 1 8640\", \"\"}",
		played_time = "109561",
		jointime = "1616131944",
		yl_commons_player_joined = "1630518939",
		digged_nodes = "5961",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_small\"}",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 3, [\"x\"] = 6107, [\"z\"] = 18154}}",
		["stamina:level"] = "18.975",
		punch_count = "212",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "2704",
		crafted = "1071",
		placed_nodes = "2421",
		xp = "8679",
		died = "3",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1616131944"
	}
}

Log identifier


[MOD] yl_report log identifier = BF2bl3t2armqhL0D9mweNwElpZwPoTCM

Profiler save:

profile-20210901T231513.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=175289, max_lag=5.32806, clients={Jerzy, hbreturns, Duximagnus, FrostRanger, alexandre2005, Boot, jakob, Sokomine, JNate, flux, Machtrollo, AspireMint, Service, AliasAlreadyTaken, Ernesto, Helel, Bailiff}

Teleport command:

/teleport xyz 6061 4 18151

Compass command:

/give_compass Construction BF2bl3t2armqhL0D9mweNwElpZwPoTCM D2691E 6061 4 18151

FrostRanger reports a bug: > snow leopards drop regular leopard skin instead of their own skin Player position: ``` { y = 3.5, x = 6060.8852539063, z = 18150.931640625 } ``` Player look: ``` { y = -0.095498286187649, x = 0.98659312725067, z = 0.13234096765518 } ``` Player information: ``` { min_rtt = 0.15999999642372, max_rtt = 24.028999328613, connection_uptime = 12001, max_jitter = 19.270000457764, minor = 5, major = 5, ip_version = 6, formspec_version = 4, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.5.0-dev-0c1e9603d-dirty", avg_rtt = 0.1630000025034, state = "Active", avg_jitter = 0.20200000703335, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_steel 1 8640\", \"3d_armor:chestplate_steel 1 8640\", \"3d_armor:leggings_steel 1 8640\", \"shields:shield_steel 1 8640\", \"3d_armor:boots_steel 1 8640\", \"\"}", played_time = "109561", jointime = "1616131944", yl_commons_player_joined = "1630518939", digged_nodes = "5961", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_small\"}", yl_church = "return {[\"last_death\"] = {[\"y\"] = 3, [\"x\"] = 6107, [\"z\"] = 18154}}", ["stamina:level"] = "18.975", punch_count = "212", arenalib_infobox_arenaID = "0", inflicted_damage = "2704", crafted = "1071", placed_nodes = "2421", xp = "8679", died = "3", hud_state = "on", repellant = "0", yl_commons_player_created = "1616131944" } } ``` Log identifier ``` [MOD] yl_report log identifier = BF2bl3t2armqhL0D9mweNwElpZwPoTCM ``` Profiler save: ``` profile-20210901T231513.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=175289, max_lag=5.32806, clients={Jerzy, hbreturns, Duximagnus, FrostRanger, alexandre2005, Boot, jakob, Sokomine, JNate, flux, Machtrollo, AspireMint, Service, AliasAlreadyTaken, Ernesto, Helel, Bailiff} ``` Teleport command: ``` /teleport xyz 6061 4 18151 ``` Compass command: ``` /give_compass Construction BF2bl3t2armqhL0D9mweNwElpZwPoTCM D2691E 6061 4 18151 ```

AliasAlreadyTaken was assigned by yourland-report

2021-09-01 21:15:14 +00:00

Styxcolor added the

1. kind/bug

label 2021-11-03 04:10:49 +00:00

Styxcolor self-assigned this 2021-11-03 04:10:53 +00:00

Bla commented

2021-11-09 17:38:06 +00:00

petz has an item for petz:snow_leopard_skin but just doesnt use it as drop for the snow leopard because some strange for loop is used to register both leopards.

petz has an item for [petz:snow_leopard_skin](https://github.com/runsy/petz/blob/86c8e4ceaf8e07707e74b6dacda77a0c1c503d4f/petz/misc/items.lua#L572) but just doesnt use it as drop for the snow leopard because some strange [for loop](https://github.com/runsy/petz/blob/8fee22f2a6442fed326bac63c3abaf6cb72a13bf/petz/petz/leopard_mobkit.lua#L12) is used to register both leopards.

Styxcolor added the

ugh/petz

label 2021-11-10 11:25:32 +00:00

Styxcolor commented

2021-11-11 11:06:44 +00:00

The straightforward solution is to separate leopard and snowleopard into two lua files, getting rid of the loop. I need Alias help to untangle the syntax though, the code that is left without the local variables from the loop has to work still.

Bla commented

2021-11-11 11:49:57 +00:00

The straightforward solution is to separate leopard and snowleopard into two lua files, getting rid of the loop. I need Alias help to untangle the syntax though, the code that is left without the local variables from the loop has to work still.

Splitting into 2 files makes pulling from upstream harder because you have to split them again everytime.
Making an PR upstream that fixes it by addinng different drops in the loop would make more sense.

> The straightforward solution is to separate leopard and snowleopard into two lua files, getting rid of the loop. I need Alias help to untangle the syntax though, the code that is left without the local variables from the loop has to work still. Splitting into 2 files makes pulling from upstream harder because you have to split them again everytime. Making an PR upstream that fixes it by addinng different drops in the loop would make more sense.

Styxcolor commented

2021-11-11 13:54:28 +00:00

Alias has found a faster, more elegant way where we don't have to undo the petz mod itself. We can change the drops remotely.

Testing successful.

Fixed in:
commit 0ebb538d91b2ce5fe48444b47d9e7408c6533ae0

Alias has found a faster, more elegant way where we don't have to undo the petz mod itself. We can change the drops remotely. Testing successful. Fixed in: commit 0ebb538d91b2ce5fe48444b47d9e7408c6533ae0

Styxcolor added the

5. result/fixed

label 2021-11-11 14:07:41 +00:00

Styxcolor added this to the 1.1.99 milestone 2021-11-11 14:07:53 +00:00

Styxcolor closed this issue

2021-11-11 14:08:00 +00:00

Sign in to join this conversation.