circular saw VS glostone #8551

New Issue

AliasAlreadyTaken · 2025-05-17T00:30:34+02:00

AliasAlreadyTaken commented

2025-05-17 00:30:34 +02:00

2025-05-17 00:19:10: ACTION[Server]: [yl_commons] AliasAlreadyTaken moves "ethereal:micro_glostone 4" to {"name":"AliasAlreadyTaken","type":"player"} [main]
2025-05-17 00:19:10: ACTION[Server]: [yl_commons] lua is using 254.0 MB
2025-05-17 00:19:12: WARNING[ConnectionSend]: con(4/1) Packet quota used up for peer_id=45052, was 512 pkts
2025-05-17 00:19:12: WARNING[ConnectionSend]: con(4/1) Packet quota used up for peer_id=45052, was 512 pkts
2025-05-17 00:19:12: WARNING[ConnectionSend]: con(4/1) Packet quota used up for peer_id=45052, was 512 pkts
2025-05-17 00:19:16: ACTION[Server]: [yl_commons] AliasAlreadyTaken takes "ethereal:micro_glostone 4" from {"name":"AliasAlreadyTaken","type":"player"} [main]
2025-05-17 00:19:16: ACTION[Server]: [yl_commons] "AliasAlreadyTaken" moves ethereal:micro_glostone 4 to moreblocks:circular_saw @ (3965,21,-9060) [recycle]
2025-05-17 00:19:16: ACTION[Main]: Server: Shutting down
2025-05-17 00:19:16: ACTION[Server]: [MOD] smart_chat : Module core: *** leaves the World.
2025-05-17 00:19:16: ACTION[Server]: AliasAlreadyTaken leaves game. List of players:
2025-05-17 00:19:21: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'moreblocks' in callback nodemeta_inventory_OnPut(): ....0/Yourland_test/bin/../mods/moreblocks/circular_saw.lua:184: attempt to index a nil value
2025-05-17 00:19:21: ERROR[Main]: stack traceback:
2025-05-17 00:19:21: ERROR[Main]: ....0/Yourland_test/bin/../mods/moreblocks/circular_saw.lua:184: in function 'update_inventory'
2025-05-17 00:19:21: ERROR[Main]: ....0/Yourland_test/bin/../mods/moreblocks/circular_saw.lua:323: in function <....0/Yourland_test/bin/../mods/moreblocks/circular_saw.lua:303>

2025-05-17 00:19:10: ACTION[Server]: [yl_commons] AliasAlreadyTaken moves "ethereal:micro_glostone 4" to {"name":"AliasAlreadyTaken","type":"player"} [main] 2025-05-17 00:19:10: ACTION[Server]: [yl_commons] lua is using 254.0 MB 2025-05-17 00:19:12: WARNING[ConnectionSend]: con(4/1) Packet quota used up for peer_id=45052, was 512 pkts 2025-05-17 00:19:12: WARNING[ConnectionSend]: con(4/1) Packet quota used up for peer_id=45052, was 512 pkts 2025-05-17 00:19:12: WARNING[ConnectionSend]: con(4/1) Packet quota used up for peer_id=45052, was 512 pkts 2025-05-17 00:19:16: ACTION[Server]: [yl_commons] AliasAlreadyTaken takes "ethereal:micro_glostone 4" from {"name":"AliasAlreadyTaken","type":"player"} [main] 2025-05-17 00:19:16: ACTION[Server]: [yl_commons] "AliasAlreadyTaken" moves ethereal:micro_glostone 4 to moreblocks:circular_saw @ (3965,21,-9060) [recycle] 2025-05-17 00:19:16: ACTION[Main]: Server: Shutting down 2025-05-17 00:19:16: ACTION[Server]: [MOD] smart_chat : Module core: *** leaves the World. 2025-05-17 00:19:16: ACTION[Server]: AliasAlreadyTaken leaves game. List of players: 2025-05-17 00:19:21: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'moreblocks' in callback nodemeta_inventory_OnPut(): ....0/Yourland_test/bin/../mods/moreblocks/circular_saw.lua:184: attempt to index a nil value 2025-05-17 00:19:21: ERROR[Main]: stack traceback: 2025-05-17 00:19:21: ERROR[Main]: ....0/Yourland_test/bin/../mods/moreblocks/circular_saw.lua:184: in function 'update_inventory' 2025-05-17 00:19:21: ERROR[Main]: ....0/Yourland_test/bin/../mods/moreblocks/circular_saw.lua:323: in function <....0/Yourland_test/bin/../mods/moreblocks/circular_saw.lua:303>

whosit commented

2025-05-17 02:36:31 +02:00

Looking at blame, seems introduced here: 2611e64a2b

We are using stairsplus:register_custom_subset() to register glostone, which calls stairsplus.register_single(), but the variable that was introduced in that commit is updated only in stairsplus:register_micro(), which calls stairsplus.register_single() itself...

So upstream messed this up by not updating the table where needed, I guess.

Looking at blame, seems introduced here: https://gitea.your-land.de/your-land/moreblocks/commit/2611e64a2b14c1586dc283569b6780611caeced0 We are using `stairsplus:register_custom_subset()` to register glostone, which calls `stairsplus.register_single()`, but the variable that was introduced in that commit is updated only in `stairsplus:register_micro()`, which calls `stairsplus.register_single()` itself... So upstream messed this up by not updating the table where needed, I guess.