your-land/bugtracker
your-land/bugtracker
40
21
Issues 3.6k Projects 4 Wiki

mobkit/init.lua:46: attempt to index local 'pos' (a nil value) #8335

New Issue
Open
opened 2025-03-29 16:42:01 +01:00 by AliasAlreadyTaken · 9 comments
AliasAlreadyTaken commented 2025-03-29 16:42:01 +01:00
Owner
Copy Link
2025-03-29 11:52:44: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'water_life' in callback environment_Step(): /home/yl/5.10.0/Yourland_test/bin/../mods/mobkit/init.lua:46: attempt to index local 'pos' (a nil value)
2025-03-29 11:52:44: ERROR[Main]: stack traceback:
2025-03-29 11:52:44: ERROR[Main]: 	/home/yl/5.10.0/Yourland_test/bin/../mods/mobkit/init.lua:46: in function 'pos_shift'
2025-03-29 11:52:44: ERROR[Main]: 	...yl/5.10.0/Yourland_test/bin/../mods/water_life/spawn.lua:335: in function 'spawnstep'
2025-03-29 11:52:44: ERROR[Main]: 	...yl/5.10.0/Yourland_test/bin/../mods/water_life/spawn.lua:454: in function 'func'
2025-03-29 11:52:44: ERROR[Main]: 	...ourland_test/bin/../builtin/profiler/instrumentation.lua:124: in function <...ourland_test/bin/../builtin/profiler/instrumentation.lua:117>
2025-03-29 11:52:44: ERROR[Main]: 	.../5.10.0/Yourland_test/bin/../builtin/common/register.lua:26: in function <.../5.10.0/Yourland_test/bin/../builtin/common/register.lua:12>
``` 2025-03-29 11:52:44: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'water_life' in callback environment_Step(): /home/yl/5.10.0/Yourland_test/bin/../mods/mobkit/init.lua:46: attempt to index local 'pos' (a nil value) 2025-03-29 11:52:44: ERROR[Main]: stack traceback: 2025-03-29 11:52:44: ERROR[Main]: /home/yl/5.10.0/Yourland_test/bin/../mods/mobkit/init.lua:46: in function 'pos_shift' 2025-03-29 11:52:44: ERROR[Main]: ...yl/5.10.0/Yourland_test/bin/../mods/water_life/spawn.lua:335: in function 'spawnstep' 2025-03-29 11:52:44: ERROR[Main]: ...yl/5.10.0/Yourland_test/bin/../mods/water_life/spawn.lua:454: in function 'func' 2025-03-29 11:52:44: ERROR[Main]: ...ourland_test/bin/../builtin/profiler/instrumentation.lua:124: in function <...ourland_test/bin/../builtin/profiler/instrumentation.lua:117> 2025-03-29 11:52:44: ERROR[Main]: .../5.10.0/Yourland_test/bin/../builtin/common/register.lua:26: in function <.../5.10.0/Yourland_test/bin/../builtin/common/register.lua:12> ```
AliasAlreadyTaken added the
1. kind/bug
3. source/testserver
 labels 2025-03-29 16:44:30 +01:00
AliasAlreadyTaken commented 2025-03-29 17:11:10 +01:00
Author
Owner
Copy Link

This is due to This is due to water_life

water_life.noSpawn = minetest.settings:get_bool("water_life_nospawn ") or false

There's a surplus blank at the end of the setting key: water_life_nospawn

This is on main, means we'll get the crash there sooner or later as well.

This is due to This is due [to water_life](https://gitea.your-land.de/your-land/water_life/src/branch/master/init.lua#L63) ``` water_life.noSpawn = minetest.settings:get_bool("water_life_nospawn ") or false ``` There's a surplus blank at the end of the setting key: water_life_nospawn This is on main, means we'll get the crash there sooner or later as well.
AliasAlreadyTaken commented 2025-03-29 17:37:37 +01:00
Author
Owner
Copy Link

Since this is actually two separate issues, here are both upstream issues:

https://github.com/berengma/water_life/issues/108
https://github.com/berengma/water_life/issues/107

Since this is actually two separate issues, here are both upstream issues: https://github.com/berengma/water_life/issues/108 https://github.com/berengma/water_life/issues/107
whosit commented 2025-03-29 17:40:47 +01:00
Member
Copy Link

Main won't crash because:
c58e503cf3/spawn.lua (L84-L88)

Because Alias has set temporary water_life.apionly = true :D

Main won't crash because: https://gitea.your-land.de/your-land/water_life/src/commit/c58e503cf32f0787af26b49cf887d3a4bb9ac3f3/spawn.lua#L84-L88 Because Alias has set temporary `water_life.apionly = true` :D
whosit commented 2025-04-09 19:29:16 +02:00
Member
Copy Link

Both issues closed upstream with new commits.

Both issues closed upstream with new commits.
whosit added the
4. step/ready to QA test
 label 2025-04-09 19:29:23 +02:00
AliasAlreadyTaken added this to the 1.1.128 milestone 2025-04-09 23:29:44 +02:00
whosit commented 2025-04-22 23:32:25 +02:00
Member
Copy Link

This crashed us so many times, we should've hotfixed it in some way.
I'm thinking about just finding the globalstep by the mod origin and replacing it with the fixed one with nil check added.

I still don't understand how exactly this can happen though?

This crashed us so many times, we should've hotfixed it in some way. I'm thinking about just finding the globalstep by the mod origin and replacing it with the fixed one with nil check added. I still don't understand how exactly this can happen though?
tour commented 2025-04-23 03:04:39 +02:00
Member
Copy Link

I still don't understand how exactly this can happen though?

coraltable[random(#coraltable)] is where it goes wrong:
random is a custom func which looks quite cursed: c58e503cf3/api.lua (L31-L43)

random(1) can return 0. But lua indices start at 1...

> I still don't understand how exactly this can happen though? `coraltable[random(#coraltable)]` is where it goes wrong: `random` is a custom func which looks quite cursed: https://gitea.your-land.de/your-land/water_life/src/commit/c58e503cf32f0787af26b49cf887d3a4bb9ac3f3/api.lua#L31-L43 `random(1)` can return 0. But lua indices start at 1...
👀 2
whosit commented 2025-04-23 07:26:46 +02:00
Member
Copy Link

(not correcting tour, because he's right, trying to unconfuse mylself)

random(1) can return 0. But lua indices start at 1...

Maybe this is where this horrible monster comes from? Trying to make sure "min = 1"? XD

lua's math.random(1) will return only 1 (!)
But, after all the shuffling, water_life.random(1) is equivalent to water_life.random(0, 1) and to math.random(0,1) which will return 0 or 1 :)

(not correcting tour, because he's right, trying to unconfuse mylself) > random(1) can return 0. But lua indices start at 1... Maybe this is where this horrible monster comes from? Trying to make sure "min = 1"? XD lua's `math.random(1)` will return only `1` (!) But, after all the shuffling, `water_life.random(1)` is equivalent to `water_life.random(0, 1)` and to `math.random(0,1)` which _will_ return 0 or 1 :)
😆 1
AliasAlreadyTaken added the
4. step/QA main
 label 2025-05-08 00:14:52 +02:00
whosit commented 2025-05-15 17:56:00 +02:00
Member
Copy Link

This fix is not on main, we got a crash :p (judging by the line numbers too)
did water_life.apionly = true again...

/eval water_life.version

upstream: 250329
we have: 250122

This fix is not on main, we got a crash :p (judging by the line numbers too) did `water_life.apionly = true` again... `/eval water_life.version` upstream: 250329 we have: 250122
whosit commented 2025-05-17 02:32:56 +02:00
Member
Copy Link

water_life.apionly = true is now a snippet temp_fix_water_life_8335
please disable when updated :p

`water_life.apionly = true` is now a snippet `temp_fix_water_life_8335` please disable when updated :p
👍 1
AliasAlreadyTaken modified the milestone from 1.1.128 to Next 2025-05-26 00:18:34 +02:00
AliasAlreadyTaken added
4. step/at work
 and removed
4. step/ready to QA test
4. step/QA main
 labels 2025-05-26 00:19:09 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
Milestone
Clear milestone
No items
No Milestone
Next
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#8335
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?