Skyisblue reports: You cant put a screwdriver in ... #81

Closed
opened 2020-10-16 16:21:53 +00:00 by yourland-report · 9 comments

Skyisblue reports a bug:

You cant put a screwdriver in an item frame

Player position:

{
	y = 15.5,
	x = 1937.7860107422,
	z = 1168.1829833984
}

Player look:

{
	y = -0.52517461776733,
	x = 0.17213512957096,
	z = 0.83340328931808
}

Log identifier


[MOD] yl_report log identifier = vWWxdQrsulCaBINCZWemnv7Dgv7tQTiI

Profiler save:

profile-20201016T182153.json_pretty

Status:

# Server: version=5.3.0-yl, uptime=324387, max_lag=0.815466, clients={Skyisblue, AliasAlreadyTaken, Bailiff}
Skyisblue reports a bug: ``` You cant put a screwdriver in an item frame ``` Player position: ``` { y = 15.5, x = 1937.7860107422, z = 1168.1829833984 } ``` Player look: ``` { y = -0.52517461776733, x = 0.17213512957096, z = 0.83340328931808 } ``` Log identifier ``` [MOD] yl_report log identifier = vWWxdQrsulCaBINCZWemnv7Dgv7tQTiI ``` Profiler save: ``` profile-20201016T182153.json_pretty ``` Status: ``` # Server: version=5.3.0-yl, uptime=324387, max_lag=0.815466, clients={Skyisblue, AliasAlreadyTaken, Bailiff} ```
AliasAlreadyTaken was assigned by yourland-report 2020-10-16 16:21:53 +00:00
Owner

Same for pedestal!

Same for pedestal!

Same for anvil

You also can't put spear into an itemframe and maybe even bows, everything that has a rightclick function

Tio fix, we'd either have to override the screwdriver code and exempt some blocks from the screwdriver mechanics, or we'd need to override all the other nodes to accept the screwdriver in some way.

A different solution might be to make the itemframe not right-clickable with the item, but open a formspec to insert the item into.

Same for anvil You also can't put spear into an itemframe and maybe even bows, everything that has a rightclick function Tio fix, we'd either have to override the screwdriver code and exempt some blocks from the screwdriver mechanics, or we'd need to override all the other nodes to accept the screwdriver in some way. A different solution might be to make the itemframe not right-clickable with the item, but open a formspec to insert the item into.
AliasAlreadyTaken added the
3. source/integration
label 2020-10-16 16:56:19 +00:00
Member

my preferred solution to this is #407 (edit: whoops, meant to put this comment on a different bug)

~~my preferred solution to this is #407~~ (edit: whoops, meant to put this comment on a different bug)
AliasAlreadyTaken was unassigned by flux 2022-04-07 18:47:13 +00:00
flux self-assigned this 2022-04-07 18:47:14 +00:00
Member

@AliasAlreadyTaken this wasn't fixed at the same time as the other right-click behavior overrides, because i wasn't sure what the correct behavior was - i do often want to rotate item frames with screwdrivers.

perhaps i could extend the override logic to check whether "sneak" being held while right-clicking the screwdriver on itemframes?

@AliasAlreadyTaken this wasn't fixed at the same time as the other right-click behavior overrides, because i wasn't sure what the correct behavior was - i do often want to rotate item frames with screwdrivers. perhaps i could extend the override logic to check whether "sneak" being held while right-clicking the screwdriver on itemframes?

Eventually we'll have to solve that in some central place. Every tool that has a right click defined is affected. Spears, pitchforks ....

Eventually we'll have to solve that in some central place. Every tool that has a right click defined is affected. Spears, pitchforks ....
Member

I think the "central place" is fine as it is now - "yl_commons". I think integration issues like this belong there.

I think the "central place" is fine as it is now - "yl_commons". I think integration issues like this belong there.
Member

Fixed in your-land/yl_commons#15, but it doesn't seem live yet

Fixed in https://gitea.your-land.de/your-land/yl_commons/pulls/15, but it doesn't seem live yet

The fix should be live ... are we missing a dependency?

The fix should be live ... are we missing a dependency?
Member

Fix is live now, closing.

For reference, you have to Aux1-right-click on an itemframe or pedestal to put the screwdriver in there.

Fix is live now, closing. For reference, you have to `Aux1-right-click` on an itemframe or pedestal to put the screwdriver in there.
flux closed this issue 2022-05-04 16:55:09 +00:00
flux added the
5. result/fixed
label 2022-05-04 16:55:19 +00:00
AliasAlreadyTaken added this to the 1.1.110 milestone 2022-05-04 17:19:27 +00:00
flux removed their assignment 2022-10-16 00:20:07 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#81
No description provided.