your-land/bugtracker
your-land/bugtracker
41
22
Issues 3.6k Projects 4 Wiki

moretrees:date_palm_sapling generate date palm trees with 11th part of trunk missing #7760

New Issue
Open
opened 2024-11-30 05:58:11 +01:00 by GIuseppe · 12 comments
GIuseppe commented 2024-11-30 05:58:11 +01:00
Copy Link

Date palm has a missing trunk block and seems also no more dates production.

Date palm has a missing trunk block and seems also no more dates production.
screenshot_20241130_055214.jpg
323 KiB
screenshot_20241130_055214.jpg
GIuseppe changed title from dtae palm tree to date palm tree 2024-11-30 05:59:46 +01:00
whosit commented 2024-11-30 09:41:30 +01:00
Member
Copy Link

daydream reports a bug:

the date palm tree has a missing node (11th up from ground) so it can't be chopped with choppy

daydream reports a bug: > the date palm tree has a missing node (11th up from ground) so it can't be chopped with choppy
whosit changed title from date palm tree to date palm tree generates with 11th part of trunk missing 2024-11-30 09:42:07 +01:00
AliasAlreadyTaken was assigned by whosit 2024-11-30 09:42:11 +01:00
whosit changed title from date palm tree generates with 11th part of trunk missing to moretrees:date_palm_sapling generate date palm trees with 11th part of trunk missing 2024-11-30 09:43:26 +01:00
whosit commented 2024-11-30 15:20:51 +01:00
Member
Copy Link

This also seems to be 5.10 issue - switching back to 5.8 makes palms grow correctly.

The node missing is the one that flowers shold be attached to, from what I can see.

This also seems to be 5.10 issue - switching back to 5.8 makes palms grow correctly. The node missing is the one that flowers shold be attached to, from what I can see.
tour commented 2024-12-02 00:29:40 +01:00
Member
Copy Link

maybe this one broke it? Did not test.
60810c2d37

I found a quite useful tool to debug this: https://content.luanti.org/packages/Wuzzy/ltool/
Playing around with it I noticed, that the R-Rule only seems to place air now

image

Found out that the normal palm is using the R-Rule too, so I planted a 🌴. It's missing a the fruit node too :/

maybe this one broke it? Did not test. https://github.com/minetest/minetest/commit/60810c2d375a8c63e096669dd6c6cd791f2c5075 I found a quite useful tool to debug this: https://content.luanti.org/packages/Wuzzy/ltool/ Playing around with it I noticed, that the `R`-Rule only seems to place air now ![image](/attachments/1123bd6a-cc1f-4b91-ba0d-ee1af7df7f0e) Found out that the normal palm is using the `R`-Rule too, so I planted a 🌴. It's missing a the fruit node too :/
image.png
1.1 MiB
😕 1
tour commented 2024-12-02 15:28:24 +01:00
Member
Copy Link

https://github.com/minetest/minetest/issues/15506
Let's see what we get...

https://github.com/minetest/minetest/issues/15506 Let's see what we get...
👍 1
whosit added the
1. kind/bug
3. source/engine
 labels 2024-12-04 16:28:56 +01:00
tour commented 2024-12-05 18:45:15 +01:00
Member
Copy Link

made a pr against yl_commons with a "fix" (not sure if a hack like that can be called fix), so the bugtracker isn't spammed with reports until the next engine update happens :-)

made a pr against yl_commons with a "fix" (not sure if a hack like that can be called fix), so the bugtracker isn't spammed with reports until the next engine update happens :-)
whosit commented 2024-12-05 19:15:23 +01:00
Member
Copy Link

tour wrote in the PR:

(I think it should be possible to bring this patch to main using //lua or snippets)

Tried changing those values on test without server restart - it works, trunks and fruits are there.

Are any other trees affected? Apples are there, cones too...
UPD: checked as tour has suggested below: don't see anymore R rules used. Thanks tour :)

tour wrote in the [PR](https://gitea.your-land.de/your-land/yl_commons/pulls/30): > (I think it should be possible to bring this patch to main using //lua or snippets) Tried changing those values on test without server restart - it works, trunks and fruits are there. ~~Are any other trees affected? Apples are there, cones too...~~ UPD: checked as tour has suggested below: don't see anymore R rules used. Thanks tour :)
whosit commented 2024-12-05 19:22:15 +01:00
Member
Copy Link

I actually applied it as auto running snippet called temp_fix_moretrees_date_palms...
Idk if there's even need to add it to yl_commons, but maybe Alias will decide that is better.

I actually applied it as auto running snippet called `temp_fix_moretrees_date_palms`... Idk if there's even need to add it to yl_commons, but maybe Alias will decide that is better.
👍 2
tour commented 2024-12-05 19:53:08 +01:00
Member
Copy Link

Are any other trees affected? Apples are there, cones too...

I think no. If you want to be really sure, you can follow the steps I did to come to this conclusion :-)

grep for "axiom" to find the mods that make use of ltrees. In my local mods folder only moretrees seems to do so. But I don't have all mods YL has.

Go into the files where the Axioms are defined and see if there is an axiom with the R-key. If there is one and fruit_chance = 0/nil in the same treedef, then the tree is affected and needs fixing too...

I actually applied it as auto running snippet called temp_fix_moretrees_date_palms...

lol, did not know it works like that :-) Feel free to close if there is no need

> Are any other trees affected? Apples are there, cones too... I think no. If you want to be really sure, you can follow the steps I did to come to this conclusion :-) grep for "axiom" to find the mods that make use of ltrees. In my local mods folder only moretrees seems to do so. But I don't have all mods YL has. Go into the files where the Axioms are defined and see if there is an axiom with the `R`-key. If there is one and `fruit_chance = 0/nil` in the same treedef, then the tree is affected and needs fixing too... > I actually applied it as auto running snippet called temp_fix_moretrees_date_palms... lol, did not know it works like that :-) Feel free to close if there is no need
👍 1
tour commented 2024-12-07 00:17:27 +01:00
Member
Copy Link

It got fixed in the engine :-)
https://github.com/minetest/minetest/pull/15513

Is there a 5.11 Milestone already?

It got fixed in the engine :-) https://github.com/minetest/minetest/pull/15513 Is there a 5.11 Milestone already?
🎉 1
whosit commented 2024-12-07 00:22:32 +01:00
Member
Copy Link

Is there a 5.11 Milestone already?

Not yet, but it already feels like there should be at least 5.10.1 :p

Also, thanks :)

> Is there a 5.11 Milestone already? Not yet, but it already feels like there should be at least 5.10.1 :p Also, thanks :)
DragonWrangler commented 2024-12-07 00:36:41 +01:00
Copy Link

It got fixed in the engine :-)
https://github.com/minetest/minetest/pull/15513

Is there a 5.11 Milestone already?

https://github.com/minetest/minetest/milestone/25

> It got fixed in the engine :-) > https://github.com/minetest/minetest/pull/15513 > > Is there a 5.11 Milestone already? https://github.com/minetest/minetest/milestone/25
AliasAlreadyTaken added this to the luanti 5.11.0 milestone 2024-12-17 22:07:02 +01:00
AliasAlreadyTaken commented 2025-03-08 18:36:58 +01:00
Owner
Copy Link

The issue appears fixed, but only due to yl_commons and snippets. Contrary to what /status says, we are not on 5.11.0 yet. See your-land/administration#226

The issue appears fixed, but only due to yl_commons and snippets. Contrary to what /status says, we are not on 5.11.0 yet. See your-land/administration#226
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/possible close

Should be closed, but a second opinion is asked

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/possible close
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
Milestone
Clear milestone
No items
No Milestone
luanti 5.11.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
AliasAlreadyTaken
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#7760
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?