your-land/bugtracker
your-land/bugtracker
41
22
Issues 3.6k Projects 4 Wiki

MoreMesecons/moremesecons_entity_detector/init.lua:68: bad argument #2 to 'set_string' (string expected, got table) #7743

New Issue
Closed
opened 2024-11-28 15:17:04 +01:00 by AliasAlreadyTaken · 12 comments
AliasAlreadyTaken commented 2024-11-28 15:17:04 +01:00
Owner
Copy Link

2024-11-28 14:15:59: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mesecons' in callback environment_Step(): .../mods/MoreMesecons/moremesecons_entity_detector/init.lua:68: bad argument #2 to 'set_string' (string expected, got table)
2024-11-28 14:15:59: ERROR[Main]: stack traceback:
2024-11-28 14:15:59: ERROR[Main]: [C]: in function 'set_string'
2024-11-28 14:15:59: ERROR[Main]: .../mods/MoreMesecons/moremesecons_entity_detector/init.lua:68: in function 'action'
2024-11-28 14:15:59: ERROR[Main]: .../5.10.0/Yourland_main/bin/../mods/digilines/internal.lua:106: in function 'transmit'
2024-11-28 14:15:59: ERROR[Main]: ...e/mt/5.10.0/Yourland_main/bin/../mods/digilines/init.lua:60: in function 'receptor_send'
2024-11-28 14:15:59: ERROR[Main]: ....10.0/Yourland_main/bin/../mods/digistuff/ioexpander.lua:68: in function 'ioexp_digiline_send'
2024-11-28 14:15:59: ERROR[Main]: ....10.0/Yourland_main/bin/../mods/digistuff/ioexpander.lua:103: in function 'action_change'
2024-11-28 14:15:59: ERROR[Main]: ...Yourland_main/bin/../mods/mesecons/mesecons/internal.lua:230: in function <...Yourland_main/bin/../mods/mesecons/mesecons/internal.lua:223>
2024-11-28 14:15:59: ERROR[Main]: ...rland_main/bin/../mods/mesecons/mesecons/actionqueue.lua:131: in function 'old_execute'
2024-11-28 14:15:59: ERROR[Main]: .../bin/../mods/mesecons_debug/overrides/mesecons_queue.lua:27: in function 'execute'
2024-11-28 14:15:59: ERROR[Main]: ...rland_main/bin/../mods/mesecons/mesecons/actionqueue.lua:121: in function 'func'
2024-11-28 14:15:59: ERROR[Main]: ...ourland_main/bin/../builtin/profiler/instrumentation.lua:124: in function <...ourland_main/bin/../builtin/profiler/instrumentation.lua:117>
2024-11-28 14:15:59: ERROR[Main]: .../5.10.0/Yourland_main/bin/../builtin/common/register.lua:26: in function <.../5.10.0/Yourland_main/bin/../builtin/common/register.lua:12>

2024-11-28 14:15:59: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mesecons' in callback environment_Step(): .../mods/MoreMesecons/moremesecons_entity_detector/init.lua:68: bad argument #2 to 'set_string' (string expected, got table) 2024-11-28 14:15:59: ERROR[Main]: stack traceback: 2024-11-28 14:15:59: ERROR[Main]: [C]: in function 'set_string' 2024-11-28 14:15:59: ERROR[Main]: .../mods/MoreMesecons/moremesecons_entity_detector/init.lua:68: in function 'action' 2024-11-28 14:15:59: ERROR[Main]: .../5.10.0/Yourland_main/bin/../mods/digilines/internal.lua:106: in function 'transmit' 2024-11-28 14:15:59: ERROR[Main]: ...e/mt/5.10.0/Yourland_main/bin/../mods/digilines/init.lua:60: in function 'receptor_send' 2024-11-28 14:15:59: ERROR[Main]: ....10.0/Yourland_main/bin/../mods/digistuff/ioexpander.lua:68: in function 'ioexp_digiline_send' 2024-11-28 14:15:59: ERROR[Main]: ....10.0/Yourland_main/bin/../mods/digistuff/ioexpander.lua:103: in function 'action_change' 2024-11-28 14:15:59: ERROR[Main]: ...Yourland_main/bin/../mods/mesecons/mesecons/internal.lua:230: in function <...Yourland_main/bin/../mods/mesecons/mesecons/internal.lua:223> 2024-11-28 14:15:59: ERROR[Main]: ...rland_main/bin/../mods/mesecons/mesecons/actionqueue.lua:131: in function 'old_execute' 2024-11-28 14:15:59: ERROR[Main]: .../bin/../mods/mesecons_debug/overrides/mesecons_queue.lua:27: in function 'execute' 2024-11-28 14:15:59: ERROR[Main]: ...rland_main/bin/../mods/mesecons/mesecons/actionqueue.lua:121: in function 'func' 2024-11-28 14:15:59: ERROR[Main]: ...ourland_main/bin/../builtin/profiler/instrumentation.lua:124: in function <...ourland_main/bin/../builtin/profiler/instrumentation.lua:117> 2024-11-28 14:15:59: ERROR[Main]: .../5.10.0/Yourland_main/bin/../builtin/common/register.lua:26: in function <.../5.10.0/Yourland_main/bin/../builtin/common/register.lua:12>
AliasAlreadyTaken commented 2024-11-28 15:20:50 +01:00
Author
Owner
Copy Link
                action = function (pos, node, channel, msg)
                        local meta = minetest.get_meta(pos)
                        local active_channel = meta:get_string("digiline_channel")
                        if channel ~= active_channel then
                                return
                        end
                        if (type(msg) ~= "string") then
                                core.log("error","#7743 pos=".. dump(pos))
                                core.log("error","#7743 node=".. dump(node))
                                core.log("error","#7743 channel=".. dump(channel))
                                core.log("error","#7743 msg=".. dump(msg))
                        end
                        meta:set_string("scanname", msg)
                        if meta:get_string("formspec") ~= "" then
                                make_formspec(meta)
                        end
                end,
``` action = function (pos, node, channel, msg) local meta = minetest.get_meta(pos) local active_channel = meta:get_string("digiline_channel") if channel ~= active_channel then return end if (type(msg) ~= "string") then core.log("error","#7743 pos=".. dump(pos)) core.log("error","#7743 node=".. dump(node)) core.log("error","#7743 channel=".. dump(channel)) core.log("error","#7743 msg=".. dump(msg)) end meta:set_string("scanname", msg) if meta:get_string("formspec") ~= "" then make_formspec(meta) end end, ```
AliasAlreadyTaken added the
1. kind/bug
2. prio/critical
 labels 2024-11-28 15:22:55 +01:00
AliasAlreadyTaken commented 2024-11-28 16:08:37 +01:00
Author
Owner
Copy Link

This is the results:

2024-11-28 15:05:24: ERROR[Server]: #7743 pos={
	z = -3,
	x = -381,
	y = 13
}
2024-11-28 15:05:24: ERROR[Server]: #7743 node={
	param1 = 14,
	name = "moremesecons_entity_detector:entity_detector_on",
	param2 = 0
}
2024-11-28 15:05:24: ERROR[Server]: #7743 channel=""
2024-11-28 15:05:24: ERROR[Server]: #7743 msg={
	d = false,
	c = false,
	b = false,
	a = true
}
This is the results: ``` 2024-11-28 15:05:24: ERROR[Server]: #7743 pos={ z = -3, x = -381, y = 13 } 2024-11-28 15:05:24: ERROR[Server]: #7743 node={ param1 = 14, name = "moremesecons_entity_detector:entity_detector_on", param2 = 0 } 2024-11-28 15:05:24: ERROR[Server]: #7743 channel="" 2024-11-28 15:05:24: ERROR[Server]: #7743 msg={ d = false, c = false, b = false, a = true } ```
AliasAlreadyTaken added the
3. source/mod upstream
 label 2024-11-28 16:16:38 +01:00
Harriet commented 2024-11-29 10:54:04 +01:00
Copy Link

I was able to trigger it on the test server by sneaking and placing a digilines I/O expander against an entity detector, near my snake farm.

I was able to trigger it on the test server by sneaking and placing a digilines I/O expander against an entity detector, near my snake farm.
whosit commented 2024-11-29 14:35:28 +01:00
Member
Copy Link

Using same modset, I have no issue on 5.8.0 and crash on 5.10.0 and 5.9.1.
I also tried disabling mesecons_debug - same crash.

The difference is in handling of incorrect arguments in case of meta:set_tring("key", {}) - it silently unsets the key on 5.8 and errors on 5.9+

diff --git a/moremesecons_entity_detector/init.lua b/moremesecons_entity_detector/init.lua
index 165e399..77421f6 100644
--- a/moremesecons_entity_detector/init.lua
+++ b/moremesecons_entity_detector/init.lua
@@ -65,7 +65,13 @@ local object_detector_digiline = {
                        if channel ~= active_channel then
                                return
                        end
-                       meta:set_string("scanname", msg)
+                        if type(msg) == "string" then
+                            -- this errors on 5.9+ if msg is not string
+                            meta:set_string("scanname", msg)
+                        else
+                            -- preserve 5.8.0 behavior
+                            meta:set_string("scanname", "")
+                        end
                        if meta:get_string("formspec") ~= "" then
                                make_formspec(meta)
                        end
--
Using same modset, I have no issue on 5.8.0 and crash on 5.10.0 and 5.9.1. I also tried disabling `mesecons_debug` - same crash. The difference is in handling of incorrect arguments in case of `meta:set_tring("key", {})` - it silently unsets the key on 5.8 and errors on 5.9+ ```diff diff --git a/moremesecons_entity_detector/init.lua b/moremesecons_entity_detector/init.lua index 165e399..77421f6 100644 --- a/moremesecons_entity_detector/init.lua +++ b/moremesecons_entity_detector/init.lua @@ -65,7 +65,13 @@ local object_detector_digiline = { if channel ~= active_channel then return end - meta:set_string("scanname", msg) + if type(msg) == "string" then + -- this errors on 5.9+ if msg is not string + meta:set_string("scanname", msg) + else + -- preserve 5.8.0 behavior + meta:set_string("scanname", "") + end if meta:get_string("formspec") ~= "" then make_formspec(meta) end -- ```
AliasAlreadyTaken added this to the 1.1.126.2 milestone 2024-11-29 18:18:26 +01:00
AliasAlreadyTaken commented 2024-11-29 18:31:25 +01:00
Author
Owner
Copy Link

Upstream issue moremesecons:

Repro:

Have mesecons, digilines, moremesecons

  1. Place mesecons_luacontroller:luacontroller
  2. Place moremesecons_entity_detector:entity_detector
  3. Add channel "kaputt" to entity_detector
  4. Add code to luacontroller: digiline_send("kaputt",{})
  5. Press Execute

Crash

AsyncErr: Lua: Runtime error from mod 'mesecons' in callback environment_Step(): .../mods/moremesecons/moremesecons_entity_detector/init.lua:68: bad argument #2 to 'set_string' (string expected, got table)
stack traceback:
	[C]: in function 'set_string'
	.../mods/moremesecons/moremesecons_entity_detector/init.lua:68: in function 'action'
	.../5.10.0/minetest-temp/bin/../mods/digilines/internal.lua:106: in function 'transmit'
	...test/5.10.0/minetest-temp/bin/../mods/digilines/init.lua:60: in function 'receptor_send'
	...emp/bin/../mods/mesecons/mesecons_luacontroller/init.lua:752: in function <...emp/bin/../mods/mesecons/mesecons_luacontroller/init.lua:746>
	...etest-temp/bin/../mods/mesecons/mesecons/actionqueue.lua:131: in function 'execute'
	...etest-temp/bin/../mods/mesecons/mesecons/actionqueue.lua:121: in function <...etest-temp/bin/../mods/mesecons/mesecons/actionqueue.lua:76>
	.../5.10.0/minetest-temp/bin/../builtin/common/register.lua:26: in function <.../5.10.0/minetest-temp/bin/../builtin/common/register.lua:12>

This doesn't happen in 5.8.0, only in 5.9.1 and 5.10.0 and 5.11.0-dev

The difference is in handling of incorrect arguments in case of meta:set_string("key", {}) - it silently unsets the key on 5.8 and errors on 5.9+

Please add a type check

Upstream issue moremesecons: Repro: > Have mesecons, digilines, moremesecons 1. Place mesecons_luacontroller:luacontroller 2. Place moremesecons_entity_detector:entity_detector 3. Add channel `"kaputt"` to entity_detector 4. Add code to luacontroller: `digiline_send("kaputt",{})` 5. Press Execute > Crash ``` AsyncErr: Lua: Runtime error from mod 'mesecons' in callback environment_Step(): .../mods/moremesecons/moremesecons_entity_detector/init.lua:68: bad argument #2 to 'set_string' (string expected, got table) stack traceback: [C]: in function 'set_string' .../mods/moremesecons/moremesecons_entity_detector/init.lua:68: in function 'action' .../5.10.0/minetest-temp/bin/../mods/digilines/internal.lua:106: in function 'transmit' ...test/5.10.0/minetest-temp/bin/../mods/digilines/init.lua:60: in function 'receptor_send' ...emp/bin/../mods/mesecons/mesecons_luacontroller/init.lua:752: in function <...emp/bin/../mods/mesecons/mesecons_luacontroller/init.lua:746> ...etest-temp/bin/../mods/mesecons/mesecons/actionqueue.lua:131: in function 'execute' ...etest-temp/bin/../mods/mesecons/mesecons/actionqueue.lua:121: in function <...etest-temp/bin/../mods/mesecons/mesecons/actionqueue.lua:76> .../5.10.0/minetest-temp/bin/../builtin/common/register.lua:26: in function <.../5.10.0/minetest-temp/bin/../builtin/common/register.lua:12> ``` This doesn't happen in 5.8.0, only in 5.9.1 and 5.10.0 and 5.11.0-dev The difference is in handling of incorrect arguments in case of `meta:set_string("key", {})` - it silently unsets the key on 5.8 and errors on 5.9+ Please add a type check
AliasAlreadyTaken commented 2024-11-29 18:34:26 +01:00
Author
Owner
Copy Link

Upstream issue https://github.com/minetest-mods/MoreMesecons/issues/38

Upstream issue https://github.com/minetest-mods/MoreMesecons/issues/38
tour commented 2024-11-29 18:35:57 +01:00
Member
Copy Link

also affected:

  • moremesecons player detector (digiline_send("kaputt",{scanname = {}}))
  • mesecons player detector (digiline_send("kaputt",{}))
also affected: - moremesecons player detector (`digiline_send("kaputt",{scanname = {}})`) - mesecons player detector (`digiline_send("kaputt",{})`)
👍 2
AliasAlreadyTaken commented 2024-11-29 20:27:44 +01:00
Author
Owner
Copy Link

Upstream issue mesecons:

Repro:

Have mesecons, digilines

  1. Place mesecons_luacontroller:luacontroller
  2. Place mesecons_detector:object_detector
  3. Add channel "kaputt" to object_detector
  4. Add code to luacontroller: digiline_send("kaputt",{})
  5. Press Execute

Crash

AsyncErr: Lua: Runtime error from mod 'mesecons' in callback environment_Step(): ...est-temp/bin/../mods/mesecons/mesecons_detector/init.lua:70: bad argument #2 to 'set_string' (string expected, got table)
stack traceback:
	[C]: in function 'set_string'
	...est-temp/bin/../mods/mesecons/mesecons_detector/init.lua:70: in function 'action'
	.../5.10.0/minetest-temp/bin/../mods/digilines/internal.lua:106: in function 'transmit'
	...test/5.10.0/minetest-temp/bin/../mods/digilines/init.lua:60: in function 'receptor_send'
	...emp/bin/../mods/mesecons/mesecons_luacontroller/init.lua:752: in function <...emp/bin/../mods/mesecons/mesecons_luacontroller/init.lua:746>
	...etest-temp/bin/../mods/mesecons/mesecons/actionqueue.lua:131: in function 'execute'
	...etest-temp/bin/../mods/mesecons/mesecons/actionqueue.lua:121: in function <...etest-temp/bin/../mods/mesecons/mesecons/actionqueue.lua:76>
	.../5.10.0/minetest-temp/bin/../builtin/common/register.lua:26: in function <.../5.10.0/minetest-temp/bin/../builtin/common/register.lua:12>

This doesn't happen in 5.8.0, only in 5.9.1 and 5.10.0 and 5.11.0-dev

The difference is in handling of incorrect arguments in case of meta:set_string("key", {}) - it silently unsets the key on 5.8 and errors on 5.9+

Please add a type check

Upstream issue mesecons: Repro: > Have mesecons, digilines 1. Place mesecons_luacontroller:luacontroller 2. Place mesecons_detector:object_detector 3. Add channel `"kaputt"` to object_detector 4. Add code to luacontroller: `digiline_send("kaputt",{})` 5. Press Execute > Crash ``` AsyncErr: Lua: Runtime error from mod 'mesecons' in callback environment_Step(): ...est-temp/bin/../mods/mesecons/mesecons_detector/init.lua:70: bad argument #2 to 'set_string' (string expected, got table) stack traceback: [C]: in function 'set_string' ...est-temp/bin/../mods/mesecons/mesecons_detector/init.lua:70: in function 'action' .../5.10.0/minetest-temp/bin/../mods/digilines/internal.lua:106: in function 'transmit' ...test/5.10.0/minetest-temp/bin/../mods/digilines/init.lua:60: in function 'receptor_send' ...emp/bin/../mods/mesecons/mesecons_luacontroller/init.lua:752: in function <...emp/bin/../mods/mesecons/mesecons_luacontroller/init.lua:746> ...etest-temp/bin/../mods/mesecons/mesecons/actionqueue.lua:131: in function 'execute' ...etest-temp/bin/../mods/mesecons/mesecons/actionqueue.lua:121: in function <...etest-temp/bin/../mods/mesecons/mesecons/actionqueue.lua:76> .../5.10.0/minetest-temp/bin/../builtin/common/register.lua:26: in function <.../5.10.0/minetest-temp/bin/../builtin/common/register.lua:12> ``` This doesn't happen in 5.8.0, only in 5.9.1 and 5.10.0 and 5.11.0-dev The difference is in handling of incorrect arguments in case of `meta:set_string("key", {})` - it silently unsets the key on 5.8 and errors on 5.9+ Please add a type check
AliasAlreadyTaken commented 2024-11-29 20:30:28 +01:00
Author
Owner
Copy Link

Upstream issue: https://github.com/minetest-mods/mesecons/issues/691

Upstream issue: https://github.com/minetest-mods/mesecons/issues/691
AliasAlreadyTaken added the
4. step/ready to QA test
 label 2024-11-29 20:39:41 +01:00
AliasAlreadyTaken added the
4. step/QA OK
 label 2024-11-30 00:52:13 +01:00
tour commented 2024-11-30 13:44:58 +01:00
Member
Copy Link

https://github.com/minetest-mods/MoreMesecons/pull/39

https://github.com/minetest-mods/MoreMesecons/pull/39
tour commented 2024-12-20 22:46:16 +01:00
Member
Copy Link

MoreMesecons pr merged, mesecons also pushed a fix :-)

MoreMesecons pr merged, mesecons also pushed a fix :-)
👍 1
Harriet commented 2025-03-08 03:54:45 +01:00
Copy Link

I think this could be closed

I think this could be closed
👍 1
AliasAlreadyTaken added the
5. result/fixed
 label 2025-03-08 17:27:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/possible close

Should be closed, but a second opinion is asked

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
kind/standalone

issues that don't depend on internal access and can be implemented as a stand-alone project

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/possible close
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
kind/standalone
Milestone
Clear milestone
No items
No Milestone
1.1.126.2
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#7743
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?