your-land/bugtracker
your-land/bugtracker
40
22
Issues 3.5k Projects 4 Wiki

kitten creating or dropping item crashes the server #7530

New Issue
Open
opened 2024-10-20 13:31:12 +02:00 by AliasAlreadyTaken · 6 comments
AliasAlreadyTaken commented 2024-10-20 13:31:12 +02:00
Owner
Copy Link

2024-10-20 11:27:53: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mobs_animal' in callback luaentity_Step(): "Runtime error from mod '??' in callback l_add_item(): .../mt/5.8.0/Minetest_live/bin/../builtin/common/vector.lua:380: attempt to index local 'v' (a nil value)
2024-10-20 11:27:53: ERROR[Main]: stack traceback:
2024-10-20 11:27:53: ERROR[Main]: .../mt/5.8.0/Minetest_live/bin/../builtin/common/vector.lua:380: in function <.../mt/5.8.0/Minetest_live/bin/../builtin/common/vector.lua:379>
2024-10-20 11:27:53: ERROR[Main]: [C]: in function 'add_entity'
2024-10-20 11:27:53: ERROR[Main]: .../5.8.0/Minetest_live/bin/../builtin/game/item_entity.lua:6: in function <.../5.8.0/Minetest_live/bin/../builtin/game/item_entity.lua:3>
2024-10-20 11:27:53: ERROR[Main]: [C]: in function 'add_item'
2024-10-20 11:27:53: ERROR[Main]: ...t/5.8.0/Minetest_live/bin/../mods/mobs_animal/kitten.lua:130: in function 'do_custom'
2024-10-20 11:27:53: ERROR[Main]: /home/mt/5.8.0/Minetest_live/bin/../mods/mobs_redo/api.lua:3589: in function 'func'
2024-10-20 11:27:53: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:101>"
2024-10-20 11:27:53: ERROR[Main]: stack traceback:
2024-10-20 11:27:53: ERROR[Main]: [C]: in function 'add_item'
2024-10-20 11:27:53: ERROR[Main]: ...t/5.8.0/Minetest_live/bin/../mods/mobs_animal/kitten.lua:130: in function 'do_custom'
2024-10-20 11:27:53: ERROR[Main]: /home/mt/5.8.0/Minetest_live/bin/../mods/mobs_redo/api.lua:3589: in function 'func'
2024-10-20 11:27:53: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:101>

2024-10-20 11:27:53: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mobs_animal' in callback luaentity_Step(): "Runtime error from mod '??' in callback l_add_item(): .../mt/5.8.0/Minetest_live/bin/../builtin/common/vector.lua:380: attempt to index local 'v' (a nil value) 2024-10-20 11:27:53: ERROR[Main]: stack traceback: 2024-10-20 11:27:53: ERROR[Main]: .../mt/5.8.0/Minetest_live/bin/../builtin/common/vector.lua:380: in function <.../mt/5.8.0/Minetest_live/bin/../builtin/common/vector.lua:379> 2024-10-20 11:27:53: ERROR[Main]: [C]: in function 'add_entity' 2024-10-20 11:27:53: ERROR[Main]: .../5.8.0/Minetest_live/bin/../builtin/game/item_entity.lua:6: in function <.../5.8.0/Minetest_live/bin/../builtin/game/item_entity.lua:3> 2024-10-20 11:27:53: ERROR[Main]: [C]: in function 'add_item' 2024-10-20 11:27:53: ERROR[Main]: ...t/5.8.0/Minetest_live/bin/../mods/mobs_animal/kitten.lua:130: in function 'do_custom' 2024-10-20 11:27:53: ERROR[Main]: /home/mt/5.8.0/Minetest_live/bin/../mods/mobs_redo/api.lua:3589: in function 'func' 2024-10-20 11:27:53: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:101>" 2024-10-20 11:27:53: ERROR[Main]: stack traceback: 2024-10-20 11:27:53: ERROR[Main]: [C]: in function 'add_item' 2024-10-20 11:27:53: ERROR[Main]: ...t/5.8.0/Minetest_live/bin/../mods/mobs_animal/kitten.lua:130: in function 'do_custom' 2024-10-20 11:27:53: ERROR[Main]: /home/mt/5.8.0/Minetest_live/bin/../mods/mobs_redo/api.lua:3589: in function 'func' 2024-10-20 11:27:53: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:101>
AliasAlreadyTaken added the
1. kind/bug
3. source/mod upstream
2. prio/critical
 labels 2024-10-20 13:32:04 +02:00
whosit commented 2024-10-20 13:58:30 +02:00
Member
Copy Link

previous issue here: #5197
(that issue fixed one potential cause for the crash, but not the crashy code itself)

previous issue here: https://gitea.your-land.de/your-land/bugtracker/issues/5197 (that issue fixed one potential cause for the crash, but not the crashy code itself)
AliasAlreadyTaken commented 2025-01-09 03:01:37 +01:00
Author
Owner
Copy Link
2025-01-09 01:55:43: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mobs_animal' in callback luaentity_Step(): "Runtime error from mod '??' in callback l_add_item(): "Invalid vector (expected table got nil)."
2025-01-09 01:55:43: ERROR[Main]: stack traceback:
2025-01-09 01:55:43: ERROR[Main]: 	[C]: in function 'add_entity'
2025-01-09 01:55:43: ERROR[Main]: 	...5.10.0/Yourland_main/bin/../builtin/game/item_entity.lua:4: in function <...5.10.0/Yourland_main/bin/../builtin/game/item_entity.lua:1>
2025-01-09 01:55:43: ERROR[Main]: 	[C]: in function 'add_item'
2025-01-09 01:55:43: ERROR[Main]: 	.../5.10.0/Yourland_main/bin/../mods/mobs_animal/kitten.lua:122: in function 'do_custom'
2025-01-09 01:55:43: ERROR[Main]: 	/home/mt/5.10.0/Yourland_main/bin/../mods/mobs_redo/api.lua:3353: in function 'func'
2025-01-09 01:55:43: ERROR[Main]: 	...ourland_main/bin/../builtin/profiler/instrumentation.lua:124: in function <...ourland_main/bin/../builtin/profiler/instrumentation.lua:117>"
2025-01-09 01:55:43: ERROR[Main]: stack traceback:
2025-01-09 01:55:43: ERROR[Main]: 	[C]: in function 'add_item'
2025-01-09 01:55:43: ERROR[Main]: 	.../5.10.0/Yourland_main/bin/../mods/mobs_animal/kitten.lua:122: in function 'do_custom'
2025-01-09 01:55:43: ERROR[Main]: 	/home/mt/5.10.0/Yourland_main/bin/../mods/mobs_redo/api.lua:3353: in function 'func'
2025-01-09 01:55:43: ERROR[Main]: 	...ourland_main/bin/../builtin/profiler/instrumentation.lua:124: in function <...ourland_main/bin/../builtin/profiler/instrumentation.lua:117>
``` 2025-01-09 01:55:43: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mobs_animal' in callback luaentity_Step(): "Runtime error from mod '??' in callback l_add_item(): "Invalid vector (expected table got nil)." 2025-01-09 01:55:43: ERROR[Main]: stack traceback: 2025-01-09 01:55:43: ERROR[Main]: [C]: in function 'add_entity' 2025-01-09 01:55:43: ERROR[Main]: ...5.10.0/Yourland_main/bin/../builtin/game/item_entity.lua:4: in function <...5.10.0/Yourland_main/bin/../builtin/game/item_entity.lua:1> 2025-01-09 01:55:43: ERROR[Main]: [C]: in function 'add_item' 2025-01-09 01:55:43: ERROR[Main]: .../5.10.0/Yourland_main/bin/../mods/mobs_animal/kitten.lua:122: in function 'do_custom' 2025-01-09 01:55:43: ERROR[Main]: /home/mt/5.10.0/Yourland_main/bin/../mods/mobs_redo/api.lua:3353: in function 'func' 2025-01-09 01:55:43: ERROR[Main]: ...ourland_main/bin/../builtin/profiler/instrumentation.lua:124: in function <...ourland_main/bin/../builtin/profiler/instrumentation.lua:117>" 2025-01-09 01:55:43: ERROR[Main]: stack traceback: 2025-01-09 01:55:43: ERROR[Main]: [C]: in function 'add_item' 2025-01-09 01:55:43: ERROR[Main]: .../5.10.0/Yourland_main/bin/../mods/mobs_animal/kitten.lua:122: in function 'do_custom' 2025-01-09 01:55:43: ERROR[Main]: /home/mt/5.10.0/Yourland_main/bin/../mods/mobs_redo/api.lua:3353: in function 'func' 2025-01-09 01:55:43: ERROR[Main]: ...ourland_main/bin/../builtin/profiler/instrumentation.lua:124: in function <...ourland_main/bin/../builtin/profiler/instrumentation.lua:117> ```
tour commented 2025-01-09 13:02:55 +01:00
Member
Copy Link

https://codeberg.org/tenplus1/mobs_redo/pulls/38

https://codeberg.org/tenplus1/mobs_redo/pulls/38
tour commented 2025-01-09 17:46:27 +01:00
Member
Copy Link

merged :-)

Maybe something about the repo for the crash:

  • change the setting remove_far_mobs to false (I assume yl has done that already, otherwise I can't see why it should crash)
  • set the kitten lifetimer to 10 (we don't want to wait the default 15 min until kittens despawn)
  • edit the kitten file so that it drops a hairball every step. (The crash happens in the extremely unlikely but possible case that a kitten tries to spawn a hairball in the same step it's lifetime expires)
  • spawn a kitten that is not owned (spawneggs don't work) and move away to let it despawn.

Or simply trust that I tested my pr before sending it to upstream (QA main) :-)

merged :-) Maybe something about the repo for the crash: - change the setting remove_far_mobs to false (I assume yl has done that already, otherwise I can't see why it should crash) - set the kitten lifetimer to 10 (we don't want to wait the default 15 min until kittens despawn) - edit the kitten file so that it drops a hairball every step. (The crash happens in the extremely unlikely but possible case that a kitten tries to spawn a hairball in the same step it's lifetime expires) - spawn a kitten that is **not** owned (spawneggs don't work) and move away to let it despawn. Or simply trust that I tested my pr before sending it to upstream (QA main) :-)
👍 1
tour added the
4. step/ready to QA test
 label 2025-01-09 17:46:56 +01:00
tour added this to the 1.1.127 milestone 2025-01-10 13:30:48 +01:00
AliasAlreadyTaken commented 2025-03-16 22:53:30 +01:00
Author
Owner
Copy Link
2025-03-16 20:10:08: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mobs_animal' in callback luaentity_Step(): "Runtime error from mod '??' in callback l_add_item(): "Invalid vector (expected table got nil)."
2025-03-16 20:10:08: ERROR[Main]: stack traceback:
2025-03-16 20:10:08: ERROR[Main]: 	[C]: in function 'add_entity'
2025-03-16 20:10:08: ERROR[Main]: 	...5.10.0/Yourland_main/bin/../builtin/game/item_entity.lua:4: in function <...5.10.0/Yourland_main/bin/../builtin/game/item_entity.lua:1>
2025-03-16 20:10:08: ERROR[Main]: 	[C]: in function 'add_item'
2025-03-16 20:10:08: ERROR[Main]: 	.../5.10.0/Yourland_main/bin/../mods/mobs_animal/kitten.lua:122: in function 'do_custom'
2025-03-16 20:10:08: ERROR[Main]: 	/home/yl/5.10.0/Yourland_main/bin/../mods/mobs_redo/api.lua:3353: in function 'func'
2025-03-16 20:10:08: ERROR[Main]: 	...ourland_main/bin/../builtin/profiler/instrumentation.lua:124: in function <...ourland_main/bin/../builtin/profiler/instrumentation.lua:117>"
2025-03-16 20:10:08: ERROR[Main]: stack traceback:
2025-03-16 20:10:08: ERROR[Main]: 	[C]: in function 'add_item'
2025-03-16 20:10:08: ERROR[Main]: 	.../5.10.0/Yourland_main/bin/../mods/mobs_animal/kitten.lua:122: in function 'do_custom'
2025-03-16 20:10:08: ERROR[Main]: 	/home/yl/5.10.0/Yourland_main/bin/../mods/mobs_redo/api.lua:3353: in function 'func'
2025-03-16 20:10:08: ERROR[Main]: 	...ourland_main/bin/../builtin/profiler/instrumentation.lua:124: in function <...ourland_main/bin/../builtin/profiler/instrumentation.lua:117>
``` 2025-03-16 20:10:08: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mobs_animal' in callback luaentity_Step(): "Runtime error from mod '??' in callback l_add_item(): "Invalid vector (expected table got nil)." 2025-03-16 20:10:08: ERROR[Main]: stack traceback: 2025-03-16 20:10:08: ERROR[Main]: [C]: in function 'add_entity' 2025-03-16 20:10:08: ERROR[Main]: ...5.10.0/Yourland_main/bin/../builtin/game/item_entity.lua:4: in function <...5.10.0/Yourland_main/bin/../builtin/game/item_entity.lua:1> 2025-03-16 20:10:08: ERROR[Main]: [C]: in function 'add_item' 2025-03-16 20:10:08: ERROR[Main]: .../5.10.0/Yourland_main/bin/../mods/mobs_animal/kitten.lua:122: in function 'do_custom' 2025-03-16 20:10:08: ERROR[Main]: /home/yl/5.10.0/Yourland_main/bin/../mods/mobs_redo/api.lua:3353: in function 'func' 2025-03-16 20:10:08: ERROR[Main]: ...ourland_main/bin/../builtin/profiler/instrumentation.lua:124: in function <...ourland_main/bin/../builtin/profiler/instrumentation.lua:117>" 2025-03-16 20:10:08: ERROR[Main]: stack traceback: 2025-03-16 20:10:08: ERROR[Main]: [C]: in function 'add_item' 2025-03-16 20:10:08: ERROR[Main]: .../5.10.0/Yourland_main/bin/../mods/mobs_animal/kitten.lua:122: in function 'do_custom' 2025-03-16 20:10:08: ERROR[Main]: /home/yl/5.10.0/Yourland_main/bin/../mods/mobs_redo/api.lua:3353: in function 'func' 2025-03-16 20:10:08: ERROR[Main]: ...ourland_main/bin/../builtin/profiler/instrumentation.lua:124: in function <...ourland_main/bin/../builtin/profiler/instrumentation.lua:117> ```
AliasAlreadyTaken commented 2025-03-25 22:20:10 +01:00
Author
Owner
Copy Link

QA

A horde of kittens was not able to crash the server again: OK

QA A horde of kittens was not able to crash the server again: OK
AliasAlreadyTaken added the
ugh/QA OK
 label 2025-03-25 22:21:02 +01:00
AliasAlreadyTaken added the
ugh/QA main
 label 2025-04-04 16:56:21 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
source/testserver

Originates on the testserver, no effect on main yet

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
source/testserver
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.127
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#7530
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?