flux' moreblocks fork adds 292 block definitions. Which?? #7337

New Issue

AliasAlreadyTaken · 2024-08-24T04:21:14+02:00

AliasAlreadyTaken commented

2024-08-24 04:21:14 +02:00

I did on main and test:

//lua local t = {} local n = 0 for k,_ in pairs(minetest.registered_nodes) do table.insert(t,k) end table.sort(t) minetest.safe_file_write(minetest.get_worldpath() .. DIR_DELIM .. "new_moreblocks.txt", table.concat(t,"\n"))

Which yielded 20111 on test and 19819 on main. That's a difference of 292 definitions. Which ones? Do we want those?

caverealms ores (~51)
deep nether brick (~??)
Some blocks have now +1 definiton (dragonscale block, petz gables and blue wood)

I'm fairly certain I'm missing some

I did on main and test: ``` //lua local t = {} local n = 0 for k,_ in pairs(minetest.registered_nodes) do table.insert(t,k) end table.sort(t) minetest.safe_file_write(minetest.get_worldpath() .. DIR_DELIM .. "new_moreblocks.txt", table.concat(t,"\n")) ``` Which yielded 20111 on test and 19819 on main. That's a difference of 292 definitions. Which ones? Do we want those? * [ ] caverealms ores (~51) * [ ] deep nether brick (~??) * [ ] Some blocks have now +1 definiton (dragonscale block, petz gables and blue wood) I'm fairly certain I'm missing some

AliasAlreadyTaken added the

1. kind/bug

1. kind/documentation

labels 2024-08-24 04:21:24 +02:00

AliasAlreadyTaken added this to the moreblocks milestone 2024-08-24 04:21:30 +02:00

AliasAlreadyTaken added

4. step/needs confirmation

and removed

1. kind/bug

labels 2024-08-24 04:21:44 +02:00

whosit commented

2024-10-16 19:29:45 +02:00

If you have 2 lists, you can do:

comm -3 <( sort -u main.txt ) <( sort -u test.txt ) | less

Which will show 2 colums of lines unique to first and second file.

If you have 2 lists, you can do: ```bash comm -3 <( sort -u main.txt ) <( sort -u test.txt ) | less ``` Which will show 2 colums of lines unique to first and second file.

Sign in to join this conversation.