your-land/bugtracker
your-land/bugtracker
41
22
Issues 3.6k Projects 4 Wiki

Shift+rightclick on 5.9.0 with waypoint compass #7005

New Issue
Closed
opened 2024-06-27 10:28:20 +02:00 by AliasAlreadyTaken · 4 comments
AliasAlreadyTaken commented 2024-06-27 10:28:20 +02:00
Owner
Copy Link

I shift+rightclicked with a waypoint compass in hand on a 5.9.0 server

2024-06-27 10:17:28: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'waypoint_compass' in callback item_OnPlace(): ...etest/5.9.0/minetest-dev/bin/../builtin/common/after.lua:152: attempt to index local 'self' (a nil value)
2024-06-27 10:17:28: ERROR[Main]: stack traceback:
2024-06-27 10:17:28: ERROR[Main]: 	...etest/5.9.0/minetest-dev/bin/../builtin/common/after.lua:152: in function 'cancel'
2024-06-27 10:17:28: ERROR[Main]: 	...netest-dev/bin/../mods/waypoint_compass/waypoint_lib.lua:231: in function 'hide'
2024-06-27 10:17:28: ERROR[Main]: 	...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:117: in function 'hide_hud_waypoint'
2024-06-27 10:17:28: ERROR[Main]: 	...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:182: in function 'update_hud_waypoint'
2024-06-27 10:17:28: ERROR[Main]: 	...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:341: in function <...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:320>
I shift+rightclicked with a waypoint compass in hand on a 5.9.0 server ``` 2024-06-27 10:17:28: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'waypoint_compass' in callback item_OnPlace(): ...etest/5.9.0/minetest-dev/bin/../builtin/common/after.lua:152: attempt to index local 'self' (a nil value) 2024-06-27 10:17:28: ERROR[Main]: stack traceback: 2024-06-27 10:17:28: ERROR[Main]: ...etest/5.9.0/minetest-dev/bin/../builtin/common/after.lua:152: in function 'cancel' 2024-06-27 10:17:28: ERROR[Main]: ...netest-dev/bin/../mods/waypoint_compass/waypoint_lib.lua:231: in function 'hide' 2024-06-27 10:17:28: ERROR[Main]: ...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:117: in function 'hide_hud_waypoint' 2024-06-27 10:17:28: ERROR[Main]: ...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:182: in function 'update_hud_waypoint' 2024-06-27 10:17:28: ERROR[Main]: ...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:341: in function <...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:320> ```
AliasAlreadyTaken added the
1. kind/bug
3. source/testserver
 labels 2024-06-27 10:28:37 +02:00
AliasAlreadyTaken added this to the minetest 5.9.0 milestone 2024-06-27 10:28:45 +02:00
AliasAlreadyTaken commented 2024-06-27 12:47:41 +02:00
Author
Owner
Copy Link

Maybe not the shiftclick caused it, but when switching away from a compass

2024-06-27 10:30:37: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'waypoint_compass' in callback environment_Step(): ...etest/5.9.0/minetest-dev/bin/../builtin/common/after.lua:152: attempt to index local 'self' (a nil value)
2024-06-27 10:30:37: ERROR[Main]: stack traceback:
2024-06-27 10:30:37: ERROR[Main]: 	...etest/5.9.0/minetest-dev/bin/../builtin/common/after.lua:152: in function 'cancel'
2024-06-27 10:30:37: ERROR[Main]: 	...netest-dev/bin/../mods/waypoint_compass/waypoint_lib.lua:231: in function 'hide'
2024-06-27 10:30:37: ERROR[Main]: 	...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:117: in function 'hide_hud_waypoint'
2024-06-27 10:30:37: ERROR[Main]: 	...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:191: in function 'update_hud_waypoint'
2024-06-27 10:30:37: ERROR[Main]: 	...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:204: in function 'func'
2024-06-27 10:30:37: ERROR[Main]: 	...minetest-dev/bin/../builtin/profiler/instrumentation.lua:124: in function <...minetest-dev/bin/../builtin/profiler/instrumentation.lua:117>
2024-06-27 10:30:37: ERROR[Main]: 	...st/5.9.0/minetest-dev/bin/../builtin/common/register.lua:26: in function <...st/5.9.0/minetest-dev/bin/../builtin/common/register.lua:12>
Maybe not the shiftclick caused it, but when switching away from a compass ``` 2024-06-27 10:30:37: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'waypoint_compass' in callback environment_Step(): ...etest/5.9.0/minetest-dev/bin/../builtin/common/after.lua:152: attempt to index local 'self' (a nil value) 2024-06-27 10:30:37: ERROR[Main]: stack traceback: 2024-06-27 10:30:37: ERROR[Main]: ...etest/5.9.0/minetest-dev/bin/../builtin/common/after.lua:152: in function 'cancel' 2024-06-27 10:30:37: ERROR[Main]: ...netest-dev/bin/../mods/waypoint_compass/waypoint_lib.lua:231: in function 'hide' 2024-06-27 10:30:37: ERROR[Main]: ...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:117: in function 'hide_hud_waypoint' 2024-06-27 10:30:37: ERROR[Main]: ...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:191: in function 'update_hud_waypoint' 2024-06-27 10:30:37: ERROR[Main]: ...5.9.0/minetest-dev/bin/../mods/waypoint_compass/init.lua:204: in function 'func' 2024-06-27 10:30:37: ERROR[Main]: ...minetest-dev/bin/../builtin/profiler/instrumentation.lua:124: in function <...minetest-dev/bin/../builtin/profiler/instrumentation.lua:117> 2024-06-27 10:30:37: ERROR[Main]: ...st/5.9.0/minetest-dev/bin/../builtin/common/register.lua:26: in function <...st/5.9.0/minetest-dev/bin/../builtin/common/register.lua:12> ```
AliasAlreadyTaken added the
4. step/ready to QA test
4. step/QA OK
 labels 2024-08-15 16:50:17 +02:00
whosit commented 2024-10-19 11:30:14 +02:00
Member
Copy Link

This was fixed by tour here (thank you tour!):
#6896

And it's caused by me mixing up method call syntax sugar, again (thing.method() vs thing:method()).

Took me a while to notice it after staring...

This is an engine change actually: https://github.com/minetest/minetest/pull/13477 (thanks for figuring it out, tour!)

Took me even longer to untangle this XD Was making no sense how it could work so long and then stop.

Problem is that now waypoint_ mods require 5.9 version of MT... (could fix it...). (thanks @tour for correcting me!)

Also, weirdly, minetest.after sometimes returns nil. Doing this in the /snippets:

local job = minetest.after(5, function() minetest.chat_send_all("timeout") end)
if job then
  minetest.chat_send_all("ok")
else
  minetest.chat_send_all("I'm going insane")
end

I get:

I am going insane
timeout

UPDATE:

What a mess :D
minetest never fails to amaze me... I hope luanti will be better.

Turns out, snippets mod is wrapping some core functions. Makes sense, but it's version of after function always returns nil.

Spent too much time being totally confused because of this...

This was fixed by `tour` here (thank you tour!): https://gitea.your-land.de/your-land/bugtracker/issues/6896 ~~And it's caused by me mixing up method call syntax sugar, again (`thing.method()` vs `thing:method()`).~~ ~~Took me a while to notice it after staring...~~ This is an engine change actually: https://github.com/minetest/minetest/pull/13477 (thanks for figuring it out, [tour](https://gitea.your-land.de/whosit/waypoint_compass/pulls/10)!) Took me even longer to untangle this XD Was making no sense how it could work so long and then stop. ~~Problem is that now `waypoint_` mods *require* 5.9 version of MT... (could fix it...).~~ (thanks @tour for correcting me!) Also, weirdly, `minetest.after` sometimes returns `nil`. Doing this in the `/snippets`: ```lua local job = minetest.after(5, function() minetest.chat_send_all("timeout") end) if job then minetest.chat_send_all("ok") else minetest.chat_send_all("I'm going insane") end ``` I get: ``` I am going insane timeout ``` UPDATE: What a mess :D minetest never fails to amaze me... I hope luanti will be better. Turns out, `snippets` mod is wrapping some `core` functions. Makes sense, but it's version of `after` function always returns nil. Spent too much time being totally confused because of this...
tour commented 2024-10-20 23:10:58 +02:00
Member
Copy Link

Problem is that now waypoint_ mods require 5.9 version of MT... (could fix it...).

Why? pre-5.9 will simply not need the parameter self and thus ignore it.

see in https://github.com/minetest/minetest/pull/10103 that the docs always said to stop with : 🤓

> Problem is that now waypoint_ mods require 5.9 version of MT... (could fix it...). Why? pre-5.9 will simply not need the parameter self and thus ignore it. ~~see in https://github.com/minetest/minetest/pull/10103 that the docs always said to stop with `:`~~ 🤓
whosit commented 2024-10-21 07:23:26 +02:00
Member
Copy Link

Why? pre-5.9 will simply not need the parameter self and thus ignore it.

You are right :p (original comment fixed)
grumbles something about sloppiness of dynamic languages that don't care even about parameter count

> Why? pre-5.9 will simply not need the parameter self and thus ignore it. You are right :p (original comment fixed) ~~*grumbles something about sloppiness of dynamic languages that don't care even about parameter count*~~
AliasAlreadyTaken added the
5. result/fixed
 label 2025-03-08 18:00:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/possible close

Should be closed, but a second opinion is asked

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
kind/standalone

issues that don't depend on internal access and can be implemented as a stand-alone project

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/possible close
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
kind/standalone
Milestone
Clear milestone
No items
No Milestone
minetest 5.9.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#7005
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?