your-land/bugtracker
your-land/bugtracker
40
21
Issues 3.6k Projects 4 Wiki

AliasAlreadyTaken reports: skinsdb skin listing minor iss ... #6918

New Issue
Closed
opened 2024-06-09 12:54:08 +02:00 by yourland-report · 8 comments
yourland-report commented 2024-06-09 12:54:08 +02:00
Member
Copy Link

AliasAlreadyTaken reports a bug:

skinsdb skin listing minor issues

Player position:

{
	y = 14.5,
	z = 1155.2469482422,
	x = 2000.3529052734
}

Player look:

{
	y = -0.092544369399548,
	z = -0.012859653681517,
	x = 0.99562555551529
}

Player information:

{
	lang_code = "de",
	ip_version = 6,
	min_rtt = 0.0010000000474975,
	min_jitter = 0,
	max_jitter = 0.30599999427795,
	avg_jitter = 0,
	connection_uptime = 1562,
	max_rtt = 0.3129999935627,
	avg_rtt = 0.0010000000474975,
	formspec_version = 7,
	protocol_version = 44
}

Player meta:

{
	fields = {
		arenalib_watchID = "0",
		["stamina:exhaustion"] = "67.5",
		repellant = "0",
		szutil_watch = "return {}",
		["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)",
		yl_commons_player_joined = "1717928887",
		["3d_armor_inventory"] = "return {\"3d_armor:boots_quickfall\", \"\", \"\", \"\", \"\", \"\"}",
		["signslib:pos"] = "(-7122,23,-9909)",
		xp_redo_hud_color = "0xFFFF00",
		["petz:lycanthropy"] = "0",
		crafted = "4819",
		hud_state = "on",
		["arena_lib_editor.spawner_ID"] = "0",
		punch_count = "65277",
		yl_church = "return {[\"last_death_portal\"] = 1713879727, [\"last_heal\"] = 1707613077, [\"last_death\"] = {[\"x\"] = 1979, [\"y\"] = 18, [\"z\"] = 1174}}",
		inflicted_damage = "3023946",
		["petz:werewolf"] = "0",
		["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["arena_lib_editor.team_ID"] = "0",
		xp = "0",
		bitten = "0",
		arenalib_infobox_arenaID = "0",
		partypvp = "true",
		["ocean_build.forbidden"] = "true",
		["petz:werewolf_clan_idx"] = "4",
		lagometer = "1",
		["ocean_build.ocean_built"] = "12",
		["hud_manager:spawnit:hud_enabled"] = "y",
		partychat = "party",
		played_time = "107049796",
		digged_nodes = "145526",
		placed_nodes = "184247",
		died = "1593",
		team = "STAFF",
		["stamina:level"] = "0",
		yl_audio_state = "off",
		["ocean_build.last_warning"] = "1.67421e+09",
		yl_commons_thankyou = "1615",
		["arena_lib_editor.players_number"] = "0",
		["ethereal:fly_timer"] = "-99",
		["petz:werewolf_vignette_id"] = "19",
		["stamina:poisoned"] = "no"
	}
}

Log identifier


[MOD] yl_report log identifier = NRoZq82Wqi97txqNp2ZA55wS9jicZAHi

Profiler save:

profile-20240609T125407.json_prettyEE

Status:

# Server: version: 5.9.0-dev-neptune | game: Minetest Game | uptime: 26min 7s | max lag: 0.121s | clients (2/52): AliasAlreadyTaken, Ernesto

Teleport command:

/teleport xyz 2000 15 1155

Compass command:

/give_compass Construction NRoZq82Wqi97txqNp2ZA55wS9jicZAHi D2691E 2000 15 1155
AliasAlreadyTaken reports a bug: > skinsdb skin listing minor issues Player position: ``` { y = 14.5, z = 1155.2469482422, x = 2000.3529052734 } ``` Player look: ``` { y = -0.092544369399548, z = -0.012859653681517, x = 0.99562555551529 } ``` Player information: ``` { lang_code = "de", ip_version = 6, min_rtt = 0.0010000000474975, min_jitter = 0, max_jitter = 0.30599999427795, avg_jitter = 0, connection_uptime = 1562, max_rtt = 0.3129999935627, avg_rtt = 0.0010000000474975, formspec_version = 7, protocol_version = 44 } ``` Player meta: ``` { fields = { arenalib_watchID = "0", ["stamina:exhaustion"] = "67.5", repellant = "0", szutil_watch = "return {}", ["sethome:home"] = "(1983.4349365234,17.5,1183.5950927734)", yl_commons_player_joined = "1717928887", ["3d_armor_inventory"] = "return {\"3d_armor:boots_quickfall\", \"\", \"\", \"\", \"\", \"\"}", ["signslib:pos"] = "(-7122,23,-9909)", xp_redo_hud_color = "0xFFFF00", ["petz:lycanthropy"] = "0", crafted = "4819", hud_state = "on", ["arena_lib_editor.spawner_ID"] = "0", punch_count = "65277", yl_church = "return {[\"last_death_portal\"] = 1713879727, [\"last_heal\"] = 1707613077, [\"last_death\"] = {[\"x\"] = 1979, [\"y\"] = 18, [\"z\"] = 1174}}", inflicted_damage = "3023946", ["petz:werewolf"] = "0", ["petz:old_override_table"] = "return {[\"speed\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false, [\"gravity\"] = 1, [\"jump\"] = 1, [\"sneak\"] = true}", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["arena_lib_editor.team_ID"] = "0", xp = "0", bitten = "0", arenalib_infobox_arenaID = "0", partypvp = "true", ["ocean_build.forbidden"] = "true", ["petz:werewolf_clan_idx"] = "4", lagometer = "1", ["ocean_build.ocean_built"] = "12", ["hud_manager:spawnit:hud_enabled"] = "y", partychat = "party", played_time = "107049796", digged_nodes = "145526", placed_nodes = "184247", died = "1593", team = "STAFF", ["stamina:level"] = "0", yl_audio_state = "off", ["ocean_build.last_warning"] = "1.67421e+09", yl_commons_thankyou = "1615", ["arena_lib_editor.players_number"] = "0", ["ethereal:fly_timer"] = "-99", ["petz:werewolf_vignette_id"] = "19", ["stamina:poisoned"] = "no" } } ``` Log identifier ``` [MOD] yl_report log identifier = NRoZq82Wqi97txqNp2ZA55wS9jicZAHi ``` Profiler save: ``` profile-20240609T125407.json_prettyEE ``` Status: ``` # Server: version: 5.9.0-dev-neptune | game: Minetest Game | uptime: 26min 7s | max lag: 0.121s | clients (2/52): AliasAlreadyTaken, Ernesto ``` Teleport command: ``` /teleport xyz 2000 15 1155 ``` Compass command: ``` /give_compass Construction NRoZq82Wqi97txqNp2ZA55wS9jicZAHi D2691E 2000 15 1155 ```
AliasAlreadyTaken was assigned by yourland-report 2024-06-09 12:54:08 +02:00
AliasAlreadyTaken commented 2024-06-09 12:54:47 +02:00
Owner
Copy Link
  1. After update everyone will have default skin unless we fix that on the database. Could you please add a migration?
  2. Could you make process_skin_texture public so that other mods can add skins as well?
  3. The _hand property removes all separators and simply concatenates the text, that again creates ambiguity. Example: character.my_name.my_skin.png VS character.my.name_my_skin.png, both lead to skinsdb:charactermynamemyskinpng
  4. Private skins do not show up anymore in the selectable list
1. After update everyone will have default skin unless we fix that on the database. Could you please add a migration? 2. Could you make process_skin_texture public so that other mods can add skins as well? 3. The `_hand` property removes all separators and simply concatenates the text, that again creates ambiguity. Example: `character.my_name.my_skin.png` VS `character.my.name_my_skin.png`, both lead to `skinsdb:charactermynamemyskinpng` 4. Private skins do not show up anymore in the selectable list
👍 1
AliasAlreadyTaken added the
1. kind/bug
3. source/mod upstream
 labels 2024-06-09 12:54:55 +02:00
AliasAlreadyTaken commented 2024-06-09 12:56:31 +02:00
Owner
Copy Link

Upstream issues

  1. https://github.com/minetest-mods/skinsdb/issues/101
  2. https://github.com/minetest-mods/skinsdb/issues/102
  3. https://github.com/minetest-mods/skinsdb/issues/103
  4. https://github.com/minetest-mods/skinsdb/issues/104
Upstream issues 1. https://github.com/minetest-mods/skinsdb/issues/101 2. https://github.com/minetest-mods/skinsdb/issues/102 3. https://github.com/minetest-mods/skinsdb/issues/103 4. https://github.com/minetest-mods/skinsdb/issues/104
AliasAlreadyTaken commented 2024-06-09 13:08:22 +02:00
Owner
Copy Link

//lua local t = skins.meta core.safe_file_write(core.get_worldpath() .."/skins_new.txt" , dump(t))

Here's before the fix:

	character_warrior_m3 = {
		__index = {
			__index = <circular reference>,
			set_hand_from_texture = <function>,
			is_applicable_for_player = <function>,
			set_skin = <function>,
			apply_skin_to_player = <function>,
			get_preview = <function>,
			get_hand = <function>,
			set_texture = <function>,
			set_preview = <function>,
			set_meta = <function>,
			get_meta = <function>,
			get_texture = <function>,
			get_key = <function>,
			get_meta_string = <function>,
			set_hand = <function>
		},
		_hand = "skinsdb:characterwarriorm3png",
		name = "warrior_m3",
		_key = "character_warrior_m3",
		format = "1.8",
		_sort_id = 5000,
		_texture = "character.warrior_m3.png"
	},

This is after the fix:

	["character.warrior_m3"] = {
		name = "warrior_m3",
		format = "1.8",
		inv_page = 3,
		__index = {
			is_applicable_for_player = <function>,
			set_skin = <function>,
			get_preview = <function>,
			apply_skin_to_player = <function>,
			get_texture = <function>,
			set_preview = <function>,
			get_hand = <function>,
			set_hand_from_texture = <function>,
			__index = <circular reference>,
			set_meta = <function>,
			get_key = <function>,
			get_meta_string = <function>,
			get_meta = <function>,
			set_hand = <function>,
			set_texture = <function>
		},
		inv_page_index = 10,
		_sort_id = 5000,
		_texture = "character.warrior_m3.png",
		_key = "character.warrior_m3",
		_hand = "skinsdb:characterwarriorm3png"
	},
`//lua local t = skins.meta core.safe_file_write(core.get_worldpath() .."/skins_new.txt" , dump(t))` Here's before the fix: ``` character_warrior_m3 = { __index = { __index = <circular reference>, set_hand_from_texture = <function>, is_applicable_for_player = <function>, set_skin = <function>, apply_skin_to_player = <function>, get_preview = <function>, get_hand = <function>, set_texture = <function>, set_preview = <function>, set_meta = <function>, get_meta = <function>, get_texture = <function>, get_key = <function>, get_meta_string = <function>, set_hand = <function> }, _hand = "skinsdb:characterwarriorm3png", name = "warrior_m3", _key = "character_warrior_m3", format = "1.8", _sort_id = 5000, _texture = "character.warrior_m3.png" }, ``` This is after the fix: ``` ["character.warrior_m3"] = { name = "warrior_m3", format = "1.8", inv_page = 3, __index = { is_applicable_for_player = <function>, set_skin = <function>, get_preview = <function>, apply_skin_to_player = <function>, get_texture = <function>, set_preview = <function>, get_hand = <function>, set_hand_from_texture = <function>, __index = <circular reference>, set_meta = <function>, get_key = <function>, get_meta_string = <function>, get_meta = <function>, set_hand = <function>, set_texture = <function> }, inv_page_index = 10, _sort_id = 5000, _texture = "character.warrior_m3.png", _key = "character.warrior_m3", _hand = "skinsdb:characterwarriorm3png" }, ```
AliasAlreadyTaken commented 2024-06-10 14:38:14 +02:00
Owner
Copy Link
  1. The PR says it cannot find a skin IF the player has an underscore in it, the skin name does not have an underscore in it.
2024-06-10 14:33:37: WARNING[Server]: skinsdb: cannot find matching skin 'player_playername_with_underscore_2' for player 'playername_with_underscore'.

Because we already renamed all the skins, because we had a dot separator already. Please note, while YL tries to stick to the naming scheme player_playername_number.png, other servers may happily name theirs player_playername_with_underscores_skinname_with_underscores.png

NOK

  1. process_skin_texture is not yet public NOK

  2. The hand key ist still ambiguous NOK

  3. Private skins show up in the right list again OK

1. The PR says it cannot find a skin IF the player has an underscore in it, the skin name does not have an underscore in it. ``` 2024-06-10 14:33:37: WARNING[Server]: skinsdb: cannot find matching skin 'player_playername_with_underscore_2' for player 'playername_with_underscore'. ``` Because we already renamed all the skins, because we had a dot separator already. Please note, while YL tries to stick to the naming scheme `player_playername_number.png`, other servers may happily name theirs `player_playername_with_underscores_skinname_with_underscores.png` NOK 2. process_skin_texture is not yet public NOK 3. The hand key ist still ambiguous NOK 4. Private skins show up in the right list again OK
AliasAlreadyTaken commented 2024-06-10 14:54:34 +02:00
Owner
Copy Link

To find all names with underscores in modstorage:

 SELECT count(*) FROM mod_storage WHERE modname = 'skinsdb' AND strpos(encode(key, 'escape'), '_') > 0;
To find all names with underscores in modstorage: ``` SELECT count(*) FROM mod_storage WHERE modname = 'skinsdb' AND strpos(encode(key, 'escape'), '_') > 0; ```
AliasAlreadyTaken added this to the 1.1.125 milestone 2024-07-03 16:18:43 +02:00
AliasAlreadyTaken added the
4. step/ready to QA test
 label 2024-07-18 05:51:25 +02:00
AliasAlreadyTaken commented 2024-07-18 05:51:42 +02:00
Owner
Copy Link

Most of that fixed upstream

Most of that fixed upstream
TheMadModder commented 2024-07-30 07:12:24 +02:00
Copy Link

Tested the naming of skins in inventory and using /skinsdb and all skins had proper naming convention.

Tested the naming of skins in inventory and using /skinsdb and all skins had proper naming convention.
daydream added the
4. step/QA OK
 label 2024-07-30 08:25:06 +02:00
AliasAlreadyTaken added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2024-11-19 08:54:11 +01:00
AliasAlreadyTaken commented 2024-11-19 08:54:44 +01:00
Owner
Copy Link

Minor issues were fixed by major rework upstream

Minor issues were fixed by major rework upstream
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
Milestone
Clear milestone
No items
No Milestone
1.1.125
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
AliasAlreadyTaken
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6918
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?