areas: Please enable us to NOT have specific conditons #6888

New Issue

AliasAlreadyTaken · 2024-06-05T05:27:50+02:00

AliasAlreadyTaken commented

2024-06-05 05:27:50 +02:00

Our server counts areas differently, in this case a registerProtectionCondition where the counting is don't according to upstream areas allows us no chance to overwrite this.

Please return some handle or other way we could use to disable those conditions, without messing with the mod itself.

Our server counts areas differently, in this case a registerProtectionCondition where the counting is don't according to upstream areas allows us no chance to overwrite this. Please return some handle or other way we could use to disable those conditions, without messing with the mod itself.

AliasAlreadyTaken added the

1. kind/bug

3. source/mod upstream

3. source/testserver

labels 2024-06-05 05:27:59 +02:00

tour commented

2024-06-05 11:07:30 +02:00

To disable all upstream conditions, do a areas.registered_protection_conditions = {}.
You would have to re-implement all upstream checks you still need, so not optimal. (currently upstream checks for privs, area count, area size and area intersection)

If you only want to disable the check for the area count:

areas.config.self_protection_max_areas_high = math.huge
areas.config.self_protection_max_areas = math.huge

should do the trick. (Or you go with the settings and set it to a number so high that no player should be able to reach it...)

To disable all upstream conditions, do a `areas.registered_protection_conditions = {}`. You would have to re-implement all upstream checks you still need, so not optimal. (currently upstream checks for privs, area count, area size and area intersection) --- If you only want to disable the check for the area count: ```lua areas.config.self_protection_max_areas_high = math.huge areas.config.self_protection_max_areas = math.huge ``` should do the trick. (Or you go with the settings and set it to a number so high that no player should be able to reach it...)

AliasAlreadyTaken commented

2024-06-05 21:43:22 +02:00

Looks like you need to overwrite both:

areas.registered_protection_conditions = {}
areas.callback_origins = {}

We do not want to disable area size checks, but we have a different way of counting areas. On YL, only "masterareas" count towards the area maximum and the player may have an infinite number of subareas. While maybe native to YL, I do see the usecase for others as well.

Looks like you need to overwrite both: ``` areas.registered_protection_conditions = {} areas.callback_origins = {} ``` We do not want to disable area size checks, but we have a different way of counting areas. On YL, only "masterareas" count towards the area maximum and the player may have an infinite number of subareas. While maybe native to YL, I do see the usecase for others as well.

AliasAlreadyTaken added this to the 1.1.125 milestone 2024-07-31 22:52:25 +02:00

AliasAlreadyTaken referenced this issue from a commit

2024-07-31 22:54:20 +02:00

your-land/bugtracker#6888 Removes only upstream ProtectionCondition

AliasAlreadyTaken referenced this issue from a commit

2024-07-31 23:03:05 +02:00

your-land/bugtracker#6888 Upgrade to registerProtectionCondition

AliasAlreadyTaken commented

2024-07-31 23:45:57 +02:00

QA

All custom conditions now match and only those.

QA All custom conditions now match and only those.