Area open crash #6811

New Issue

AliasAlreadyTaken · 2024-05-16T20:06:44+02:00

AliasAlreadyTaken commented

2024-05-16 20:06:44 +02:00

User Ravise sent /area_open 8974

2024-05-16 17:59:00: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback on_chat_message(): /home/mt/5.8.0/Minetest_live/bin/../mods/areas/internal.lua:377: attempt to index field 'parent' (a number value)
2024-05-16 17:59:00: ERROR[Main]: stack traceback:
2024-05-16 17:59:00: ERROR[Main]: 	/home/mt/5.8.0/Minetest_live/bin/../mods/areas/internal.lua:377: in function 'isOwnerOfMasterArea'
2024-05-16 17:59:00: ERROR[Main]: 	...t/5.8.0/Minetest_live/bin/../mods/areas/chatcommands.lua:319: in function 'func'
2024-05-16 17:59:00: ERROR[Main]: 	...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function 'func'
2024-05-16 17:59:00: ERROR[Main]: 	/home/mt/5.8.0/Minetest_live/bin/../builtin/game/chat.lua:79: in function </home/mt/5.8.0/Minetest_live/bin/../builtin/game/chat.lua:52>
2024-05-16 17:59:00: ERROR[Main]: 	...t/5.8.0/Minetest_live/bin/../builtin/common/register.lua:26: in function <...t/5.8.0/Minetest_live/bin/../builtin/common/register.lua:12>

User Ravise sent `/area_open 8974` ``` 2024-05-16 17:59:00: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback on_chat_message(): /home/mt/5.8.0/Minetest_live/bin/../mods/areas/internal.lua:377: attempt to index field 'parent' (a number value) 2024-05-16 17:59:00: ERROR[Main]: stack traceback: 2024-05-16 17:59:00: ERROR[Main]: /home/mt/5.8.0/Minetest_live/bin/../mods/areas/internal.lua:377: in function 'isOwnerOfMasterArea' 2024-05-16 17:59:00: ERROR[Main]: ...t/5.8.0/Minetest_live/bin/../mods/areas/chatcommands.lua:319: in function 'func' 2024-05-16 17:59:00: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function 'func' 2024-05-16 17:59:00: ERROR[Main]: /home/mt/5.8.0/Minetest_live/bin/../builtin/game/chat.lua:79: in function </home/mt/5.8.0/Minetest_live/bin/../builtin/game/chat.lua:52> 2024-05-16 17:59:00: ERROR[Main]: ...t/5.8.0/Minetest_live/bin/../builtin/common/register.lua:26: in function <...t/5.8.0/Minetest_live/bin/../builtin/common/register.lua:12> ```

AliasAlreadyTaken added the

1. kind/bug

label 2024-05-16 20:07:46 +02:00

AliasAlreadyTaken commented

2024-06-06 04:23:41 +02:00

Issue is in line

		if ((not cur.parent) or (not cur.parent.yl_city)) and cur.owner == name then

of function

function areas:isOwnerOfMasterArea(id, name)

Most likely because cur.parent.yl_city doesn't mean anything.

Issue is in line ``` if ((not cur.parent) or (not cur.parent.yl_city)) and cur.owner == name then ``` of function ``` function areas:isOwnerOfMasterArea(id, name) ``` Most likely because `cur.parent.yl_city` doesn't mean anything.

AliasAlreadyTaken referenced this issue from a commit

2024-06-07 05:33:08 +02:00

your-land/bugtracker#6811 Fixes expression so it detects the onwer of a city

AliasAlreadyTaken added the

4. step/ready to QA test

label 2024-06-07 05:33:17 +02:00

AliasAlreadyTaken added this to the 1.1.125 milestone 2024-06-07 05:33:22 +02:00

AliasAlreadyTaken commented

2024-07-30 00:25:17 +02:00

QA

Fixed, it doesn't crash in this constellation anymore

QA Fixed, it doesn't crash in this constellation anymore