your-land/bugtracker
your-land/bugtracker
41
22
Issues 3.6k Projects 4 Wiki

testserver lua crash in 3d_armor while looking at exevirus' solution for GOIR #6804

New Issue
Open
opened 2024-05-15 22:47:22 +02:00 by AliasAlreadyTaken · 4 comments
AliasAlreadyTaken commented 2024-05-15 22:47:22 +02:00
Owner
Copy Link
2024-05-15 20:39:02: ERROR[Main]: 	[C]: in function 'add_entity'
2024-05-15 20:39:02: ERROR[Main]: 	...st_exevirus/bin/../mods/3d_armor/3d_armor_stand/init.lua:62: in function 'update_entity'
2024-05-15 20:39:02: ERROR[Main]: 	...st_exevirus/bin/../mods/3d_armor/3d_armor_stand/init.lua:398: in function 'func'
2024-05-15 20:39:02: ERROR[Main]: 	...est_exevirus/bin/../builtin/profiler/instrumentation.lua:124: in function <...est_exevirus/bin/../builtin/profiler/instrumentation.lua:117>
``` 2024-05-15 20:39:02: ERROR[Main]: [C]: in function 'add_entity' 2024-05-15 20:39:02: ERROR[Main]: ...st_exevirus/bin/../mods/3d_armor/3d_armor_stand/init.lua:62: in function 'update_entity' 2024-05-15 20:39:02: ERROR[Main]: ...st_exevirus/bin/../mods/3d_armor/3d_armor_stand/init.lua:398: in function 'func' 2024-05-15 20:39:02: ERROR[Main]: ...est_exevirus/bin/../builtin/profiler/instrumentation.lua:124: in function <...est_exevirus/bin/../builtin/profiler/instrumentation.lua:117> ```
AliasAlreadyTaken commented 2024-05-16 00:14:33 +02:00
Author
Owner
Copy Link

This is how it started:

2024-05-15 20:39:00: WARNING[Main]: ServerEnvironment::deactivateFarObjects(): id=15 m_static_exists=true but static data do>
2024-05-15 20:39:00: WARNING[Main]: StaticObjectList::remove(): id=15 not found
2024-05-15 20:39:00: WARNING[Main]: MapBlock::saveStaticObject(): Trying to store id = 0 statically but block (172,3,-31) al>
2024-05-15 20:39:00: WARNING[Main]: MapBlock::saveStaticObject(): Trying to store id = 0 statically but block (172,3,-31) al>
2024-05-15 20:39:00: WARNING[Main]: MapBlock::saveStaticObject(): Trying to store id = 0 statically but block (172,3,-31) al>
This is how it started: ``` 2024-05-15 20:39:00: WARNING[Main]: ServerEnvironment::deactivateFarObjects(): id=15 m_static_exists=true but static data do> 2024-05-15 20:39:00: WARNING[Main]: StaticObjectList::remove(): id=15 not found 2024-05-15 20:39:00: WARNING[Main]: MapBlock::saveStaticObject(): Trying to store id = 0 statically but block (172,3,-31) al> 2024-05-15 20:39:00: WARNING[Main]: MapBlock::saveStaticObject(): Trying to store id = 0 statically but block (172,3,-31) al> 2024-05-15 20:39:00: WARNING[Main]: MapBlock::saveStaticObject(): Trying to store id = 0 statically but block (172,3,-31) al> ```
AliasAlreadyTaken commented 2024-05-16 00:44:38 +02:00
Author
Owner
Copy Link

What exactly did we test? We had a couple of clients (~10) and a lot of entities 5000+ and waited for the server to crash.

repo https://github.com/ExeVirus/minetest.git
branch feature/exevirus_optimize_server_object_lookups
commit d5316f224b4992b48330e6dc3a64f5d0cea1c4b1
What exactly did we test? We had a couple of clients (~10) and a lot of entities 5000+ and waited for the server to crash. ``` repo https://github.com/ExeVirus/minetest.git branch feature/exevirus_optimize_server_object_lookups commit d5316f224b4992b48330e6dc3a64f5d0cea1c4b1 ```
AliasAlreadyTaken added the
1. kind/bug
3. source/engine
3. source/testserver
 labels 2024-05-16 00:52:19 +02:00
Niklp commented 2024-05-16 13:09:16 +02:00
Collaborator
Copy Link

3d_armor issue, I take this one :)

Edit 2024-05-18:
Checked the code, 3d_armor does nothing wrong. This seems to be caused by the new fancy GOIR solution.

3d_armor issue, I take this one :) Edit 2024-05-18: Checked the code, 3d_armor does nothing wrong. This seems to be caused by the new *fancy* GOIR solution.
AliasAlreadyTaken commented 2024-05-19 22:27:11 +02:00
Author
Owner
Copy Link
root@yourland ~ # perf stat -p 207059
^C
 Performance counter stats for process id '207059':

        124,062.84 msec task-clock                       #    1.148 CPUs utilized             
            61,610      context-switches                 #  496.603 /sec                      
             1,175      cpu-migrations                   #    9.471 /sec                      
            47,068      page-faults                      #  379.388 /sec                      
   519,850,790,045      cycles                           #    4.190 GHz                         (36.31%)
   514,162,533,314      instructions                     #    0.99  insn per cycle              (45.44%)
    93,976,563,797      branches                         #  757.492 M/sec                       (45.52%)
     3,316,557,895      branch-misses                    #    3.53% of all branches             (45.52%)
     2,835,982,733      CPU_CLK_UNHALTED.REF_XCLK        #   22.859 M/sec                     
                                                  #     17.9 %  tma_frontend_bound     
                                                  #     25.9 %  tma_retiring           
                                                  #     43.3 %  tma_backend_bound      
                                                  #     13.0 %  tma_bad_speculation      (45.55%)
   351,227,597,899      IDQ_UOPS_NOT_DELIVERED.CORE      #    2.831 G/sec                       (45.50%)
    22,475,437,697      INT_MISC.RECOVERY_CYCLES_ANY     #  181.162 M/sec                       (36.32%)
     2,533,287,789      CPU_CLK_UNHALTED.ONE_THREAD_ACTIVE #   20.419 M/sec                       (36.36%)
   519,564,982,421      CPU_CLK_UNHALTED.THREAD          #    4.188 G/sec                       (36.34%)
   510,107,709,153      UOPS_RETIRED.RETIRE_SLOTS        #    4.112 G/sec                       (36.32%)
   720,029,806,007      UOPS_ISSUED.ANY                  #    5.804 G/sec                       (36.27%)

     108.027256715 seconds time elapsed
``` root@yourland ~ # perf stat -p 207059 ^C Performance counter stats for process id '207059': 124,062.84 msec task-clock # 1.148 CPUs utilized 61,610 context-switches # 496.603 /sec 1,175 cpu-migrations # 9.471 /sec 47,068 page-faults # 379.388 /sec 519,850,790,045 cycles # 4.190 GHz (36.31%) 514,162,533,314 instructions # 0.99 insn per cycle (45.44%) 93,976,563,797 branches # 757.492 M/sec (45.52%) 3,316,557,895 branch-misses # 3.53% of all branches (45.52%) 2,835,982,733 CPU_CLK_UNHALTED.REF_XCLK # 22.859 M/sec # 17.9 % tma_frontend_bound # 25.9 % tma_retiring # 43.3 % tma_backend_bound # 13.0 % tma_bad_speculation (45.55%) 351,227,597,899 IDQ_UOPS_NOT_DELIVERED.CORE # 2.831 G/sec (45.50%) 22,475,437,697 INT_MISC.RECOVERY_CYCLES_ANY # 181.162 M/sec (36.32%) 2,533,287,789 CPU_CLK_UNHALTED.ONE_THREAD_ACTIVE # 20.419 M/sec (36.36%) 519,564,982,421 CPU_CLK_UNHALTED.THREAD # 4.188 G/sec (36.34%) 510,107,709,153 UOPS_RETIRED.RETIRE_SLOTS # 4.112 G/sec (36.32%) 720,029,806,007 UOPS_ISSUED.ANY # 5.804 G/sec (36.27%) 108.027256715 seconds time elapsed ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/possible close

Should be closed, but a second opinion is asked

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/possible close
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6804
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?