your-land/bugtracker
your-land/bugtracker
41
22
Issues 3.6k Projects 4 Wiki

590: API change in set_physics_override #6733

New Issue
Closed
opened 2024-04-28 00:57:02 +02:00 by AliasAlreadyTaken · 8 comments
AliasAlreadyTaken commented 2024-04-28 00:57:02 +02:00
Owner
Copy Link

Looks like the API doesn't accept a call like set_physics_override(1,1,1) anymore but demands a table instead. Happens in

your-land/bugtracker#6726

Also affected: cottages sleeping mat and maybe more mods

Looks like the API doesn't accept a call like set_physics_override(1,1,1) anymore but demands a table instead. Happens in your-land/bugtracker#6726 Also affected: cottages sleeping mat and maybe more mods
AliasAlreadyTaken added the
1. kind/bug
2. prio/critical
 labels 2024-04-28 00:57:10 +02:00
AliasAlreadyTaken added this to the minetest 5.9.0 milestone 2024-04-28 00:57:12 +02:00
Niklp commented 2024-04-28 21:02:23 +02:00
Collaborator
Copy Link

Crosspost from the Archtec bugtracker https://github.com/Archtec-io/bugtracker/issues/179

Crosspost from the Archtec bugtracker https://github.com/Archtec-io/bugtracker/issues/179
AliasAlreadyTaken commented 2024-04-30 18:30:27 +02:00
Author
Owner
Copy Link

We probably should ask rubenwardy to read out from the content DB where the "old" (read: wrong) style is used and then poke maintainers.

We probably should ask rubenwardy to read out from the content DB where the "old" (read: wrong) style is used and then poke maintainers.
AliasAlreadyTaken commented 2024-04-30 18:40:13 +02:00
Author
Owner
Copy Link

In the YL solution, set_physics_override is used in 31 places:

  • 3d_armor looks ok
  • airutils looks ok
  • beds looks ok
  • cheese looks ok
  • cottages NOK
  • cucina_vegana looks ok
  • digistuff looks ok
  • limit-physics-monoid looks ok
  • smartshop looks ok
  • petz looks ok
  • pipeworks: only adds that for the fake player
  • player-monoids: looks ok
  • stamina: looks ok
  • ts_furniture: NOK
In the YL solution, set_physics_override is used in 31 places: * [ ] 3d_armor looks ok * [ ] airutils looks ok * [ ] beds looks ok * [ ] cheese looks ok * [ ] cottages NOK * [ ] cucina_vegana looks ok * [ ] digistuff looks ok * [ ] limit-physics-monoid looks ok * [ ] smartshop looks ok * [ ] petz looks ok * [ ] pipeworks: only adds that for the fake player * [ ] player-monoids: looks ok * [ ] stamina: looks ok * [x] ts_furniture: NOK
Niklp commented 2024-04-30 18:55:13 +02:00
Collaborator
Copy Link

We probably should ask rubenwardy to read out from the content DB where the "old" (read: wrong) style is used and then poke maintainers.

I linked already to a zipgrep on the Archtec bugtracker two days ago 🙃

> We probably should ask rubenwardy to read out from the content DB where the "old" (read: wrong) style is used and then poke maintainers. I linked already to a zipgrep on the Archtec bugtracker two days ago 🙃
👍 1 😆 1
AliasAlreadyTaken commented 2024-08-15 17:50:28 +02:00
Author
Owner
Copy Link

We are using set_physics_override in 34 places over 19 files:

  • airutils/lib_planes/utilities.lua:139: --player:set_physics_override({speed = 1, jump = 1, gravity = 1, sneak = true})
  • 3d_armor/3d_armor/README.md:344:Note: The player physics modifications won't be applied via set_physics_override if player_physics_locked is set to 1 in the respective player's meta.
  • 3d_armor/3d_armor/api.lua:520: player:set_physics_override(physics)
  • yl_commons/bugfixes/eye_height.lua:50: player:set_physics_override({speed = 0, jump = 0, gravity = 0})
  • yl_commons/bugfixes/eye_height.lua:79: player:set_physics_override({speed = 1, jump = 1, gravity = 1})
  • cheese/fantasy_effects.lua:11: player:set_physics_override({[attribute]=value})
  • cheese/fantasy_effects.lua:18: player:set_physics_override({[attribute]=1})
  • cheese/player_effect_init.lua:129: player:set_physics_override({[attribute]=value})
  • cheese/player_effect_init.lua:136: player:set_physics_override({[attribute]=1})
  • ts_furniture/init.lua:44: player:set_physics_override({speed = 0, jump = 0, gravity = 0})
  • ts_furniture/init.lua:71: player:set_physics_override({speed = 1, jump = 1, gravity = 1})
  • minetest-limit_physics_monoids/init.lua:53: player:set_physics_override(ov)
  • minetest-limit_physics_monoids/init.lua:63: player:set_physics_override(ov)
  • minetest-limit_physics_monoids/init.lua:73: player:set_physics_override(ov)
  • stamina/init.lua:290: player:set_physics_override(def)
  • beds/functions.lua:77: player:set_physics_override({
  • beds/functions.lua:129: player:set_physics_override({speed = 0, jump = 0, gravity = 0})
  • petz/petz/misc/lycanthropy.lua:187: player:set_physics_override(lycanthropy.werewolf.override_table)
  • petz/petz/misc/lycanthropy.lua:209: player:set_physics_override(minetest.deserialize(override_table))
  • fakelib/player.lua:464: "set_nametag_attributes", "set_physics_override",
  • player_monoids/README.md:51: player:set_physics_override(override)
  • player_monoids/standard_monoids.lua:48: player:set_physics_override(ov)
  • player_monoids/standard_monoids.lua:62: player:set_physics_override(ov)
  • player_monoids/standard_monoids.lua:74: player:set_physics_override(ov)
  • digistuff/controller.lua:32: player:set_physics_override({speed = 1,jump = 1,})
  • cottages/nodes_furniture.lua:405: clicker:set_physics_override(1, 1, 1)
  • cottages/nodes_furniture.lua:423: clicker:set_physics_override(0, 0, 0)
  • cottages/nodes_furniture.lua:453: clicker:set_physics_override(1, 1, 1)
  • cottages/nodes_furniture.lua:554: clicker:set_physics_override(1, 1, 1)
  • cottages/nodes_furniture.lua:565: clicker:set_physics_override(0, 0, 0)
  • cucina_vegana/lib.lua:109: playerobject:set_physics_override({speed = highspeed})
  • cucina_vegana/lib.lua:124: playerobject:set_physics_override({speed = normalspeed})
  • minetest-smartshop/tests/initialize.lua:43: player:set_physics_override({
We are using `set_physics_override` in 34 places over 19 files: * [x] airutils/lib_planes/utilities.lua:139: --player:set_physics_override({speed = 1, jump = 1, gravity = 1, sneak = true}) * [x] 3d_armor/3d_armor/README.md:344:*Note: The player physics modifications won't be applied via `set_physics_override` if `player_physics_locked` is set to 1 in the respective player's meta.* * [x] 3d_armor/3d_armor/api.lua:520: player:set_physics_override(physics) * [x] yl_commons/bugfixes/eye_height.lua:50: player:set_physics_override({speed = 0, jump = 0, gravity = 0}) * [x] yl_commons/bugfixes/eye_height.lua:79: player:set_physics_override({speed = 1, jump = 1, gravity = 1}) * [x] cheese/fantasy_effects.lua:11: player:set_physics_override({[attribute]=value}) * [x] cheese/fantasy_effects.lua:18: player:set_physics_override({[attribute]=1}) * [x] cheese/player_effect_init.lua:129: player:set_physics_override({[attribute]=value}) * [x] cheese/player_effect_init.lua:136: player:set_physics_override({[attribute]=1}) * [x] ts_furniture/init.lua:44: player:set_physics_override({speed = 0, jump = 0, gravity = 0}) * [x] ts_furniture/init.lua:71: player:set_physics_override({speed = 1, jump = 1, gravity = 1}) * [x] minetest-limit_physics_monoids/init.lua:53: player:set_physics_override(ov) * [x] minetest-limit_physics_monoids/init.lua:63: player:set_physics_override(ov) * [x] minetest-limit_physics_monoids/init.lua:73: player:set_physics_override(ov) * [x] stamina/init.lua:290: player:set_physics_override(def) * [x] beds/functions.lua:77: player:set_physics_override({ * [x] beds/functions.lua:129: player:set_physics_override({speed = 0, jump = 0, gravity = 0}) * [x] petz/petz/misc/lycanthropy.lua:187: player:set_physics_override(lycanthropy.werewolf.override_table) * [x] petz/petz/misc/lycanthropy.lua:209: player:set_physics_override(minetest.deserialize(override_table)) * [x] fakelib/player.lua:464: "set_nametag_attributes", "set_physics_override", * [x] player_monoids/README.md:51: player:set_physics_override(override) * [x] player_monoids/standard_monoids.lua:48: player:set_physics_override(ov) * [x] player_monoids/standard_monoids.lua:62: player:set_physics_override(ov) * [x] player_monoids/standard_monoids.lua:74: player:set_physics_override(ov) * [x] digistuff/controller.lua:32: player:set_physics_override({speed = 1,jump = 1,}) * [ ] cottages/nodes_furniture.lua:405: clicker:set_physics_override(1, 1, 1) * [ ] cottages/nodes_furniture.lua:423: clicker:set_physics_override(0, 0, 0) * [ ] cottages/nodes_furniture.lua:453: clicker:set_physics_override(1, 1, 1) * [ ] cottages/nodes_furniture.lua:554: clicker:set_physics_override(1, 1, 1) * [ ] cottages/nodes_furniture.lua:565: clicker:set_physics_override(0, 0, 0) * [x] cucina_vegana/lib.lua:109: playerobject:set_physics_override({speed = highspeed}) * [x] cucina_vegana/lib.lua:124: playerobject:set_physics_override({speed = normalspeed}) * [x] minetest-smartshop/tests/initialize.lua:43: player:set_physics_override({
AliasAlreadyTaken commented 2024-08-15 19:49:23 +02:00
Author
Owner
Copy Link

The only mod that was not fixed at the time of QA was cottages, which is pending a huge PR by flux. So I fixed in the yl_stable branch.

The only mod that was not fixed at the time of QA was cottages, which is pending a huge PR by flux. So I fixed in the yl_stable branch.
AliasAlreadyTaken added the
4. step/ready to QA test
4. step/QA OK
 labels 2024-08-15 19:54:46 +02:00
AliasAlreadyTaken commented 2024-08-15 19:55:05 +02:00
Author
Owner
Copy Link

QA

At least it doesn't crash anymore :D

QA At least it doesn't crash anymore :D
AliasAlreadyTaken commented 2025-03-08 18:07:19 +01:00
Author
Owner
Copy Link

All positions were replaced, cottages has a PR. At least it doesn't crash anymore :D

All positions were replaced, cottages has a PR. At least it doesn't crash anymore :D
AliasAlreadyTaken added the
5. result/fixed
 label 2025-03-08 18:07:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/petz

yet another petz bugz.

  
3. source/testserver

Originates on the testserver, no effect on main yet

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/possible close

Should be closed, but a second opinion is asked

  
4. step/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
4. step/QA NOK

Fix didn't yield the expected results

  
4. step/QA OK

tested

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
kind/standalone

issues that don't depend on internal access and can be implemented as a stand-alone project

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/petz
3. source/testserver
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/possible close
4. step/QA main
4. step/QA NOK
4. step/QA OK
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
kind/standalone
Milestone
Clear milestone
No items
No Milestone
minetest 5.9.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6733
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?