debian44 reports: Dupe: If a cottages:pitchfork ... #670

New Issue

yourland-report · 2021-06-26T06:27:46Z

yourland-report commented

2021-06-26 06:27:46 +00:00

debian44 reports a bug:

Dupe: If a cottages:pitchfork is placed and digged again very fast, it just dupes randomly.

Player position:

{
	y = 17.5,
	x = -1591.2430419922,
	z = 1505.9530029297
}

Player look:

{
	y = -0.76480895280838,
	x = -0.55636221170425,
	z = 0.324851334095
}

Player information:

{
	min_rtt = 0.0089999996125698,
	max_rtt = 0.061999998986721,
	connection_uptime = 946,
	max_jitter = 0.052000001072884,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.0099999997764826,
	state = "Active",
	avg_jitter = 0.0010000001639128,
	min_jitter = 0,
	address = "::ffff:79.227.114.58"
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 7780\", \"3d_armor:chestplate_crystal 1 7780\", \"shields:shield_crystal 1 7780\", \"3d_armor:boots_crystal 1 7780\", \"3d_armor:leggings_crystal 1 7780\", \"\"}",
		yl_commons_thankyou = "15",
		jointime = "1618588574",
		yl_commons_player_joined = "1624687938",
		["signslib:pos"] = "(2137,19,1136)",
		digged_nodes = "353044",
		bitten = "0",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 10, [\"x\"] = 1807, [\"z\"] = 1502}, [\"last_heal\"] = 1622882700, [\"last_death_portal\"] = 1624637352}",
		["stamina:level"] = "12",
		punch_count = "16809",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "191704",
		crafted = "32635",
		played_time = "2020139",
		xp = "248277",
		placed_nodes = "135386",
		died = "187",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1618588574"
	}
}

Log identifier


[MOD] yl_report log identifier = yEVCa9TUDwBvlUGquPZvzF3eMQ74OReR

Profiler save:

profile-20210626T082746.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=272984, max_lag=1.6683, clients={debian44, Xonon, wishingirl, Yumpy, Papi, AliasAlreadyTaken, Bailiff, DeepDweller, Service}

debian44 reports a bug: > Dupe: If a cottages:pitchfork is placed and digged again very fast, it just dupes randomly. Player position: ``` { y = 17.5, x = -1591.2430419922, z = 1505.9530029297 } ``` Player look: ``` { y = -0.76480895280838, x = -0.55636221170425, z = 0.324851334095 } ``` Player information: ``` { min_rtt = 0.0089999996125698, max_rtt = 0.061999998986721, connection_uptime = 946, max_jitter = 0.052000001072884, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.0099999997764826, state = "Active", avg_jitter = 0.0010000001639128, min_jitter = 0, address = "::ffff:79.227.114.58" } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 7780\", \"3d_armor:chestplate_crystal 1 7780\", \"shields:shield_crystal 1 7780\", \"3d_armor:boots_crystal 1 7780\", \"3d_armor:leggings_crystal 1 7780\", \"\"}", yl_commons_thankyou = "15", jointime = "1618588574", yl_commons_player_joined = "1624687938", ["signslib:pos"] = "(2137,19,1136)", digged_nodes = "353044", bitten = "0", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 10, [\"x\"] = 1807, [\"z\"] = 1502}, [\"last_heal\"] = 1622882700, [\"last_death_portal\"] = 1624637352}", ["stamina:level"] = "12", punch_count = "16809", arenalib_infobox_arenaID = "0", inflicted_damage = "191704", crafted = "32635", played_time = "2020139", xp = "248277", placed_nodes = "135386", died = "187", hud_state = "on", repellant = "0", yl_commons_player_created = "1618588574" } } ``` Log identifier ``` [MOD] yl_report log identifier = yEVCa9TUDwBvlUGquPZvzF3eMQ74OReR ``` Profiler save: ``` profile-20210626T082746.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=272984, max_lag=1.6683, clients={debian44, Xonon, wishingirl, Yumpy, Papi, AliasAlreadyTaken, Bailiff, DeepDweller, Service} ```

AliasAlreadyTaken was assigned by yourland-report

2021-06-26 06:27:46 +00:00

whosit added the

1. kind/bug

label 2021-06-28 17:43:53 +00:00

AliasAlreadyTaken commented

2021-07-17 04:21:20 +00:00

Hi,

looks like I cannot reproduce the bug, can you show me again how to do it?

Gretings, Alias

Hi, looks like I cannot reproduce the bug, can you show me again how to do it? Gretings, Alias

AliasAlreadyTaken added the

4. step/question

label 2021-07-17 04:21:39 +00:00

AliasAlreadyTaken commented

2021-07-18 05:09:46 +00:00

Compare #717

AliasAlreadyTaken referenced this issue

2021-07-18 05:09:56 +00:00

putting a cottages:pitchfork in an item frame duplicates it #717

Styxcolor self-assigned this 2021-11-03 03:27:50 +00:00

flux commented

2022-05-28 18:26:39 +00:00

I cannot reproduce this. Possibly this was just lag? I can't reproduce it when there's lag either, though.

Suggest: source/lag and result/cannot reproduce.

I cannot reproduce this. Possibly this was just lag? I can't reproduce it when there's lag either, though. Suggest: `source/lag` and `result/cannot reproduce`.

flux added the

4. step/want approval

label 2022-05-29 00:25:53 +00:00

AliasAlreadyTaken commented

2022-06-06 09:08:27 +00:00

I can reproduce if I place and dig in quick succession. From the dtimes you can see there is no terrible lag.

2022-06-06 11-06-12.mp4

3.1 MiB

flux removed the

4. step/want approval

label 2022-06-06 15:49:04 +00:00

flux commented

2022-06-06 19:00:07 +00:00

I was able to replicate this too now, and the fix to #717 doesn't change this behavior.

flux commented

2022-06-06 19:22:00 +00:00

I pushed some code to yl_commons that I think fixes the issue, though I never really found a great way to replicate the duplication reliably. 8996fa3a25

Alias, could you test whether the duplication still happens when using that commit?

I pushed some code to yl_commons that I *think* fixes the issue, though I never really found a great way to replicate the duplication reliably. https://gitea.your-land.de/your-land/yl_commons/commit/8996fa3a25576bcdbbd4fab49b5910a11386f171 Alias, could you test whether the duplication still happens when using that commit?

AliasAlreadyTaken commented

2022-06-07 10:24:09 +00:00

In a low lag environment it seems to be fixed :)

AliasAlreadyTaken added this to the 1.1.112 milestone 2022-06-07 10:24:14 +00:00

AliasAlreadyTaken added the

4. step/ready to QA test

label 2022-06-07 10:24:19 +00:00

flux commented

2022-06-07 16:03:14 +00:00

seems fine to me, and live now.

flux closed this issue

2022-06-07 16:03:14 +00:00