noodles reports: castle_farming:bound_straw ... ... #668

New Issue

yourland-report · 2021-06-25T00:55:44Z

yourland-report commented

2021-06-25 00:55:44 +00:00

noodles reports a bug:

castle_farming:bound_straw ... recipe collision ... ( [1] bound_straw --> farming:straw ), and also ( [1] bound_straw --> [3] cottages:straw_mat ). I think the second recipe should be changed to [2] bound_straw --> [6] straw_mat.

Player position:

{
	y = 19.5,
	x = -30906.185546875,
	z = 30920.677734375
}

Player look:

{
	y = -0.47085791826248,
	x = -0.24967405200005,
	z = -0.84614163637161
}

Player information:

{
	min_rtt = 0.1330000013113,
	max_rtt = 1.2450000047684,
	connection_uptime = 2514,
	max_jitter = 1.0989999771118,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.13699999451637,
	state = "Active",
	avg_jitter = 0.0069999992847443,
	min_jitter = 0,
	address = "::ffff:74.132.138.131"
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 17340\", \"shields:shield_crystal 1 17340\", \"3d_armor:chestplate_crystal 1 17340\", \"3d_armor:leggings_crystal 1 17340\", \"3d_armor:boots_crystal 1 17340\", \"\"}",
		played_time = "1400641",
		jointime = "1614625622",
		yl_commons_player_joined = "1624580075",
		["signslib:pos"] = "(3186,72,-710)",
		digged_nodes = "248844",
		bitten = "0",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -8, [\"x\"] = -30876, [\"z\"] = 30887}, [\"last_death_portal\"] = 1624248421}",
		["stamina:level"] = "13",
		punch_count = "16190",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "193388",
		crafted = "8166",
		placed_nodes = "93295",
		yl_commons_thankyou = "3",
		xp = "240132",
		died = "28",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1614625622"
	}
}

Log identifier


[MOD] yl_report log identifier = jMGt5F57ewyqkp2440bdZEjv5SuO9DlL

Profiler save:

profile-20210625T025544.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=166813, max_lag=1.19745, clients={Sparkles, Diaeresis, noodles, Bailiff, AliasAlreadyTaken, Service, Probator}

noodles reports a bug: > castle_farming:bound_straw ... recipe collision ... ( [1] bound_straw --> farming:straw ), and also ( [1] bound_straw --> [3] cottages:straw_mat ). I think the second recipe should be changed to [2] bound_straw --> [6] straw_mat. Player position: ``` { y = 19.5, x = -30906.185546875, z = 30920.677734375 } ``` Player look: ``` { y = -0.47085791826248, x = -0.24967405200005, z = -0.84614163637161 } ``` Player information: ``` { min_rtt = 0.1330000013113, max_rtt = 1.2450000047684, connection_uptime = 2514, max_jitter = 1.0989999771118, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.13699999451637, state = "Active", avg_jitter = 0.0069999992847443, min_jitter = 0, address = "::ffff:74.132.138.131" } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 17340\", \"shields:shield_crystal 1 17340\", \"3d_armor:chestplate_crystal 1 17340\", \"3d_armor:leggings_crystal 1 17340\", \"3d_armor:boots_crystal 1 17340\", \"\"}", played_time = "1400641", jointime = "1614625622", yl_commons_player_joined = "1624580075", ["signslib:pos"] = "(3186,72,-710)", digged_nodes = "248844", bitten = "0", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = -8, [\"x\"] = -30876, [\"z\"] = 30887}, [\"last_death_portal\"] = 1624248421}", ["stamina:level"] = "13", punch_count = "16190", arenalib_infobox_arenaID = "0", inflicted_damage = "193388", crafted = "8166", placed_nodes = "93295", yl_commons_thankyou = "3", xp = "240132", died = "28", hud_state = "on", repellant = "0", yl_commons_player_created = "1614625622" } } ``` Log identifier ``` [MOD] yl_report log identifier = jMGt5F57ewyqkp2440bdZEjv5SuO9DlL ``` Profiler save: ``` profile-20210625T025544.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=166813, max_lag=1.19745, clients={Sparkles, Diaeresis, noodles, Bailiff, AliasAlreadyTaken, Service, Probator} ```

AliasAlreadyTaken was assigned by yourland-report

2021-06-25 00:55:44 +00:00

whosit added the

3. source/integration

label 2021-06-29 07:52:10 +00:00

Styxcolor self-assigned this 2021-11-16 14:10:22 +00:00

Styxcolor commented

2021-11-16 14:48:55 +00:00

I needed a bit to get used to all the different uses of the straws in question. I realized there was indeed a recipe missing that gives you back farming:straw for your castle_farming:bound_straw. From a developer point of view it was easier to sneak in a new crafting recipe for 8 farming:straws out of two castle_farming:straws than to change the cottage recipe as I would have to clear all and reinsert all other recipes, too.

While my solution does not follow the suggested path, it functionally bridges the undesired gap in the straw item conversion cycle. It's not ideal, but it's a full cycle now and I hope it is what noodles and the other players wanted!

I needed a bit to get used to all the different uses of the straws in question. I realized there was indeed a recipe missing that gives you back farming:straw for your castle_farming:bound_straw. From a developer point of view it was easier to sneak in a new crafting recipe for 8 farming:straws out of two castle_farming:straws than to change the cottage recipe as I would have to clear all and reinsert all other recipes, too. While my solution does not follow the suggested path, it functionally bridges the undesired gap in the straw item conversion cycle. It's not ideal, but it's a full cycle now and I hope it is what noodles and the other players wanted!

Styxcolor commented

2021-11-16 14:50:46 +00:00

Fixed in:
commit 565d0e1878039edd1f151f89db73c83356aca235

Fixed in: commit 565d0e1878039edd1f151f89db73c83356aca235

Styxcolor added the

5. result/fixed

label 2021-11-16 14:50:52 +00:00

AliasAlreadyTaken was unassigned by Styxcolor

2021-11-16 14:50:57 +00:00

Styxcolor added this to the 1.1.100 milestone 2021-11-16 14:50:59 +00:00

Styxcolor closed this issue

2021-11-16 14:51:02 +00:00