AspireMint reports: Destroying lead with electrume ... #6578

New Issue

yourland-report · 2024-03-27T17:12:13Z

yourland-report commented

2024-03-27 17:12:13 +00:00

AspireMint reports a bug:

Destroying lead with electrumese sword (explosion) in MY area shows: "This block is protected! Your hit glancied off of the protection and turned you around."

Player position:

{
	y = 18,
	z = 1175.1989746094,
	x = 1982.6989746094
}

Player look:

{
	y = -0.84141647815704,
	z = -0.023477051407099,
	x = -0.53987693786621
}

Player information:

{
	formspec_version = 6,
	max_rtt = 1.7680000066757,
	major = 5,
	version_string = "5.7.0",
	ip_version = 6,
	min_rtt = 0.025000000372529,
	avg_rtt = 0.027000000700355,
	min_jitter = 0,
	max_jitter = 0.78100001811981,
	avg_jitter = 0.0010000001639128,
	connection_uptime = 4331,
	lang_code = "",
	patch = 0,
	protocol_version = 42,
	state = "Active",
	serialization_version = 29,
	minor = 7
}

Player meta:

{
	fields = {
		["petz:werewolf"] = "0",
		partychat = "party",
		["petz:lycanthropy"] = "1",
		arenalib_infobox_arenaID = "0",
		["signslib:pos"] = "(-428,56,21498)",
		hotbar_size = "16",
		yl_commons_player_joined = "1711555259",
		crafted = "158777",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}",
		["stamina:level"] = "16",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 29000, [\"z\"] = 20414, [\"x\"] = -82}, [\"last_death_portal\"] = 1711392041, [\"last_heal\"] = 1708702962}",
		["stamina:poisoned"] = "no",
		jointime = "1619715757",
		bitten = "0",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 1900\", \"3d_armor:chestplate_nether 1 3800\", \"3d_armor:leggings_nether 1 13960\", \"shields:shield_nether 1 3800\", \"3d_armor:boots_crystal 1 1900\", \"\"}",
		hud_state = "on",
		played_time = "7708036",
		digged_nodes = "2175376",
		placed_nodes = "409363",
		died = "395",
		yl_commons_player_created = "1619715757",
		xp = "2263504",
		yl_commons_thankyou = "329",
		["stamina:exhaustion"] = "39",
		inflicted_damage = "12642684",
		repellant = "0",
		punch_count = "584586",
		["ocean_build.last_warning"] = "1.65674e+09",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		["petz:werewolf_clan_idx"] = "3"
	}
}

Log identifier


[MOD] yl_report log identifier = t7kQZOzqeYLvcX5cDTATgrC62sW4y0Gs

Profiler save:

profile-20240327T171213.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 3d 4h 6min 55s | max lag: 1.53s | clients (16/52): AliasAlreadyTaken, AspireMint, Bailiff, Boot, DannyVimaranes, flux, Keya, LeetPeet, Lucien, Murmel, nixOS, Noii, pifo, poppyasdan, rheo, Tute

Teleport command:

/teleport xyz 1983 18 1175

Compass command:

/give_compass Construction t7kQZOzqeYLvcX5cDTATgrC62sW4y0Gs D2691E 1983 18 1175

AspireMint reports a bug: > Destroying lead with electrumese sword (explosion) in MY area shows: "This block is protected! Your hit glancied off of the protection and turned you around." Player position: ``` { y = 18, z = 1175.1989746094, x = 1982.6989746094 } ``` Player look: ``` { y = -0.84141647815704, z = -0.023477051407099, x = -0.53987693786621 } ``` Player information: ``` { formspec_version = 6, max_rtt = 1.7680000066757, major = 5, version_string = "5.7.0", ip_version = 6, min_rtt = 0.025000000372529, avg_rtt = 0.027000000700355, min_jitter = 0, max_jitter = 0.78100001811981, avg_jitter = 0.0010000001639128, connection_uptime = 4331, lang_code = "", patch = 0, protocol_version = 42, state = "Active", serialization_version = 29, minor = 7 } ``` Player meta: ``` { fields = { ["petz:werewolf"] = "0", partychat = "party", ["petz:lycanthropy"] = "1", arenalib_infobox_arenaID = "0", ["signslib:pos"] = "(-428,56,21498)", hotbar_size = "16", yl_commons_player_joined = "1711555259", crafted = "158777", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}", ["stamina:level"] = "16", yl_church = "return {[\"last_death\"] = {[\"y\"] = 29000, [\"z\"] = 20414, [\"x\"] = -82}, [\"last_death_portal\"] = 1711392041, [\"last_heal\"] = 1708702962}", ["stamina:poisoned"] = "no", jointime = "1619715757", bitten = "0", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 1900\", \"3d_armor:chestplate_nether 1 3800\", \"3d_armor:leggings_nether 1 13960\", \"shields:shield_nether 1 3800\", \"3d_armor:boots_crystal 1 1900\", \"\"}", hud_state = "on", played_time = "7708036", digged_nodes = "2175376", placed_nodes = "409363", died = "395", yl_commons_player_created = "1619715757", xp = "2263504", yl_commons_thankyou = "329", ["stamina:exhaustion"] = "39", inflicted_damage = "12642684", repellant = "0", punch_count = "584586", ["ocean_build.last_warning"] = "1.65674e+09", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", ["petz:werewolf_clan_idx"] = "3" } } ``` Log identifier ``` [MOD] yl_report log identifier = t7kQZOzqeYLvcX5cDTATgrC62sW4y0Gs ``` Profiler save: ``` profile-20240327T171213.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 3d 4h 6min 55s | max lag: 1.53s | clients (16/52): AliasAlreadyTaken, AspireMint, Bailiff, Boot, DannyVimaranes, flux, Keya, LeetPeet, Lucien, Murmel, nixOS, Noii, pifo, poppyasdan, rheo, Tute ``` Teleport command: ``` /teleport xyz 1983 18 1175 ``` Compass command: ``` /give_compass Construction t7kQZOzqeYLvcX5cDTATgrC62sW4y0Gs D2691E 1983 18 1175 ```

AliasAlreadyTaken was assigned by yourland-report

2024-03-27 17:12:13 +00:00

flux added the

1. kind/bug

3. source/unknown

labels 2024-03-27 20:39:52 +00:00

flux commented

2024-03-27 20:40:48 +00:00

wait, what? per #6462, leashes aren't protected from explosions even in (other players') protection areas! did someone fix that somehow? i wrote a fix for that but haven't even PR'ed upstream yet.

flux added the

4. step/needs confirmation

label 2024-03-27 20:48:04 +00:00

flux commented

2024-03-27 20:50:47 +00:00

i can't replicate this.

if i'm not the owner of the area, the electrumese sword explosion removes the lead, but triggers a protection violation because it tries to destroy protected nodes.
if i am the owner of the area, the electrumese sword explosion destroys stuff, i get the lead in my inventory (?!), and no protection violation is triggered
if i'm not the owner of the area, and punch the lead, that triggers a protection violation
if i'm not the owner of the area, and try to attach a lead, that triggers a protection violation.

i can't replicate this. * if i'm not the owner of the area, the electrumese sword explosion removes the lead, but triggers a protection violation because it tries to destroy protected nodes. * if i *am* the owner of the area, the electrumese sword explosion destroys stuff, i get the lead in my inventory (?!), and no protection violation is triggered * if i'm not the owner of the area, and punch the lead, that triggers a protection violation * if i'm not the owner of the area, and try to attach a lead, that triggers a protection violation.

flux commented

2024-03-27 20:58:49 +00:00

AspireMint showed me that it requires having the explosion hit the middle of the leash not the attached ends. in that case, i get the protection violation message, and the leash ends up in my inventory

AspireMint showed me that it requires having the explosion hit the *middle* of the leash not the attached ends. in that case, i get the protection violation message, and the leash ends up in my inventory

flux added

3. source/mod upstream

and removed

4. step/needs confirmation

labels 2024-03-27 20:59:03 +00:00

flux commented

2024-03-27 21:13:07 +00:00

rheo can blow it up w/out the message though.

flux commented

2024-03-27 21:30:15 +00:00

figured it out, more or less.

3fad55a571/util.lua (L248-L262)
https://gitea.your-land.de/your-land/leads/src/branch/main/internal.lua#L87-L93

when a player breaks the lead, the mod temporarily causes everything to be protected for that player. my suspicion is that the explosion isn't yet done causing damage ... though it should only affect entities after trying to destroy the nodes, so that shouldn't be it? and the only other entity in the area would be the bullet itself, which doesn't do any protection checks?

figured it out, more or less. https://gitea.your-land.de/your-land/leads/src/commit/3fad55a57195e082128a2bc0754c32e1e67ffc71/util.lua#L248-L262 https://gitea.your-land.de/your-land/leads/src/branch/main/internal.lua#L87-L93 when a player breaks the lead, the mod temporarily causes *everything* to be protected for that player. my suspicion is that the explosion isn't yet done causing damage ... though it should only affect entities after trying to destroy the nodes, so that shouldn't be it? and the only other entity in the area would be the bullet itself, which doesn't do any protection checks?

flux added

3. source/integration

and removed

3. source/unknown

labels 2024-03-27 21:30:32 +00:00

flux commented

2024-03-27 21:48:22 +00:00

oh, this only happens if the explosion is large enough to also damage the "knots" after damaging the "lead" (the rope between the knots). thanks, debug.traceback().

also this happens even in unprotected areas.

oh, this only happens if the explosion is large enough to also damage the "knots" after damaging the "lead" (the rope between the knots). thanks, `debug.traceback()`. also this happens even in unprotected areas.

flux referenced this issue

2024-03-28 01:23:38 +00:00

Jammy reports: leashes fly away when hit by e ... #6462

flux added this to the flux's TODO list project 2024-04-05 21:45:08 +00:00

flux added the

4. step/at work

label 2024-04-05 21:45:13 +00:00

Sign in to join this conversation.