whosit reports: normal digistuff:touchscreen s ... #6510

New Issue

yourland-report · 2024-03-17T08:49:45Z

yourland-report commented

2024-03-17 08:49:45 +00:00

whosit reports a bug:

normal digistuff:touchscreen says "can be placed only by staff"

Player position:

{
	y = 7.5,
	z = 30089.79296875,
	x = 25100.287109375
}

Player look:

{
	y = -0.99631541967392,
	z = 0.080551445484161,
	x = 0.029445761814713
}

Player information:

{
	max_rtt = 3.5910000801086,
	minor = 8,
	formspec_version = 7,
	avg_jitter = 0,
	version_string = "5.8.0",
	ip_version = 6,
	min_rtt = 0.041000001132488,
	avg_rtt = 0.043999999761581,
	min_jitter = 0,
	max_jitter = 2.9210000038147,
	major = 5,
	connection_uptime = 7912,
	serialization_version = 29,
	patch = 0,
	lang_code = "",
	protocol_version = 42,
	state = "Active"
}

Player meta:

{
	fields = {
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		played_time = "9315550",
		digged_nodes = "354055",
		placed_nodes = "101381",
		died = "791",
		crafted = "87956",
		yl_commons_player_created = "1615221933",
		yl_commons_player_joined = "1710657492",
		bitten = "0",
		lagometer = "1",
		["petz:werewolf"] = "1",
		["stamina:level"] = "9",
		["petz:lycanthropy"] = "1",
		["stamina:poisoned"] = "no",
		yl_commons_thankyou = "302",
		["stamina:exhaustion"] = "109.5",
		arenalib_infobox_arenaID = "0",
		["petz:werewolf_vignette_id"] = "20",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		repellant = "0",
		["petz:werewolf_clan_idx"] = "3",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 1300\", \"3d_armor:boots_crystal 1 1300\", \"3d_armor:leggings_crystal 1 1300\", \"shields:shield_crystal 1 1300\", \"3d_armor:chestplate_crystal 1 1300\", \"\"}",
		xp_redo_hud_color = "0x0000ff",
		hud_state = "on",
		xp = "205827",
		["petz:pre_werewolf_animation"] = "return {[\"animation\"] = \"stand\", [\"animation_speed\"] = 30, [\"model\"] = \"skinsdb_3d_armor_character_5.b3d\", [\"textures\"] = {\"blank.png\", \"character.warrior_m1.png\", \"3d_armor_trans.png^3d_armor_helmet_crystal.png^3d_armor_boots_crystal.png^3d_armor_leggings_crystal.png^shields_shield_crystal.png^3d_armor_chestplate_crystal.png\", \"3d_armor_trans.png\"}}",
		partychat = "party",
		["signslib:pos"] = "(2181,22,1163)",
		hotbar_size = "16",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 29226, [\"z\"] = 1497, [\"x\"] = 1742}, [\"last_death_portal\"] = 1710628547, [\"last_heal\"] = 1708284048}",
		punch_count = "41250",
		jointime = "1615221933",
		inflicted_damage = "636090"
	}
}

Log identifier


[MOD] yl_report log identifier = BqP8K19JjdL6LZ9t3ZWdwq0VdijrywxD

Profiler save:

profile-20240317T084945.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 16h 49min 17s | max lag: 0.497s | clients (14/52): AliasAlreadyTaken, Bailiff, Bingo, Boot, Davidsoft, joke15, kirill818459, Koolk7474, Papi, playor, prhg, Service, testmineweirdo, whosit

Teleport command:

/teleport xyz 25100 8 30090

Compass command:

/give_compass Construction BqP8K19JjdL6LZ9t3ZWdwq0VdijrywxD D2691E 25100 8 30090

whosit reports a bug: > normal digistuff:touchscreen says "can be placed only by staff" Player position: ``` { y = 7.5, z = 30089.79296875, x = 25100.287109375 } ``` Player look: ``` { y = -0.99631541967392, z = 0.080551445484161, x = 0.029445761814713 } ``` Player information: ``` { max_rtt = 3.5910000801086, minor = 8, formspec_version = 7, avg_jitter = 0, version_string = "5.8.0", ip_version = 6, min_rtt = 0.041000001132488, avg_rtt = 0.043999999761581, min_jitter = 0, max_jitter = 2.9210000038147, major = 5, connection_uptime = 7912, serialization_version = 29, patch = 0, lang_code = "", protocol_version = 42, state = "Active" } ``` Player meta: ``` { fields = { ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", played_time = "9315550", digged_nodes = "354055", placed_nodes = "101381", died = "791", crafted = "87956", yl_commons_player_created = "1615221933", yl_commons_player_joined = "1710657492", bitten = "0", lagometer = "1", ["petz:werewolf"] = "1", ["stamina:level"] = "9", ["petz:lycanthropy"] = "1", ["stamina:poisoned"] = "no", yl_commons_thankyou = "302", ["stamina:exhaustion"] = "109.5", arenalib_infobox_arenaID = "0", ["petz:werewolf_vignette_id"] = "20", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", repellant = "0", ["petz:werewolf_clan_idx"] = "3", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 1300\", \"3d_armor:boots_crystal 1 1300\", \"3d_armor:leggings_crystal 1 1300\", \"shields:shield_crystal 1 1300\", \"3d_armor:chestplate_crystal 1 1300\", \"\"}", xp_redo_hud_color = "0x0000ff", hud_state = "on", xp = "205827", ["petz:pre_werewolf_animation"] = "return {[\"animation\"] = \"stand\", [\"animation_speed\"] = 30, [\"model\"] = \"skinsdb_3d_armor_character_5.b3d\", [\"textures\"] = {\"blank.png\", \"character.warrior_m1.png\", \"3d_armor_trans.png^3d_armor_helmet_crystal.png^3d_armor_boots_crystal.png^3d_armor_leggings_crystal.png^shields_shield_crystal.png^3d_armor_chestplate_crystal.png\", \"3d_armor_trans.png\"}}", partychat = "party", ["signslib:pos"] = "(2181,22,1163)", hotbar_size = "16", yl_church = "return {[\"last_death\"] = {[\"y\"] = 29226, [\"z\"] = 1497, [\"x\"] = 1742}, [\"last_death_portal\"] = 1710628547, [\"last_heal\"] = 1708284048}", punch_count = "41250", jointime = "1615221933", inflicted_damage = "636090" } } ``` Log identifier ``` [MOD] yl_report log identifier = BqP8K19JjdL6LZ9t3ZWdwq0VdijrywxD ``` Profiler save: ``` profile-20240317T084945.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 16h 49min 17s | max lag: 0.497s | clients (14/52): AliasAlreadyTaken, Bailiff, Bingo, Boot, Davidsoft, joke15, kirill818459, Koolk7474, Papi, playor, prhg, Service, testmineweirdo, whosit ``` Teleport command: ``` /teleport xyz 25100 8 30090 ``` Compass command: ``` /give_compass Construction BqP8K19JjdL6LZ9t3ZWdwq0VdijrywxD D2691E 25100 8 30090 ```

AliasAlreadyTaken was assigned by yourland-report

2024-03-17 08:49:45 +00:00

tour commented

2024-03-17 08:56:15 +00:00

~~#4876~~

Edit: Oh, sorry. missed up the touchscreen names...

~~#4876~~ Edit: Oh, sorry. missed up the touchscreen names...

whosit commented

2024-03-17 10:48:48 +00:00

4876

Yeah, but it's a normal one, not "adv"... Maybe they are aliased or something...

> # 4876 Yeah, but it's a normal one, not "adv"... Maybe they are aliased or something...

AliasAlreadyTaken added the

1. kind/bug

label 2024-03-17 12:23:59 +00:00

flux commented

2024-03-18 00:47:34 +00:00

intentional because #5923, probably close as a dupe. once the client fixes get shipped (5.9?) we can re-enable that touchscreen.

👀 1

whosit commented

2024-03-19 15:47:32 +00:00

Seems like overkill... If someone made a crashy touch screen, it would only affect people who actually click on it. To reset it, you only need to break it and fix the code in luac that generated it. If it's done with malicious intent, we would know who exactly programmed it... Only people with mesemaker could do it... And as far as we know, this has never came up while screens were in use...

On the other hand, I guess we're not a machine server and screens are niche use, so, meh...

Seems like overkill... If someone made a crashy touch screen, it would only affect people who actually click on it. To reset it, you only need to break it and fix the code in luac that generated it. If it's done with malicious intent, we would know who exactly programmed it... Only people with mesemaker could do it... And as far as we know, this has never came up while screens were in use... On the other hand, I guess we're not a machine server and screens are niche use, so, meh...

whosit closed this issue

2024-03-19 15:47:33 +00:00

whosit added the

5. result/wontfix

label 2024-03-19 15:47:44 +00:00

flux commented

2024-03-21 03:39:43 +00:00

Seems like overkill... If someone made a crashy touch screen, it would only affect people who actually click on it.

that's trolly enough to trap neophytes. and as you point out, we're not a machine server - if some machines are disabled until an the fixed version of the client gets released, i won't lose any sleep. it'll get re-enabled eventually.

> Seems like overkill... If someone made a crashy touch screen, it would only affect people who actually click on it. that's trolly enough to trap neophytes. and as you point out, we're not a machine server - if some machines are disabled until an the fixed version of the client gets released, i won't lose any sleep. it'll get re-enabled eventually.

whosit commented

2024-03-21 04:37:26 +00:00

Well, even when new client is out, significant number of people will still use older versions. So, if the goal is to never let anyone crash because of this, then release of 5.9.0 is not when this should be re-enabled...

flux commented

2024-03-21 05:31:39 +00:00

even when new client is out, significant number of people will still use older versions

when the new client is released, we can at least point people at how to fix the issue. sure, it's possible to build your own client while cherry-picking the relevant commit. but most people will not be able to do that, either because they can't understand how to do that, or because the fix just isn't otherwise available on their platform. until then, it's unfortunately on us to prevent the problem. when there's an official release to the majority of our audience, then we can re-enable this without fear of alienating too many people.

> even when new client is out, significant number of people will still use older versions when the new client is released, we can at least point people at how to fix the issue. sure, it's possible to build your own client while cherry-picking the relevant commit. but most people will not be able to do that, either because they can't understand how to do that, or because the fix just isn't otherwise available on their platform. until then, it's unfortunately on us to prevent the problem. when there's an official release to the majority of our audience, then we can re-enable this without fear of alienating too many people.

AliasAlreadyTaken commented

2024-03-21 13:46:51 +00:00

Regarding backwards compat, the YL approach is "Clients back to 5.0.0 should not crash immediately. If they can't access each and every game content as well as an up to date client, that's ok."

We are not responsible for people who build their own client and remove exactly the bugfixes, but that's a such small group.

In this case I'd say we can reenable this with the release of 5.9.0 - if THEN anyone chooses to crash their client repeatedly on the touchscreen, so be it. The user must access the touchscreen for the bug to happen, it's not that there is a mapblock he cannot access anymore, if there is such a faulty touchscreen in there.

Regarding backwards compat, the YL approach is "Clients back to 5.0.0 should not crash immediately. If they can't access each and every game content as well as an up to date client, that's ok." We are not responsible for people who build their own client and remove exactly the bugfixes, but that's a such small group. In this case I'd say we can reenable this with the release of 5.9.0 - if THEN anyone chooses to crash their client repeatedly on the touchscreen, so be it. The user must access the touchscreen for the bug to happen, it's not that there is a mapblock he cannot access anymore, if there is such a faulty touchscreen in there.

Sign in to join this conversation.