your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

rhotator crash #6502

New Issue
Open
opened 2024-03-16 10:10:26 +00:00 by whosit · 7 comments
whosit commented 2024-03-16 10:10:26 +00:00
Member
Copy Link
2024-03-16 09:46:03: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback item_OnPlace(): ...e/mt/5.7.0/Minetest_live/bin/../mods/rhotator/notify.lua:120: bad argument #1 to 'hud_get' (number expected, got nil)
2024-03-16 09:46:03: ERROR[Main]: stack traceback:
2024-03-16 09:46:03: ERROR[Main]: [C]: in function 'hud_get'
2024-03-16 09:46:03: ERROR[Main]: ...e/mt/5.7.0/Minetest_live/bin/../mods/rhotator/notify.lua:120: in function 'notify'
2024-03-16 09:46:03: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../mods/rhotator/init.lua:690: in function 'copy_rotation_callback'
2024-03-16 09:46:03: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../mods/rhotator/init.lua:485: in function 'func'
2024-03-16 09:46:03: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function 'callback'
2024-03-16 09:46:03: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../builtin/game/item.lua:285: in function 'on_place'
2024-03-16 09:46:03: ERROR[Main]: ...mt/5.7.0/Minetest_live/bin/../mods/replacer/replacer.lua:214: in function 'replace_single_node'
2024-03-16 09:46:03: ERROR[Main]: ...mt/5.7.0/Minetest_live/bin/../mods/replacer/replacer.lua:307: in function <...mt/5.7.0/Minetest_live/bin/../mods/replacer/replacer.lua:252>
```prolog 2024-03-16 09:46:03: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '' in callback item_OnPlace(): ...e/mt/5.7.0/Minetest_live/bin/../mods/rhotator/notify.lua:120: bad argument #1 to 'hud_get' (number expected, got nil) 2024-03-16 09:46:03: ERROR[Main]: stack traceback: 2024-03-16 09:46:03: ERROR[Main]: [C]: in function 'hud_get' 2024-03-16 09:46:03: ERROR[Main]: ...e/mt/5.7.0/Minetest_live/bin/../mods/rhotator/notify.lua:120: in function 'notify' 2024-03-16 09:46:03: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../mods/rhotator/init.lua:690: in function 'copy_rotation_callback' 2024-03-16 09:46:03: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../mods/rhotator/init.lua:485: in function 'func' 2024-03-16 09:46:03: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function 'callback' 2024-03-16 09:46:03: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../builtin/game/item.lua:285: in function 'on_place' 2024-03-16 09:46:03: ERROR[Main]: ...mt/5.7.0/Minetest_live/bin/../mods/replacer/replacer.lua:214: in function 'replace_single_node' 2024-03-16 09:46:03: ERROR[Main]: ...mt/5.7.0/Minetest_live/bin/../mods/replacer/replacer.lua:307: in function <...mt/5.7.0/Minetest_live/bin/../mods/replacer/replacer.lua:252> ```
whosit added the
1. kind/bug
3. source/mod upstream
 labels 2024-03-16 10:10:38 +00:00
whosit commented 2024-03-16 10:20:21 +00:00
Author
Member
Copy Link
hud_add(hud definition): add a HUD element described by HUD def, returns ID number on success

meaning, it can fail and returned ID needs to be checked

opened upstream issue:
https://github.com/SwissalpS/replacer/issues/52 wrong repo, it's not replacer, it's rhotator!

``` hud_add(hud definition): add a HUD element described by HUD def, returns ID number on success ``` meaning, it can fail and returned ID needs to be checked opened upstream issue: ~~https://github.com/SwissalpS/replacer/issues/52~~ wrong repo, it's not replacer, it's rhotator!
whosit commented 2024-03-16 10:24:02 +00:00
Author
Member
Copy Link

Did we run out of HUD ids?!

They are stored in std::vector<HudElement *> hud; per-player.
and hud_add() checks if ID of the new element does not fit into u32 (addHud also seems to re-use freed ids):

// hud_add(self, form)
int LuaLocalPlayer::l_hud_add(lua_State *L)
{
	LocalPlayer *player = getobject(L, 1);

	HudElement *elem = new HudElement;
	read_hud_element(L, elem);

	u32 id = player->addHud(elem);
	if (id == U32_MAX) {
		delete elem;
		return 0;
	}
	lua_pushnumber(L, id);
	return 1;
}

I guess we can't exclude possibility of some mod leaking HUDs...

It could be any other mod besides replacer, so we need to find the player who used the replacer when server has crashed and then try to figure out what they were doing that could've created HUDs in excess.

~~Did we run out of HUD ids?!~~ They are stored in `std::vector<HudElement *> hud;` per-player. and `hud_add()` checks if ID of the new element does not fit into `u32` (`addHud` also seems to re-use freed ids): ```c++ // hud_add(self, form) int LuaLocalPlayer::l_hud_add(lua_State *L) { LocalPlayer *player = getobject(L, 1); HudElement *elem = new HudElement; read_hud_element(L, elem); u32 id = player->addHud(elem); if (id == U32_MAX) { delete elem; return 0; } lua_pushnumber(L, id); return 1; } ``` ~~I guess we can't exclude possibility of some mod leaking HUDs...~~ ~~It could be any other mod besides replacer, so we need to find the player who used the replacer when server has crashed and then try to figure out what they were doing that could've created HUDs in excess.~~
AliasAlreadyTaken commented 2024-03-16 16:17:17 +00:00
Owner
Copy Link
2024-03-16 16:15:44: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'moretrees' in callback item_OnPlace(): ...e/mt/5.7.0/Minetest_live/bin/../mods/rhotator/notify.lua:120: bad argument #1 to 'hud_get' (number expected, got nil)
2024-03-16 16:15:44: ERROR[Main]: stack traceback:
2024-03-16 16:15:44: ERROR[Main]: 	[C]: in function 'hud_get'
2024-03-16 16:15:44: ERROR[Main]: 	...e/mt/5.7.0/Minetest_live/bin/../mods/rhotator/notify.lua:120: in function 'notify'
2024-03-16 16:15:44: ERROR[Main]: 	...e/mt/5.7.0/Minetest_live/bin/../mods/rhotator/notify.lua:80: in function 'warning'
2024-03-16 16:15:44: ERROR[Main]: 	/home/mt/5.7.0/Minetest_live/bin/../mods/rhotator/init.lua:684: in function 'copy_rotation_callback'
2024-03-16 16:15:44: ERROR[Main]: 	/home/mt/5.7.0/Minetest_live/bin/../mods/rhotator/init.lua:485: in function 'func'
2024-03-16 16:15:44: ERROR[Main]: 	...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function 'callback'
2024-03-16 16:15:44: ERROR[Main]: 	...t_live/bin/../games/minetest_game/mods/default/trees.lua:594: in function 'sapling_on_place'
2024-03-16 16:15:44: ERROR[Main]: 	.../5.7.0/Minetest_live/bin/../mods/moretrees/node_defs.lua:444: in function <.../5.7.0/Minetest_live/bin/../mods/moretrees/node_defs.lua:443>
``` 2024-03-16 16:15:44: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'moretrees' in callback item_OnPlace(): ...e/mt/5.7.0/Minetest_live/bin/../mods/rhotator/notify.lua:120: bad argument #1 to 'hud_get' (number expected, got nil) 2024-03-16 16:15:44: ERROR[Main]: stack traceback: 2024-03-16 16:15:44: ERROR[Main]: [C]: in function 'hud_get' 2024-03-16 16:15:44: ERROR[Main]: ...e/mt/5.7.0/Minetest_live/bin/../mods/rhotator/notify.lua:120: in function 'notify' 2024-03-16 16:15:44: ERROR[Main]: ...e/mt/5.7.0/Minetest_live/bin/../mods/rhotator/notify.lua:80: in function 'warning' 2024-03-16 16:15:44: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../mods/rhotator/init.lua:684: in function 'copy_rotation_callback' 2024-03-16 16:15:44: ERROR[Main]: /home/mt/5.7.0/Minetest_live/bin/../mods/rhotator/init.lua:485: in function 'func' 2024-03-16 16:15:44: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:108: in function 'callback' 2024-03-16 16:15:44: ERROR[Main]: ...t_live/bin/../games/minetest_game/mods/default/trees.lua:594: in function 'sapling_on_place' 2024-03-16 16:15:44: ERROR[Main]: .../5.7.0/Minetest_live/bin/../mods/moretrees/node_defs.lua:444: in function <.../5.7.0/Minetest_live/bin/../mods/moretrees/node_defs.lua:443> ```
Boot commented 2024-03-16 16:40:00 +00:00
Member
Copy Link

And in the log is no coord where?

And in the log is no coord where?
whosit changed title from replacer crash to rhotator crash 2024-03-16 19:41:36 +00:00
whosit commented 2024-03-16 19:45:14 +00:00
Author
Member
Copy Link

rhotator has a "memory" function that tries to rotate blocks after placement even if you place them by hand or with a replacer...

`rhotator` has a "memory" function that tries to rotate blocks after placement even if you place them by hand or with a replacer...
whosit commented 2024-03-16 19:47:44 +00:00
Author
Member
Copy Link

This crash seems to be fixed upstream:
3b29e5f438

And we have merged it... does it not work?

UPD:
seems like needs to guard other place too..

Something weird is going on there.

~~This crash seems to be fixed upstream:~~ https://github.com/entuland/rhotator/commit/3b29e5f4384ab75b2f4f9f97c3008d997fbed6ad ~~And we have merged it... does it not work?~~ UPD: seems like needs to guard other place too.. Something weird is going on there.
flux commented 2024-03-17 23:54:38 +00:00
Member
Copy Link

meaning, it can fail and returned ID needs to be checked
...
seems like needs to guard other place too..

i can't remember if used to know this and just forgot, but all my hud management stuff seems to already makes sure the id is defined before trying to get the hud definition (and then validates it further before making any changes). sometimes minetest's API makes it really easy for things to fail and mess up other code's logic - HUD management is one of the worst examples.

> meaning, it can fail and returned ID needs to be checked ... > seems like needs to guard other place too.. i can't remember if used to know this and just forgot, but all my hud management stuff seems to already makes sure the id is defined before trying to get the hud definition (and then validates it further before making any changes). sometimes minetest's API makes it really easy for things to fail and mess up other code's logic - HUD management is one of the worst examples.
AliasAlreadyTaken added the
2. prio/critical
 label 2024-03-18 15:42:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6502
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?