whosit reports: can't put nodes into deployer: ... #6455

New Issue

yourland-report · 2024-03-12T16:50:11Z

yourland-report commented

2024-03-12 16:50:11 +00:00

whosit reports a bug:

can't put nodes into deployer: get "dirt cannot be used in Deployer" message

Player position:

{
	x = 25061.970703125,
	y = 5.5,
	z = 30110.46875
}

Player look:

{
	x = 0.048326808959246,
	y = -0.27362349629402,
	z = 0.96062207221985
}

Player information:

{
	min_jitter = 0,
	max_jitter = 21.11600112915,
	avg_jitter = 0.9909999370575,
	connection_uptime = 247,
	serialization_version = 29,
	patch = 0,
	formspec_version = 7,
	max_rtt = 21.165000915527,
	version_string = "5.8.0",
	minor = 8,
	lang_code = "",
	major = 5,
	protocol_version = 42,
	state = "Active",
	ip_version = 6,
	min_rtt = 0.041000001132488,
	avg_rtt = 1.0369999408722
}

Player meta:

{
	fields = {
		punch_count = "41169",
		played_time = "9117761",
		inflicted_damage = "634966",
		placed_nodes = "100140",
		died = "788",
		crafted = "85301",
		["petz:werewolf"] = "1",
		yl_commons_thankyou = "287",
		["petz:werewolf_vignette_id"] = "20",
		hotbar_size = "16",
		xp = "208878",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "109.5",
		jointime = "1615221933",
		bitten = "0",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 30307, [\"y\"] = -14, [\"z\"] = -422}, [\"last_heal\"] = 1708284048, [\"last_death_portal\"] = 1709833136}",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 15780\", \"3d_armor:boots_crystal 1 15880\", \"3d_armor:chestplate_crystal 1 15780\", \"3d_armor:leggings_crystal 1 15780\", \"shields:shield_crystal 1 15780\", \"\"}",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		arenalib_infobox_arenaID = "0",
		["petz:pre_werewolf_animation"] = "return {[\"textures\"] = {\"blank.png\", \"character.warrior_m1.png\", \"3d_armor_trans.png^3d_armor_helmet_crystal.png^3d_armor_boots_crystal.png^3d_armor_chestplate_crystal.png^3d_armor_leggings_crystal.png^shields_shield_crystal.png\", \"default_glass.png^[colorize:#FFFF78\"}, [\"animation\"] = \"stand\", [\"animation_speed\"] = 30, [\"model\"] = \"skinsdb_3d_armor_character_5.b3d\"}",
		yl_commons_player_created = "1615221933",
		xp_redo_hud_color = "0x0000ff",
		["signslib:pos"] = "(3828,77,104)",
		lagometer = "1",
		["petz:werewolf_clan_idx"] = "3",
		hud_state = "on",
		digged_nodes = "351424",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["petz:lycanthropy"] = "1",
		yl_commons_player_joined = "1710262017",
		["stamina:level"] = "7",
		repellant = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = jhRBkIcCv1Weq2kX2vWMuSrdoShABwm7

Profiler save:

profile-20240312T165011.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 3h 6min 12s | max lag: 0.723s | clients (18/52): AliasAlreadyTaken, Bailiff, BenOnly, Crazylad, DragonWrangler1, gianlp, invizone, jackofthebean000, JinnyC, LadyPixels, laira, Murmel, poppyasdan, rewired_X, Service, Sokomine, thatchristianguy, whosit

Teleport command:

/teleport xyz 25062 6 30110

Compass command:

/give_compass Construction jhRBkIcCv1Weq2kX2vWMuSrdoShABwm7 D2691E 25062 6 30110

whosit reports a bug: > can't put nodes into deployer: get "dirt cannot be used in Deployer" message Player position: ``` { x = 25061.970703125, y = 5.5, z = 30110.46875 } ``` Player look: ``` { x = 0.048326808959246, y = -0.27362349629402, z = 0.96062207221985 } ``` Player information: ``` { min_jitter = 0, max_jitter = 21.11600112915, avg_jitter = 0.9909999370575, connection_uptime = 247, serialization_version = 29, patch = 0, formspec_version = 7, max_rtt = 21.165000915527, version_string = "5.8.0", minor = 8, lang_code = "", major = 5, protocol_version = 42, state = "Active", ip_version = 6, min_rtt = 0.041000001132488, avg_rtt = 1.0369999408722 } ``` Player meta: ``` { fields = { punch_count = "41169", played_time = "9117761", inflicted_damage = "634966", placed_nodes = "100140", died = "788", crafted = "85301", ["petz:werewolf"] = "1", yl_commons_thankyou = "287", ["petz:werewolf_vignette_id"] = "20", hotbar_size = "16", xp = "208878", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "109.5", jointime = "1615221933", bitten = "0", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"x\"] = 30307, [\"y\"] = -14, [\"z\"] = -422}, [\"last_heal\"] = 1708284048, [\"last_death_portal\"] = 1709833136}", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 15780\", \"3d_armor:boots_crystal 1 15880\", \"3d_armor:chestplate_crystal 1 15780\", \"3d_armor:leggings_crystal 1 15780\", \"shields:shield_crystal 1 15780\", \"\"}", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", arenalib_infobox_arenaID = "0", ["petz:pre_werewolf_animation"] = "return {[\"textures\"] = {\"blank.png\", \"character.warrior_m1.png\", \"3d_armor_trans.png^3d_armor_helmet_crystal.png^3d_armor_boots_crystal.png^3d_armor_chestplate_crystal.png^3d_armor_leggings_crystal.png^shields_shield_crystal.png\", \"default_glass.png^[colorize:#FFFF78\"}, [\"animation\"] = \"stand\", [\"animation_speed\"] = 30, [\"model\"] = \"skinsdb_3d_armor_character_5.b3d\"}", yl_commons_player_created = "1615221933", xp_redo_hud_color = "0x0000ff", ["signslib:pos"] = "(3828,77,104)", lagometer = "1", ["petz:werewolf_clan_idx"] = "3", hud_state = "on", digged_nodes = "351424", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["petz:lycanthropy"] = "1", yl_commons_player_joined = "1710262017", ["stamina:level"] = "7", repellant = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = jhRBkIcCv1Weq2kX2vWMuSrdoShABwm7 ``` Profiler save: ``` profile-20240312T165011.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 3h 6min 12s | max lag: 0.723s | clients (18/52): AliasAlreadyTaken, Bailiff, BenOnly, Crazylad, DragonWrangler1, gianlp, invizone, jackofthebean000, JinnyC, LadyPixels, laira, Murmel, poppyasdan, rewired_X, Service, Sokomine, thatchristianguy, whosit ``` Teleport command: ``` /teleport xyz 25062 6 30110 ``` Compass command: ``` /give_compass Construction jhRBkIcCv1Weq2kX2vWMuSrdoShABwm7 D2691E 25062 6 30110 ```

AliasAlreadyTaken was assigned by yourland-report

2024-03-12 16:50:11 +00:00

whosit added the

1. kind/bug

3. source/integration

labels 2024-03-12 16:50:46 +00:00

whosit commented

2024-03-12 16:54:28 +00:00

Reason: yl_commons code here:
36fdc526cb/bugfixes/pipeworks_wielder.lua (L141)

(def.type == "node" and def.on_place == minetest.nodedef_default.on_place) or

it expects function to have default on_place, but in game it's:

{
        nups = 1,
        short_src = "worldmods\\leads/internal.lua",
        currentline = -1,
        func = <function>,
        isvararg = true,
        source = "worldmods\\leads/internal.lua",
        what = "Lua",
        namewhat = "",
        nparams = 3,
        lastlinedefined = 51,
        linedefined = 38
}

So it get overridden by this:
3fad55a571/internal.lua (L38)

Reason: yl_commons code here: https://gitea.your-land.de/your-land/yl_commons/src/commit/36fdc526cbce0d4684eae5860f0cfde048bcc2c2/bugfixes/pipeworks_wielder.lua#L141 ```lua (def.type == "node" and def.on_place == minetest.nodedef_default.on_place) or ``` it expects function to have default `on_place`, but in game it's: ```lua { nups = 1, short_src = "worldmods\\leads/internal.lua", currentline = -1, func = <function>, isvararg = true, source = "worldmods\\leads/internal.lua", what = "Lua", namewhat = "", nparams = 3, lastlinedefined = 51, linedefined = 38 } ``` So it get overridden by this: https://gitea.your-land.de/your-land/leads/src/commit/3fad55a57195e082128a2bc0754c32e1e67ffc71/internal.lua#L38

Murmel commented

2024-03-12 18:34:50 +00:00

Reason: yl_commons code here:
36fdc526cb/bugfixes/pipeworks_wielder.lua (L141)

(def.type == "node" and def.on_place == minetest.nodedef_default.on_place) or

it expects function to have default on_place, but in game it's:

{
        nups = 1,
        short_src = "worldmods\\leads/internal.lua",
        currentline = -1,
        func = <function>,
        isvararg = true,
        source = "worldmods\\leads/internal.lua",
        what = "Lua",
        namewhat = "",
        nparams = 3,
        lastlinedefined = 51,
        linedefined = 38
}

So it get overridden by this:
3fad55a571/internal.lua (L38)

Is that enough information to solve it or woulkd it help to list other stuff also forbidden in deployer now? I believe some people have bild a "furnace" by using deployer and lava pick, so there might be a lot ogf machines that stopped working.

> Reason: yl_commons code here: > https://gitea.your-land.de/your-land/yl_commons/src/commit/36fdc526cbce0d4684eae5860f0cfde048bcc2c2/bugfixes/pipeworks_wielder.lua#L141 > ```lua > (def.type == "node" and def.on_place == minetest.nodedef_default.on_place) or > ``` > it expects function to have default `on_place`, but in game it's: > ```lua > { > nups = 1, > short_src = "worldmods\\leads/internal.lua", > currentline = -1, > func = <function>, > isvararg = true, > source = "worldmods\\leads/internal.lua", > what = "Lua", > namewhat = "", > nparams = 3, > lastlinedefined = 51, > linedefined = 38 > } > ``` > So it get overridden by this: > https://gitea.your-land.de/your-land/leads/src/commit/3fad55a57195e082128a2bc0754c32e1e67ffc71/internal.lua#L38 Is that enough information to solve it or woulkd it help to list other stuff also forbidden in deployer now? I believe some people have bild a "furnace" by using deployer and lava pick, so there might be a lot ogf machines that stopped working.

whosit commented

2024-03-12 18:46:12 +00:00

Is that enough information to solve it or woulkd it help to list other stuff also forbidden in deployer now? I believe some people have bild a "furnace" by using deployer and lava pick, so there might be a lot ogf machines that stopped working.

Well, I know that nodes (blocks) in deployers are broken. If there's something else that you expect to be able to put in in deployer or breaker that you can't then please report too.

> Is that enough information to solve it or woulkd it help to list other stuff also forbidden in deployer now? I believe some people have bild a "furnace" by using deployer and lava pick, so there might be a lot ogf machines that stopped working. Well, I know that nodes (blocks) in _deployers_ are broken. If there's something else that you expect to be able to put in in deployer or breaker that you can't then please report too.

flux commented

2024-03-12 21:40:59 +00:00

ugh, that check was really hacky when i wrote it, this was inevitable. let me see if i can figure something else...

flux added this to the flux's TODO list project 2024-03-12 21:41:53 +00:00

flux self-assigned this 2024-03-12 21:42:00 +00:00

whosit commented

2024-03-12 21:47:51 +00:00

Even more hacky is the leads code though, probably it should not override everything.

flux referenced this issue from a commit

2024-03-12 22:27:12 +00:00

your-land/bugtracker#6455 don't break putting nodes in the deployer if on_place gets overridden

flux commented

2024-03-12 22:28:05 +00:00

i removed that check. i tried putting some of the things that previously wouldn't go in the deployer, and they're fine. not 100% tested, but nothing looked to suspicious. 447e1b3f9b

i removed that check. i tried putting some of the things that previously wouldn't go in the deployer, and they're fine. not 100% tested, but nothing looked to suspicious. https://gitea.your-land.de/your-land/yl_commons/commit/447e1b3f9b488c09fbdb60dc981e34dced407690

flux added the

2. prio/critical

4. step/ready to QA test

labels 2024-03-12 22:28:19 +00:00

AliasAlreadyTaken added this to the 1.1.123.1 milestone 2024-03-13 08:14:41 +00:00

Murmel commented

2024-03-13 08:49:08 +00:00

Is that enough information to solve it or woulkd it help to list other stuff also forbidden in deployer now? I believe some people have bild a "furnace" by using deployer and lava pick, so there might be a lot ogf machines that stopped working.

Well, I know that nodes (blocks) in deployers are broken. If there's something else that you expect to be able to put in in deployer or breaker that you can't then please report too.

Do leaves count as blocks? If not they are another category of Items that do not work.
default:stick still work.
Other tools (pick, sword etc.) do not work, but I do not know if they did before.

> > > Is that enough information to solve it or woulkd it help to list other stuff also forbidden in deployer now? I believe some people have bild a "furnace" by using deployer and lava pick, so there might be a lot ogf machines that stopped working. > > Well, I know that nodes (blocks) in _deployers_ are broken. If there's something else that you expect to be able to put in in deployer or breaker that you can't then please report too. Do leaves count as blocks? If not they are another category of Items that do not work. default:stick still work. Other tools (pick, sword etc.) do not work, but I do not know if they did before.

Boot commented

2024-03-13 14:53:22 +00:00