JeCel reports: After the update Mithril picka ... #6454

New Issue

yourland-report · 2024-03-12T14:47:11Z

yourland-report commented

2024-03-12 14:47:11 +00:00

JeCel reports a bug:

After the update Mithril pickaxe (at least both enchanted versions) seem to be much slower. This is pretty annoying as now one has to either use Lava Pick or Rainbow Pick which both need repair very often

Player position:

{
	x = 5164.1328125,
	y = -105.49900054932,
	z = 22117.755859375
}

Player look:

{
	x = -0.0055951159447432,
	y = -0.23666855692863,
	z = -0.97157436609268
}

Player information:

{
	ip_version = 6,
	min_rtt = 0.025000000372529,
	avg_rtt = 0.028000000864267,
	min_jitter = 0,
	max_jitter = 1.6330000162125,
	avg_jitter = 0.029999997466803,
	connection_uptime = 3300,
	serialization_version = 29,
	patch = 0,
	formspec_version = 6,
	max_rtt = 1.6610000133514,
	version_string = "5.7.0",
	minor = 7,
	lang_code = "",
	major = 5,
	protocol_version = 42,
	state = "Active"
}

Player meta:

{
	fields = {
		punch_count = "402529",
		played_time = "9262033",
		digged_nodes = "3066015",
		placed_nodes = "905926",
		died = "52",
		crafted = "885900",
		["petz:werewolf"] = "0",
		yl_commons_thankyou = "363",
		["petz:lycanthropy"] = "0",
		["stamina:level"] = "19",
		["ambience.svol"] = "0.1",
		["stamina:poisoned"] = "no",
		["ocean_build.last_warning"] = "1.66672e+09",
		jointime = "1621787993",
		bitten = "0",
		partychat = "main",
		yl_church = "return {[\"last_death_portal\"] = 1707868012, [\"last_heal\"] = 1694896547, [\"last_death\"] = {[\"z\"] = 10301, [\"x\"] = 6510, [\"y\"] = 29995}}",
		["petz:werewolf_vignette_id"] = "19",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false, [\"speed\"] = 2, [\"sneak\"] = true}",
		yl_commons_player_created = "1621787993",
		xp_redo_hud_color = "0x99ffff",
		["signslib:pos"] = "(6531,-25,10358)",
		arenalib_infobox_arenaID = "0",
		["petz:werewolf_clan_idx"] = "4",
		hud_state = "on",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		xp = "4402287",
		inflicted_damage = "8765354",
		yl_commons_player_joined = "1710251565",
		["stamina:exhaustion"] = "78",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 26520\", \"3d_armor:chestplate_nether 1 22640\", \"3d_armor:leggings_nether 1 22640\", \"shields:shield_nether 1 22640\", \"nether_mobs:dragon_boots 1 26500\", \"\"}",
		repellant = "0",
		["ocean_build.ocean_built"] = "8"
	}
}

Log identifier


[MOD] yl_report log identifier = KA0r7VRBtM8x29RPjOd1npmhAK6hbHbw

Profiler save:

profile-20240312T144710.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1h 44s | max lag: 0.486s | clients (16/52): AliasAlreadyTaken, Arkduck, Bailiff, Davidsoft, DragonWrangler1, invizone, JeCel, JinnyC, LadYeauty, LadyPixels, MeZN, Murmel, Noii, ProMemm, Service, whosit

Teleport command:

/teleport xyz 5164 -105 22118

Compass command:

/give_compass Construction KA0r7VRBtM8x29RPjOd1npmhAK6hbHbw D2691E 5164 -105 22118

JeCel reports a bug: > After the update Mithril pickaxe (at least both enchanted versions) seem to be much slower. This is pretty annoying as now one has to either use Lava Pick or Rainbow Pick which both need repair very often Player position: ``` { x = 5164.1328125, y = -105.49900054932, z = 22117.755859375 } ``` Player look: ``` { x = -0.0055951159447432, y = -0.23666855692863, z = -0.97157436609268 } ``` Player information: ``` { ip_version = 6, min_rtt = 0.025000000372529, avg_rtt = 0.028000000864267, min_jitter = 0, max_jitter = 1.6330000162125, avg_jitter = 0.029999997466803, connection_uptime = 3300, serialization_version = 29, patch = 0, formspec_version = 6, max_rtt = 1.6610000133514, version_string = "5.7.0", minor = 7, lang_code = "", major = 5, protocol_version = 42, state = "Active" } ``` Player meta: ``` { fields = { punch_count = "402529", played_time = "9262033", digged_nodes = "3066015", placed_nodes = "905926", died = "52", crafted = "885900", ["petz:werewolf"] = "0", yl_commons_thankyou = "363", ["petz:lycanthropy"] = "0", ["stamina:level"] = "19", ["ambience.svol"] = "0.1", ["stamina:poisoned"] = "no", ["ocean_build.last_warning"] = "1.66672e+09", jointime = "1621787993", bitten = "0", partychat = "main", yl_church = "return {[\"last_death_portal\"] = 1707868012, [\"last_heal\"] = 1694896547, [\"last_death\"] = {[\"z\"] = 10301, [\"x\"] = 6510, [\"y\"] = 29995}}", ["petz:werewolf_vignette_id"] = "19", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"sneak_glitch\"] = false, [\"speed\"] = 2, [\"sneak\"] = true}", yl_commons_player_created = "1621787993", xp_redo_hud_color = "0x99ffff", ["signslib:pos"] = "(6531,-25,10358)", arenalib_infobox_arenaID = "0", ["petz:werewolf_clan_idx"] = "4", hud_state = "on", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", xp = "4402287", inflicted_damage = "8765354", yl_commons_player_joined = "1710251565", ["stamina:exhaustion"] = "78", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 26520\", \"3d_armor:chestplate_nether 1 22640\", \"3d_armor:leggings_nether 1 22640\", \"shields:shield_nether 1 22640\", \"nether_mobs:dragon_boots 1 26500\", \"\"}", repellant = "0", ["ocean_build.ocean_built"] = "8" } } ``` Log identifier ``` [MOD] yl_report log identifier = KA0r7VRBtM8x29RPjOd1npmhAK6hbHbw ``` Profiler save: ``` profile-20240312T144710.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 1h 44s | max lag: 0.486s | clients (16/52): AliasAlreadyTaken, Arkduck, Bailiff, Davidsoft, DragonWrangler1, invizone, JeCel, JinnyC, LadYeauty, LadyPixels, MeZN, Murmel, Noii, ProMemm, Service, whosit ``` Teleport command: ``` /teleport xyz 5164 -105 22118 ``` Compass command: ``` /give_compass Construction KA0r7VRBtM8x29RPjOd1npmhAK6hbHbw D2691E 5164 -105 22118 ```

AliasAlreadyTaken was assigned by yourland-report

2024-03-12 14:47:11 +00:00

AliasAlreadyTaken commented

2024-03-12 15:02:00 +00:00

This is why: https://github.com/minetest-mods/moreores/pull/44

For some reason they changed the coolcaps

This is why: https://github.com/minetest-mods/moreores/pull/44 For some reason they changed the coolcaps

AliasAlreadyTaken added the

1. kind/bug

1. kind/balancing

labels 2024-03-12 15:02:14 +00:00

flux commented

2024-03-13 04:10:30 +00:00

coolcaps

toolcaps?

imo we should fix this by totally redesigning tools and enchanting.i've got a lot of groundwork done for that but i need a coherent plan from alias to implement yl's desired capabilities

> coolcaps toolcaps? imo we should fix this by totally redesigning tools and enchanting.i've got a lot of groundwork done for that but i need a coherent plan from alias to implement yl's desired capabilities

😆 1

AliasAlreadyTaken commented

2024-03-13 07:16:06 +00:00

coolcaps

toolcaps?

Yesh. I probably was half asleep when I wrote this, lucky it didn't turn into cooltaps or worse. :D:D:D

imo we should fix this by totally redesigning tools and enchanting.i've got a lot of groundwork done for that but i need a coherent plan from alias to implement yl's desired capabilities

True. This weapon redesign is a 1.4 feature. It not only requires a different approach to weapons and damage and damagetypes, but generic damage sources and armour that protects against it and ... a lot more.

For this issue, we can't wait for the redesign. We need to make up our mind whether we want to go along with upstream or change it back to what it was before on YL.

> > coolcaps > > toolcaps? Yesh. I probably was half asleep when I wrote this, lucky it didn't turn into cooltaps or worse. :D:D:D > imo we should fix this by totally redesigning tools and enchanting.i've got a lot of groundwork done for that but i need a coherent plan from alias to implement yl's desired capabilities True. This weapon redesign is a 1.4 feature. It not only requires a different approach to weapons and damage and damagetypes, but generic damage sources and armour that protects against it and ... a lot more. For this issue, we can't wait for the redesign. We need to make up our mind whether we want to go along with upstream or change it back to what it was before on YL.

AliasAlreadyTaken added this to the 1.1.123.1 milestone 2024-03-13 08:13:04 +00:00

flux commented

2024-03-13 20:19:47 +00:00

For this issue, we can't wait for the redesign. We need to make up our mind whether we want to go along with upstream or change it back to what it was before on YL.

i vote we override it back to what it was before. enchanted mithril pick wasn't best for all situations, but it was a good workhorse.

> For this issue, we can't wait for the redesign. We need to make up our mind whether we want to go along with upstream or change it back to what it was before on YL. i vote we override it back to what it was before. enchanted mithril pick wasn't best for all situations, but it was a good workhorse.

AliasAlreadyTaken commented

2024-03-13 20:26:52 +00:00

For this issue, we can't wait for the redesign. We need to make up our mind whether we want to go along with upstream or change it back to what it was before on YL.

i vote we override it back to what it was before. enchanted mithril pick wasn't best for all situations, but it was a good workhorse.

Agreed. People decided on their tools according to what it was. Let's override that in yl_commons

> > > For this issue, we can't wait for the redesign. We need to make up our mind whether we want to go along with upstream or change it back to what it was before on YL. > > i vote we override it back to what it was before. enchanted mithril pick wasn't best for all situations, but it was a good workhorse. Agreed. People decided on their tools according to what it was. Let's override that in yl_commons

AliasAlreadyTaken referenced this issue from a commit

2024-03-14 03:22:17 +00:00

your-land/bugtracker#6454 Return mithril tools to YL values

AliasAlreadyTaken added the

4. step/ready to QA test

label 2024-03-14 03:22:50 +00:00

AliasAlreadyTaken referenced this issue from a commit

2024-03-14 03:56:33 +00:00

your-land/bugtracker#6454 Bugfix mithril tools to YL values

AliasAlreadyTaken referenced this issue from a commit

2024-03-14 04:05:14 +00:00

your-land/bugtracker#6454 Bugfix mithril tools to YL values

AliasAlreadyTaken referenced this issue

2024-03-14 04:36:54 +00:00

AliasAlreadyTaken reports: minetest.global_exists("enchan ... #6470

AliasAlreadyTaken referenced this issue from a commit

2024-03-14 04:49:29 +00:00

your-land/bugtracker#6454 Bugfix2 mithril tools to YL values

AliasAlreadyTaken added the

ugh/QA OK

label 2024-03-14 05:08:50 +00:00

Murmel commented

2024-03-14 14:07:54 +00:00

Still buggy:
Chache reported Mithril axe to be very slow, so we tested and can confirm.
Crystal, Diamond, Nether and Mese axe seem to work normally.
Interesting fact:
Mithril axe does not take any damage.
If you start chopping with choppy with mithril axe it's quite slow. If you switch to another axe then while chopping, a normal tree is chopped instantly. I'll try with some bigger trees.
With bigger trees change to another pickaxe while using choppy doen't remove it instantly but chopping with normal speed.

Still buggy: Chache reported Mithril **axe** to be very slow, so we tested and can confirm. Crystal, Diamond, Nether and Mese axe seem to work normally. Interesting fact: **Mithril axe does not take any damage.** If you start chopping with choppy with mithril axe it's quite slow. If you switch to another axe then while chopping, a normal tree is chopped instantly. I'll try with some bigger trees. With bigger trees change to another pickaxe while using choppy doen't remove it instantly but chopping with normal speed.

whosit added

ugh/QA NOK

and removed

ugh/QA OK

labels 2024-03-14 14:15:33 +00:00

AliasAlreadyTaken modified the milestone from 1.1.123.1 to 1.1.123.2

2024-03-14 17:42:11 +00:00

AliasAlreadyTaken referenced this issue

2024-03-14 17:43:58 +00:00

1.1.123.2 #6481

AliasAlreadyTaken referenced this issue from a commit

2024-03-14 19:01:50 +00:00

your-land/bugtracker#6454 Bugfix3 mithril axe was a shovel

AliasAlreadyTaken removed the

ugh/QA NOK

label 2024-03-15 00:01:38 +00:00

AliasAlreadyTaken added the

ugh/QA OK

label 2024-03-15 04:37:30 +00:00

LeetPeet commented

2024-03-26 04:19:39 +00:00

I think this issue has been fixed...

flux commented

2024-03-26 21:49:56 +00:00

I think this issue has been fixed...

i didn't notice the axe being slow in some informal testing, either on test or main. did this get deployed by accident?

> I think this issue has been fixed... i didn't notice the axe being slow in some informal testing, either on test or main. did this get deployed by accident?

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2024-03-28 23:13:30 +00:00

AliasAlreadyTaken was unassigned by flux

2024-03-28 23:13:32 +00:00

flux commented

2024-03-28 23:14:57 +00:00

live

flux closed this issue

2024-03-28 23:14:57 +00:00