AspireMint reports: Golden *apple* should also res ... #6393

New Issue

yourland-report · 2024-03-03T21:23:31Z

yourland-report commented

2024-03-03 21:23:31 +00:00

AspireMint reports a bug:

Golden apple should also restore hunger, now it works like health potion - new item? :)

Player position:

{
	x = 1982.6989746094,
	y = 18.000999450684,
	z = 1175.04296875
}

Player look:

{
	x = -0.76884323358536,
	y = -0.63930481672287,
	z = 0.013017589226365
}

Player information:

{
	max_rtt = 2.7530000209808,
	protocol_version = 42,
	lang_code = "",
	minor = 7,
	version_string = "5.7.0",
	state = "Active",
	formspec_version = 6,
	ip_version = 6,
	min_rtt = 0.032000001519918,
	avg_rtt = 0.034000001847744,
	min_jitter = 0,
	max_jitter = 2.5550000667572,
	avg_jitter = 0.0029999986290932,
	connection_uptime = 3916,
	serialization_version = 29,
	patch = 0,
	major = 5
}

Player meta:

{
	fields = {
		digged_nodes = "2029934",
		placed_nodes = "397167",
		died = "385",
		crafted = "128840",
		yl_commons_player_joined = "1709497172",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 2399, [\"y\"] = -13, [\"z\"] = 2160}, [\"last_heal\"] = 1708702962, [\"last_death_portal\"] = 1709497703}",
		punch_count = "563305",
		["stamina:level"] = "9",
		repellant = "0",
		yl_commons_thankyou = "295",
		hud_state = "on",
		["ocean_build.forbidden"] = "true",
		["petz:werewolf_clan_idx"] = "4",
		["petz:lycanthropy"] = "0",
		arenalib_infobox_arenaID = "0",
		["petz:werewolf"] = "0",
		["ocean_build.last_warning"] = "1.65674e+09",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 1240\", \"\", \"3d_armor:chestplate_nether 1 2480\", \"shields:shield_nether 1 2480\", \"3d_armor:boots_crystal 1 1240\", \"3d_armor:leggings_nether 1 2480\"}",
		["ocean_build.ocean_built"] = "12",
		["stamina:exhaustion"] = "40",
		xp = "2121216",
		yl_commons_player_created = "1619715757",
		jointime = "1619715757",
		played_time = "6998762",
		["signslib:pos"] = "(-54,5,22529)",
		["stamina:poisoned"] = "no",
		partychat = "party",
		inflicted_damage = "12185294"
	}
}

Log identifier


[MOD] yl_report log identifier = 2z8XIwIwG1bJPFhTkvwLOBTp6Vt3HTTB

Profiler save:

profile-20240303T212331.json_prettyEE

Status:

# Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 6h 22min 34s | max lag: 1.09s | clients (22/52): AliasAlreadyTaken, Apocralypse, AspireMint, Bailiff, Boot, Chache, Craftsman, damour2_, daydream, DragonWrangler1, Empempires, flux, formations52, hedwig, jackofthebean000, jim15, laira, Miche, poppyasdan, Qichta29, Ravise, Service

Teleport command:

/teleport xyz 1983 18 1175

Compass command:

/give_compass Construction 2z8XIwIwG1bJPFhTkvwLOBTp6Vt3HTTB D2691E 1983 18 1175

AspireMint reports a bug: > Golden *apple* should also restore hunger, now it works like health potion - new item? :) Player position: ``` { x = 1982.6989746094, y = 18.000999450684, z = 1175.04296875 } ``` Player look: ``` { x = -0.76884323358536, y = -0.63930481672287, z = 0.013017589226365 } ``` Player information: ``` { max_rtt = 2.7530000209808, protocol_version = 42, lang_code = "", minor = 7, version_string = "5.7.0", state = "Active", formspec_version = 6, ip_version = 6, min_rtt = 0.032000001519918, avg_rtt = 0.034000001847744, min_jitter = 0, max_jitter = 2.5550000667572, avg_jitter = 0.0029999986290932, connection_uptime = 3916, serialization_version = 29, patch = 0, major = 5 } ``` Player meta: ``` { fields = { digged_nodes = "2029934", placed_nodes = "397167", died = "385", crafted = "128840", yl_commons_player_joined = "1709497172", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"water_life:croc_bag\"}", yl_church = "return {[\"last_death\"] = {[\"x\"] = 2399, [\"y\"] = -13, [\"z\"] = 2160}, [\"last_heal\"] = 1708702962, [\"last_death_portal\"] = 1709497703}", punch_count = "563305", ["stamina:level"] = "9", repellant = "0", yl_commons_thankyou = "295", hud_state = "on", ["ocean_build.forbidden"] = "true", ["petz:werewolf_clan_idx"] = "4", ["petz:lycanthropy"] = "0", arenalib_infobox_arenaID = "0", ["petz:werewolf"] = "0", ["ocean_build.last_warning"] = "1.65674e+09", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 1240\", \"\", \"3d_armor:chestplate_nether 1 2480\", \"shields:shield_nether 1 2480\", \"3d_armor:boots_crystal 1 1240\", \"3d_armor:leggings_nether 1 2480\"}", ["ocean_build.ocean_built"] = "12", ["stamina:exhaustion"] = "40", xp = "2121216", yl_commons_player_created = "1619715757", jointime = "1619715757", played_time = "6998762", ["signslib:pos"] = "(-54,5,22529)", ["stamina:poisoned"] = "no", partychat = "party", inflicted_damage = "12185294" } } ``` Log identifier ``` [MOD] yl_report log identifier = 2z8XIwIwG1bJPFhTkvwLOBTp6Vt3HTTB ``` Profiler save: ``` profile-20240303T212331.json_prettyEE ``` Status: ``` # Server: version: 5.7.0-yl-thx-tmm | game: Minetest Game | uptime: 6h 22min 34s | max lag: 1.09s | clients (22/52): AliasAlreadyTaken, Apocralypse, AspireMint, Bailiff, Boot, Chache, Craftsman, damour2_, daydream, DragonWrangler1, Empempires, flux, formations52, hedwig, jackofthebean000, jim15, laira, Miche, poppyasdan, Qichta29, Ravise, Service ``` Teleport command: ``` /teleport xyz 1983 18 1175 ``` Compass command: ``` /give_compass Construction 2z8XIwIwG1bJPFhTkvwLOBTp6Vt3HTTB D2691E 1983 18 1175 ```

AliasAlreadyTaken was assigned by yourland-report

2024-03-03 21:23:31 +00:00

rewired_X commented

2024-03-03 21:51:23 +00:00

Gapples used to restore a tiny amount of hunger, but for whatever reason that function got removed.

AliasAlreadyTaken added the

1. kind/documentation

label 2024-03-03 22:56:44 +00:00

daydream commented

2024-03-05 22:42:18 +00:00

The gapple's function is definitely a health boost (at least now) but I have never heard a convincing argument why a werewolf can't also partake of it. Just to stop players wanting to be werewolves? It doesn't - so that is a failed concept.

flux commented

2024-03-09 02:13:03 +00:00

the changes in the effect of eating a golden apple have mostly been erratic and unplanned, though we've done a little to restore them to older behaviors. it's a complicated story. but this is a reasonable request - it used to regain a smidgen of stamina.

personally i still think we should give up on the stamina mod and adopt my new nutrition system. that's controversial, but would differentiate the server a lot and give a lot more control to the admins.

the changes in the effect of eating a golden apple have mostly been erratic and unplanned, though we've done a little to restore them to older behaviors. it's a complicated story. but this is a reasonable request - it used to regain a smidgen of stamina. personally i still think we should give up on the stamina mod and adopt my new nutrition system. that's controversial, but would differentiate the server a lot and give a lot more control to the admins.

👍 1

Jammy commented

2024-03-12 13:39:41 +00:00

personally i still think we should give up on the stamina mod and adopt my new nutrition system. that's controversial, but would differentiate the server a lot and give a lot more control to the admins.

I agree, and this change should be made as soon as possible. It would solve many issues, including but not limited to:

Gapple stamina
Different sounds for eating and drinking
Improved food "morsel" particle effect
Unbalanced food system
More interesting tippiness effect

> personally i still think we should give up on the stamina mod and adopt my new nutrition system. that's controversial, but would differentiate the server a lot and give a lot more control to the admins. I agree, and this change should be made as soon as possible. It would solve many issues, including but not limited to: - Gapple stamina - Different sounds for eating and drinking - Improved food "morsel" particle effect - Unbalanced food system - More interesting tippiness effect

👎 1

flux commented

2024-03-13 00:12:10 +00:00

it's a complicated story.

#1745 gapples used to heal werewolves and not consume the apple

solution: check to see if the apple was actually consumed before applying the healing effect
#3951 request to prevent eating gapples when you have full HP

solution: implemented that
#4445 non-werewolves can't eat gapples when they have full stamina

solution: set the stamina regained to zero, so the apple can be consumed by players with full stamina

> it's a complicated story. * #1745 gapples used to heal werewolves and not consume the apple solution: check to see if the apple was actually consumed before applying the healing effect * #3951 request to prevent eating gapples when you have full HP solution: implemented that * #4445 non-werewolves can't eat gapples when they have full stamina solution: set the stamina regained to zero, so the apple can be consumed by players with full stamina

flux referenced this issue from a commit

2024-03-13 00:24:57 +00:00

your-land/bugtracker#6393 add a bit of stamina back when eating a golden apple

flux commented

2024-03-13 00:25:25 +00:00

restored the old behavior 57d0352ee0

EDIT: i just noticed this was marked as "documentation", not "bug". is this not wanted?

restored the old behavior https://gitea.your-land.de/your-land/yl_commons/commit/57d0352ee07cc4740de1c36073a7d05420460e74 EDIT: i just noticed this was marked as "documentation", not "bug". is this not wanted?

Sign in to join this conversation.