your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.5k Projects 2 Wiki

Administrator reports: Add to log which items a playe ... #6366

New Issue
Closed
opened 2024-02-27 00:42:25 +00:00 by yourland-report · 12 comments
yourland-report commented 2024-02-27 00:42:25 +00:00
Member
Copy Link

Administrator reports a bug:

Add to log which items a player picks up from ground

Player position:

{
	x = -450.71801757813,
	y = 58.870002746582,
	z = 21498.12890625
}

Player look:

{
	x = 0.021808940917253,
	y = -0.21643961966038,
	z = -0.97605240345001
}

Player information:

{
	max_rtt = 0.52300000190735,
	ip_version = 6,
	min_rtt = 0.013000000268221,
	avg_rtt = 0.014999999664724,
	min_jitter = 0,
	max_jitter = 0.50800001621246,
	avg_jitter = 0.0010000010952353,
	connection_uptime = 6500,
	serialization_version = 29,
	patch = 0,
	lang_code = "de",
	minor = 9,
	major = 5,
	version_string = "5.9.0-dev-63a985381",
	state = "Active",
	protocol_version = 43,
	formspec_version = 7
}

Player meta:

{
	fields = {
		["stamina:level"] = "0",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "111.5",
		lagometer = "1",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_small\"}",
		repellant = "0",
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal\", \"\", \"\", \"\", \"\", \"\"}",
		bitten = "0",
		played_time = "4737756",
		digged_nodes = "78275",
		placed_nodes = "130834",
		died = "185",
		punch_count = "1082",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "40220",
		xp = "0",
		["hud_manager:spawnit:hud_enabled"] = "y",
		yl_commons_player_joined = "1708988047",
		hud_state = "on",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 54, [\"x\"] = -3844, [\"z\"] = -5201}}",
		crafted = "216",
		["sethome:home"] = "(2218.833984375,40.9880027771,981.63397216797)",
		["ethereal:fly_timer"] = "-99",
		yl_commons_thankyou = "18",
		["ocean_build.ocean_built"] = "9",
		["signslib:pos"] = "(2005,3,1149)",
		["ocean_build.last_warning"] = "1708072099"
	}
}

Log identifier


[MOD] yl_report log identifier = LIcG13Opu4hCnsvjrU41lAOmguMBxbNX

Profiler save:

profile-20240227T004224.json_prettyEE

Status:

# Server: version: 5.8.0-yl-test | game: Minetest Game | uptime: 10h 18min 7s | max lag: 0.303s | clients (3/52): Administrator, AspireMint, daydream

Teleport command:

/teleport xyz -451 59 21498

Compass command:

/give_compass Construction LIcG13Opu4hCnsvjrU41lAOmguMBxbNX D2691E -451 59 21498
Administrator reports a bug: > Add to log which items a player picks up from ground Player position: ``` { x = -450.71801757813, y = 58.870002746582, z = 21498.12890625 } ``` Player look: ``` { x = 0.021808940917253, y = -0.21643961966038, z = -0.97605240345001 } ``` Player information: ``` { max_rtt = 0.52300000190735, ip_version = 6, min_rtt = 0.013000000268221, avg_rtt = 0.014999999664724, min_jitter = 0, max_jitter = 0.50800001621246, avg_jitter = 0.0010000010952353, connection_uptime = 6500, serialization_version = 29, patch = 0, lang_code = "de", minor = 9, major = 5, version_string = "5.9.0-dev-63a985381", state = "Active", protocol_version = 43, formspec_version = 7 } ``` Player meta: ``` { fields = { ["stamina:level"] = "0", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "111.5", lagometer = "1", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_small\"}", repellant = "0", ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal\", \"\", \"\", \"\", \"\", \"\"}", bitten = "0", played_time = "4737756", digged_nodes = "78275", placed_nodes = "130834", died = "185", punch_count = "1082", arenalib_infobox_arenaID = "0", inflicted_damage = "40220", xp = "0", ["hud_manager:spawnit:hud_enabled"] = "y", yl_commons_player_joined = "1708988047", hud_state = "on", yl_church = "return {[\"last_death\"] = {[\"y\"] = 54, [\"x\"] = -3844, [\"z\"] = -5201}}", crafted = "216", ["sethome:home"] = "(2218.833984375,40.9880027771,981.63397216797)", ["ethereal:fly_timer"] = "-99", yl_commons_thankyou = "18", ["ocean_build.ocean_built"] = "9", ["signslib:pos"] = "(2005,3,1149)", ["ocean_build.last_warning"] = "1708072099" } } ``` Log identifier ``` [MOD] yl_report log identifier = LIcG13Opu4hCnsvjrU41lAOmguMBxbNX ``` Profiler save: ``` profile-20240227T004224.json_prettyEE ``` Status: ``` # Server: version: 5.8.0-yl-test | game: Minetest Game | uptime: 10h 18min 7s | max lag: 0.303s | clients (3/52): Administrator, AspireMint, daydream ``` Teleport command: ``` /teleport xyz -451 59 21498 ``` Compass command: ``` /give_compass Construction LIcG13Opu4hCnsvjrU41lAOmguMBxbNX D2691E -451 59 21498 ```
👍 2
AliasAlreadyTaken was assigned by yourland-report 2024-02-27 00:42:25 +00:00
AliasAlreadyTaken added the
1. kind/enhancement
 label 2024-02-27 01:15:11 +00:00
flux added the
4. step/ready to QA test
 label 2024-03-04 21:03:03 +00:00
flux commented 2024-03-04 21:03:55 +00:00
Member
Copy Link

done: fa78f3975c

note that the logic is a bit complicated, because technically items can define their own on_pickup logic which might replace one item with another.

done: https://gitea.your-land.de/your-land/yl_commons/commit/fa78f3975c3de86adcaa6e1a5383b8bd9f8192b5 note that the logic is a bit complicated, because technically items can define their own on_pickup logic which might replace one item with another.
AliasAlreadyTaken added this to the 1.1.123 milestone 2024-03-04 23:06:30 +00:00
AliasAlreadyTaken commented 2024-03-07 11:43:16 +00:00
Owner
Copy Link

QA

I can't see the new log messages. That's all I get:

2024-03-07 11:42:37: ACTION[Server]: [yl_commons] "AliasAlreadyTaken" dropped "bucket:bucket_empty 3" at pos "(2006.7409667969,14.5,1153.2839355469)"
2024-03-07 11:42:37: ACTION[Server]: [yl_commons] AliasAlreadyTaken takes "bucket:bucket_empty 3" from {"name":"AliasAlreadyTaken","type":"player"} [main]
2024-03-07 11:42:39: ACTION[Server]: [yl_commons] [__builtin:item] removing "ghost of bucket:bucket_empty 3" dropped by AliasAlreadyTaken @ (2007,15,1152) 1.9s ago
2024-03-07 11:42:39: ACTION[Server]: player AliasAlreadyTaken (id=2, hp=20) punched LuaEntitySAO "__builtin:item" at (2007,15,1152) (id=12350, hp=1), damage=0

QA I can't see the new log messages. That's all I get: 2024-03-07 11:42:37: ACTION[Server]: [yl_commons] "AliasAlreadyTaken" dropped "bucket:bucket_empty 3" at pos "(2006.7409667969,14.5,1153.2839355469)" 2024-03-07 11:42:37: ACTION[Server]: [yl_commons] AliasAlreadyTaken takes "bucket:bucket_empty 3" from {"name":"AliasAlreadyTaken","type":"player"} [main] 2024-03-07 11:42:39: ACTION[Server]: [yl_commons] [__builtin:item] removing "ghost of bucket:bucket_empty 3" dropped by AliasAlreadyTaken @ (2007,15,1152) 1.9s ago 2024-03-07 11:42:39: ACTION[Server]: player AliasAlreadyTaken (id=2, hp=20) punched LuaEntitySAO "__builtin:item" at (2007,15,1152) (id=12350, hp=1), damage=0
AliasAlreadyTaken added the
ugh/QA NOK
 label 2024-03-07 11:43:23 +00:00
flux commented 2024-03-09 04:14:49 +00:00
Member
Copy Link

I can't see the new log messages.

are you checking debug.txt and not the console output? you recently mentioned that as a reason why we saw different results.

> I can't see the new log messages. are you checking debug.txt and not the console output? you recently mentioned that as a reason why we saw different results.
AliasAlreadyTaken commented 2024-03-12 00:09:44 +00:00
Owner
Copy Link

I can't see the new log messages.

are you checking debug.txt and not the console output? you recently mentioned that as a reason why we saw different results.

That explains. It does appear in the debug.txt.

Unfortunately we don't store debug.txt, we only store terminal. Can you please make it that it appears in the console output?

> > I can't see the new log messages. > > are you checking debug.txt and not the console output? you recently mentioned that as a reason why we saw different results. That explains. It does appear in the debug.txt. Unfortunately we don't store debug.txt, we only store terminal. Can you please make it that it appears in the console output?
AliasAlreadyTaken removed the
ugh/QA NOK
 label 2024-03-12 00:09:52 +00:00
AliasAlreadyTaken commented 2024-03-12 00:26:07 +00:00
Owner
Copy Link

Looks like it IS logged to the terminal, but not always?

2024-03-12 00:22:30: ACTION[Server]: [yl_commons] poppyasdan picks up item "canned_food:canned_potato" dropped by poppyasdan @ (2016,23,1156)
2024-03-12 00:24:49: ACTION[Server]: [yl_commons] AliasAlreadyTaken picks up item "y_bows:slingshot_steel" dropped by AliasAlreadyTaken @ (2011,15,1151)
2024-03-12 00:24:54: ACTION[Server]: [yl_commons] poppyasdan picks up item "y_bows:arrow_diamond 82" dropped by poppyasdan @ (2025,15,1159)
2024-03-12 00:24:54: ACTION[Server]: [yl_commons] poppyasdan picks up item "y_bows:bow_steel 1 47826" dropped by poppyasdan @ (2025,15,1159)
2024-03-12 00:24:55: ACTION[Server]: [yl_commons] poppyasdan picks up item "moreores:enchanted_sword_mithril_sharp 1 8193" dropped by poppyasdan @ (2025,15,1159)
2024-03-12 00:24:55: ACTION[Server]: [yl_commons] poppyasdan picks up item "y_bows:slingshot_wood 1 20817" dropped by poppyasdan @ (2025,15,1159)
2024-03-12 00:24:55: ACTION[Server]: [yl_commons] poppyasdan picks up item "y_bows:bow_wood 1 7788" dropped by poppyasdan @ (2025,15,1159)
2024-03-12 00:24:56: ACTION[Server]: [yl_commons] poppyasdan picks up item "anvil:hammer 1 3900" dropped by poppyasdan @ (2025,15,1159)
2024-03-12 00:24:56: ACTION[Server]: [yl_commons] poppyasdan picks up item "y_bows:arrow_fire 85" dropped by poppyasdan @ (2025,15,1159)
2024-03-12 00:24:56: ACTION[Server]: [yl_commons] poppyasdan picks up item "canned_food:canned_potato 71" dropped by poppyasdan @ (2025,15,1159)
2024-03-12 00:24:56: ACTION[Server]: [yl_commons] poppyasdan picks up item "vessels:glass_bottle 42" dropped by poppyasdan @ (2025,15,1159)
2024-03-12 00:24:56: ACTION[Server]: [yl_commons] poppyasdan picks up item "moreores:enchanted_pick_mithril_fast 1 4401" dropped by poppyasdan @ (2025,15,1159)
2024-03-12 00:24:57: ACTION[Server]: [yl_commons] poppyasdan picks up item "default:mese_crystal" dropped by poppyasdan @ (2025,15,1159)
2024-03-12 00:25:45: ACTION[Server]: [yl_commons] daydream picks up item "y_bows:arrow_fire 53" dropped by daydream @ (2153,16,1029)
2024-03-12 00:25:45: ACTION[Server]: [yl_commons] daydream picks up item "y_bows:slingshot_steel" dropped by daydream @ (2154,16,1029)
2024-03-12 00:25:45: ACTION[Server]: [yl_commons] daydream picks up item "y_bows:ball_rock 20" dropped by daydream @ (2153,16,1029)
2024-03-12 00:25:45: ACTION[Server]: [yl_commons] daydream picks up item "farming:tomato 2" dropped by daydream @ (2153,16,1029)
Looks like it IS logged to the terminal, but not always? ``` 2024-03-12 00:22:30: ACTION[Server]: [yl_commons] poppyasdan picks up item "canned_food:canned_potato" dropped by poppyasdan @ (2016,23,1156) 2024-03-12 00:24:49: ACTION[Server]: [yl_commons] AliasAlreadyTaken picks up item "y_bows:slingshot_steel" dropped by AliasAlreadyTaken @ (2011,15,1151) 2024-03-12 00:24:54: ACTION[Server]: [yl_commons] poppyasdan picks up item "y_bows:arrow_diamond 82" dropped by poppyasdan @ (2025,15,1159) 2024-03-12 00:24:54: ACTION[Server]: [yl_commons] poppyasdan picks up item "y_bows:bow_steel 1 47826" dropped by poppyasdan @ (2025,15,1159) 2024-03-12 00:24:55: ACTION[Server]: [yl_commons] poppyasdan picks up item "moreores:enchanted_sword_mithril_sharp 1 8193" dropped by poppyasdan @ (2025,15,1159) 2024-03-12 00:24:55: ACTION[Server]: [yl_commons] poppyasdan picks up item "y_bows:slingshot_wood 1 20817" dropped by poppyasdan @ (2025,15,1159) 2024-03-12 00:24:55: ACTION[Server]: [yl_commons] poppyasdan picks up item "y_bows:bow_wood 1 7788" dropped by poppyasdan @ (2025,15,1159) 2024-03-12 00:24:56: ACTION[Server]: [yl_commons] poppyasdan picks up item "anvil:hammer 1 3900" dropped by poppyasdan @ (2025,15,1159) 2024-03-12 00:24:56: ACTION[Server]: [yl_commons] poppyasdan picks up item "y_bows:arrow_fire 85" dropped by poppyasdan @ (2025,15,1159) 2024-03-12 00:24:56: ACTION[Server]: [yl_commons] poppyasdan picks up item "canned_food:canned_potato 71" dropped by poppyasdan @ (2025,15,1159) 2024-03-12 00:24:56: ACTION[Server]: [yl_commons] poppyasdan picks up item "vessels:glass_bottle 42" dropped by poppyasdan @ (2025,15,1159) 2024-03-12 00:24:56: ACTION[Server]: [yl_commons] poppyasdan picks up item "moreores:enchanted_pick_mithril_fast 1 4401" dropped by poppyasdan @ (2025,15,1159) 2024-03-12 00:24:57: ACTION[Server]: [yl_commons] poppyasdan picks up item "default:mese_crystal" dropped by poppyasdan @ (2025,15,1159) 2024-03-12 00:25:45: ACTION[Server]: [yl_commons] daydream picks up item "y_bows:arrow_fire 53" dropped by daydream @ (2153,16,1029) 2024-03-12 00:25:45: ACTION[Server]: [yl_commons] daydream picks up item "y_bows:slingshot_steel" dropped by daydream @ (2154,16,1029) 2024-03-12 00:25:45: ACTION[Server]: [yl_commons] daydream picks up item "y_bows:ball_rock 20" dropped by daydream @ (2153,16,1029) 2024-03-12 00:25:45: ACTION[Server]: [yl_commons] daydream picks up item "farming:tomato 2" dropped by daydream @ (2153,16,1029) ```
AliasAlreadyTaken added the
ugh/QA NOK
 label 2024-03-12 00:27:13 +00:00
AliasAlreadyTaken modified the milestone from 1.1.123 to 1.1.124 2024-03-12 00:27:39 +00:00
AliasAlreadyTaken commented 2024-03-12 02:11:19 +00:00
Owner
Copy Link

whosit discovered that when I pick items up with empty hand, I don't see the log message. If I pick it up with some item in hand, I do get the log message.

whosit discovered that when I pick items up with empty hand, I don't see the log message. If I pick it up with some item in hand, I do get the log message.
flux commented 2024-03-12 22:43:44 +00:00
Member
Copy Link

whosit discovered that when I pick items up with empty hand, I don't see the log message. If I pick it up with some item in hand, I do get the log message.

that's... really weird. i can replicate the issue locally, let me see if i can figure it out.

> whosit discovered that when I pick items up with empty hand, I don't see the log message. If I pick it up with some item in hand, I do get the log message. that's... really weird. i can replicate the issue locally, let me see if i can figure it out.
flux commented 2024-03-12 22:49:22 +00:00
Member
Copy Link

apparently the on_punch callback is never even called when i've got an empty hand?! oh, i have an idea....

apparently the `on_punch` callback is never even called when i've got an empty hand?! oh, i have an idea....
flux commented 2024-03-12 22:53:57 +00:00
Member
Copy Link

fixed 4e0d2bf2f1, ready to QA again

fixed https://gitea.your-land.de/your-land/yl_commons/commit/4e0d2bf2f17eb4b04936fb9bbf62130ff74778c5, ready to QA again
👍 1
whosit removed the
ugh/QA NOK
 label 2024-03-12 22:57:44 +00:00
AliasAlreadyTaken modified the milestone from 1.1.124 to 1.1.123.1 2024-03-13 09:26:29 +00:00
AliasAlreadyTaken commented 2024-03-13 21:27:33 +00:00
Owner
Copy Link

QA

Now works with empty hand :)

QA Now works with empty hand :)
AliasAlreadyTaken added the
ugh/QA OK
 label 2024-03-13 21:27:39 +00:00
flux commented 2024-03-28 22:59:39 +00:00
Member
Copy Link

i can't check this on main due to lack of access

i can't check this on main due to lack of access
AliasAlreadyTaken commented 2024-03-28 23:36:18 +00:00
Owner
Copy Link

This works on main and was already used. Fixed!

This works on main and was already used. Fixed!
👍 1
AliasAlreadyTaken added the
5. result/fixed
 label 2024-03-28 23:36:29 +00:00
flux removed the
4. step/ready to QA test
 label 2024-03-29 02:34:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.123.1
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
AliasAlreadyTaken
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#6366
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?