Make sure detached inventories are handled properly #6313

New Issue

whosit · 2024-02-18T09:26:51Z

whosit commented

2024-02-18 09:26:51 +00:00

Detached inventories I get on join to test:

trash
airutils_whosit_977061
unified_trash
saddlebag_inventory
whosit_armor
yl_speak_up_player_whosit
whosittrash_review
whosit_bags
whositrefill

some other can appear after players interact with stuff like NPCs

Detached inventories I get on join to test: - trash - airutils_whosit_977061 - unified_trash - saddlebag_inventory - whosit_armor - yl_speak_up_player_whosit - whosittrash_review - whosit_bags - whositrefill some other can appear after players interact with stuff like NPCs

whosit referenced this issue

2024-02-18 09:27:30 +00:00

yl_speak_up: on server join, I get every other player's detached inventory for NPCs #6235

whosit commented

2024-02-18 09:28:18 +00:00

Alias wrote in other thread:

What's the difference between trash and unified_trash and trash_review?

Need to look it up...

I also don't see why bags need a detached inventory, its not that anyone else would interact with them

Same goes for armour?

Seems that there's no way to make additional inventories for the player, except detached ones?

Alias wrote in other thread: > What's the difference between trash and unified_trash and trash_review? Need to look it up... > I also don't see why bags need a detached inventory, its not that anyone else would interact with them > > Same goes for armour? Seems that there's no way to make additional inventories for the player, except detached ones?

AliasAlreadyTaken added the

2. prio/interesting

label 2024-02-18 09:29:50 +00:00

flux commented

2024-02-18 20:05:12 +00:00

What's the difference between trash and unified_trash and trash_review?

i think "trash" is the "main" trash inventory, the location where you can drag items to destroy them, while trash_review is tab where you can pull the last few things out of the trash.

Seems that there's no way to make additional inventories for the player, except detached ones?

no, note that the bag contents are already player inventories. imo these things should be player inventories, though it might be tough to get such a change merged upstream.

> What's the difference between trash and unified_trash and trash_review? i think "trash" is the "main" trash inventory, the location where you can drag items to destroy them, while trash_review is tab where you can pull the last few things out of the trash. > Seems that there's no way to make additional inventories for the player, except detached ones? no, note that the bag contents are already player inventories. imo these things should be player inventories, though it might be tough to get such a change merged upstream.

flux commented

2024-03-28 21:57:53 +00:00

when final-checking #6235, i noticed that personal_log is sending a detached inventory from every player to every player. those should probably be made player inventories or at least restricted to the individual player.

Sign in to join this conversation.